zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-28 13:13:37 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,771 Commits 43 Branches 79 Tags
main
Commit Graph
5672 Commits
Author SHA1 Message Date
Ruslan Lesiutin b73d2d5cbf Merge remote-tracking branch 'chromedevtools/chromium/7103' into repo-sync 2025-06-10 18:46:44 +01:00
Eric Leese 91f0826c2d [m136] Always round test duration to milliseconds 
Bug: 408145209
Fixed: 411315974
Change-Id: I7246d08a8ff033c081a141b49ded7070f977ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429854
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
(cherry picked from commit 9876f54da0)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468182
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-04-17 02:16:33 -07:00
Eric Leese c4dc89bb73 [m136] Report test durations in seconds, not ms 
Bug: 408145209, 411315974
Change-Id: I25bc8902ea54c3dc994b9e00dce11351dc7221b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6430184
Auto-Submit: Eric Leese <leese@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
(cherry picked from commit e4c5ad52c8)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468181
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-04-17 02:13:03 -07:00
Kim-Anh Tran 36943d1130 [GM3Restyling] Hide layers information if nothing can be shown 
This changes the layers panel to only show the empty state if nothing
can be shown yet.

Before: https://i.imgur.com/jC0gqBa.png
After: https://i.imgur.com/VvoIxie.png
Fixed: 400383914
Change-Id: I0ea7d8438d86dc8a000b09582739368a4ac9b171
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415488
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-31 03:28:07 -07:00
Connor Clark e7a6489e5c Enable projectService for TypeScript files in eslint config 
Enabling this is required for rules that need to use the types as
resolved by the TypeScript compiler.

The no-floating-promises rule was missing some stuff due to missing
types, so this CL resolves that too. Also, return-await kicked up more
stuff.

A warm run of `npm run lint` went from ~23s to ~35s on my M1 Mac.

Bug: 406518012
Change-Id: I0c413e2ca14ee903851fd8404e490335c7f8aae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397499
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 05:02:27 -07:00
Nikolay Vitkov cf70a057cf [test] Fix types for selectors 
Bug: none
Change-Id: I84974d640a005fbbf0f1aed3c802202731b40381
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404073
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-28 02:25:44 -07:00
Paul Irish 109655405f RPP: Polish UI 
- Reduce insight sidebar whitespace
- Drop transition on insight hover button.
- Make Magic pen animation smoother

Change-Id: I6a1cc2d83e73db66472d945bd51960c5417da547
Bug: 395797366
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395296
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-27 10:52:20 -07:00
Nikolay Vitkov bcd8cd9979 [eslint] Allow !! instead of Boolean 
This provides better type inference when using TypeScript,
specifically the .filter methods
Also allowed by Google style guide.
https://google.github.io/styleguide/tsguide.html#type-coercion

Change-Id: I79745812f57670a0057145609b7949b2a12d9fbe
Bug:397260638
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403239
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-27 10:49:17 -07:00
Kim-Anh Tran 9d8351cff5 [GM3Restyling] Update Popover Helper usages 
Screenshot: https://imgur.com/a/J3ewzJ2
Bug: 406664599
Change-Id: I6d90f444824158af688f6d233a68d77f0e2cff5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396865
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-27 05:34:16 -07:00
Camillia Smith Barnes e252e5697b Update Protocol 
Bug: chromium:401011862
Change-Id: I3c0032666c3b1cee1e5c6169878cb7cb214c95e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395222
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-03-27 05:30:40 -07:00
Vlad Krot 5d269b125c DirectSocket TCP panel #1 
DirectSocket TCP protocol methods are added to NetworkManager.ts with
tests. The next CL will add necessary panels to UI.

The related commit in chromium -
https://chromium-review.googlesource.com/c/chromium/src/+/6308994

Design Document: go/chrome-devtools:directsockets-design

Bug: 358327120
Change-Id: I59f6c213f44db29ba4b2563d15d081c9c407a512
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6316791
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Vlad Krot <vkrot@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-03-27 04:05:17 -07:00
Adam Raine 72cff9ffa5 [Lighthouse] Roll Lighthouse 12.5.1 
Bug: 40543651
Change-Id: Id022662b3b9587789e24721e6797de0731e8da63
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6398222
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Adam Raine <asraine@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2025-03-26 15:15:41 -07:00
Kim-Anh Tran 77e873a9b7 [GM3Restyling] Update buttons in network payload tab 
This changes two <button>s to use the Button component.

Before: https://i.imgur.com/zyw1gZ7.png
After: https://i.imgur.com/rNo5HSd.png
Bug: none
Change-Id: I8d8b094c37f91da74df85671811f2df5eea9dc1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387116
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-26 01:59:21 -07:00
Adam Raine e9a34eb812 [Lighthouse] Roll Lighthouse 12.5.0 
Bug: 40543651
Change-Id: I1234f71d79d2b2c053501d5dec711721f690f7dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395415
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Adam Raine <asraine@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-25 19:09:15 -07:00
Wolfgang Beyer 9f1b5619d6 Remove 'autofill-view' experiment 
Experiment has been enabled by default for a long time.

Bug: none
Change-Id: I3a1e7756197a438c2257a642fa61c60817c0f0f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387440
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-25 08:21:19 -07:00
Nikolay Vitkov 58be9b4c44 [cleanup] Don't declare default in constructor (#1) 
This moves some of the default from the constructor
to the declaration methods, this requires less space and
also point easier to what is coming from outside and what
the constructor is doing.

Bug: 397260638
Change-Id: I67a00b28e2cc92394e4bceca431b3d6f662a7537
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6377983
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-25 07:25:21 -07:00
Liviu Rau 5cb7bc8501 Provide mocha context to it.only function 
On e2e_non_hosted tests it.only fails with:
`ReferenceError: mocha is not defined`

Bug: 400683715
Change-Id: I576eb03f5f007e032a772a3230802c06e9443812
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387109
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-25 03:49:10 -07:00
Philip Pfaffe bc6940d1fe [unit] log browser output 
Bug: none
Change-Id: I8aabb82379cabe1939e05a55d04cc61d715b2c21
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387802
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-25 02:34:04 -07:00
Kim-Anh Tran 9edfcd178b [GM3Restyling] Update payload key-value pairs 
Before: https://i.imgur.com/LJFe1Rv.png
After: https://i.imgur.com/qeiLbsM.png
Bug: 325443308
Change-Id: If0ca6888147ceaca898efd1994d5774a397a98eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375424
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-24 07:53:04 -07:00
Liviu Rau e63bd640be Port 1 elements tests to non-hosted 
Bug: 400683715
Change-Id: I2535e72ff4cdab24e8c5e3a423b6a9f65944d11d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367036
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2025-03-24 07:05:01 -07:00
Adriana Ixba 7a9b937ce4 Use kB and avoid unit conversion for tables 
This is to keep units from varying within the same context. This
change includes the perf panel 3P table, network & memory panel tables

Bug: 398040368
Change-Id: Ib170f2f9a1a0126c8d190698a654d84f23e0843d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6300607
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-24 04:55:42 -07:00
Danil Somsikov 6de27def00 Screenshot tests for the protocol monitor view 
Bug: 388730998
Change-Id: I423f3d1b86938f4a683fa7a608e5a5e4d692aa9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6329382
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2025-03-24 04:40:28 -07:00
Kim-Anh Tran 008c0475f2 [GM3Restyling] Update Headers key value pairs 
Changes the key-value pair styles in the Headers tab of the Network
panel.

Before: https://i.imgur.com/mradPDQ.png
After: https://i.imgur.com/KlwZuue.png
Bug: 325443308
Change-Id: Ic613c567c366ab440445d7f4069dcc3111e73924
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372906
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-24 02:25:00 -07:00
Jack Franklin ab914907ab Try to deflake RPP landing page test 
This has flaked a few times. Trying to see if this retry function will
improve its stability, as we have quite a few rAFs to try to make this
test work.

Bug: 405356930
No-Presubmit: True
No-Tree-Checks: True
No-Try: True
Change-Id: Ib9864aef67413ef1d3fa36d99359e8756b6626cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381858
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-21 07:17:09 -07:00
Joshua Thomas 7411149fb5 Reland "Have InspectorView remove the Infobar instead of CookieControlsView" 
This is a reland of commit 1ac4ec696c

Original change's description:
> Have InspectorView remove the Infobar instead of CookieControlsView
>
> If CookieControlsView was responsible for listening for a
> PrimaryPageChanged event and then removing the Infobar, the infobar
> would not be removed if CookieControlsView was never created to
> listen in the first place. This is a problem because the Infobar
> might be created by the InspectorMain entrypoint which does not
> guarantee that a CookieControlsView will be created as well.
>
> By moving the listener to the InspectorView, we guarantee that the
> Infobar is removed when the user reloads the page without needing
> to open the Privacy and security panel.
>
> Bug: 400962121
> Change-Id: I612c4899e218e094fd31a3eda154ec69c20e8035
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346989
> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Joshua Thomas <masnoble@chromium.org>

Bug: 400962121
Change-Id: Id4b4c5a1e46e84877642978c3763af784ff751b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367775
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
 2025-03-20 05:33:53 -07:00
Adriana Ixba 3067d40135 [RPP] Use main thread and treeView bottomUpRootNode for 3P insight 
This also simplifies the insight shape closer to how we use it in RPP,
and how we will use it in LH. This also simplifies some tests.

This modifies how we generate eventIDs when grouping by 3P. This fixes a
bug where when grouping by 3P, generateEventID can incorrectly group
events of different entities.

This fixes:
- misalignment in main thread times insight<->3P table
(by using same data source, including instant events, filters)
- incorrect event grouping: breaking bottomUp button and causing further
incorrect selftime/transfersize (bottomUp tree node ID generation)

Bug: 394651390
Change-Id: I1660a5b5b9a90be89815aad858caea94f153eabb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6341914
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2025-03-19 13:07:38 -07:00
Nikolay Vitkov 35f3849054 [e2e] Dedupe types 
Also improves some names, comments and IDE error fixes.

Bug: none
Change-Id: I7bad9d6f85555a9e17d140c2987e8ee06090ec95
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6366899
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-19 03:34:40 -07:00
Philip Pfaffe 590d640790 Revert "Have InspectorView remove the Infobar instead of CookieControlsView" 
This reverts commit 1ac4ec696c.

Reason for revert: e2e test is flaky on CI: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Linux%20Official/14090/overview

Original change's description:
> Have InspectorView remove the Infobar instead of CookieControlsView
>
> If CookieControlsView was responsible for listening for a
> PrimaryPageChanged event and then removing the Infobar, the infobar
> would not be removed if CookieControlsView was never created to
> listen in the first place. This is a problem because the Infobar
> might be created by the InspectorMain entrypoint which does not
> guarantee that a CookieControlsView will be created as well.
>
> By moving the listener to the InspectorView, we guarantee that the
> Infobar is removed when the user reloads the page without needing
> to open the Privacy and security panel.
>
> Bug: 400962121
> Change-Id: I612c4899e218e094fd31a3eda154ec69c20e8035
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346989
> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Joshua Thomas <masnoble@chromium.org>

Bug: 400962121
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Id4947497e7cbca2c734f2d1308ef1a115155ee64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367219
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-03-18 07:13:13 -07:00
Liviu Rau 8c380711e8 Add Mocha.Context to the e2e_non_hosted testing function signature 
Bug: none
Change-Id: I973f6d43e19fe3b547be3a22ec73938f44097016
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6361534
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-18 05:43:32 -07:00
Joshua Thomas 1ac4ec696c Have InspectorView remove the Infobar instead of CookieControlsView 
If CookieControlsView was responsible for listening for a
PrimaryPageChanged event and then removing the Infobar, the infobar
would not be removed if CookieControlsView was never created to
listen in the first place. This is a problem because the Infobar
might be created by the InspectorMain entrypoint which does not
guarantee that a CookieControlsView will be created as well.

By moving the listener to the InspectorView, we guarantee that the
Infobar is removed when the user reloads the page without needing
to open the Privacy and security panel.

Bug: 400962121
Change-Id: I612c4899e218e094fd31a3eda154ec69c20e8035
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346989
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
 2025-03-18 05:41:26 -07:00
Kateryna Prokopenko 7809edb4e4 [GM3Restyling] Use <select> for Recorder replay options menu 
Screenshot: https://imgur.com/a/nUiK1om

Bug: 325441856
Change-Id: I41396ff80c62dd745e6d73873f5239dfaadb6e0f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6354790
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-18 05:40:22 -07:00
Kateryna Prokopenko 95ba1d9042 [GM3Restyling] Use <select> for Recorder replay throttling menu 
Screenshot: https://imgur.com/a/Jp38ktC

Bug: 325441856
Change-Id: I563be8cb189c76547746102edd77fede703c6f99
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357350
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-18 03:07:03 -07:00
Yanling Wang e274f6c7b8 Dom Adorner 
This CL adds support to show multiple issues through squiggly lines in
the DOM tree of Elements Panel.

Screenshot:https://imgur.com/a/hKpaXd3 Explainer:
https://docs.google.com/document/d/1NIoIQdiSN72HVb4TosfE7tMHNTjEEjsCye_ymqoOXHw/edit?tab=t.0#heading=h.mymnss778pd7

Bug: 378738916
Change-Id: I0b37553c056b429cbac445bdbc35779af81ffdc9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6249604
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2025-03-18 03:05:59 -07:00
Alex Rudenko 03eabb6cc1 [Recorder] restrict navigation 
Fixed: 401927528
Change-Id: Ica9e5f2e1b28aa7ee6c0b2ee7cd43390c2eebd5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6355192
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2025-03-17 10:27:39 -07:00
Philip Pfaffe f77b30f086 [non-hosted] Pause before every test when debugging 
Bug: none
Change-Id: Ie5aa8b5ab11a2b3d796a6bec68852d0d7c172166
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357123
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-03-17 06:51:49 -07:00
Philip Pfaffe 77a1baee45 Revert "Migrate throttling tests to non-hosted e2e tests" 
This reverts commit 204e1b01a2.

Reason for revert: flaky test

Original change's description:
> Migrate throttling tests to non-hosted e2e tests
>
> Bug: 400683715
> Change-Id: I14a736f0ac15edaf4607caa8058046ad39f8f4c4
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6308987
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>

Bug: 400683715
Change-Id: I52f216dec3b7e6af557d43c2336ada15aaf3c400
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357020
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-17 05:04:49 -07:00
Nikolay Vitkov 6b580c71b0 [test] Fix E2E non hosted TS refs 
Typescript in the IDE complains as the config does not include
the reference to the e2e test, currently we re-use a lot of
helper from there and we build with that in mind.

Bug: none
Change-Id: I3d2a23f418e568d78b0f46915e3704200819212e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357120
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-17 03:58:33 -07:00
Alex Rudenko feb21f6438 Add assertScreenshot to unit tests 
This CL adds a custom browser wrapper that starts the browser using
Puppeteer instead of letting Karma to directly start the browser. The
wrapper also exposes a binding that allows the test code to capture a
screenshot of the test DOM. The helper reuses existing screenshot
assertions and reports the result back to the test code.

This CL also adds args to improve stability of screenshots and
fixes the font to be a Roboto font loaded from Google Fonts.

To test: `npm run test --
front_end/panels/ai_assistance/components/UserActionRow.test.ts`

Bug: 401489541
Change-Id: I04889d0f0caa5c468fd35f98c66b0e6ac393de18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330749
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-03-14 11:32:55 -07:00
Liviu Rau bb891260ee Construct the correct test name in rdb results 
Bug: none
Change-Id: I0627133adafb4f2277825fbf3e537d413d3d0bed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6355827
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-14 04:48:39 -07:00
Liviu Rau 7562199cd8 Migrate targets tests to non-hosted e2e tests 
Bug: 400683715
Change-Id: I2215bdba2baf399a6260ab6aa97a44bd4bd0f7fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6321794
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-14 04:36:48 -07:00
Liviu Rau 204e1b01a2 Migrate throttling tests to non-hosted e2e tests 
Bug: 400683715
Change-Id: I14a736f0ac15edaf4607caa8058046ad39f8f4c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6308987
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-14 03:50:51 -07:00
Liviu Rau ee4571ad0a Migrate webaudio tests to non-hosted e2e tests 
Drive-by: with suites ported there is no reason to keep the dummy suite around; removed.

Bug: 400683715
Change-Id: I7d60ac3121ae13ce1361a5416d9893f907f80f0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6308503
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2025-03-14 01:22:44 -07:00
“jalonthomas” 094b6c30b8 Add filtering for name and domain in the Cookie Report table 
Filter behavior:
http://go/scrcast/NjAwMzk2NTE3ODE1MDkxMnwxM2RiODNiMi0wYQ

Bug: 395067568
Change-Id: I9695a76744334dc114cc91f243b8004ca8fa4f9f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6253558
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jalon Thomas <jalonthomas@google.com>
 2025-03-13 11:29:08 -07:00
Nikolay Vitkov 9ddeb2503f [VE] Fail E2E test on Unknown VE context 
Report the error when running E2E test, that will catch some of the
issue before getting merged.

Bug: none
Change-Id: I9cc984edf9ec61c60b175b5d27bc444151a9ae69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6352082
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-13 11:01:24 -07:00
Nikolay Vitkov 8be47c2962 [test] Use Puppeteer to deduce Element types 
Bug: none
Change-Id: I8899a6795b6a7931f5afcb5dcbe2740623c9ed74
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6348456
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-13 08:17:11 -07:00
Alex Rudenko 1deba54fc0 Stability improvements of existing screenshot tests 
This CL reduces retries to 1 (no-retries) and the threshold for diffs to 0.1. This CL
also adds the following flags that should help to render in a more
stable way:

- `--disable-font-subpixel-positioning` disables subpixel positioning for fonts.
- `--disable-lcd-text` disables subpixel antialiasing.
- `--force-device-scale-factor=1` forces device scale factor to be 1.
- `--hide-scrollbars` hides scrollbars which might affect rendering.

Also, this CL imports a Roboto web font into component docs and adds a
special CSS class to force all fonts to be the same font (see
front_end/design_system_tokens.css and
front_end/ui/components/docs/component_docs_styles.css).

Bug: 401489541
Change-Id: I94e6a733d63459d1692197536511dad199ee168b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6342613
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-13 04:26:29 -07:00
Philip Pfaffe d85bddcbf4 Deflake styles-disable-inherited_test.ts 
This reverts the changes of https://crrev.com/c/6298060 for this test
which likely introduced the flakiness.

Bug: none
Change-Id: If373e18c88d2733f5fa9f0dda12527daa41d811b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346611
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-12 11:14:09 -07:00
Nikolay Vitkov 1e817df121 [AI Assistance] Fix CSS nested selector 
Strip the special selector, this allows us to at least apply a change,
else we didn't pick anything and we failed to update the styles.

Bug: 402735143
Change-Id: Iadacb4df3afae67dbcb15b1347bcc1d52bdc2876
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346593
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-12 08:19:33 -07:00
Nikolay Vitkov a28d2abfcf Reland "[test] Remove snapshot assertions" 
This is a reland of commit 8b9f9ec907

Original change's description:
> [test] Remove snapshot assertions
>
> Only used in recorder.
>
> Fixed: 402422819
> Change-Id: Ia3e20ecce7e1fbaf176e856289d628c8d22d8fa7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6345653
> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>

Change-Id: I779ee739f2e11a07934d42d048d49a46d8c7717e
Bug: 402422819
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346912
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-12 07:28:56 -07:00
Liviu Rau 4108f27a20 [screenshots] Preserve screenshots where already present 
Bug: 402695834
Change-Id: I7ba180b35e8b3b92f6b6faf968cd6511d11de305
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346591
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-03-12 07:14:13 -07:00