zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-11-01 18:59:10 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,405 Commits 44 Branches 79 Tags
376e9667e4e05cdfed567baefea7efb74e3dcff6
Commit Graph
3405 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim van der Lippe 376e9667e4 Fix nesting of ts_library outputs 
For TypeScript-authored files, we would create the wrong output
in the `resources/inspector` directory. While `ts_library.py`
would copy to the correct location, `typescript.gni` disagreed.

The culprit is that we were only taking 1 directory from the
`target_gen_dir`, but this could be arbitrarily many. Instead,
we now compare to the full path of the generated front_end
directory.

To make sure that this works in a standalone and Chromium checkout,
we have to differentiate on `_devtools_location`. I also cleaned
that logic up by always prepending a slash at the end of a
Chromium checkout. As such, you can string interpolate without
having to worry about the extra space.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1011811
Change-Id: I186396fe7a5001dc2930a37562640feedb6291a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201650
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-15 09:32:48 +00:00
Sigurd Schneider 6fb3b0178b Fix type and guard against undefined 
R=szuend@chromium.org

Bug: chromium:1072335
Change-Id: I88abb81cd02ddcbffb0ccd4f3919efac23307af5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2203446
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-15 09:20:26 +00:00
Alex Rudenko 83eb9158dd Fix duplicated toolbar items 
Changes SourcesView so that toolbar items are removed and appended
within the same cycle preventing duplicate items from appearing.

Fixed: 1083136
Change-Id: I1379d8b67189ed1e6dba7e42553799737e22352c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2203445
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 09:07:06 +00:00
Mathias Bynens 91c67413a6 Improve contrast for null and undefined values 
Any `null` and `undefined` values logged to the Console are styled
in grey. This patch tweaks the shade of grey used in order to bring
the contrast to an acceptable level, for the light theme and the dark
theme alike.

Bug: chromium:1066415
Change-Id: I5e410013dbf6e87a7018e68c487f9e5d44993f6c
Fixed: chromium:1083126
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2203442
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 08:14:16 +00:00
Yang Guo 2b1843a570 Fix ownership of README.md 
TBR=tvanderlippe@chromium.org

Change-Id: I428968ee35cb2d0daf6009323c9918aef303b289
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2203439
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-15 07:57:36 +00:00
Songtao Xia 2dcb84564b [DevTools] [Styles] Keyboard focus set after editing 
The accessibility bug below is about lost keyboard focus after using
keyboard to edit style rules. It reveals a flaw in the style editing
code: it is justifiable to call "toggle property and continue editing"
when the property is being typed. But when the command handler realizes
that we need to cancel this editing, the following problems occured.

1) The cancel editing code is called before the necessary information
for continuing editing is gathered. An exception can be thrown. The fix
orders them correctly.
2) The continue editing code does not set the focuses correctly. There
are three situations:
2.a) the canceled editing is in the middle of a list of properties;
focus/editing-starting position should be at the next property.
2.b) the canceled editing is at the end of a list of properties; it
should be reasonable to set focus/editing-starting position at the
last property.
2.c) the section has no css rules; it is reasonable to set focus on
the section itself.

Screen recording for 2.a and 2.c:
continue editing the next property:
https://imgur.com/VFJjhE2
no property in section, focus on section:
https://imgur.com/mlhgo5t



Change-Id: Ic8c41ef3acc4f55331356b651aabcf7dc90ca43e
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1081766
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2196823
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Brian Cui <brcui@microsoft.com>
Commit-Queue: Songtao Xia <soxia@microsoft.com>
 2020-05-15 03:08:26 +00:00
Jose Leal Chapa 8321a572fc Add e2e tests for Memory panel 
Bug: 1079076
Change-Id: Ic160aefc7da4f1347b32edf1d6f0991e8e02543d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2191712
Commit-Queue: Jose Leal <joselea@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
 2020-05-14 21:50:56 +00:00
Ted Meyer 446c499de1 Match some color schemes to the other parts of devtools 
Alternating colors in lists now get the same colors as other components
and the underline-on-hover is replaced with a background color change on
hover.

Before: https://files.tedm.io/dtss/media_colors_before.mp4
After: https://files.tedm.io/dtss/media_colors_after.mp4


Bug: 794255
Change-Id: I8ea998481d245cc93380274c4ffb0722669e26dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200145
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-05-14 19:33:26 +00:00
Ted Meyer 8e272a6a28 Don't word wrap long lines for titles and other properties. 
Bug: 1080571
Change-Id: Ibcc0dbc5adc38d48343e7043ac4ce3557efaed7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200072
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
 2020-05-14 17:16:05 +00:00
Junyi Xiao 90c7477737 Devtools: remove tabIndex when JS VM instance list is empty 
Issue: On Profiler, the Javascript VM instance list has a tabIndex 0 even the list is empty, which results focus lost alike behavior when traversing using Tab key.

This change sets tabIndex to 0 if the list is not empty and resets it to -1 when it becomes empty.

Bug: 1078243
Change-Id: I265656f0cdfe7c412ceb37cef93f5fb33873df48
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199400
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
 2020-05-14 16:36:56 +00:00
Wolfgang Beyer 21cb0818fe Port PerformanceMetricsModel.js to TypeScript 
Bug: chromium:1011811, chromium:1079233
Change-Id: Iba7a7b1f397261796486e26d32f182248eed7253
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201176
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-14 15:24:05 +00:00
Philip Pfaffe f5e2e5abac Fix Wasm debugging based on the DWARF SourceMap approach 
After the DebugSymbols CDP change landed, the backend stopped reporting
the fake wasm://dwarf source map urls. Until we properly support
DebugSymbols in the frontend, bring the fak url back in the frontend to
fix the DWARF SourceMap approach.

Bug: chromium:1082720
Change-Id: I366993c7183b9d47b7f42f7d2517571907f913f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201636
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-14 14:49:25 +00:00
Yang Guo 74e1a7aa26 Assign owners to hidden files in root 
R=tvanderlippe@chromium.org

Bug: chromium:1082687
Change-Id: I9cb5df8b2386fa8482b01230b429403651aac6e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201640
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-14 14:00:15 +00:00
Maks Orlovich 5782dc8fcf Add test for _generateBrandVersionList 
Bug: 1073909
Change-Id: I2d9e10ce4e04d8c17df4dd07e3d1d95f23550ccd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198547
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-14 13:50:25 +00:00
Wolfgang Beyer 7730698789 Fix return type after porting to TypeScript 
Bug: chromium:1011811, chromium:1079233
Change-Id: I3c68b5e1859725991eba615dfddd22ac276ac0fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201638
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-05-14 13:47:24 +00:00
Eric Leese 17023a6a5d Keep editing enabled for filesystem scripts 
Bug: chromium:1081865
Change-Id: I808b811422af62e4e1a53a6660c8f257b6ee4e33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201177
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2020-05-14 13:46:05 +00:00
Philip Pfaffe e701fe1a41 Reenable tests 
After chromium:1079328 is considered fixed, reenable the affected tests.

Bug: chromium:1079328
Change-Id: I0d7120909ae7434bad950a11307254428e0188cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199085
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-14 13:43:10 +00:00
Mathias Bynens 15213d068d Enable no-global-assign lint rule 
This actually caught an issue in ElementsTestRunner.js.

Bug: chromium:1057042
Change-Id: I850156e6b7956fe9b24295eb084e5b228113bda9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201178
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-05-14 13:42:05 +00:00
devtools-ci-autoroll-builder babd873bca Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/a93cb80..f70e3b9

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ia7052c37955ad75c17e1b32edf96e32e9381769c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201278
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-05-14 13:41:00 +00:00
Philip Pfaffe c7172a2a68 Disable the flaky Animations Panel test 
The test is turning the tree red.

TBR=tvanderlippe@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1082735
Change-Id: I01454ab9b25a72edf527c1d61b5a46fcda369b79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201639
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-14 13:39:56 +00:00
Wolfgang Beyer 493b76784e Port Script.js to TypeScript 
Bug: chromium:1011811, chromium:1079233
Change-Id: Ia54603a0ecd19787dedd9cd25cf8bfe25771a8d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199131
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-14 12:01:24 +00:00
Andrey Kosyakov 8ad44a779e Ignore getResourceTree responses with invalid URLs 
Test is downstream: https://crrev.com/c/chromium/src/+/2200430

Bug: 1078135, 1081270
Change-Id: I4381429951f301f9461947568d4539bcd783fc56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200666
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-14 10:15:54 +00:00
Tim van der Lippe d0ed351152 Update TypeScript to 3.9.2 
DISABLE_THIRD_PARTY_CHECK=TypeScript update
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I14c8201cf46b78b73afdc4cd7d68c8c87a2cf697
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199124
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-14 10:14:34 +00:00
Tim van der Lippe c1b68e2514 Emit fixes for TypeScript 3.9.2 
These fixes are required to fix the declaration files emitted
with TypeScript 3.9.2

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: If7c29221d31c228b0d0bbbd2949168de0f68444d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199079
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-14 10:10:34 +00:00
Philip Pfaffe 457095815d Libraryize the symbol server 
To simplify adding multiple drivers (such as native and wasm), this CL
pulls apart the driver and library components of the tool into separate
directories.

Change-Id: If15ae7490e56ada1fa1fee6c4c856f97372bdecf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2187625
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2020-05-14 08:40:24 +00:00
Paul Irish 67aa7a28dd Audits: Roll Lighthouse 6.0.0 (7e4fa5587) 
Built from https://github.com/GoogleChrome/lighthouse/tree/v6
Diff: https://github.com/GoogleChrome/lighthouse/compare/dt-600rc1..v6
Bug: 772558
Change-Id: I9979d26bb09613873b2b65fd293c1b5a8905e009
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200644
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2020-05-14 08:07:24 +00:00
Kayce Basques 01fa8b73e9 Add WNDT84 
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=986998#c30

Bug: 986998
Change-Id: I0510daef5903458b4eb61cbb98df3ef3aa6a2755
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2195557
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Kayce Basques <kayce@google.com>
 2020-05-14 07:54:35 +00:00
Yang Guo b8584478dd More specific OWNERS where appropriate 
DISABLE_THIRD_PARTY_CHECK=no code change

Change-Id: I02f6ae91f7412c287ecf931e5681c1c882faa26c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198956
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-14 06:52:14 +00:00
devtools-ci-autoroll-builder a68a625dfd Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I5c928a9d552d0b2f61ac41096623c41a9e02fae6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200640
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-05-14 06:21:44 +00:00
Benedikt Meurer 1c890492a7 [wasmparser] Use standardized text format for variable instructions. 
https://webassembly.github.io/spec/core/text/instructions.html#variable-instructions
specifies that the variable instructions use `local.get` instead of
`get_local`, `local.set` instead of `set_local`, and so on. This
changes the disassembler (and the internal names) to match the format
in the standard.

Ref: wasdk/wasmparser#39
Bug: chromium:1043031
Change-Id: I3199443f2c3af003833fc036713e5f1f983e4bb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199080
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2020-05-14 06:16:04 +00:00
Alex Rudenko 7bf4d03c58 Move overlay implementation to DevTools 
This CL moves the implementation of inspect_tool_highlight.html to
DevTools, sets up a separate resource build target containing code
bundles produced by rollup. Also, it adds size checks and sets up
an example test. The future CLs will cover the rest of inspector tools
and better tests. A follow-up CL for Chromium to use the newly generated
resource is prepared[1].

[1] https://crrev.com/c/2194865

Bug: 1078267
Change-Id: I1c66e3c2aaec04c2f07fab8623d674ada95d8b24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192892
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-05-14 06:05:14 +00:00
devtools-ci-autoroll-builder 0e2e530e15 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/1ea3c3a..a93cb80

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8280ae5..30ef5cb

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I95a92a7c7e2f59bab36cc50e18d4382f252ccc0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200229
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-05-14 03:17:34 +00:00
Songtao Xia c2ed931621 [Emulation] Dual screen support frontend 
Behind an experimental flag, this adds support for dual screen device:

1. Two devices are added. Surface Duo and Galaxy Fold
2. Device orientation spec is extended to include dual screen mode:
horizontal spanned and vertical spanned.
3. Device may have a hinge in dual screen mode, which is shown if
provided.
4. Emulation bar has an extra button to span: extending the device view
from single screen to dual screen. New icons are added.
5. Rotation and other emulation related functions work fine with the
presence of a hinge.

Screenshots:
1. Duo dual screen (two horizontals):
https://imgur.com/FCVzlLS
2. Duo dual screen (two verticals, rotation of 1):
https://imgur.com/WNrIlp7
3. Duo dual screen with other highlights:
https://imgur.com/hPNZKnE
4. Experimental flag:
https://imgur.com/CzDVKKt
5. Flag is off by default (note that Duo is listed but span button
is hidden):
https://imgur.com/2kO0LQq
6. Fold secondary (folded slender):
https://imgur.com/MM85hOR
7. Fold main (unfolded, after rotation of 6):
https://imgur.com/qs8YBHy

Change-Id: I21e440590f7c75dccc9c8f7b420ede8b830c4b14
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2183217
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Songtao Xia <soxia@microsoft.com>
 2020-05-14 00:12:44 +00:00
Paul Irish bf20468f57 Audits: Roll Lighthouse 6.0.0-rc.1 (0d6f7e799) 
Adds: desktop scoring for LCP/TBT, Snyk roll, Score calculator link
Fixes: Uses pubads-1.1.0-beta release

Built from https://github.com/GoogleChrome/lighthouse/tree/dt-600rc1
Diff: https://github.com/GoogleChrome/lighthouse/compare/dt-600rc0..dt-600rc1
Bug: 772558
Change-Id: Ib725c3f3a87abe75243051233a2f621e19ee71d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199999
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2020-05-13 23:38:54 +00:00
Paolo Severini 0a227c84a5 Make DWARFSymbolServer build on Windows 
- Updated README.md with Windows build instructions.
- Fixed a couple of minor build issues on Windows.

Change-Id: Ic1a04d3295b8194b035fd9620169b89339873346
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198196
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-13 21:59:54 +00:00
Jose Leal Chapa 8355052cad Add e2e test for Animations panel 
Bug: 1079076
Change-Id: Iea721a119ea1d36c5e93e13a31e047385778d740
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192317
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-05-13 17:58:45 +00:00
Christy Chen cbe422760f third_party review for i18n infrastructure scripts 
This CL adds two build time scripts (collect-strings.js and bake-ctc-to-lhl.js) that won’t be shipped with the product. The scripts are used to collect the localizable resources from the DevTools frontend, construct .ctc.json files and convert them into .json format

The i18n infrastructure scripts are required for the localization of DevTools.
See DevTools localization design doc https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit?ts=5d945064#heading=h.iqvhsrml3gl9

Two scripts are ported from Google Lighthouse project
collect-strings.js:
https://github.com/GoogleChrome/lighthouse/blob/f3d0e3459d8fd15b055148dec0ae4e430df6495b/lighthouse-core/scripts/i18n/collect-strings.js
bake-ctc-to-lhl.js:
https://github.com/GoogleChrome/lighthouse/blob/f3d0e3459d8fd15b055148dec0ae4e430df6495b/lighthouse-core/scripts/i18n/bake-ctc-to-lhl.js

Change-Id: If5ea844e56d2d2b4587a041337b43bfd42d3a2af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2173686
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
 2020-05-13 17:48:45 +00:00
Christy Chen 1a7ab6e05d front_end/third_party review for i18n.js 
This CL adds one script(i18n.js) that will be shipped with DevTools. The script is used to enable runtime string replacement. DevTools is already shipping a version of i18n.js inside lighthouse bundle, and the i18n script in this CL let other parts of the DevTools can consume i18n besides Lighthouse tool.

The i18n.js is required for the localization of DevTools.
See DevTools localization design doc https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit?ts=5d945064#heading=h.iqvhsrml3gl9

Two script is ported from Google Lighthouse project
i18n.js:
https://github.com/GoogleChrome/lighthouse/blob/f3d0e3459d8fd15b055148dec0ae4e430df6495b/lighthouse-core/lib/i18n/i18n.js


Bug: 941561
Change-Id: I79bff0f26eeea3a2d036629eca0b19a641d32059
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119671
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-05-13 17:40:45 +00:00
Michael Liao a9794c3cfc [Styles - Swatch Popover]: Fixing failure where SwatchPopoverHelper._view is undefined in a SwatchPopoverHelper.reposition call 
Issue:
- SwatchPopoverHelper.hide is triggered via focusout/blur event listeners
- SwatchPopoverHelper.reposition is triggered via a SizeChanged event through its parent class (ColorSwatchPopoverIcon)
- hide will delete this._view and reposition does not handle the case where this._view is undefined
- We are exposed to the scenario where the focusout/blur events are queued up before the SizeChanged event
  - in this scenario, this._view is deleted and causes a failure in reposition(...)

Changes:
- Protecting against the scenario above by adding a "this._view" check at the beginning of reposition

Bug: 1081532
Change-Id: I216dca5b7f27cd302424ba2bd178f2bc206d5381
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2195541
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2020-05-13 16:51:25 +00:00
Eric Leese 85929a4b04 Add test case for C++ namespaces 
Bug: chromium:1056264
Change-Id: I6e40869b7bafe3f669183e4568f84398beb53d39
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199127
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-13 15:51:51 +00:00
Benedikt Meurer d4131e6fbd Enable proper syntax highlighting for WebAssembly text format. 
Previously we just used JavaScript syntax highlighting for WebAssembly
text format, which is obviously not ideal.

Bug: chromium:1042721
Change-Id: I57e98f0ccd1361822fef077e674d0a42371f9642
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199132
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-05-13 15:42:51 +00:00
Maks Orlovich fc32e0d59e ch-ua emulation: match GREASE and arch changes in Chrome 
Chrome started randomizing the brand list (in a deterministic
way), and stopped including architecture on Android, so match
that when emulating Chrome.

(The brandlist generating code is straight up translation of
 aarontag@'s code for that in Chrome)

See:
https://chromium-review.googlesource.com/c/chromium/src/+/2196403
https://chromium-review.googlesource.com/c/chromium/src/+/2181733

Bug: 1073909
Change-Id: If18b2bf32eaa5fd8d6c188cbd2d45c5b4370ba00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2197235
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-13 15:18:11 +00:00
Alex Rudenko 8c83a073ae Typecheck TracingModel.js 
Enable typechecking for TracingModel.js

Bug: 1011811, 1079233
Change-Id: Ia7c3a3752338d4e793def8d676dff678b39c5b1b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2196385
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-13 14:44:01 +00:00
François Beaufort 9fee874360 Show manifest shortcuts in Application panel 
This CL adds support for web app manifest shortcuts to the Application
panel. It makes sure shortcut icons follow same validation errors
as manifest icons.

Screenshot: https://i.imgur.com/gTO2eMy.png
Test: https://app-shortcuts.glitch.me/
Spec: https://w3c.github.io/manifest/#shortcuts-member

No-Presubmit: true
Change-Id: I3e451b18eb7bf84b2f338ed60cf874c5d4bb25e4
Bug: 955497
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2197436
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-13 14:38:41 +00:00
Tim van der Lippe ee6e3e9141 Add missing generic types 
This is required for the TypeScript 3.9.2 upgrade

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I4336ee694b7b77344e13e3aded89d3db432cf6c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199126
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-13 14:34:31 +00:00
Tim van der Lippe e812fa900d Add missing return types for front_end files 
These are required for the TypeScript 3.9.2 upgrade.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I85f8f2bbfa1366743a365cdcade04adcb94e5c60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199123
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-13 14:26:01 +00:00
Peter Marshall 327d14ae50 Remove unused profiling frequency as a trace option 
The backend doesn't do anything with this argument.

This code calls into Tracing.start:
https://vanilla.aslushnikov.com/?Tracing.start

Which is implemented in TracingHandler::Start()
Which calls TraceConfig::InitializeFromStrings()
Which does not look for the 'sampling-frequency' string.

Change-Id: Ieb0a71ce9a8b7bab52fe657ddc525614f71d94f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199117
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
 2020-05-13 14:11:11 +00:00
Tim van der Lippe 403a88dd52 Add missing return types for function parameters in ui/ 
These are required for the upcoming TypeScript 3.9.2 upgrade.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ibb7000f4c70863549bf6ce160a9fb89cb163e6f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199122
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-13 14:09:01 +00:00
devtools-ci-autoroll-builder 6f60dca882 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/398b73d..1ea3c3a

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I1da164a2b9929849ab255719d5572c645b3f017f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198656
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-05-13 12:54:21 +00:00
Tim van der Lippe 86e3a6a5ad Add missing return types for function parameters in sdk/ 
These are required for the upcoming TypeScript 3.9.2 upgrade.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I6e9d568ea8a9c7482d355a7d8bc084a579a0202e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199120
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-13 11:31:01 +00:00