Previously, when a network UISourceCode was open, and a persistence
binding appeared, the user was transferred over to a new SourceFrame
for the filesystem UISourceCode. This resulted in an annoying flicker,
and caused a loss of undo history.
Bug: 778043
Change-Id: Ie846f96d3c4f2553e8a78db5259f394e358f94fa
Reviewed-on: https://chromium-review.googlesource.com/1015195
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552267}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4435c448310d3850f31c65509f2dfce32ddf594e
This patch merges some variables together which were seperate inf
JavaScriptSourceFrame, takes @unrestricted off of the plugins, and
renames JavaScriptSourceFrame to DebuggerPlugin where appropriate in
tests.
Bug: 778043
Change-Id: If1d86f46afff1bf0af328090a15a5a1bc92726d7
Reviewed-on: https://chromium-review.googlesource.com/1015650
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552218}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ffc418d98575770088e992d1e88bcd95d6395bea
- Adds an empty 15px space directly below the Console
prompt's editor.
- Updates "isScrolledToBottom" logic in Console to account
for the new space. Without this update, typing on the
prompt's last line will not "jump + stick to bottom"
as expected.
With this CL, overlay scrollbars (e.g. on Mac), should
never cover the prompt's editor.
Bug: 725249
Change-Id: Ib0167f6919d5b9942e7f2dc4d8cf0c15fc9368df
Reviewed-on: https://chromium-review.googlesource.com/965020
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 06e046ba940fb6dffe3bbed45b85fb840b4a9194
The contentEncoded bit would sometimes be lost if a revision was added
before the original content was recieved.
The ImageView was not waiting long enough before calculating the image
size.
Missing content failures were not being detected.
Change-Id: I6bf7069fe7ee185b24be60ebceb023613af76a99
Reviewed-on: https://chromium-review.googlesource.com/1008864
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550358}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 774d5e9188fbd15ff84c187540b6694fb21aa744
Devtools keybindings to Actions are not disabled when the associated
command is disabled. The recently added Focus Debuggee command used F12
as a key binding but this had undesirable behavior when the DevTools
were docked in the browser window. This CL removes the F12 key binding.
Bug: 821285
Change-Id: I6acd66e01ba9a8ef3a8a082bd18e7da569ff347f
Reviewed-on: https://chromium-review.googlesource.com/1010469
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550328}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b0f3a6bd2b46f98007eedf120865687f7b104311
Previously the Lighthouse audit wasn't waiting long enough before
trying to linkify the node paths, creating a race condition.
The fix is to wait a bit longer, for the load event, instead of
main frame navigated.
Change-Id: I8c57e894bfa76ed50fa4c41bbaf2b3c49b0db211
Reviewed-on: https://chromium-review.googlesource.com/1006116
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549897}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d458cc5819fe36bfcba4a9811dc931ff3785ec0a
This gets the highlighter type from the network UISourceCode, if it
exists. For overrides files with no extension, they will stay colorful
as long as they are bound.
Change-Id: I5f1ff41f54eabb7a7f1abf1aa27b19629529fbfd
Reviewed-on: https://chromium-review.googlesource.com/1003875
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549683}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e832b8e15e96305ca27ce44aaa95e910ffc42ace
This adds a _serializedFileOperation method to IsolatedFileSystem
which waits for all pending DevTools reads/writes to finish for
a file path.
Change-Id: I5a1dd55dbe40ae0bf8335bc8e1994c1209fcc999
Reviewed-on: https://chromium-review.googlesource.com/991201
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549628}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 70c0896fddc9b319eb3728438c6959c35907b35a
Renames "WebKit/source" to "blink/renderer" references in DevTools.
Skipping presubmit for protocol.json and CodeMirror (usually
requires words "roll CodeMirror" in description when making changes
in cm/ or cm_modes/).
NOPRESUBMIT=true
Bug: none
Change-Id: Iadb44142a5ae1058dae656b93e904c7636f1fa32
Reviewed-on: https://chromium-review.googlesource.com/1003033
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549220}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aff59449a34f98ed04cd94547f0ceaaf25d38f71
Erik Luo