Commit Graph
43 Commits
Author SHA1 Message Date
Nikolay Vitkov b4e8dc7ac2 Update EsLint v9
Bug: none
Change-Id: Iebcc53c0f70a51242f22e4df167cd588b08cefcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140633
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
2025-01-07 05:41:31 -08:00
Nikolay Vitkov 937f463144 Revert "[eslint] Prefer TypeScript interface over type aliases."
This reverts commit af6c6337aa.

Reason for revert: The latest version of EsLint v9 does not work with the plugin added here, also the rule does more that just change shape objects from type to interface.

Original change's description:
> [eslint] Prefer TypeScript `interface` over type aliases.
>
> We have a mix of `type` and `interface` usage throughout our codebase,
> that is sometimes difficult to follow and reason about. We should follow
> the suggestion from the TypeScript PM and use `interface` consistently
> where possible. This leads to better type display in errors and makes
> our codebase easier to read (b/c consistency).
>
> This CL adds the `etc/prefer-interface` ESLint rule to accomplish this.
>
> Fixed: 387237537
> Change-Id: Idd6775094ba94b8397f626191788437f6b156dc6
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6135001
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>

Bug: 387237537
Change-Id: I6ecf18bfdaa4ad9efb17f0801def528035f9e703
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140555
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
2025-01-03 09:42:50 -08:00
Benedikt Meurer af6c6337aa [eslint] Prefer TypeScript interface over type aliases.
We have a mix of `type` and `interface` usage throughout our codebase,
that is sometimes difficult to follow and reason about. We should follow
the suggestion from the TypeScript PM and use `interface` consistently
where possible. This leads to better type display in errors and makes
our codebase easier to read (b/c consistency).

This CL adds the `etc/prefer-interface` ESLint rule to accomplish this.

Fixed: 387237537
Change-Id: Idd6775094ba94b8397f626191788437f6b156dc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6135001
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2025-01-02 03:42:22 -08:00
Nikolay Vitkov 65f45cc921 [deps] Update TypeScript EsLint parser
Update the @typescript-eslint - eslint-plugin and parser to v7.18.0
cia incremental patches.
This is the last version before breaking changes need to start be applied to the infrastructure.
Needed to update EsLint to v8.56.0 as required by the above major v7.
Only one new error was uncovered in test file and fixed.

No-Presubmit: true
Bug: none
Change-Id: I4e4fe265b82deeb49786c5bf3e154dac8fcfecbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6054130
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
2024-11-29 13:15:35 +00:00
Alex Rudenko 6562717533 Bump puppeteer to 22.8.2
Bug: none
Change-Id: I4ac9c6a9685a4699ddf91c71a88ad070f43128b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5756162
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2024-08-02 09:19:05 +00:00
Simon Zünd aebbf4f106 [deps] Update 'eslint-plugin-jsdoc' to 46.10.1
This silences a warning because our Node engine is newer then the
package expects.

There are newer versions of the plugin by now, but the transitive
dependencies are younger than 1 week so the audit mirror blocks them.
46.10.1 seems like it was stable for a couple months so we use that.

R=alexrudenko@chromium.org

Bug: None
Change-Id: Icf1c1276852e55dcad97d2ea2eeb6a8d7a9d82ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5660063
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2024-06-27 09:26:18 +00:00
Simon Zünd 73104de8cd Revert "Update puppeteer-core to 22.10.0"
This reverts commit 8c51286814.

Reason for revert: Causes e2e failures on CI

Original change's description:
> Update puppeteer-core to 22.10.0
>
> Bug: none
> Change-Id: Iac037f0e23af8660ed6014b91e7ebfdf7d45aec7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5596376
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: none
Change-Id: I101d94fc6b652481162d85057c1c047a217601a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5600358
Auto-Submit: Simon Zünd <szuend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2024-06-05 06:20:14 +00:00
Alex Rudenko 8c51286814 Update puppeteer-core to 22.10.0
Bug: none
Change-Id: Iac037f0e23af8660ed6014b91e7ebfdf7d45aec7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5596376
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-06-05 04:55:13 +00:00
Alex Rudenko af11b7ca25 [test] Update Puppeteer to v22
DISABLE_THIRD_PARTY_CHECK=updating deps

Bug: none
Change-Id: I12b06b26f0bb0b938666c7748198187259fcd9fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5268589
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2024-02-07 07:11:54 +00:00
Alex Rudenko 1552f2b3ac Update puppeteer in node_modules
Bug: none
Change-Id: I47c32ffa1ee9f34bdfccb930d288a364afaa280f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4675897
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2023-07-11 12:54:29 +00:00
Randolf Jung bcb3bc8d41 Update puppeteer and @puppeteer/replay
- puppeteer replaced with puppeteer-core (20.7.3). DevTools does not actually need puppeteer as it downloads the browsers on its own. PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not needed too.
- @puppeteer/replay upgraded to 2.11.2

DISABLE_THIRD_PARTY_CHECK=requires code updates for puppeteer-core
Bug: none
Change-Id: I173c228d766681a1a8a9ada3fcf17525cd191726
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4640022
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
2023-06-26 18:05:57 +00:00
Jack Franklin b6e869c1ff Update @typescript-eslint/* deps
Following the update to TS 5.1.3, updating the ESLint plugins too.
Includes a couple of small fixes where more floating promises are now
detected.

DISABLE_THIRD_PARTY_CHECK=source file changes to fix issues

Bug: none
Change-Id: Ia4b346ded7a63abed3dfc08db5f7b15baf6a40c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4584591
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2023-06-02 14:33:49 +00:00
Jack Franklin 98d9d46d28 Upgrade TypeScript to 5.1.3
DISABLE_THIRD_PARTY_CHECK=TS upgrade and source code changes.

Bug: none
Change-Id: I21244e75a24e8e323ef40c696254e552f3956e6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4583215
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2023-06-02 13:05:48 +00:00
Randolf Jung 95337a1834 Update puppeteer to 19.11.1
Bug: none
Change-Id: I8cc107acb06ac82bb6c6b060c86a6346a09d464a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4475485
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Auto-Submit: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2023-04-25 16:12:28 +00:00
Jack Franklin 2703ce56ba Upgrade @typescript-eslint packages
After upgrading TS to 4.9, we need to upgrade these packages so they can
parse the new TS features (such as the `satisfies` keyword).

Bug: 1392651
Change-Id: I85466727628e37b5b63c0f1e45484324fd05b8fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4046522
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2022-11-28 11:31:39 +00:00
Jack Franklin 2204d75049 Upgrade TS to 4.9
DISABLE_THIRD_PARTY_CHECK=TS upgrade.

Bug: 1392092
Change-Id: I3a5f352b12914ea6f908118fe6fda8ca3286cae5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4041404
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-11-21 15:14:06 +00:00
Jack Franklin e7a4dd0e8a Upgrade ESLint+TypeScript node_modules
Bug: none
Change-Id: I1f99b10bc418d589cb11adba64ef2211bede5cd8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3757653
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2022-07-13 11:51:00 +00:00
Simon Zünd 7a5852438e Update @typescript-eslint/plugin to 5.20.0
Our current @typescript-eslint version does not support TypeScript 4.6.
The update fixes that.

.eslintrc.js changes taken from https://crrev.com/c/3583292.

DISABLE_THIRD_PARTY_CHECK="Update contains a breaking change. Requires
updated config"

Bug: None
Change-Id: Id1d9f4f073f068ec95af6632a6d061adbee63cca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3592593
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-04-19 07:12:14 +00:00
Tim van der Lippe b693eb34d5 Update remaining NPM dependencies
DISABLE_THIRD_PARTY_CHECK=NPM fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I41baa3294f88b7e4463fdc580c050932c5abe40e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372932
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:42:53 +00:00
Tim van der Lippe 953e537f89 Update typescript-eslint
DISABLE_THIRD_PARTY_CHECK=ESLint fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3c9830be1bf007e8443d1664d3979625d175248d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372929
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2022-01-07 14:30:30 +00:00
Tim van der Lippe 0ceb465d1c Update ESLint and plugin packages
R=jacktfranklin@chromium.org

Bug: none
Change-Id: If1b2420ba6e1c100c3d6b2013815ff1a555ea987
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369367
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-01-06 15:06:40 +00:00
Johan Bay 72ea2d5c4b Revert "Update NPM dependencies"
This reverts commit 192c3d4ee1.

Reason for revert: Puppeteer's types.d.ts is broken.
See crrev.com/c/3320453.

Original change's description:
> Update NPM dependencies
>
> Update puppeteer to version 12.0.1
>
> Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
> Bug: none
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
> Commit-Queue: Johan Bay <jobay@chromium.org>
> Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Ia73b4360e062e5cfb932ae4af96d28af32c79973
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3320462
Auto-Submit: Johan Bay <jobay@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
2021-12-08 11:13:19 +00:00
Johan Bay 192c3d4ee1 Update NPM dependencies
Update puppeteer to version 12.0.1

Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
2021-12-07 09:32:13 +00:00
Tim van der Lippe c4035e3b0d Update TypeScript to 4.5.2
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I24da805038bd5d1d88dfad689f7a4ccf894af904
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-24 12:24:53 +00:00
Tim van der Lippe 0fb47801b6 Upgrade ESLint
This pulls in version 8, which covers numerous breaking changes. Most
notably, the `CLIEngine` class has been removed, for which we should now
use `ESLint`.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3b64600e690f073d4db19fb34539db7200f3b561
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268298
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-11 09:11:25 +00:00
Tim van der Lippe 6ddb01d4f5 Upgrade typescript-eslint
This also includes some fixes in the rule implementations that are
required for the 5.0.0 breaking change as documented in
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0
which lists the AST-Spec changes. Specifically, `ClassProperty`
was renamed to `PropertyDefinition`.

DISABLE_THIRD_PARTY_CHECK=Requires AST changes in ESLint rules
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I1d107b071fa265af8e178ee5e229f4a9d2f00d75
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268295
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-08 16:19:39 +00:00
Tim van der Lippe 8fc2d46d56 Update types and typescript packages
- Update all `@types` packages to the latest version
- Updates TypeScript to 4.4.3

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia6482e6d53428f962cec2561823d2db66631f4e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158342
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-09-13 15:44:39 +00:00
Tim van der Lippe a66194127a Update linter packages
- Update ESLint
- Update typescript-eslint
- Update eslint-plugin-import
- Update Stylelint standard config

R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=ESLint fix

Bug: none
Change-Id: Ic1efac8b4f7b085b8f2b792a76b8b99b9f583da3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158225
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-09-13 13:34:28 +00:00
Tim van der Lippe 2c89197d0d Update ESLint-related packages
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: none
Change-Id: I52dc24b12e350787085c5e3d131cface7ea87142
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060705
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-07-30 11:02:26 +00:00
Simon Zünd 52e202093a [deps] Upgrade eslint to 7.28.0 and typescript-eslint to 4.27.0
R=tvanderlippe@chromium.org

Bug: 1057042
Change-Id: I0c658894c7c75a773e39314c66862c7af76d876c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2963817
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-06-16 09:10:18 +00:00
Tim van der Lippe a0dce6da2f Add NPM packages for coverage instrumentations
These packages and types are required to implement code coverage
instrumentation in interactions tests.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1206705
Change-Id: Ie9c4f04dd93acc1c0fbab8ffa2be73dc4af076a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2879985
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-05-10 12:26:02 +00:00
Tim van der Lippe 685c0b8953 Update typescript-eslint and type packages
R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=TypeScript-eslint update

Bug: none
Change-Id: I4e22f8fe3e2c089331a6615c47916860237e7596
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815123
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-09 12:39:43 +00:00
Tim van der Lippe 0a9b84dbd8 Update NPM dependencies
Major updates to Puppeteer (Chromium roll and updates to types:
https://github.com/puppeteer/puppeteer/blob/0b5969dea9048dc34a4d2e109e96c42e8928182c/CHANGELOG.md#800-2021-02-26) and Sinon (unaffected by browser support changes).

DISABLE_THIRD_PARTY_CHECK=NPM updates
R=jacktfranklin@chromium.org

Fixed: 1176642
Change-Id: I419300fc573e8086b4a7b3b6281c81602890f8d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2782553
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-03-24 13:47:34 +00:00
Jack Franklin 9fd84dfc8c Add postcss to Node deps
We already had PostCSS as an implicit dep because stylelint depends on
it. I need to use its API to parse CSS for some of the dark mode
migration, so I'm moving postcss to be a top level dep.

DISABLE_THIRD_PARTY_CHECK=updating node modules

Bug: chromium:1152736
Change-Id: I93919fb2d676337604209cf6bf9c8570f98bd5e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2780799
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-03-23 10:52:17 +00:00
Tim van der Lippe 6d109a9d45 Update Mocha to 8.3.0
This also adds Python-2.0 to the list of accepted licenses.

Lastly, it fixes a bug where the package.json files were incorrectly
reordered. For the `exports` of a particular package, the order that
the entrypoints are defined in is crucial. Therefore, we should not
alter the order of entrypoints and instead maintain the originally
defined ordering. We can use an `OrderedDict` to ensure that Python
always loads the JSON files in the same order.

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I5a309782de6015edea6ba3b502aa0db1f008d973
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692909
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-02-17 12:08:49 +00:00
Tim van der Lippe cf4ab40452 Update typescript-eslint to 4.15.0
This also fixes a bug in the PRESUBMIT that ensures that, whenever
we update typescript-eslint, we correctly rerun the full linter
check.

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I016f73b26cd84cabf3171aba89c88a0d72820f1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692165
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-02-12 15:42:37 +00:00
Tim van der Lippe efb716af67 Update linter packages
- Updates stylelint to 13.8.0
- Updates ESLint to 7.14.0
- Updates @typescript-eslint to 4.9.0

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: I207e204607ede782710e042c17d6510c7f696905
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566806
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-12-01 16:04:40 +00:00
Tim van der Lippe afe76b65c9 Update @typescript-eslint packages
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0
none of the breaking changes apply to us.

DISABLE_THIRD_PARTY_CHECK=NPM updates
R=jacktfranklin@chromium.org

Change-Id: Id61788dc65d352f7ecffaea9cf1918141ae3f842
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2537959
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-11-16 15:53:09 +00:00
Jack Franklin 264237a972 Upgrade TypeScript ESLint dependencies.
DISABLE_THIRD_PARTY_CHECK=node_modules update

This was an attempt to fix https://crbug.com/1102821 however the issue still
appears. I expect it will until TS4.0 is out of beta and the ecosystem catches
up.

We were however on a much older version so I took the opportunity to update us
to the current latest version.

Change-Id: I8332409e9de50d60f6284eef5098b55a7f9535c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2299995
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-07-15 09:29:44 +00:00
Tim van der Lippe 2a1ede5c26 Fix newline additions in package.json files in node_modules/
`manage_node_deps.py` was changed in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259834
to add line endings at the end of the package.json file

However, `npm run install-deps` was not rerun to add the line endings.
To prevent future CLs that add deps to include the line ending changes,
fix them in this CL.

R=mathias@chromium.org

Change-Id: Id4ee0003520c4aa0cb55494cdf64df57e31a86d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2263952
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-06-24 12:59:49 +00:00
Mathias Bynens 779b5ea094 Roll Puppeteer v4.0.0
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Change-Id: I37d4670cf18e26e8caa8a5b1ca19c8f187244bac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259851
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-06-23 12:40:26 +00:00
Tim van der Lippe e4974ddc4c Remove whitespace at the end of the package.json lines
json.dump appears to add extraneous spaces before newline characters. By
specifying the separators option, we can remove these whitespaces,
reducing the diff noise. Solution taken from
https://stackoverflow.com/questions/16311562/python-json-without-whitespaces

DISABLE_THIRD_PARTY_CHECK=Fix whitespace in node_modules

Change-Id: I26556e5053f19a9021ad41779319bdfe3f8c2b6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013154
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-01-22 15:17:25 +00:00
Tim van der Lippe 8aaca9e8f1 Update node_modules to include typescript-eslint
DISABLE_THIRD_PARTY_CHECK=Updates package.json

Bug: 1041811
Change-Id: I9493880aed334f02e5899efed3fc8bb964d0bbb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1998770
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-01-14 13:05:28 +00:00