zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
17,373 Commits 45 Branches 79 Tags
5d07f613bd609d654b99c82347d4da79f381fa2d
Commit Graph
17373 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jack Franklin 5d07f613bd Add timing types to TimelineOverviewCalculator 
This CL updates the TimelineOverviewCalculator by moving it into its own
file, and changing its types from `number` to the `MilliSeconds` type.
This is important because the trace engine works primarily in
microseconds, so if we just use the `number` type we could easily get
into a confusing world where we are passing round numbers in different
units.

Bug: 1464206
Change-Id: I439c120c83950c2ca2cfa0c892b9f9065359dba7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4777912
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-16 09:07:39 +00:00
devtools-ci-autoroll-builder 76dc7d12fe Roll (puppeteer-core) 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

Roll created at https://cr-buildbucket.appspot.com/build/8772731396558250593

R=alexrudenko@chromium.org, devtools-waterfall-sheriff-onduty@grotations.appspotmail.com

Bug: none
Change-Id: I6eebe154ee382b712c188186df5c05db49fae0ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778895
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2023-08-16 07:23:32 +00:00
Jecelyn Yeen 2ee1b328c4 [overrides] Hide "Override content" for source mapped file 
screenshot: https://crbug.com/1473038#c2

Bug: 1473038
Change-Id: Ibb3a055cda783e85f9a6b8992d601b2f41709a24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778471
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-08-16 07:22:00 +00:00
devtools-ci-autoroll-builder cf884f0347 Update Chromium PINS 
Chromium pin updated to 118.0.5950.0

Roll created at https://cr-buildbucket.appspot.com/build/8772640800191021889

Bug: none
Change-Id: I237c4ec739985a18a196ee296939c14a7568dbe6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4782388
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-16 04:25:20 +00:00
devtools-ci-autoroll-builder 286169d43e Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/542e6f2..d7d4a53

Roll created at https://cr-buildbucket.appspot.com/build/8772640800191021889

Bug: none
Change-Id: I9ce77d6cced97457fa71f9dd851022bf0fcb5f6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4782387
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-16 04:24:18 +00:00
Yanling Wang 11ca806035 [Accessibility] Add keyboard navigation for 'save' button in Profile 
Sidebar

Currently, keyboard users are unable to access the 'Save' button present
inside the 'Snapshots' menu item.

This fix will allow keyboard users to navigate to the 'Save' button.
With the extra aria label 'Press enter to save file', users have enough
information to interact with 'Save' button.

Bug: 1472401
Change-Id: Ia946abaea35908e462e9bcb7d23292eb71941b4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778908
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Yanling Wang <yanlingwang@microsoft.com>
 2023-08-15 16:24:32 +00:00
Jack Franklin ef151c4a08 Remove TimelineModel#navStartTimes and TracingModel#navStartTimes 
Fixed: 1472229
Change-Id: I4e3fdcc9e6456125ad77d2b9e8225295eb982520
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4777128
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2023-08-15 16:09:26 +00:00
Jack Franklin 288e9f34c6 Add contextmenu shell for FlameChart 
This CL adds the starting shell for supporting context menus when a user
right clicks on an entry in the timeline, as part of the stack
manipulation work.

Bug: 1469887
Change-Id: I813cea510cac2d978500de6f5de2d344094232f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4768203
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
 2023-08-15 16:03:54 +00:00
Paul Irish 625cb73c8a RPP: Keep piechart at top regardless of legend height 
Bug:1472155
Change-Id: I586427bf9f69686d32b73b44a68240e966f6eb53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4779170
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-15 15:05:10 +00:00
Jack Franklin 4c1d236ee8 Fix warning in test helper 
This CL fixes an issue in Chromium where builds of DevTools cause the
following output:

```
 ../../third_party/devtools-frontend/src/test/shared/helper.ts:352:44:
      352 │ ...tion = runWithDescription.bind(this, description, innerFunction);
          │                                   ~~~~
          ╵                                   undefined

  This file is considered to be an ECMAScript module because of the "export" keyword here:
```

To avoid this, we can avoid using `this`. The target function
`runWithDescription` is an arrow function, so binding it doesn't make
any difference anyway.

Fixed: 1472963
Change-Id: Ia10b9e832c6fea5b2a41f0ba8286a412b805d39d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778469
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-15 11:50:52 +00:00
Paul Irish a38de5d30f RPP: Speed up decorations 
Each WARNING_TRIANGLE decoration was being repeatedly added to the
entryDecorations array on each draw. Instead we'll add each just once.

Separately, we were drawing the each decoration once per color bucket.
As they don't change per color bucket, we'll reduce total draw calls
by painting them in their own follow-up  pass.

Bug: 1472155
Change-Id: If3b158e5994036595ce2a825f9e3ed14da56f92b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778904
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-15 10:50:29 +00:00
devtools-ci-autoroll-builder d2d8004242 Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/193968c..542e6f2

Roll created at https://cr-buildbucket.appspot.com/build/8772731396558250593

Bug: none
Change-Id: I11c8f4d3358eb3e645d786d3a2c30b537e9bf4ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778894
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-15 04:16:33 +00:00
Jack Franklin b0c4fcea82 Remove setNavStart method from minimap and use new engine 
This CL updates the TimelineMiniMap to use the new engine for its
navigation events. We remove the explicit method that was used to set
the navigation start events, and instead calculate them via the new
engine.

I also renamed the MiniMap `updateControls` method to `setData` to
better reflect what it does.

After this CL the old engine's tracking of navigation start events is
entirely unused; I will therefore remove it but do so in a follow-up to
avoid this CL getting too large.

Bug: 1464206, 1472229
Change-Id: If5379434b8ea91504b3783b97f92b5fc7b4c127f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774407
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-14 17:53:23 +00:00
Nikolay Vitkov 8e38b97515 [Recorder] Fix Select color issue 
Wrong color in select options
Note: hover is OS specific and not changeable

Bug: 1472713
Change-Id: Ibcf110d2c2c4c4da3d6bd308493b0e78c2885196
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774405
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2023-08-14 16:12:54 +00:00
Jack Franklin d98e8fe9d3 Remove unused TimelineModel methods 
- `mainFrameID()`
- `timeMarkerEvents()`

Both of these are unused / only used in tests so can be removed.

Bug: none
Change-Id: I8778dd98217164939cb507dba7936572fbe86476
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774210
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2023-08-14 15:57:24 +00:00
Jack Franklin 4fde0a8b1b RPP: Throw out negative duration synthetic events 
We've found Animation trace events that have multiple begin events
per id2.local. They can create invalid entries, so we skip them.

Plus, small drive-by for a more terse sort comparator

Bug:1472375
Change-Id: I6c8125661da7afa76aa8eb74286df22bfba23d8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774709
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-14 15:39:09 +00:00
Jack Franklin fd0c29a000 Add alinavarkki@ to COMMON_OWNERS 
Bug: None
Change-Id: I48e95effbc3b519d0214c2d047cf0da8838815c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774206
Commit-Queue: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2023-08-14 14:01:51 +00:00
Eric Leese 23e6a0bdb7 Report step name when tests time out 
Adds the step name to the error message when a test times out.
Additionally provides a description for common waiting functions
so that we get a description of what the test was waiting for
when it hung.

Bug: None
Change-Id: Ieffc1cb537a66db0512f51745f552e49d029801c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774503
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-14 13:39:11 +00:00
devtools-ci-autoroll-builder 816666e4fc Update DevTools DEPS (trusted) 
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/7fc2793..a5ad157

Roll created at https://cr-buildbucket.appspot.com/build/8772788020622598369

Bug: none
Change-Id: I8c11e037a2b3af61e86659c31dea5761da036a94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4776194
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-14 13:07:15 +00:00
Jack Franklin 98466b1cc2 Update UIUtils to not worry about legacy events for nav adjustment 
Now that both the network and flame chart data provider return
navigations from the new engine, we can simplify the helper in UIUtils
to only worry about events from the new engine.

This is step one of a few CLs that will remove navigation start event
logic from the old engine entirely as we can rely exclusively on the new
engine for it.

Bug: 1472229
Change-Id: I64067f1e39742c17284ccbff8033044508cc4aae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4771027
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
 2023-08-14 12:09:34 +00:00
Jack Franklin 804d0c4d56 Generate Minimap markers from the new engine 
This CL moves the generation of markers (vertical lines on the minimap)
into the minimap component and removes its dependency on the old engine
- which means in a follow-up CL we can begin to remove some code.

This also means now that the Minimap generates the markers, rather than
being given them, which is why the screenshot tests are being updated in
this CL as they now have some new vertical lines on them which is
expected!

Bug: 1472229, 1464206
Change-Id: Ic5fa2706c9a843494bd3405bad64dd093582559f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770846
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2023-08-14 11:53:20 +00:00
Paul Irish 3885731717 RPP: Don't redraw the flamechart once per screenshot 
The flamechart had logic to debounce its scheduleUpdate(),
but crrev.com/c/4345505 accidentally removed it whilst
adopting the renderCoordinator.

This was most apparent in a trace with many screenshots (>200),
and opening the Frames track. The entire flamechart was redrawn
repeatedly, once per screenshot.

This CL restores debouncing logic and fixes this and probably other cases where redundant flamechart redraws were performed.

Bug: 1472155
Change-Id: I0786275fa52d7d853206beb72c0b4b86e3f033ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774716
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-14 11:25:11 +00:00
devtools-ci-autoroll-builder 68a78b7443 Update Chromium PINS 
Roll created at https://cr-buildbucket.appspot.com/build/8772821993686135569

Bug: none
Change-Id: I8642a8f70a4943b0e720c4fb6cee8d5828ccab4a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4775355
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-14 11:24:08 +00:00
devtools-ci-autoroll-builder c15cf6676e Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/4fb90f2..193968c

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a9a6f0c..7fc2793

Roll created at https://cr-buildbucket.appspot.com/build/8772821993686135569

Bug: none
Change-Id: I09bf76d4215c0927799e6ac1484534ac008a26a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4775354
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-14 11:23:05 +00:00
Jecelyn Yeen 8ec0a4f8be [overrides] Add margin to the pencil icon 
Network panel > response header > hover over to see the pencil icon,
Add margin right to make it stay away from the vertical scroll bar

screenshot: https://crbug.com/1469241#c5

Bug: 1469241
Change-Id: Ie1272256b157c84e48836f70b1db8b42786c2467
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4777900
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2023-08-14 11:22:02 +00:00
Paul Irish 3615697997 Create candystripe pattern just once, on-demand 
Bug:1472155
Change-Id: I3979aee111a1dfa56eec003c5614b6296abe7dd3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774979
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2023-08-14 11:20:58 +00:00
Paul Irish f743f9f631 Performance: Add DevTools.TraceLoad histogram metric 
Measures the time a trace is loading. Starts when recording is stopped or file/url load was started. Stops after the first render of the
flamechart.

Chrome CL: crrev.com/c/4774972

Bug:1472540
Change-Id: I9f6816ec2771c89106d3bd994cd5bae01da37127
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4776481
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-14 11:19:55 +00:00
Simon Zünd ae9845e539 [scripts] Add new 'rename-legacy-global.mjs' migration utility 
This CL is a temporary migration helper for the *-legacy.ts removal
effort. It's a slightly better search&replace that also adds the
necessary import statement if needed.

R=jacktfranklin@chromium.org

Bug: 1442410
Change-Id: Idcba121da6176f745db3e98d9e9ba0ac836d7b7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774939
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-14 11:18:52 +00:00
Nikolay Vitkov 0d92935d8e [Fix] Disable suspect test 
Disable test that fails and causes other test to fail.

Bug: 1472651
Change-Id: I8efcebe52b67ba8a1e571ffa826f851758cdffab
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4777699
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2023-08-14 11:17:21 +00:00
Jack Franklin 098bf1829f Add documentation on custom events in components 
Bug: 1344124
Change-Id: I61e00b2bb2f45106f1f3cab1c5ad867e268415b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774938
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-11 19:25:41 +00:00
Hadrien Jaubert 46cf6b82aa [Performance Panel] Update colors to material 3 
Change the background color of containers and toolbar to white.
Change border color of toolbar.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1472243
Bug: 1472243
Change-Id: I64b3c03b590782a540cbe9b8340ada5b1c44e133
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770843
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Hadrien Jaubert <hadrienjaubert@google.com>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2023-08-11 16:25:30 +00:00
Simon Zünd 62d81dec72 [search] Move SearchMatch comparator into SearchMatch class 
Small cleanup CL that moves the SearchMatch comparator into the
SearchMatch class as a static method.

An upcoming change also requires the comparator so we wanna share it.

Drive-by: Mark properties as readonly.

R=kprokopenko@chromium.org

Bug: 1468875
Change-Id: If8cb2532ebb4b201576376c35227a41ccc7954c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4768198
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2023-08-11 15:36:27 +00:00
Jack Franklin d38ffb5fb6 Remove remnants of TBT calculation from TimelineModel 
Bug: 1455498
Change-Id: I3ad054cca7929b7b1538dadc7ac4d980be90243a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4774438
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-11 15:35:23 +00:00
Eric Leese 40a97c18ac Fix source map infobar bug 
The "Source map skipped" infobar was sometimes showing on scripts
that had no source map at all because it could be triggered by
loading an unrelated source map.

Bug: 1459610
Change-Id: I315dbe5905fca76bdd13bf6c364ae8deeb7fade7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770695
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2023-08-11 14:06:29 +00:00
Eric Leese 1cfe387994 Use ignore listing to pre-filter Search results panel 
Bug: 1472019
Change-Id: I6fb91cb221447ebbf716475ddcd62dd27bc54bbe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770835
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2023-08-11 14:05:25 +00:00
Andrew Williams 3f88923ea2 [Cookies] Add warning message for cookies with disallowed characters 
Corresponds to the changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/4717730

I tested this locally and confirmed that it works as expected.

Bug: 1233602, 1228815
Change-Id: Ice74b8037299d08fa8fd10b5cad9123c14910a4e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4767278
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Andrew Williams <awillia@chromium.org>
 2023-08-11 13:43:25 +00:00
devtools-ci-autoroll-builder 73901bed6e Update Chromium PINS 
Roll created at https://cr-buildbucket.appspot.com/build/8773059810685025969

Bug: none
Change-Id: I0f5945cf7ad26c16686e030175f9c84e9a3116ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4773558
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2023-08-11 13:03:49 +00:00
Philip Pfaffe 67d3eec66c Update browser_protocol 
Bug: none
Change-Id: I7d24933c1e3596fe8de493aa5d172ac185d495bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770839
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2023-08-11 12:01:55 +00:00
Jack Franklin fc985ab838 Filter for main frame navigations in the MetaHandler 
Storing main frame navigations as we go rather than asking all the
callsites to do it is much more effective, so let's do that.

Bug: 1472229
Change-Id: I6e07fa433d553a66dd42e407515da3a18b3a3125
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770844
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
 2023-08-11 11:51:06 +00:00
Simon Zünd 82714dc02e Reland "[search] Rename panel/search/SearchConfig.ts to SearchScope.ts" 
This is a reland of commit 865fa23ae6

The reland CL adds changes to the search-legacy.ts file to map the
SearchScope/SearchResult properly on the Search global.

Original change's description:
> [search] Rename panel/search/SearchConfig.ts to SearchScope.ts
>
> After https://crrev.com/c/4765267 extracted the SearchConfig class to
> models/workspace, we should rename the remaining file to better
> reflect what it contains.
>
> R=leese@chromium.org
>
> Bug: 1468875
> Change-Id: Idfa3dcca627350b31fc7a0625b34944cbf04b332
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4765497
> Auto-Submit: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Eric Leese <leese@chromium.org>
> Reviewed-by: Eric Leese <leese@chromium.org>

Bug: 1468875
Change-Id: I6919a990f23913ffe009a7ea86ae8a9aad15d39b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770838
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2023-08-11 11:31:34 +00:00
Al Muthanna Athamina 3ca07b9609 Disable assertion for debugger lanuage plugins test 
Disable after resume assertion in the "can access wasm data directly"
test until we can find a way to remove flakiness by making the stopid
deterministic. Also include TODO and bug.

Bug: 1419802
Change-Id: I807e223cd44d08e560bc9c3f9bb21af934c0b116
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4771028
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2023-08-11 11:01:00 +00:00
Wolfgang Beyer 997a3fbb39 Fix scrolling behaviour when highlighting a request header 
- Scroll the header in the details panel into view
- Scroll the request in the list of requests into view

Video: https://i.imgur.com/On21YsP.mp4

Fixed: 1470193
Change-Id: I13ad1276693ddcb1970fbbf3d5953a1af55290ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770840
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2023-08-11 10:54:39 +00:00
Jack Franklin 65a445aa42 Disable flaking ApplicationPanelSidebar cookies test 
Bug: 1472237
Change-Id: I4b00fc21a8cb56ef302a0f26e6f8819b635a6691
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770842
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2023-08-11 10:47:56 +00:00
Hadrien Jaubert 70797cab06 [Protocol Monitor] Fix enums inside arrays 
Enums parameters nested inside were not displayed correctly because of the types for this particular was set to object and not string.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1471512
Bug: 1471512
Change-Id: I5e5336a0c222fa697ede61380c697fee45ced659
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4765073
Commit-Queue: Hadrien Jaubert <hadrienjaubert@google.com>
Reviewed-by: Nancy Li <nancyly@chromium.org>
 2023-08-11 10:31:01 +00:00
Jack Franklin 9e748461df Revert "Reenable source map test" 
This reverts commit e27e214ebb.

Reason for revert: this test is flaking again on the waterfall: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/13203/overview

Original change's description:
> Reenable source map test
>
> Bug: 1346228
> Change-Id: I0c1be9b57794c847530ab8373cbd15898092b8c8
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4760104
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Eric Leese <leese@chromium.org>
> Auto-Submit: Eric Leese <leese@chromium.org>

Bug: 1346228
Change-Id: I02d1b3b8c6c6916c2dff3ebe465cef1466b89a59
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770841
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2023-08-11 09:34:11 +00:00
Jack Franklin 6b5f443f4a Disable karma coverage if the build is not debug 
Coverage on a release build is inaccurate and we don't use it, but it
also slows down the tests due to the instrumentation. So if we detect a
release build, let's warn and also disable coverage.

Bug: none
Change-Id: Id669c417b5c9e2f3302d4e7359e3d79dc0c61215
No-Tree-Checks: True
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770777
Reviewed-by: Liviu Rau <liviurau@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-11 09:31:40 +00:00
Jecelyn Yeen b1e6aade40 [network] Align Status dot and text in network details 
drive-by: rearrange the code
screenshot: https://imgur.com/a/EZmDQAN

Bug: 1471157
Change-Id: I74f1e4f46b41575a85470d3a2f195e6917b61df0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4761065
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2023-08-11 08:50:22 +00:00
Jack Franklin 3c2cf761e8 TimelineFlameChartDataProvider uses new engine for nav start events 
This introduces a small amount of duplication across the two data
providers which I will fix in a future CL and pull it into a helper.

Bug: none
Change-Id: Iccfd52220c09ea74acd1fd522f69759c2dddf165
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770775
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-11 08:48:29 +00:00
Jack Franklin a13abd8cd6 Rename navStartTimes() 
The name `navStartTimes` in the TimelineFlameChartDataProvider type was
confusing as it returned a map of NavigationID=>TraceEvent. But where we
used this function we didn't care about the navigationID or the map
structure. So in this CL I have renamed the method and changed it to
return an array to make it easier to work with.

Bug: none
Change-Id: Ia5855144839a2c8778b472645d7627ea7a2bb0f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770694
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-08-11 08:40:46 +00:00
Shuran Huang 07a5a61e4e Roll dependencies 
Follow third_party/blink/renderer/core/frame/deprecation/README.md
step 6.

Bug: 1469135
Change-Id: Ie1da545e3e91b6bf31d9b0b688440cf8c39ef92c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4770235
Auto-Submit: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-08-11 06:00:29 +00:00