Commit Graph
11167 Commits
Author SHA1 Message Date
Tim van der Lippe 60679104f6 Reland "Update to Node 16"
This reverts commit 86a7f83986.

Reason for revert: fixed sync on Mac

Original change's description:
> Revert "Update to Node 16"
>
> This reverts commit 69fd14af2a.
>
> Reason for revert: Breaks gclient sync on mac: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8831691191675479761/+/u/gclient_runhooks/stdout
>
> Original change's description:
> > Update to Node 16
> >
> > Chromium updated to Node 16, so we can do so too.
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Node
> > R=​szuend@chromium.org
> >
> > Bug: 1248945
> > Change-Id: Ibd983d3e94a849aa19ffd8b4cf36951c61748c93
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253581
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: 1248945
> Change-Id: Ie30e45513212cd8e6a88532ee14431741c181057
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257541
> Auto-Submit: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

DISABLE_THIRD_PARTY_CHECK=Updating Node

Bug: 1248945
Change-Id: I15473467092ddf463a941c2b5531ff53874981a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257662
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-02 12:52:59 +00:00
Tim van der Lippe f8b49324ba Remove panels/console/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I18b832b9b2a00e06fe9c93e24a21dfa39df23b43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253019
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-02 12:47:16 +00:00
devtools-ci-autoroll-builder eba9da2156 Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/1eb779c..21f6fd1

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I48a7fbed259465987a226d0ccc10988c78464e01
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256013
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-11-02 12:45:19 +00:00
Tim van der Lippe a98783c582 Remove entrypoints/inspector_main/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I144e809d2715d88574cfab757bd8b0b631dd8d64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253399
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-02 12:27:16 +00:00
Johan Bay 884171e732 Skip ignored nodes in accessibility pane
This change should have no effect at the moment, but it is made in
anticipation of changes on the backend that will include ignored nodes
in the AccessibilityModel.

Bug: 1226486
Change-Id: I58d2470d486e1041e126f4308c06c006c90659c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250784
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2021-11-02 11:38:49 +00:00
Johan Bay be03b85c18 Disable test for experimental a11y tree to unblock Chromium roll
Bug: 1265818
Change-Id: Ib16b463acfc988eb2af812551e4987c0de6bf78b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256543
Auto-Submit: Johan Bay <jobay@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2021-11-02 10:00:19 +00:00
Wolfgang Beyer 391d679781 Allow setting styles for each data grid column
Previously the content of the first column of every data grid was
centered. This change allows defining individual styles for each column
when creating a data grid.

Bug: 3253323
Change-Id: I300803243f5758bc9279e16c6dd14afdc3596566
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253064
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-02 09:57:24 +00:00
Simon Zünd 4c44dc592f [sync] Enable sync experiment by default
Drive-by: Mark the "consoleGroupSimilar" setting as synced.

R=alexrudenko@chromium.org

Fixed: 1245541
Change-Id: I15031094b609be0849f24f6f251f8d201c3a29ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256544
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2021-11-02 09:15:29 +00:00
Wolfgang Beyer f3925bb32b Add icon with link to header item of reporting API reports grid
This adds the ability to customise DataGrid header cells by providing
a LitHTML template result. This is used to add an icon with a link to
some documentation to the DataGrid which shows reporting API reports.

Fixed: 1260295
Change-Id: Id3636636afbbe598cb7110182d0315822e0b6ff4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252953
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2021-11-02 09:13:17 +00:00
Simon Zünd 86a7f83986 Revert "Update to Node 16"
This reverts commit 69fd14af2a.

Reason for revert: Breaks gclient sync on mac: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8831691191675479761/+/u/gclient_runhooks/stdout

Original change's description:
> Update to Node 16
>
> Chromium updated to Node 16, so we can do so too.
>
> DISABLE_THIRD_PARTY_CHECK=Updating Node
> R=​szuend@chromium.org
>
> Bug: 1248945
> Change-Id: Ibd983d3e94a849aa19ffd8b4cf36951c61748c93
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253581
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: 1248945
Change-Id: Ie30e45513212cd8e6a88532ee14431741c181057
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257541
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2021-11-02 09:11:20 +00:00
Alex Rudenko 2b96231c3a Test that whitespace minification is working
Using x-link as an example. Note that lit-html template
cannot be rendered inside the unit test file because
it seems those are not minified.

Fixed: 1264791
Change-Id: I53d428d5d1f9bb9e5a4258b076819f78cc9a1166
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253395
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2021-11-02 07:42:22 +00:00
Tim van der Lippe 69fd14af2a Update to Node 16
Chromium updated to Node 16, so we can do so too.

DISABLE_THIRD_PARTY_CHECK=Updating Node
R=szuend@chromium.org

Bug: 1248945
Change-Id: Ibd983d3e94a849aa19ffd8b4cf36951c61748c93
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253581
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-02 07:37:42 +00:00
Tim van der Lippe ae9e00a5c3 Make both text_editor and source_frame autostart
These modules contain CSS files that are about to be (partially)
removed with the CodeMirror 6 upgrade. To avoid merge conflicts and
breakages, let's make them autostart for now. This allows us to
clean up and remove numerous other module.json files, which were
blocked on just these two. In a future Chrome release, we will
remove the legacy text_editor altogether, at which we can remove
all these files.

R=szuend@chromium.org

Bug: 1127902
Change-Id: Ib44927067931f40a0212f4e0209815d736025000
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253018
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-02 07:23:42 +00:00
Tim van der Lippe 5c204eaf6e Remove panels/css_overview/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Id5b0b827a8e3e1435b4cfc0fc5d3ace2c948b2bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253398
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-02 07:06:32 +00:00
devtools-ci-autoroll-builder 5750cbd3da Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/f0fa7d2..1eb779c

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0f5bd4f..aebf624

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I638898939873a96a298acbe9ba7815511c7408e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256008
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-11-02 03:44:02 +00:00
Rob Paveza a654d5cfb3 Conditionally unset tree focusable in Events
When no event handlers are present for a given element, the focusable
tree outline would appear to be a line in tab-order. This change
corrects that issue by unsetting the tree's focusable state whenever
the tree has no elements (specifically when the "No event listeners"
message is visible).

After: https://imgur.com/a/r0TDY4n

Bug: 1171703
Change-Id: Iae79239c4c95ea5561d51515fe09062242e03835
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3193509
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-11-01 16:29:52 +00:00
devtools-ci-autoroll-builder 15f873cfa4 Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/bdfad5a..f0fa7d2

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ib2c80647ba85574492f893540028d4456b6bcbbf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3254954
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-11-01 12:41:13 +00:00
devtools-ci-autoroll-builder fdde1904ad Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/443dfa4..bdfad5a

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ia7cf798838fd4d51392bb02644b4934834d99159
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3254787
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-11-01 03:38:42 +00:00
devtools-ci-autoroll-builder 641505d73c Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3b0e838..443dfa4

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I8b9921768cab0c8e5c17f4abbfd3aa02f0e30e78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3254232
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-10-31 12:42:01 +00:00
devtools-ci-autoroll-builder 858b2aba5e Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d552bed..3b0e838

Rolling buildtools/linux64: git_revision:f847b5744a81d23b96de3f2e56ce0398f550bd0e..git_revision:8926696a4186279489cc2b8d768533e61bba73d7

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I9ddbe3b3eca18243c3c8f96a129bba97a38d5684
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3254489
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-10-31 03:38:21 +00:00
devtools-ci-autoroll-builder 1e2213ae6a Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/2dbe2b9..d552bed

Rolling buildtools/linux64: git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4..git_revision:f847b5744a81d23b96de3f2e56ce0398f550bd0e

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b3a1a79..0f5bd4f

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I2eaab1855cf337c7cb9b45838871b0f7d153ac7d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253906
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-10-30 03:40:05 +00:00
Marijn Haverbeke aaad5f15f1 Don't make the autocompletion option apply to non-sources editors
R=tvanderlippe@chromium.org

Bug: 1264815
Change-Id: I32acf9305589b5f6e9ce21f0f66834dc81b27c0c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253394
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-29 15:57:03 +00:00
Alex Rudenko 273b9aa203 ESLint: ban <a> tags in lit-html templates
NOPRESUBMIT=true
Bug: 1264796
Change-Id: I58b7e01d4232e93fc08f12fa2f9173e1c6c07060
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253322
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-29 13:47:02 +00:00
devtools-ci-autoroll-builder c976246734 Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/40d725c..2dbe2b9

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ic83f92c41910739515b3e97d8b89f1751de3a47d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3251548
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-10-29 12:42:02 +00:00
Tim van der Lippe 067a9d95d1 Remove entrypoints/node_main/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I01c222ca7829254d8f4ff16d178f787ff7ccd29d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252968
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-29 12:32:22 +00:00
Tim van der Lippe d073fc405a Remove panels/mobile_throttling/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Iac1bb6c1277b719f18e1b0895392a4b523385f09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252966
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-29 12:28:53 +00:00
Tim van der Lippe c1273183f9 Fix modifier key handling for changing numbers in emulation size inputs
R=yangguo@chromium.org

Fixed: 1264200
Change-Id: I2c144c4b08f10a7cc333046e0cb4111465cb64d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253321
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2021-10-29 12:25:14 +00:00
Mathias Bynens 4c6e92b7b8 Avoid collapsing inline tag whitespace
This patch ensures we collapse spaces between DOM nodes
into a single space rather than removing the space entirely.
This prevents issues with missing spaces in UI text, and
generally makes the HTML minification step more safe.

Bug: chromium:1264791
Change-Id: Ib8dfaa58e973ee8682a1f43226db9f9483d9606b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252958
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2021-10-29 12:24:12 +00:00
Tim van der Lippe 11e4a42f47 Remove panels/performance_monitor/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I718f72e77f915b907a17ea8fd1fb2b229703ba30
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252967
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-29 12:11:02 +00:00
Tim van der Lippe 105f14cabc Remove panels/event_listeners/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Iea91581b6e57d196943c8f4b801c18699c87174d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252965
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-29 12:05:14 +00:00
Alex Rudenko 9d83083730 Add default weights to coverage columns
This CL sets weights to the columns so that the
button to reset columns works.

Fixed: 1262514
Change-Id: Ia506efd0310f7cbfd57f02b3344e4f296b508924
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253261
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2021-10-29 11:32:16 +00:00
Marijn Haverbeke 8b0e19e539 Fix highlighting of numbers in dark theme
R=tvanderlippe@chromium.org

Bug: 1215072
Change-Id: If83954b576d7451e8a9364d949d20cf622067f50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253263
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-10-29 11:31:14 +00:00
Tim van der Lippe 0f53a91595 Reland "Remove ui/legacy/components/color_picker/module.json"
This reverts commit 04e525377a.

Reason for revert: CL was unlikely the culprit.

Original change's description:
> Revert "Remove ui/legacy/components/color_picker/module.json"
>
> This reverts commit 416944ab56.
>
> Reason for revert: failing CI
>
> Original change's description:
> > Remove ui/legacy/components/color_picker/module.json
> >
> > R=​szuend@chromium.org
> >
> > Bug: 1190991, 1127902
> > Change-Id: Idf344c4c49ae1486313cfe73248b3e0490aab431
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250786
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: 1190991, 1127902
> Change-Id: I85a882ba79f31582cd47d4ead3edfefce2a1e7d5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252950
> Auto-Submit: Maksim Sadym <sadym@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Maksim Sadym <sadym@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>

Bug: 1190991, 1127902
Change-Id: Idb52d139f6505ae2e780ddaa7b10a59e80ecf43a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252963
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
2021-10-29 11:01:32 +00:00
Alex Rudenko 9b3b05a23e Fix outline for select elements
Removes the double outline as according to the design
system we should have a single outline using --color-button-outline-focus.

Fixed: chromium:1246832
Change-Id: Iec6b3d2afc9ca47644612f205dfe32ad5ce2c434
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252956
Reviewed-by: Peter Müller <petermueller@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2021-10-29 10:28:24 +00:00
Tim van der Lippe cab72e5e68 Remove ui/legacy/components/inline_editor/module.json
R=szuend@chromium.org

Bug: 1190991, 1127902
Change-Id: I3602e2681847567580a193725f4e3b349d94a3ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250789
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-29 10:21:33 +00:00
devtools-ci-autoroll-builder eb1297f90b Update DevTools DEPS.
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/b726d24..40d725c

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/850fe71..80e4f83

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8daf244..b3a1a79

Rolling third_party/inspector_protocol: https://chromium.googlesource.com/deps/inspector_protocol/+log/79d3093..d45d496

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I57c573658bdd2f70233b5d3c9626fb498b860084
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3251541
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-10-29 09:51:06 +00:00
Changhao Han c8c027bd45 Add experiment setting for <length>
Backend CL for histogram: https://crrev.com/c/3251024

Bug: chromium:1259088, chromium:1172993
Change-Id: I743f1841dd03008f29f7a680e776cde3438831a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3251065
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-10-29 09:50:04 +00:00
Yang Guo c91867280b Fix background color for console context dropdown
The CSS rule button.soft-dropdown:focus-visible::before
is redundant to .toolbar-item.highlight::before. Removing it
fixes issue 1264372 and does not affect other use sites of
SoftDropDown.

R=nancyly@chromium.org

Fixed:1264372
Change-Id: I8939258d4f3b705638593270c0951abcdf048142
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252951
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2021-10-29 09:49:02 +00:00
Maksim Sadym 04e525377a Revert "Remove ui/legacy/components/color_picker/module.json"
This reverts commit 416944ab56.

Reason for revert: failing CI

Original change's description:
> Remove ui/legacy/components/color_picker/module.json
>
> R=​szuend@chromium.org
>
> Bug: 1190991, 1127902
> Change-Id: Idf344c4c49ae1486313cfe73248b3e0490aab431
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250786
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: 1190991, 1127902
Change-Id: I85a882ba79f31582cd47d4ead3edfefce2a1e7d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252950
Auto-Submit: Maksim Sadym <sadym@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2021-10-29 09:21:00 +00:00
Tim van der Lippe 416944ab56 Remove ui/legacy/components/color_picker/module.json
R=szuend@chromium.org

Bug: 1190991, 1127902
Change-Id: Idf344c4c49ae1486313cfe73248b3e0490aab431
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250786
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 14:40:36 +00:00
Tim van der Lippe 3f891a4892 Remove panels/web_audio/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I10cac51e1bf811afc445a029aa09285115de7cea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250781
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 14:23:56 +00:00
Mathias Bynens beced6bd2e Prefer appearance over -webkit-appearance
Bug: none
Change-Id: I3508781aff4ea36013a9c1c97f21ae0eca20d14f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250785
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
2021-10-28 12:56:56 +00:00
Tim van der Lippe 996ab930ab Remove panels/help/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Iff4f1de4b108cc542d1e3e10438f9034b9e18076
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250783
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 12:52:16 +00:00
devtools-ci-autoroll-builder e454a4f0df Update DevTools DEPS.
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/673e8ed..8daf244

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Iafcf70da05d338ff6c36b4925d5068029f553c62
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250573
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-10-28 12:45:18 +00:00
Tim van der Lippe cb1605f3eb Remove panels/console_counters/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I695980f897678ce846c2053bf6dc64997108df32
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250782
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 11:40:46 +00:00
Tim van der Lippe b3f9132666 Remove panels/input/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Id2426975d86026b35fa5949806158eda08b8dc08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3250780
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 11:36:56 +00:00
Tim van der Lippe 4869306b1c Remove ui/legacy/components/cookie_table/module.json
R=szuend@chromium.org

Bug: 1127902, 1190991
Change-Id: I8e7fdbd0dac0a99eb88d7a3a78402cc9a4bda3dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247441
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 11:33:56 +00:00
Tim van der Lippe 9667b4fe60 Remove panels/settings/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: Ida10bb785b347699946725ddcc4b113d6575eb9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247444
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 10:45:56 +00:00
Tim van der Lippe 3a689db601 Remove panels/webauthn/module.json
R=szuend@chromium.org

Bug: 1127902
Change-Id: I378ee08f448c94e8a1f9ac9345fc4a193c23f4b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247443
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-10-28 09:57:56 +00:00
Tim van der Lippe 5841c2bf19 Revert "Include group children if group parent header is filtered"
This reverts commit cf6a634062.

Reason for revert: crbug.com/1263070

Original change's description:
> Include group children if group parent header is filtered
>
> This CL adds groupParent and groupChildren to consoleMessage. These are used to filter the console message if group parent or child has the filtered text.
>
> Test link: https://codepen.io/noobtiger/pen/QWpYamX
>
> Example gif: https://i.imgur.com/8RyRdcI.gif
>
> Bug:363796
> Change-Id: I874c9fd82d72ebb532d14b8b8ec46c529cdfd0b2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3024878
> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

Bug: 363796
Fixed: 1263070
Change-Id: I8fbc85ddd79cc16c85373d0b1b7fbcb1f0665d10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3247430
Reviewed-by: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2021-10-28 09:56:06 +00:00