Commit Graph
4 Commits
Author SHA1 Message Date
Philip Pfaffe 140e54340d [extensions] Add a columnNumber argument to panels.openResource
chrome.devtools.panels.openResource is an extension API that causes a
page resource to be opened in the sources panel at a given line. For
wasm, though, line numbers are meaningless. Across DevTools, wasm module
offsets are encoded as column numbers. This CL adds a column number to
the openResource API.

Fixed: 1234438
Change-Id: I141ea0cdb10e211d9cdb8bbab0fc994597ddb5a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3063505
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-09-14 05:24:00 +00:00
Philip Pfaffe 11e43681c0 [extensions] Replace getter with readonly property in interface
Bug: none
Change-Id: I3803e8d2ebfd5b98f33ff42530de95331fb3d0b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3059611
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-07-29 12:32:37 +00:00
Philip Pfaffe 1e2a371b61 [language extensions] Use extension-api typedefs
This CL removes the remaining duplicates of the langauge extension api
type declarations, and uses the extension-api in their place.

Drive-by: Add an enumerators field to the API.

Bug: none
Change-Id: Ic71871aa0364eb715fa90ab5cc1becf5a43cb9e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3045353
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2021-07-23 10:37:22 +00:00
Philip Pfaffe 5df6626235 [ts] ExtensionAPI: Add public extension api typedefs
This change adds typedefs for the public extension API that can be
imported both by the front_end as well as the e2e tests.

Bug: 1219420
Change-Id: I4cde713d167bec0ce3acbe5187f9914b3223e666
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2963825
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-07-19 15:25:40 +00:00