zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-19 13:04:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,167 Commits 45 Branches 79 Tags
60679104f62f52f044fa030e0eee8575cbd605fc
Commit Graph
3 Commits
Author SHA1 Message Date
Paul Lewis 2afe8be656 Skip VSCode settings update on error 
I had a rogue comma in my settings.json file. This prevented the require
from running correctly, which in turn stopped gclient sync from running.
This CL adds a try-catch around the code so that on any error, the
update is skipped.

This CL also adds a bypass option, so that people can opt out of syncing
their VSCode settings entirely.

R=jacktfranklin@chromium.org

Bug: None
Change-Id: I3d90dc0546fcc145c881cb1aa49964e79db3f24f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2914873
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
 2021-05-24 09:12:16 +00:00
Jack Franklin 1d1253c7c9 sync-vscode-settings now copies from devtools-workspace-settings.json 
This CL upgrades the sync-vscode-settings.js script to copy from the
`.vscode/devtools-workspace-settings.json` into
`.vscode/settings.json`, rather than have it hardcode the settings
into the script.

Bug: none
Change-Id: I250b122b47decc8fad937c9030e38603c4f0c403
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2902818
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-05-18 14:04:41 +00:00
Tim van der Lippe 7882ce0ca7 Add DEPS hook for syncing VS Code settings 
Now, when an engineer runs `gclient sync`, we will automatically
augment their VS Code settings to have the correct Node binary
for running the ESLint extension. The augmentation will always
preserve any pre-existing setting specified by the engineer.
If the file doesn't exist yet, it would also be created.

R=szuend@chromium.org,jacktfranklin@chromium.org

Bug: none
Change-Id: I8f4e31b9f12315fb65f5723b6072042cccccacab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886931
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-05-12 09:06:03 +00:00