zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-13 01:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity
21,420 Commits 45 Branches 79 Tags
625c4bcd65120c8143fd4bbf13402a3b052a7abb
Commit Graph
21420 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Benedikt Meurer 625c4bcd65 [docs] Initial skeleton for the UX Style Guide. 
This CL adds an initial skeleton for the UX Style Guide and also
merges the

1. go/chrome-devtools/ux-writing and
2. go/chrome-devtools/ui-glossary

documentation sets into this already, as well as moving and slightly
adjusting the Material 3 styling documentation.

Bug: 354102605
Change-Id: Ida1e5e47038fac421e665eac9785bdc1fe04d6de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725533
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-07-23 07:23:15 +00:00
Alina Varkki e41cef5981 [RPP] Move EntriesFilter to Timeline and check if an entry the Expand icon is added to is visible in the timeline 
Move EntriesFilter to Timeline because EntriesFilter needs a function that checks if the entry is visible in the Timeline to correctly add the "Expand" button and the `entryIsVisibleInTimeline` function is using a function from EventUICategory, which cannot be imported into the `models`.

Also add a test to cover the case when the next parent is not visible in the timeline.

Bug: 338977625
Change-Id: I52120c97cdeba87231bcdcc2f39a6eff710f62e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5718089
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-23 06:11:36 +00:00
devtools-ci-autoroll-builder 854c2e95f3 Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6612.0

Roll created at https://cr-buildbucket.appspot.com/build/8741656637982111489

Bug: none
Change-Id: Icae84bda090097ce393af5ac29ae0f6d456055ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5730902
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-23 04:00:45 +00:00
devtools-ci-autoroll-builder adc91b7afd Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/7a8285c..5f1a1b3

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cba7859..ede9a33

Roll created at https://cr-buildbucket.appspot.com/build/8741656637982111489

Bug: none
Change-Id: Id41138d32d546392282e7dd7a680f0aeaa5b50a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5730901
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-23 03:49:24 +00:00
Simon Zünd 48f2dfc46a [cleanup] Remove platform/SetUtilities.ts 
We can replace the last use-sites of 'addAll' with either union or
inline it.

R=pfaffe@chromium.org

Bug: None
Change-Id: Ifc61bc4e91b21d88cb96a672941ad6ff5ef3e029
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729974
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-22 17:31:46 +00:00
Simon Zünd c10915f77f [cleanup] Use a Map of Sets for extraPropertyValues 
This allows us also to use the new Set.prototype.union. Once we have
migrated all call-sites of Platform.SetUtilities.addAll, we can remove
SetUtilities wholesale.

R=pfaffe@chromium.org

Bug: None
Change-Id: I13f8f1af0f1a46eb2a134538c1835945f15f6e47
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729973
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-22 16:22:41 +00:00
Yang Guo b4487a7452 Change sort order of timer event break points 
Fixed:351408641
Change-Id: I92ec41e65ab6804bf59b5050e5284cdc9a775a41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725915
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
 2024-07-22 14:48:22 +00:00
Nikolay Vitkov 26a5adddb2 Always use Rating enum 
Improve types

Bug: none
Change-Id: Ie6111d6c9c1d8d1eac09957dd0ef714e611ba1b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729336
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-07-22 13:51:06 +00:00
Kim-Anh Tran 207787b38f Change Network Panel icon color in header overrides 
Icon colors should by default be black. Removing the
specific icon colors will default to black (--icon-default).

Fixed: 339805299
Change-Id: I837eb43d2102e3d79a87addc81575418ce01065c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5707449
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2024-07-22 13:46:54 +00:00
Jack Franklin 26ee92bbb6 [RPP] Fix toggling and overlays for sidebar insights 
This sets up a system for knowing what insights are being toggled to
help with expanding & overlay logic.
Insights have their own name, and these
are toggled by the single-navigation-component accordingly.
These are controlled by dispatched events that pass in the
insight+navigationId info so that the correct overlay is displayed.

Bug:344550388
Also-By: aixba@google.com
Change-Id: I3734d3a908a96d3b30f0f598f000821e1a950bda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5715119
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2024-07-22 13:23:38 +00:00
Kim-Anh Tran d1cd165c75 [GM3Restyling] Update icon and color for security panel 
Icons should never be gray (except of if disabled). Replacing
the indeterminate icon by the info icon.

Before: https://i.imgur.com/9VwGY0V.png
After: https://i.imgur.com/lbwEzyx.png
Bug: 319384095
Change-Id: I3a777d970ac5dc1e7c28c91ac0fe35964f6c26ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5718150
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2024-07-22 13:16:05 +00:00
devtools-ci-autoroll-builder 21ac46082a Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6611.0

Roll created at https://cr-buildbucket.appspot.com/build/8741713257219513569

Bug: none
Change-Id: I89e1fc900f712e73f848515ba66366dd27607eed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5726904
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-22 12:49:26 +00:00
¨Meysam b63fdcb790 Add committers policy 
Bug: none
Change-Id: I9048bc48fbfba662e448099274a72490a689a362
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729492
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Meysam Sarabadani <meysarabadani@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2024-07-22 12:45:50 +00:00
devtools-ci-autoroll-builder abe2e8bf62 Update DevTools DEPS (trusted) 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b122579..cba7859

Roll created at https://cr-buildbucket.appspot.com/build/8741713257219513569

Bug: none
Change-Id: I01ce07e429413a73601fa20e662d59ac4548d95b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5726903
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-22 12:39:24 +00:00
Jordan efb1a681c7 front_end/third_party/lit/README.chromium update Revision 
This Revision has been derived using the provided version.

Revisions are now required for dependencies with a git upstream.

This is an initial attempt to uplift the current README metadata.

Respond with Code-Review '-1' if this README file is automatically
updated, you will need to update your automation.

If you need help, or it's not feasible,
file a bug similar to b/352221788 (android_deps).

FAQ:
* Google-internal: go/fix_chromium_metadata
* External: https://docs.google.com/document/d/1pejJ6JSS4lfDfnZ23VfpT1qJ1irDHMBueauCza6tNuo

This CL was uploaded by git cl split.

R=jacktfranklin@chromium.org

Bug: 350851535
Change-Id: I349f95d7ee34d23c5304e16d06818060618b2875
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5722334
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jordan Brown <rop@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-22 09:49:36 +00:00
Nancy Li 083d4f33b5 [RPP] Update the name and colours of network track. 
To match the Network panel
Related doc: https://docs.google.com/document/d/14OzcO7F3MqTzRhJa1Qj25QwbNcAGrc9QoPoTNT0zUhQ/edit?tab=t.0

Before: https://screenshot.googleplex.com/3LHTVbiuaBac5hN
After: https://screenshot.googleplex.com/AdN3NeEaCBjvhKN

Bug: 352244019
Change-Id: Iedd4437dc0201dd846dabcda189ec84dc32e73dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5726132
Auto-Submit: Nancy Li <nancyly@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-22 09:40:35 +00:00
Simon Zünd 273ece7891 Fix memory leak in ObjectPropertiesSectionsTreeExpandController 
This CL fixes a small leak. Currently we use a 'Map' to cache
property paths for tree elements in the object UI (and also the
section map). We never delete from this map so we just keep
accumulating entries. For every pause on the "new tab page" and
expanding the 'globalThis' object this adds 800+ new entries to the
cache map.

This CL replaces 'Map' with 'WeakMap', which fixes the leak (verified
with heapsnapshots).

Drive-by: Move the maps as static private members and use private
field syntax.

R=pfaffe@chromium.org

Bug: None
Change-Id: Ib12795a78ebf05b9812285108ec57d519e0dbba7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724711
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-22 07:27:18 +00:00
Simon Zünd f01aee2eb9 [scopes] Replace original scope kind with index into 'names' array 
The spec PR https://github.com/tc39/source-map/pull/107 changed the
original scope kind to be an index into the names array given that
'global', 'function', etc. might not be applicable to every authored
language.

This CL aligns the DevTools implementation with the latest spec.

R=pfaffe@chromium.org

Bug: 40277685
Change-Id: Id4b9915aaab6138fbf2dae5eaf48c6e52b999b40
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724710
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-22 06:43:56 +00:00
devtools-ci-autoroll-builder 83471c147b Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6610.0

Roll created at https://cr-buildbucket.appspot.com/build/8741747234881529105

Bug: none
Change-Id: I9480f12c5901febe663eaa64ba52cbcbb447b77f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724478
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-22 04:12:35 +00:00
devtools-ci-autoroll-builder b7843c5f91 Update DevTools DEPS (trusted) 
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/adc2a53..3ef44a2

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/397bf12..b122579

Roll created at https://cr-buildbucket.appspot.com/build/8741747234881529105

Bug: none
Change-Id: I85b5c90007d2e2eabc14b328613af7f5dc931b8b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5726899
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-22 04:04:27 +00:00
devtools-ci-autoroll-builder 4697712568 Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6609.0

Roll created at https://cr-buildbucket.appspot.com/build/8741803855657933441

Bug: none
Change-Id: I5274c84642a2fba375f973b29bd40d046f75a02a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5728452
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-21 12:57:46 +00:00
devtools-ci-autoroll-builder 9fa7a87350 Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6608.0

Roll created at https://cr-buildbucket.appspot.com/build/8741837831921438417

Bug: none
Change-Id: Ibdaccbeef73117c87dec1549546381d8d6c89417
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5727410
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-21 03:52:22 +00:00
devtools-ci-autoroll-builder bb611b670c Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/4cc54fa..7a8285c

Roll created at https://cr-buildbucket.appspot.com/build/8741837831921438417

Bug: none
Change-Id: I84ba096681d1c5959565224af9f4485850950d78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5726236
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-21 03:35:48 +00:00
devtools-ci-autoroll-builder d996b26918 Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6607.0

Roll created at https://cr-buildbucket.appspot.com/build/8741894453747695489

Bug: none
Change-Id: I87dbc8733fe2f07a480c5bb2c02f4396124bb43d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725085
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-20 13:05:39 +00:00
devtools-ci-autoroll-builder abd82264fe Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/5167102..4cc54fa

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/91937bf..397bf12

Roll created at https://cr-buildbucket.appspot.com/build/8741894453747695489

Bug: none
Change-Id: Ifd113ba9fd183f7c4ed5ddbba0e0965341f5e7c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725084
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-20 13:00:35 +00:00
devtools-ci-autoroll-builder c2e676b663 Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/9ad8e1f..5167102

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1c81122..91937bf

Roll created at https://cr-buildbucket.appspot.com/build/8741928428450446785

Bug: none
Change-Id: Ib6a2b4776ff4758b47573571d47cd2b8186855c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725080
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-20 03:58:35 +00:00
devtools-ci-autoroll-builder c471eef708 Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6606.0

Roll created at https://cr-buildbucket.appspot.com/build/8741928428450446785

Bug: none
Change-Id: I2476384ef70ce99ff5de5b00c64e4d85cbedd5d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725081
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-20 03:57:31 +00:00
Connor Clark 625fcea468 [RPP] Add DocumentLatency insight for redirects and server response time 
Bug: 313905799
Change-Id: I7a8bdd511f96c96ab4022f70ede313c028cc56c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5719103
Reviewed-by: Adam Raine <asraine@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-19 19:31:18 +00:00
Changhao Han bbc5b06e91 Deprecate unit dropdown in length swatch 
Bug: 41495618
Change-Id: Ic1bbfd4e7b0de9255e5149262274dc43a0ea6e84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5717109
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2024-07-19 19:01:22 +00:00
Simon Zünd 7b228c01bc [test] Rewrite CPUThrottlingManager tests to use mock connection 
We want to get rid of 'describeWithRealConnection' in the long-term.
It's probably enough that CPUThrottlingManager invokes CDP the
right way and uses the corresponding result.

R=pfaffe@chromium.org

Bug: None
Change-Id: I416de5a78ff4c88ade7b0cd48249555ce7a5d4af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725356
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-19 19:00:18 +00:00
Simon Zünd 3dba79f655 [scopes] Resolve source mapped 'this' on the model layer 
This moves the last of the "extra properties" to the model layer so
we can get rid of some code on the view layer.

R=pfaffe@chromium.org

Bug: 40277685
Change-Id: I486095e947b12d184f63b616a365bb307f50c5c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5720868
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-19 18:59:14 +00:00
devtools-ci-autoroll-builder 285933ff39 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8741985050912109697

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: Ie43a00474923304fc6deb38537040ad106fa6f6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725773
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2024-07-19 16:43:49 +00:00
Seth Brenith 0427285e8c Fix possible exception when sorting Retainers pane 
In some cases, it is possible that the "Restore ignored retainers"
button does not show up after ignoring a retainer. The sequence of steps
in the failure is as follows:

1. HeapSnapshotGridNode.sort() calls populateChildren with toPosition
   greater than 100.
2. populateChildren requests the first 100 items from the worker.
3. The worker responds with fewer than 100 items.
4. populateChildren requests more items, starting at index 100.
5. The worker throws an exception because the start index is invalid.
6. sort() fails, so the remaining steps of
   HeapSnapshotRetainmentDataGrid.dataSourceChanged don't run. One of
   those skipped steps would have shown the "Restore ignored retainers"
   button.

The fix is simple: don't request out-of-bounds data from the worker.
This CL also removes an unclear todo comment from 2012.

Bug: 327337527
Change-Id: I3770c4f7386804039df63f2350ebdf2b15dd466c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5720774
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-07-19 16:33:00 +00:00
Seth Brenith 54bcb97168 Always include numeric values in heap snapshots 
When we added an option to include numeric values in heap snapshots, the
heap snapshot generator was astonishingly slow. At that time, adding
more numeric strings would have a compounding effect on the slowness.
However, that problem was fixed by crrev.com/c/4428811 . Now, I see no
compelling reason to ever omit the numeric values from the heap
snapshot, so this change permanently enables capturing of numeric
values. I did comparisons on several websites and found that this caused
a slowdown of roughly 4% and increased the size of the .heapsnapshot
files by about 2%. I think that the benefit of removing a checkbox from
a complicated tool outweighs those minor performance regressions.

Bug: 40763322
Change-Id: I80567612f90824d5266ac2e27338df19331f75a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5722295
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
 2024-07-19 16:09:44 +00:00
Simon Zünd bd8d9a57d1 [scopes] Move 'exception' and 'return value' properties to model layer 
These synthetic properties are currently added on the UI layer to
the scopes view.

This CL moves 2 of the 3 synthetic properties to the model layer. We
add a new 'extraProperties' method on the 'ScopeChainEntry' interface.

Long-term we might move towards adding them to the RemoteObject
directly but that is yet to be determined.

Note that we don't change the @description of the UI strings: This
way we don't need to re-translate them. We'll move the translated
scope description and translated synthetic property names to the
UI layer at some point.

R=pfaffe@chromium.org

Bug: 40277685
Change-Id: Icac5e2f45c12c458ae621b1f81346391e851b6d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5718090
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-19 15:51:01 +00:00
Peter Müller 8c81e7c383 [GM3Restyling] Add indigo tokens 
Used in Performance to indicate Wasm network requests.

Bug: 354171827
Change-Id: I69a25dfd9d73cf6ecf446ea088ba7d7583772eb6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724793
Reviewed-by: Nancy Li <nancyly@chromium.org>
Auto-Submit: Peter Müller <petermueller@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2024-07-19 14:47:55 +00:00
Andrés Olivares aa9ba78ffa Reset flamechart data and extension data gatherer in timings track test 
To prevent data leaking across tests

Bug: none
Change-Id: I4406f6d297d6d9fef40c4cab215c72bca4a639ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725540
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2024-07-19 14:02:38 +00:00
Jecelyn Yeen 1172b49093 [Layers] Remove deprecation feedback banner 
We received enough feedback for next steps. We will remove the warning banner for now.

Bug: 328948996
Change-Id: I035e492fd38d3960b7377c117d24c08ca858991b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5711872
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-07-19 13:58:03 +00:00
Jack Franklin 152a4b9189 RPP: add elevation to sidebar floating icon 
Bug: 353906376
Change-Id: Id01034c23a60a9d397729ecba6d9d942bbbc6851
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725271
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-19 13:15:42 +00:00
devtools-ci-autoroll-builder 29e8054ff2 Update DevTools DEPS (trusted) 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5a72350..1c81122

Roll created at https://cr-buildbucket.appspot.com/build/8741985050912109697

Bug: none
Change-Id: I76e2669a1ad21f3e59369d18853cfce4810be188
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725772
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-19 13:03:01 +00:00
Andrés Olivares 6fd142605f [RPP] Make extensibility API support non-experimental 
Adding official support for v1 (https://bit.ly/rpp-e11y), according to
http://goto.google.com/cpq:rpp-e11y-v1-rollout

Bug: 313903057
Change-Id: Id6627841181b1d0f6e2e199753e2e86bfcc70848
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725348
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2024-07-19 13:00:44 +00:00
Simon Zünd 9f22e5dbd6 [test] Replace describeWithRealConnection with mock connection 
The tests don't really seem to require the real connection and pass
without it.

R=pfaffe@chromium.org

Bug: None
Change-Id: Id2e169743e3f9c7be6f3909cb2a0868555bafd20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724789
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2024-07-19 12:49:03 +00:00
devtools-ci-autoroll-builder cbc7a6b76a Update Chrome (for Testing) PIN 
Chromium pin updated to 128.0.6605.0

Roll created at https://cr-buildbucket.appspot.com/build/8741985050912109697

Bug: none
Change-Id: If06cf812d7c38b8cfe258cc85713635485d9bdc9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725069
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-07-19 12:35:13 +00:00
Paul Irish 220f9e11aa Color: extract a common color Space type 
Bug:none
Change-Id: Ia56f6a9b86b10be617e895a8bbb660c4ec0e2db0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725535
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2024-07-19 12:18:01 +00:00
Changhao Han 6d89bba2a5 Remove deprecated position fallback 
Bug: 330065088
Change-Id: Ic44fdfdb2889ab8638090d0f2b75ebc31bfdc4e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725612
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-07-19 11:57:13 +00:00
Bruno Braga 90e4cbb731 [autofill in devtools] Make test addresses more obviously fake. 
This was requested during full launch request as a quick follow up.
There were cases in the past where raters accidently ordered stuff to
Google offices and we want to avoid that. Noted that this is still very
unlikely to happen.

Bug:40270486
Change-Id: Ia46105b49a7308e5475025f698d7831a7fa4a81f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724571
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Bruno Braga <brunobraga@google.com>
 2024-07-19 11:37:56 +00:00
Peter Müller 056d3bb61d [GM3Restyling] Update green-bright 
Bug: 353694341
Change-Id: Ib8b51d639f921853f288a2f85d757ae4a088c330
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5718128
Commit-Queue: Peter Müller <petermueller@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2024-07-19 11:03:24 +00:00
Peter Müller 24cfaa2c9d [GM3Restyling] Add font tokens 
Add font tokens to easier reference font styles

Bug: 353696934
Change-Id: I0e961ce6e464c6ed25880f3a3a9b0fda79a33105
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5718129
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Peter Müller <petermueller@chromium.org>
 2024-07-19 10:53:04 +00:00
Yang Guo 3bb0904c9e Change UI string from "system preference" to "browser preference" 
... for the color theme choice in Settings. This better reflects the
intent and the current behavior.

Fixed: 352282703
Change-Id: I948a7777c61f06f2a824aeb496f287e15642ecd8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5699227
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2024-07-19 10:25:46 +00:00
Simon Zünd ed07d7f0e6 Remove check for side-effect free evaluate support 
The feature landed in V8 6.7. This means it's supported since Chrome 67
and Node.js 10.

Worst-case if we debug anything older with a new version of DevTools
is that we'll execute side-effects that shouldn't happen.

R=bmeurer@chromium.org

Bug: None
Change-Id: Ib2a02be14144137d2f99435baaa0a9e3477f4e31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5714671
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-07-19 10:06:44 +00:00