- Disallow passing async callbacks to describe, as that's a great source
of bugs (anything defined after an `await` will not run).
- Disallow global tests.
- Disallow nested tests, as those will not run (and we had a few of
them).
Drive-by-fix: Use the proper mocha/no-exclusive-tests plugin instead of
our homegrown one, and teach the mocha plugin about the various describe
versions (which consistently works for all the other mocha eslint rules
then as well).
Bug: b:319814509, b:326206427
Change-Id: Icfa9caf468882a226a5dbdd3be27b0f66fe4479f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309877
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
- puppeteer replaced with puppeteer-core (20.7.3). DevTools does not actually need puppeteer as it downloads the browsers on its own. PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is not needed too.
- @puppeteer/replay upgraded to 2.11.2
DISABLE_THIRD_PARTY_CHECK=requires code updates for puppeteer-core
Bug: none
Change-Id: I173c228d766681a1a8a9ada3fcf17525cd191726
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4640022
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
This CL adds conversion capabilities to the new color classes. Colors can be converted between each other (but conversions always start from the original color, we avoid chaining to avoid accumulating rounding errors).
Bug: 1395782
Change-Id: If4ef28b10b1e254f10924e2cfde315bf9851c448
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4065840
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
The tests were relying on the order in which styles are rendered
in the styles panel. It appears that the order is not guaranteed at
least at some points in time. This CL updates the font editor
tests to click on a font editor button that exists in the element.style
section instead of clicking on any button that is found first.
Bug: chromium:1184658
Change-Id: I75de95462dd2d9dab1a4d99112685f682bbe80e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2780808
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
The before hook of test/e2e/inline_editor/font-editor_test.ts
is timing out on bots. This might be a problem with a waitFor
in the hook, or the timeout might be too low. This CL speculatively
doubles the timeout so we can see whether it is due to the timeout.
Bug: chromium:1184658
Change-Id: Ie7696190f087dc57e9b263c5cae96827ea8cf433
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2744584
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Previously when ArrowDown was pressed it could happen that the body
tag was still collapsed. This lead to selecting the closing html
tag in the Elements panel instead of #inspected. This CL changes the
interaction to press ArrowRight two times that ensures that the body
tag is expanded and the #inspected element is selected.
Fixed: 1154590, 1149358
Change-Id: I0fbf4786713d115eb7018489d19cd78b1c0af7d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2573359
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
While working on refactoring the color and var swatches recently, I had
to disable a few web tests in chromium.src.
Instead of fixing them and re-enabling them now, I'm taking this
opportunity to convert them to the appropriate unit or e2e tests in the
frontend (this helps reduce the dependency for frontend-only features on
chromium.src).
Here is the list of disabled web_tests and what I did for each:
1. third_party/blink/web_tests/http/tests/devtools/elements/styles-1/color-swatch.js
Converted to both new unit and e2e test cases for what wasn't already
covered.
2. third_party/blink/web_tests/http/tests/devtools/elements/styles/url-color-swatch.js
Added new e2e test cases for what wasn't already covered.
3. third_party/blink/web_tests/http/tests/devtools/elements/css-variables/color-swatch.js
Also added new e2e test cases to cover this.
3. third_party/blink/web_tests/http/tests/devtools/sources/color-swatch-position.js
This one is different as it tests editing CSS code in the Sources
panel. Because the current e2e helpers lack support for this, I will
fix and re-enable this web_test in chromium.src. It doesn't seem
worth it right now to create a bunch of new helpers just for the
color swatch. But we should do this too eventually.
Backend CL: https://chromium-review.googlesource.com/c/chromium/src/+/2507510/
Bug: 1137438
Change-Id: Ic260e460ba215dd9a317ae2843d927c2d1bace3d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2506954
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
The recently introduced CSSVarSwatch component was handling color-like
variables on its own, by displaying a color swatch when needed.
This color swatch did not support shift-click format changes, nor click
to change the color.
This change removes this handling and uses the new color swatch
component instead.
This way, click and shift-click on color swatches for CSS vars does work
as expected (even if it "computed" the value and therefore removes the
var link).
GIF: https://imgur.com/egBMRU6.gif
Bug: 1137438
Change-Id: Ie7b6cf31833b6c3e0b8b225da5f4bdf512876a17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2495208
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Benedikt Meurer
