This reverts commit 2d8ad76070a840ce3821f3d28e55cd952f7640c0.
Reason for revert: Grouping would break alphabetical sort, which is controversial.
Original change's description:
> DevTools: prepare Computed sidebar for groups
>
> Computed sidebar
> - Removes even/odd striping
> - Extracts a function to build a property's TreeElement
>
> Bug: 929536
> Change-Id: I727cf1efa5ac65277a046b52575f35102323c38f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548446
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#648029}
TBR=luoe@chromium.org,jarhar@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 929536
Change-Id: Icec233a91c07b2b864830df6419690911070101a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565380
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#650149}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 37893dee61d4f8d4a23c0d23bd36dbd4ef6d893c
Accessibility testing revealed that there are tab traps in all of the text editors including read only ones. Once keyboard users tab into the editor, they cannot tab out the editor.
This change adds a shortcut to disable/re-enable tab for indentation, which allows keyboard users continue to use tab to navigate to next UI component.
Settings Shortcuts page screenshot: https://imgur.com/a/qeOjGoB
Change-Id: I026a5a9c47407634a78c2ccf1a0bc532baa39e07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545200
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#649901}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27ff38b767bc1659a596830b864acf60850e6bd0
* Enabled the check_localization presubmit script.
* Fixed localization issues caught by the check_localization presubmit script.
* Updated the check_localization script to allow contatenation of non-alphabetic strings with localized strings.
* For example, ls`Status Code` + ": " is a valid concatenation. This allows for decorations to be concatenated with localized strings.
Change-Id: I741940c9ebdac363ac0ccad3f7de20d508204e2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544878
Auto-Submit: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#647134}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7a329cb73b0b5d5cddb89a34fd7da6cb1a3c87dd
Automated testing revealed:
1. the three-dot button on tabbed pane of the drawer view doesn't have a name property which can impair screenreader's ability to announce the appropriate context of focus;
2. the tab close button doesn't have have a name property which can impair screenreader's ability to announce the appropriate context when users try to access the control with some pointing device;
This change adds
1. a title to the three-dot button mentioned above;
2. a title to the tab close button;
3. a minor fix for misused even.key of Space key.
Change-Id: Ieca67cc385d57fac534d28a2a3631c155e1e27ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536444
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646058}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 275582c729d4a3ee1bb456e85aa6e6b060cdfbde
After submiting accessbility fixes for the Sensors tool and Performance
Monitor, we should aim to not regress these improvements.
This change adds the AxeCoreTestRunner module which uses aXe to run
basic accessbility checks on the UI.
It also adds a test that runs aXe against the Performance Monitor and
Sensors tool since they have already received an initial accessibility
pass and are not reporting any violations in aXe.
Change-Id: I6443d5014d9200a9295746aaec7a71b4659a6417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534551
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Amanda Baker <ambake@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#645823}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f854b6f5a7a1e16fe5880c40e8055e92eca37943
Small patch to fix an issue with the colors of the TreeOutine.
Specifically, in the dark theme the selected item in the tree does not
have sufficient contrast when focus is placed outside the tree.
The following image shows the change:
https://imgur.com/a/WXY2CtT
The fix was to add a new css variable into inspectorStyle.css which is
given the existing foreground color in the light theme, but is over-
ridden in the dark theme with a better contrasting color. The new
color is then applied in treeoutline.css to selected non-focused items.
Change-Id: Iec42e6dbbc2264651dd9c6b0238a1e65ecf6246b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540270
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: James Lissiak <jalissia@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#644826}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7b9e32ec329e08b58d36ec7affe375fa50e4b9ed
Without an entry counter, users might get confused how many entries
are in a cache storage, because the UI indication is not obvious enough.
Besides, adding an entry counter is consistent with IndexedDB tables.
When the path filter is not an empty string, the count reflects how
many responses were matched in total.
Bug: 930865
Change-Id: I058562a251163459eeb2adc24def4888f9a9e863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537254
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644523}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 45237b838f0aaf393967a9a8b46d83bbee20851b
Before, Console logs with an associated Network request would link
all links to the request's URL. Now, it uses normal linkifier,
for links with a different URL, allowing external ones.
Bug: 925508
Change-Id: I96e7aaf75ad1597852a8dd5e1b2a5363df3ff844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540060
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644506}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 636c11b47a4c74808356171c53f0d7892ef90d16
When a page makes a 'POST' XHR request, and then sends a typed array as
binary data, there is no request content type.
If the user, then exports the contents of the network tool to a HAR
file, the postData section is missing the mimeType field. HttpWatch
requires the MimeType field, otherwise it treats the file as if its
incorrectly formatted.
The fix is to ensure we always generate the mimeType field for the
postData section.
Change-Id: Id110887fac50057ccab7a257a8de770a9d92b03c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535348
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644467}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 93409376431a411e34a1bce2ab2e7136580a60f2
This change adds 4 new performance histograms for the DevTools using the
prefix 'DevTools.Launch':
- DevTools.Launch.Console
- DevTools.Launch.Elements
- DevTools.Launch.Network
- DevTools.Launch.Sources
These histograms measure the time between the DevTools window being
shown during 'DevToolsWindow::ToggleDevToolsWindow' and a point in each
tool that corresponds to the 'ready' state as seen by a user. These end
points are unique to each tool but are as follows:
- Console: At the end of the ConsolePrompt constructor
- Elements: At the end of _updateMetrics when the styles panel has
been populated for the initially selected node
- Network: After the panel is shown
- Sources: After the NetworkNavigatorView has been loaded
These tools were chosen as they represent the most popular in terms of
usage and will allow us to identify any significant performance impact
in the time taken to launch the DevTools when these panels open by
default.
To see time captured by the histograms in terms of a perf trace for
each tool please take a look at the following screenshots:
https://imgur.com/a/rcAgQ8h
In the traces you can see that the end marker for each load is at the
end of the trace near first meaningful paint, and just as the user
will see the content of the tool render fully.
To accomplish the histograms, a new native function has been added to
the DevTools ui bindings/embedder classes called
'recordPerformanceHistogram'. Along with the plumbing and a new helper
function in the frontend javascript Host.UserMetrics file called
'panelLoaded'
When the frontend javascript loads, it will store the initial panel to
be loaded from the preferences. Once that panel has been created and
the appropriate loaded marker has been hit, the duration of the launch
will be calculated using performance.now(). That duration is then sent
to the native code which will fire the appropriate histogram via the
'UMA_HISTOGRAM_TIMES' macros.
The mechanism is similar to the existing one used for enumerated
histograms and can be expanded to fire additional performance histograms
in the future.
Also added a new test for user-metrics to ensure that the panelLoaded
function will correctly record the histograms.
Change-Id: Ib9f0bf80c651231d6d2e308bee36c1a1223f04db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506388
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: James Lissiak <jalissia@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#644407}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 296f6b12650bd5e38eaf1fe0987c46910fe2d6eb
Daniel Cheng
