Commit Graph
3 Commits
Author SHA1 Message Date
Mathias Bynens 6b5621bb77 Improve copy JS path functionality
This patch simplifies DOMPath.js by using CSS.escape to produce
valid CSS identifiers, instead of a custom (and subtly broken)
implementation.

Similarly, instead of custom logic, JSON.stringify is now used to
produce valid JavaScript string literals.

Bug: chromium:930625
Change-Id: I4462cca6b41ae1a0b1232c4517e02fb171bbccad
Reviewed-on: https://chromium-review.googlesource.com/c/1464719
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#631337}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39d011cffef144bc7cf3d019c248c8032e9fe5d2
2019-02-12 19:36:54 +00:00
Andrey Lushnikov c197ddf043 DevTools: copy JS path
This patch introduces a new 'Copy js path' option to the context
menu that allows to get a JavaScript reference to the object
in the DOM Tree. This comes handy when dealing with Shadow DOM
trees.

R=dgozman

Change-Id: I07a77597f88b6cc500baed8ae9ee097b35d79b4f
Reviewed-on: https://chromium-review.googlesource.com/c/1300756
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606723}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: be8b1dc6dcc9c479f3df1aa11bf542e3a9790ae7
2018-11-09 03:25:59 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00