Commit Graph
6 Commits
Author SHA1 Message Date
Erik Luo f484eb2c6e Reland "DevTools: optimize Styles sidebar for reading property values"
This is a reland of df31273ec872f5f578b4fe92747c7f663c7154a2

Original change's description:
> DevTools: optimize Styles sidebar for reading property values
>
> SSP UI changes
> - Curly brace, Source link color less dark
> - Source links are more aggressively truncated
> - "Inherited from" separators have less noise
>
> Screenshot: https://imgur.com/a/SwpWkGs
>
> Bug: 929536
> Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Reviewed-by: Joel Einbinder <einbinder@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#642093}

TBR=einbinder@chromium.org

Bug: 929536
Change-Id: I1a67b4243cbe0409337faf7a53c620123cb23a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531692
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#642334}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc3f154a8e94c37a41f3c4ee858ec9d80ce60b79
2019-03-20 02:41:28 +00:00
Carlos Knippschild 00e09a7e5d Revert "DevTools: optimize Styles sidebar for reading property values"
This reverts commit df31273ec872f5f578b4fe92747c7f663c7154a2.

Reason for revert: breaking tests in chromium.win/WebKit Win10

Original change's description:
> DevTools: optimize Styles sidebar for reading property values
> 
> SSP UI changes
> - Curly brace, Source link color less dark
> - Source links are more aggressively truncated
> - "Inherited from" separators have less noise
> 
> Screenshot: https://imgur.com/a/SwpWkGs
> 
> Bug: 929536
> Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Reviewed-by: Joel Einbinder <einbinder@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#642093}

TBR=einbinder@chromium.org,luoe@chromium.org

Change-Id: I31744312f8bd5ff2ad295cc2956cff816d114806
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 929536, 943802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530826
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#642221}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a67e3eb195bab80f0e0a711c5e76d2bf6b45a449
2019-03-19 22:32:03 +00:00
Erik Luo e0870a2653 DevTools: optimize Styles sidebar for reading property values
SSP UI changes
- Curly brace, Source link color less dark
- Source links are more aggressively truncated
- "Inherited from" separators have less noise

Screenshot: https://imgur.com/a/SwpWkGs

Bug: 929536
Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#642093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df31273ec872f5f578b4fe92747c7f663c7154a2
2019-03-19 18:34:43 +00:00
Erik Luo 39452ffb18 DevTools: allow Console message keyboard navigation
This makes Consoles messages focusable and navigable using:
ArrowUp/Down/Left/Right, Home, End

Screenshot: https://imgur.com/a/6JWY0iU

Bug: 865674
Change-Id: I4166bf4d8d57856c6d1f7d51ef29e2dea0c088eb
Reviewed-on: https://chromium-review.googlesource.com/1144453
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588237}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fce8ab13eba5c18c14e308a9821d0675e0a4a1e
2018-09-01 01:08:07 +00:00
Erik Luo 94efa87349 DevTools: give visual signal when filters are active
- Non-empty text filters retain their blue outline even when not
  focused.
- Searching the the StylesSidebarPane no longer highlights the
  toolbar yellow, just the selector/prop matches.

Screenshots:
https://imgur.com/a/suybNVy
https://imgur.com/a/s0R04ar

Bug: 808159
Change-Id: I7dc5b89ca96ca181e767bd271cd648bee4cb0ca1
Reviewed-on: https://chromium-review.googlesource.com/1060574
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#571967}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8
2018-07-02 19:32:06 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00