zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 14:14:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,025 Commits 45 Branches 79 Tags
779b46bac3bb2ca8aa997d683183eded1971fadc
Commit Graph
13 Commits
Author SHA1 Message Date
Tim van der Lippe d7cfd14814 Fix no-implicit-coercion errors in front_end/ 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-07 12:40:16 +00:00
Christy Chen 5d7848d54d Reland "[Loc] Migrate changes tool to localization V2" 
This reverts commit 9e5ab71e50.

Reason for revert: The Cl was reverted due to devtools pak file limitation. That issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2558341

Original change's description:
> Revert "[Loc] Migrate changes tool to localization V2"
>
> This reverts commit abcb8f7aa8.
>
> Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.
>
> To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.
>
> You can run this locally in Chromium to reproduce via:
>
> autoninja -C out/Default chrome:packed_resources_extra
>
> Which will show the error. 
>
> Original change's description:
> > [Loc] Migrate changes tool to localization V2
> >
> > Migrate changes tool
> > Tested with en-XL: https://imgur.com/a/hFDBjQV
> >
> >
> > Bug: 1136655
> > Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> > Commit-Queue: Christy Chen <chrche@microsoft.com>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> TBR=szuend@chromium.org,chrche@microsoft.com
>
> Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1136655
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com,jacktfranklin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1136655
Change-Id: I35166a6f4f38462073b933c01c169b3c8d14311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567344
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-12-02 06:13:17 +00:00
Jack Franklin 9e5ab71e50 Revert "[Loc] Migrate changes tool to localization V2" 
This reverts commit abcb8f7aa8.

Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example.

To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue.

You can run this locally in Chromium to reproduce via:

autoninja -C out/Default chrome:packed_resources_extra

Which will show the error. 

Original change's description:
> [Loc] Migrate changes tool to localization V2
>
> Migrate changes tool
> Tested with en-XL: https://imgur.com/a/hFDBjQV
>
>
> Bug: 1136655
> Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
> Commit-Queue: Christy Chen <chrche@microsoft.com>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,chrche@microsoft.com

Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-24 10:54:09 +00:00
Christy Chen abcb8f7aa8 [Loc] Migrate changes tool to localization V2 
Migrate changes tool
Tested with en-XL: https://imgur.com/a/hFDBjQV


Bug: 1136655
Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-23 18:46:16 +00:00
Tim van der Lippe 3a34cdfe5a Typecheck changes/ChangesTextEditor.js with TypeScript 
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I90f983c10cf6855a07f1ce9e077a47d4c2a10974
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2526687
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-10 16:29:28 +00:00
Jan Scheffler a5c5b34d67 Migrate front_end/changes to devtools_entrypoint 
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: Ie26902cda0e64b14670026bfc92ed9c65e9fdaa3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332221
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-31 13:24:59 +00:00
Tim van der Lippe e7f27058f4 Replace double class invocations of createElementWithClass 
This applies the following replacement to the codebase:

(\S+) = createElementWithClass\('(\w+)', '([^'\s]+) ([^'\s]+)'\);

to

$1 = document.createElement('$2');\n$1.classList.add('$3');\n$1.classList.add('$4');

R=aerotwist@chromium.org

Bug: 1011811, 1077215
Change-Id: I0ac37f594bd12dd7b1ffb53d7ca9ef04761df5f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176114
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-04 09:49:41 +00:00
Tim van der Lippe 4abec848cb Remove typedefs from changes-legacy.js 
Bug: 1006759
Change-Id: I83d4c4ad7f8dd247c8a27ef6e83bbe27a7eec17b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2057204
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 15:21:06 +00:00
Tim van der Lippe aa76aa23f5 Fix internal bindings in ui/ 
These were some left-over fixes that regressed while doing phase 3 of
ESM. It includes fixing the typedefs in ui-legacy to be in the proper
file and exported.

Bug: 1006759
Change-Id: Ie398fcec632bcaf6462b44581213f5e6c45882de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055066
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-14 15:21:06 +00:00
Tim van der Lippe bd62fd61e5 Migrate changes/ to import cross-module 
Bug: 1006759
Change-Id: I426354313642308278f258294995bbf26ffe5cf6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2054161
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-13 15:30:45 +00:00
Michael Liao 76192f01c8 [Changes]: Allowing horizontal scrolling using arrow keys 
Issue:
- Users could not use arrow keys to scroll horizontally in the Changes tool

Changes:
- Added extraKeys param to ChangesTextEditor that re-routes Left/Right arrow key input to scroll horizontally

GIF: https://imgur.com/7F3Enxi

Bug: 963183
Change-Id: I97768a3d21caee80e8d22dc52eea8a5a86c71112
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2027844
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-02-07 18:36:51 +00:00
Paul Lewis 95eeb30b5f Migrates changes/ to ESM internally 
Bug: 1006759
Change-Id: I6543c6eddbba6b01b9e096c5ae813bde9add9d9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991639
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-10 11:45:16 +00:00
Jack Lynch 9542a8be14 Fix accessibility issues in the Changes editor 
This change makes the Changes drawer editor more accessible by adding a
gutter column with +/- symbols on added or deleted rows, respectively.
This information was previously conveyed only through color, a WCAG
violation.

In order to communicate whether a line is an addition or deletion to
screen reader users, I created a new code mirror input style that
prepends 'Addition:' or 'Deletion:' to the text that screen readers read
out for each diff line. This solution was settled on after discussing it
with other devs working on accessibility in order to avoid implementing
something more complex like VS Code's screen reader diff experience [1].

Screenshot: https://gyazo.com/8fe95b563a9e74d0d8b1a88900876c2a

[1] https://github.com/Microsoft/vscode/issues/17263#issuecomment-305701496

Bug: 963183
Change-Id: Ieeab30b8058fb36ef3a0d9ef4beac52419f6dc33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891836
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2019-12-31 21:42:27 +00:00