zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 21:28:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,025 Commits 45 Branches 79 Tags
779b46bac3bb2ca8aa997d683183eded1971fadc
Commit Graph
7025 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim van der Lippe 779b46bac3 Inline and remove peekLast() 
In the future we can use `.at()`, but that has not been shipped yet.

R=szuend@chromium.org

Bug: 1050549
Change-Id: I89e760db277ffb91bfbba93106e6e11d3ece91d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624711
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 14:09:52 +00:00
Tim van der Lippe bcd6b5c3ff Inline and remove isEnterKey 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I7242fa3b0c2a69d2e4b4dd7c642ba09a5f4dc9bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624713
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 13:02:42 +00:00
Tim van der Lippe 6d5bdf4f7e [module.json extensions] developer_resources 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I433c9a8d02541ace0fbf7662f6689faaa7f0607a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612856
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 12:40:02 +00:00
devtools-ci-autoroll-builder 09c9268401 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/787a10d..d68ac97

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8149a96..fdd8946

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I03c9649281de3fa754c729483c9bbf8a4a26bcce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2625866
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-13 12:28:42 +00:00
devtools-ci-autoroll-builder 95ab239e91 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ia21e4b03926cb7522a723f03d819ccf02277b79f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2625861
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-13 11:41:42 +00:00
Jack Franklin 0771fdcbac Fix report view component doc 
Because the import was only used for types, it got dropped. We need the
side-effect and the `type` import to ensure the component code gets
pulled in.

Change-Id: I1dd8bf686c41f19412e997a7419f1ba799717000
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626289
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-13 11:10:42 +00:00
Tim van der Lippe 2f1ea1c2ca [module.json extensions] changes 
R=andoli@chromium.org

Bug: 1134103
Change-Id: Ic2d249ae33f7e291ff7bdf921e35c92d8f5649ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612853
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 10:55:43 +00:00
Sigurd Schneider 8d62769d7e Collect UMA on developer resource loads 
Bug: chromium:1069378
Change-Id: I324712b50ee50c39620fa76669125f1e3b5e01d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622195
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-01-13 10:48:33 +00:00
Andres Olivares afef376c66 [module.json extensions] Add check for duplicate actions and views 
To prevent duplicates amongst legacy and pre-registered views and
actions a check is implemented in the place where both legacy and new
extensions of registered in the same data structure and an error is
thrown in the case of duplicates. Note that this check had been
implemented already for setting extensions.

This is only to keep support for both the legacy and new extension
registration systems during the migration. Because a check for
duplicates already exists for extensions registered with the new system,
checks added in this CL will be deleted once all extensions have been
migrated and the legacy system has been completely removed.

Bug: 1134103
Change-Id: I3601dffe64cd2ccfb7c16e3ad10bdc0cb103b189
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2607298
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 10:46:52 +00:00
Alfonso Castaño d057a44ae3 Center vertically popover icon 
This CL makes the icon inside RowMessage vertically aligned with the text.

Screenshot-before: https://i.imgur.com/jMqLY8s.png
Screenshot-after: https://i.imgur.com/ExNvmYG.png
Design-doc: https://docs.google.com/document/d/1TgMAUsruc_xAPAseG96H0-NHRT_PiXciedD58hgq1e4
Bug: chromium:1150883
Change-Id: Ie6f71697732c0f25a87677b3e34d6f218742f519
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2591132
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-13 10:45:22 +00:00
Tim van der Lippe 6d21034c1b [module.json extensions] animation 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I40dd16d7e5ddc9c3b1a879bdda0b9d0de13fdf20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612854
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 10:35:02 +00:00
Paul Lewis 7a4c23a564 Perf panel: fix request finish time 
When providing the details for a request in the performance panel, we
calculate the network duration based on the request's finish time minus
its start time. However for data URLs there is no request finish time
since these never go out to the network, which results in a negative
time shown as the code defaults the finish time to zero (0).

This CL updates the code to default the finish time to be the start
time in the event that no finish time exists or if it is zero(0).

Bug: 1157396
Change-Id: I04b03fdeb7941009e88707df44ec68ef9e2f0fda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2627269
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-13 10:11:42 +00:00
Benedikt Meurer c5a80dd56e [e2e] Temporarily disable tests to unblock the Chromium roll. 
These tests need to be rebaselined and reenabled after Chromium
(with V8 changes) rolls into devtools-frontend.

Bug: chromium:1165304
Change-Id: I2c27d91e19b65debd14dda0bd83d76b05193c375
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2627268
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-13 09:58:42 +00:00
Kim-Anh Tran 17c7b27c25 Allow live locations even if the debugger is disabled 
Previously we relied on the debuggerModel to create a raw location,
which is used for creating live locations.

This changes raw locations (DebuggerWorkspaceBinding.Location)
to rely on scriptIds instead of scripts. As a result we can create a
live location even if we currently do not have a script.

As soon as the debugger is enabled and a script is parsed, the
live locations will be updated with the relevant information.

We use this change in the Linkifier, which now shows no link if
the debugger is disabled (e.g. if we profile), and updates the
location and shows the link as soon as the debugger is enabled.

Also-by: bmeurer@chromium.org
Also-by: pfaffe@chromium.org
Bug: chromium:1132260

Change-Id: I48dc6016099d5b82d702a4331f93301693a6a6f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595386
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-13 09:30:32 +00:00
Jack Franklin cc988a955f Move binaryIndexOf into ArrayUtilities 
Bug: chromium:1050549
Change-Id: I16b64efa3f28239e503478f00e8ba876b34998f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622192
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-13 08:43:52 +00:00
devtools-ci-autoroll-builder 26ac0bee01 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/3769c3b..787a10d

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/59b0ce2..8149a96

Rolling third_party/inspector_protocol: https://chromium.googlesource.com/deps/inspector_protocol/+log/751c62b..62c7be8

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I12778649e3a11249097631112f00911d26e8f9dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626887
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-13 03:29:02 +00:00
Songtao Xia 2d846ce149 Hide span button for single screen device 
Currently the span button was disabled but still visible for
single screen devices, sometimes confusing.

Bug: crbug.com/1164493
Change-Id: I3c618acd97c3e20a7e65e2db6f4188de6873bec9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2618572
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
 2021-01-13 01:23:01 +00:00
Tim van der Lippe e2ffb37426 Remove Closure-related types in legacy-defs 
These were necessary during the migration towards TypeScript, but
can be removed now that Closure is gone.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ie5ceb46fae590689762f7a55ebed8d4117b077b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624712
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-12 16:49:41 +00:00
Tim van der Lippe 30ec438102 Move String.hashCode into string-utilities 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I79358c4de54b907c142ae39e5be2d602d3889c4e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624710
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-12 16:41:11 +00:00
Tim van der Lippe 3a0ca76b82 Move unescapeCssString into elements/ 
This was the only place where this utility function was used.

R=szuend@chromium.org

Bug: 1050549
Change-Id: I599800e0ba085f1514b6b3db164f9c91575ac673
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624389
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-12 16:04:11 +00:00
Jack Franklin dfd5a68bf0 Remove Set#firstValue proto method 
A grep of the codebase for `firstValue` provides no calls to this.

Bug: chromium:1050549
Change-Id: I84f1a685044a0a71d15507f7446fa6669a7a8808
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622193
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-12 15:56:21 +00:00
Tim van der Lippe a71272ea25 [module.json extensions] coverage 
R=andoli@chromium.org

Bug: 1134103
Change-Id: Iefcbb03583eaeb7d008abb0d4cbce7256747a149
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612857
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-12 15:38:31 +00:00
Tim van der Lippe ea9b5bbcb5 Move Array#sortRange into array-utilities.ts 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I7243ecce5b9b4da2ff2a72ddf5bf195574f3aaad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622196
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-12 14:52:31 +00:00
Tim van der Lippe 942f3d36c4 Remove global singleton function 
This function is unused.

R=jacktfranklin@chromium.org

Bug: 1050549
Change-Id: I5c658e87afcdac3bba3ca73b881a828b71d878e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2623946
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-12 14:42:31 +00:00
devtools-ci-autoroll-builder 9dd43ad51d Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d599553..3769c3b

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/82b992a..59b0ce2

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Icd30cd25fde0a44c5084d386e2450a08d1265af3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624418
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-12 12:37:21 +00:00
Jan Scheffler 40b825b8bb Reland "[JSDOC2TS]: Migrate webauthn" 
This is a reland of 1623b7a7e9

Original change's description:
> [JSDOC2TS]: Migrate webauthn
>
> Bug: chromium:1158760
> Change-Id: I1b04015d139133ec608830644d2bd188ba299d53
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622073
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: chromium:1158760
Change-Id: I8487f9f79e454340e4f055effb4a1d1aa84914e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622198
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
 2021-01-12 12:25:41 +00:00
Almothana Athamneh 7297ea89b0 Add E2E test for syntax highlighting test case 
Change-Id: I0e7b0772332cf3f703e906fc2a87e72bcc2f157f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2618319
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-01-12 11:20:31 +00:00
Jan Scheffler d862f14f50 [JSDOC2TS]: Migrate web_audio 
Bug: chromium:1158760
Change-Id: I2fdefac0c70b93c220842cbae32ce9c7350ba938
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622194
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-12 10:46:01 +00:00
Jack Franklin a60056fee7 Migrate Number.toFixedIfFloating to utilities 
Bug: chromium:1050549
Change-Id: I605bdc07675b98b3dd038c624f6303523145c7bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619689
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-12 09:29:30 +00:00
Patrick Brosset 746d0b6b36 Don't emulate screen size for fullsize shots to avoid unwanted resizing 
We used to need to emulate a different screen size when taking fullsize
screenshots in devtools.

However, since https://bugs.chromium.org/p/chromium/issues/detail?id=1003629
was fixed, we now have access to a new CDP parameter when taking
screenhots that allows to create screenshots even when all or part of
the image is "below the fold".

This parameter, captureBeyondViewport, is already set to true in the
ScreenCaptureModel here:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/sdk/ScreenCaptureModel.js;l=55;drc=5215b2bdd2f7d5b1387df5783edbf9385591d221

This means the emulation data we're setting prior to taking the
screenshot is now redundant:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/emulation/DeviceModeModel.js;l=834;drc=d7cfd148144b8bc0964ddfab1a2c91980519361c
and we can just remove it.

This fixes an issue where the resulting image was larger than the page
actually was.

Bug: 1158735
Change-Id: Ic44ea9ebea52165bdd231afb748dcc7b15d1d176
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2621732
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-01-12 09:17:10 +00:00
Simon Zünd 828355c9f6 Show error icon in the Trust Token tab label if the operation failed 
Screenshot: https://imgur.com/a/ownq5U4

R=sigurds@chromium.org

Bug: chromium:1126824
Change-Id: I020ca57f0d1efdc67e65d884b3ba067f9fef9b3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587737
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-01-12 08:05:10 +00:00
Sigurd Schneider 12cf869509 Add performance measureMemory in FrameDetailsView 
This CL adds the availability of performance.measureMemory
to the API availablility section in the frame details view.

Screenshot: https://imgur.com/a/INrFzF3
Bug: chromium:1139899
Change-Id: I6406cffac8c96f81719d935ddd30f303ab50ee1b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619690
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-01-12 08:00:31 +00:00
devtools-ci-autoroll-builder 537f11c114 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/8874a0a..d599553

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/2277272..235cfe4

Rolling buildtools/linux64: git_revision:0d67e272bdb8145f87d238bc0b2cb8bf80ccec90..git_revision:595e3be7c8381d4eeefce62a63ec12bae9ce5140

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c1aa4ec..82b992a

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I4f911bf7c463a351cb50c1c1aaa198dfb856bd30
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2623636
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-12 03:20:30 +00:00
Songtao Xia d08c553176 Make dual screen support default 
Based on user study, setting this experiment default on may reduce
confusion and encourage more usage.

Change-Id: I29206cdf08725f51c26104b53da1482b751689d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2618641
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-01-11 23:33:40 +00:00
Michael Liao 4f62c670fe [Icon]: Change dropdown arrow to svg and add dark theme dropdown arrow 
Issue:
- chrome-select inputs have slightly blurry dropdown arrow
- chrome-select inputs in dark theme have a hard to see dropdown arrow due to contrast

Changes:
- changing dropdown arrow icons to .svg
- adding dark theme dropdown arrow

Pictures:

Before - Settings in Dark Theme: https://imgur.com/NePBXu6
After - Settings in Dark Theme: https://imgur.com/aGjk7UM

Before - Settings in Light Theme: https://imgur.com/78VAoee
After - Settings in Light Theme: https://imgur.com/kLCyEqM

Bug: 1164031
Change-Id: I2d7c10788692cf973e24a23f4c22b12e22a26919
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2616383
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2021-01-11 19:03:56 +00:00
vidorteg b90a077d51 Reducing ambiguity in some strings 
- Fixing an ambiguous description on the Paints panel, otherwise
"Paints" could be used as a "Pictures" in some languages.
- Locking the "live expression" term as it could be translated
as an "artistic expression" in some languages.

Bug: 1136655
Change-Id: I88d46f53af0461e2379a1f0821dfeedc78420db4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2615135
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2021-01-11 18:25:37 +00:00
Maks Orlovich 5ebe27d191 Custom UA-CH emulation: initial integration test 
Fow now, this just covers adding a new emulation device, including
user agent client hints, and that this actually works.

Bug: 1073909
Change-Id: I18c358277565531aeed6c1195ce318dbc793d46a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610068
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-11 17:34:17 +00:00
Jan Scheffler 0489faf3e3 Revert "[JSDOC2TS]: Migrate webauthn" 
This reverts commit 1623b7a7e9.

Reason for revert: Fails presubmits in checkouts

Original change's description:
> [JSDOC2TS]: Migrate webauthn
>
> Bug: chromium:1158760
> Change-Id: I1b04015d139133ec608830644d2bd188ba299d53
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622073
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,janscheffler@chromium.org

Change-Id: I84edc9efad503faf5a7ef463bdc8f897e670b210
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1158760
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622197
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-01-11 17:15:31 +00:00
Tim van der Lippe 28a79aace9 Move assertNotNull into platform 
R=jacktfranklin@chromium.org

Fixed: 1154208
Change-Id: I3729d0f06577a3bb065ea362dec9e83d096965b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2618318
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-11 17:14:27 +00:00
Jan Scheffler 1623b7a7e9 [JSDOC2TS]: Migrate webauthn 
Bug: chromium:1158760
Change-Id: I1b04015d139133ec608830644d2bd188ba299d53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2622073
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-11 16:47:46 +00:00
Jack Franklin fd9dfaa5e7 [Dark mode] replace #fff background-color 
This CL searches for CSS that matches:

- background: #fff
- background: #ffffff
- background: #white
- background-color: #fff
- background-color: #ffffff
- background-color: #white

And replaces the declaration with var(--color-background) from the new
set of color variables.

Bug: 1152736
Change-Id: Ia0575ccfa4e23c92fd4f83e6c911236dbb893fea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577559
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-11 16:18:06 +00:00
Alexander Timin d73d6ee257 [devtools] Remove timeline flow event experiment. 
This experiment is relying on the deprecated format of flow events and
there are no plans to ship in the immediate future.

Remove it to unblock removing the old flow event macroses. This
experiment should be reimplemented on top of the new trace event flow
format instead.

R=yangguo@chromium.org,caseq@chromium.org
BUG=1164298

Change-Id: Ibf29a2842750c0fab8b6099e992aed27f4886b12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2617780
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-11 16:16:06 +00:00
Brandon Goddard 6f4e54f003 Limit Datagrid Screen Reader Alerts to Focused Grids 
This CL addresses an issue where datagrids could unexpectedly announce
content to screen readers if a grid node is selected when the grid
does not have focus - which can occur when a grid is first created.

This change limits datagrid alerts to when the grid has focus.

Repro steps in bug description.

Bug: 1164034
Change-Id: Ib6fd7012782f7073617ed20d5432333d83732ccb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2618379
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
 2021-01-11 16:11:12 +00:00
Jack Franklin cac69b4441 [Dark mode]: generate dark styles for cmdevtools.css 
Uses the new script to generate the dark mode styles for cmdevtools so save us
manually processing it. Tested by clicking around the sources panel in light and
dark mode and verifying that things look as expected.

Also fixed some bugs in the generator script to ensure we generate the
right selectors.

Bug: 1152736
Change-Id: If3491651be116033be7248e695ceab1de5f3fc5c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593129
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-11 16:10:06 +00:00
Maks Orlovich 991e2385ae Custom UA ch editting: fix key behavior on the folder 
For the right/left arrows to expand the folder, the root item
needs to already be selected per notion of Treeoutline

Bug: 1162902
Change-Id: I3a3999900473d441623c4a5555d44bcb69c2a045
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610064
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
 2021-01-11 16:09:01 +00:00
Michael Achenbach a1a01b5e46 [build] Remove obsolete gn flag 
Bug: chromium:1164276
Change-Id: If15d7504df7b37eaec931783054613702ca5ae0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619604
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2021-01-11 16:07:57 +00:00
Simon Zünd ccdfc9bed1 Roll deps from Chromium into DevTools 
This CL is the result of running roll_deps.py and
npm run generate-protocol-resources.

Additionally, cookie unit tests are adjusted to include a new property.

DISABLE_THIRD_PARTY_CHECK=Chromium deps roll

R=wolfi@chromium.org

Change-Id: Ifb2d7b4bc6839de2a6fe269ebfe918f43f21d1b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619610
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-11 13:00:56 +00:00
Philip Pfaffe f2846bd3d9 Update DevTools Chromium DEPS. 
R=sigurds@chromium.org
CC=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I5053b228e8362bed088393bc6d644d160f083e00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619605
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-11 12:59:26 +00:00
Tim van der Lippe 5511047da1 Fix changes computation for inspector-stylesheet 
The inspector-stylesheet is a special virtual file that is used
to keep track of any new CSS rules, which can be added by clicking
the "New Style Rule" button in the Elements panel. However, the
changes computation broke and was no longer showing any changes
to this file.

The most likely culprit is https://crrev.com/c/2378070 which changed
the way errors were handled. The TLDR is that the `baseline` became
an empty string, which is falsy. Hence, the diff computation bailed
and was not showing any diffs.

Instead, we should be explicitly checking of the `baseline` is `null`,
since it is legal to perform a diff computation between an empty
string and a larger string.

R=szuend@chromium.org

Fixed: 1152507
Change-Id: I1aa778e7922586a4381cbc1e1e6e543a5ccffdd9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610964
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-11 12:57:37 +00:00
devtools-ci-autoroll-builder 94d38f6943 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d1a7463..8874a0a

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ia9a81bc0c3490222b8e8f2a4dc3a8424fc6d732b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2621575
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-11 12:22:16 +00:00