Tim van der Lippe
5511047da1
The inspector-stylesheet is a special virtual file that is used to keep track of any new CSS rules, which can be added by clicking the "New Style Rule" button in the Elements panel. However, the changes computation broke and was no longer showing any changes to this file. The most likely culprit is https://crrev.com/c/2378070 which changed the way errors were handled. The TLDR is that the `baseline` became an empty string, which is falsy. Hence, the diff computation bailed and was not showing any diffs. Instead, we should be explicitly checking of the `baseline` is `null`, since it is legal to perform a diff computation between an empty string and a larger string. R=szuend@chromium.org Fixed: 1152507 Change-Id: I1aa778e7922586a4381cbc1e1e6e543a5ccffdd9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610964 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Chrome DevTools frontend
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
Source code
The frontend is available on chromium.googlesource.com.
Design guidelines
Please be aware that DevTools follows additional development guidelines.
Issue triage
The issue triage guidelines can be found here.
Workflows
Instructions to set up, use, and maintain a DevTools frontend checkout can be found here.
Additional references
- DevTools documentation: devtools.chrome.com
- Debugging protocol docs and Chrome Debugging Protocol Viewer
- awesome-chrome-devtools: recommended tools and resources
- Contributing to DevTools: bit.ly/devtools-contribution-guide
- Contributing To Chrome DevTools Protocol: docs.google.com
- DevTools Design Review Guidelines: design_guidelines.md
Source mirrors
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
Getting in touch
-
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
-
All open DevTools tickets on crbug.com
-
File a new DevTools ticket: new.crbug.com
-
Code reviews mailing list: devtools-reviews@chromium.org
-
@ChromeDevTools on Twitter
-
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools