zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
1,921 Commits 45 Branches 79 Tags
7cd600f9d2ed1b5f3dbce9ea71bf2a98d5f150b2
Commit Graph
1921 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jack Lynch 7cd600f9d2 Reland: Make call stack keyboard navigable 
This is a reland of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515,
which was reverted at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1961190
due to test failures that do not repro or appear to be related.

This PR makes the call stack sidebar pane in the Sources panel more
accessible by:
  - enabling keyboard navigation of the call frame list by managing call
  frame selection outside of ListControl as suggested by Joel in [2]
  - adding the aria-disabled attribute to unselectable call frames
  - adding an aria description to blackboxed call frames

This will break several web tests, so [3] must be merged first to
disable them.
Originally reviewed in [1], where the web test fixes for this CL now
live.

Video showing navigation: https://i.imgur.com/55tJy2k.mp4

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117

Bug: 963183
Change-Id: I826e1c5c2f78c235823a71c956fde6ef73bcccac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1965855
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-13 23:13:35 +00:00
Rob Paveza 41120592d3 Refactor of the 'copy_all_modules' build step 
I've sporadically seen the same CreateProcess failure in ninja recently
that we'd been seeing for the GRD script [1]. This failure is related to
the copy_devtools_modules script.

As part of this change I've also corrected some linting errors that I
had made with the previous fix.

[1] The previous fix can be found at
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1992319

Change-Id: Ic9a66160acddfc929fdd43f20572435ceff3724c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997723
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 19:07:47 +00:00
Joey Arhar 8b09057179 Fix request cookies view with no cookies 
The request cookies tab isn't supposed to appear if a request has no
cookies. After crrev.com/c/1950166 it started appearing for requests
with no cookies, which uncovered a cookies panel which I unfortunately
didn't set up to look OK if there are no cookies.

This patch both makes the cookies panel look OK if there are no cookies
and makes the cookies tab once again only appear if the request has
cookies.

Change-Id: I79e1177b2289935159bdc7525d33a2a8d7da9afa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1992204
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
 2020-01-13 18:58:35 +00:00
Tim van der Lippe 3cd66dcf89 Migrate main/ to ESM internally 
Bug: 1006759
Change-Id: I44435dcd09afe2c3cbac7bbda46df415b77c12d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994969
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-13 18:01:15 +00:00
Jack Lynch 7bc9bf2b07 Performance Event Log link accessibility 
This CL makes the links in the Performance panel Event Log details view,
shown to the right in [1], tabstops so that they can be accessed by
keyboard users.

[1] https://gyazo.com/de063c6b02c4d7580807338a6371f9f7

Bug: 963183
Change-Id: I718805bc31fbfa681a035909358345e96d3aa8bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891710
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-13 17:53:35 +00:00
Jack Lynch 0a882882e4 Highlight DOM breakpoints when hit 
This CL fixes an issue where one or both of the two instances of the DOM
breakpoints pane (in Sources and Elements) fail to update when a
breakpoint is hit. There's a video in the linked bug showing more
specific repro steps, but the issue stems from three different
extensions in browser_debugger.json that reference
DOMBreakpointsSidebarPane: two views and a ContextFlavorListener. Unlike
every other view in the devtools, these ones define a factoryName rather
than a className. This makes the devtools create separate instances for
each rather than using runtime.sharedInstance(), which breaks
UI.Context._dispatchFlavorChange(), which does rely on
runtime.sharedInstance().

In order to make _dispatchFlavorChange() work properly with both the
Elements and Sources panel views, I replaced their factoryNames with
classNames, i.e. made them share an instance. Some minor changes to
ContainerWidget and _ExpandableContainerWidget were needed to make sure
the shared instance actually shows up where needed, but everything now
works as expected. An alternative would be to rework
Extension.instance() and ContextFlavorListener, but that seems more
invasive.

Bug: 973251
Change-Id: I288dea794518605f8f93c28c7826372dbaea2e1f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1984805
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-13 17:23:55 +00:00
Tim van der Lippe e584de248b Fix file references to wasm parser 
In
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1941748
a new wasmparser worker was introduced, which uses files from a
third_party file. However, the source files of the third_party folder
were added to `all_devtools_files` instead of `all_devtools_modules`.
This causes the Chromium build to not bundle these files in, as they
were not in the GRD file.

We will fix the `check_gn` script to properly error on this issue.

Fixed: 1041415
Change-Id: Iae077c91ac62ca794086229d7b73f1485b5a9b44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997350
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
 2020-01-13 16:37:44 +00:00
Tim van der Lippe 151993a023 Migrate js_main/ to ESM internally 
Bug: 1006759
Change-Id: I3e74d38abc989ebe2da1b6d6fedcbacd12695e33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994968
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-13 16:16:34 +00:00
Tim van der Lippe 99a53d75fc Move side-effects of TestRunner to test_runner 
Importing exported symbols of the TestRunner was not possible, as the
instantiation of the TestRunner was performed in the file itself.
Therefore, we should move the side-effect instantation to test_runner,
which thus allows us to import TestRunner.js.

Bug: 1006759
Change-Id: I271931709114d52f2f98b6a14468ae584d6310c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997348
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-13 16:04:34 +00:00
Paul Lewis 6196e75c80 Migrates persistence/ to ESM internally 
Bug: 1006759
Change-Id: I3f6351fe6b9f97ca88b528369168bba2fe00f76b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994978
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 15:48:34 +00:00
Paul Lewis 7483c1d8ab Migrates node_main/ to ESM internally 
Bug: 1006759
Change-Id: Ifabc2e1087a5e9a7877d9fad1c6661474c177ef3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994972
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 15:39:05 +00:00
Paul Lewis ce12468cae Migrates layer_viewer/ to ESM internally 
Bug: 1006759
Change-Id: I1e2ea259f826248fcb942ac99534664b9cdaca6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994971
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 15:35:14 +00:00
Paul Lewis c13effef13 Migrates help/ to ESM internally 
Bug: 1006759
Change-Id: I35599d0de17f810a45cb77c5a5148fb9362aad2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994963
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 15:19:14 +00:00
Almothana Athamneh 3643fae0fa Add test files for classes depending on SDK 
This CL attempts to add Karma test files with minimal tests to make some
classes depending on SDK appear in coverage reports and to use them as
placeholders for future tests

Bug: chromium:1032561
Change-Id: Icd678b1eb8ac906b7b3028577458e91a0664b88c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997344
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2020-01-13 14:53:54 +00:00
Paul Lewis 493aece635 Updates root.js reference for browser_sdk 
Bug: 1006759
Change-Id: I91f9c225444ce2d6a15fbdff690abe21eb18e160
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1997346
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-13 14:51:24 +00:00
Paul Lewis 6d37afcf11 Migrates performance_monitor/ to ESM internally 
Bug: 1006759
Change-Id: I71003990205d75dd8f09af322a8ad4dd58cef364
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994976
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 14:46:24 +00:00
Paul Lewis 2143421bb0 Migrates layers/ to ESM internally 
Bug: 1006759
Change-Id: I4252276f9d42a807461cefe49f18e29ef3e33d06
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994964
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 12:10:35 +00:00
Paul Lewis 2ccee08877 Migrates color_picker/ to ESM internally 
Bug: 1006759
Change-Id: I827674111e473d531f5594dbb5cf71ce519ff734
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993462
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-13 11:51:44 +00:00
Paul Lewis 2cfa94e681 Migrates perf_ui/ to ESM internally 
Bug: 1006759
Change-Id: Ie9c125e505ee60831bc0942e7e0111ced5a45082
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994977
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-13 10:57:04 +00:00
Benedikt Meurer 7f0d1dad84 Roll upstream changes. 
Tbr: yangguo@chromium.org
Change-Id: I047030ef3bca6d0f5189a4294bc083e5ef15faab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994975
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2020-01-13 06:34:04 +00:00
Simon Zünd 165ea10cdd Prepare SourceMapNamesResolver.js for source map asyncification 
This CL prepares {SourceMapNamesResolver._resolveExpression} for the
upcoming asyncification of
{DebuggerWorkspaceBinding.uiLocationToRawLocations}.

R=janscheffler@chromium.org

Bug: chromium:1032016
Change-Id: Iebe22450bcf7f87073b783e2f1d679c98e25f17b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994961
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2020-01-13 05:57:15 +00:00
devtools-ci-autoroll-builder 6f1adcb16c Update DevTools DEPS. 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fc132e6..7a8bf94

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I0b105f5eef104ba7f5ccfa4f225d67c3c0b2a981
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1995484
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-01-11 12:09:42 +00:00
John Emau c13cd77e04 Fix autocomplete TypeError: protoNames is not iterable 
Background:
protoNames is needed to display JavaScript object properties in the
autocomplete flyout. For example when editing code snippets in the
console, watches, and source pane.

Problem:
When callFunctionJSON fails due to a Protocol Error protoName is null [1]
which will cause the runtime TypeError: protoNames is not iterable [2].

Solution:
Check that protoNames is truthy before iterating over it; return early
with an empty array if protoNames is falsy.

[1]: https://cs.chromium.org/chromium/src/third_party/devtools-frontend/src/front_end/sdk/RemoteObject.js?l=658&rcl=6ced335a
[2]: https://cs.chromium.org/chromium/src/third_party/devtools-frontend/src/front_end/object_ui/JavaScriptAutocomplete.js?l=172&rcl=6ced335

Change-Id: I1431d3de6333bfd331e8ec1a1446d8051aa24157
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1919852
Commit-Queue: John Emau <John.Emau@microsoft.com>
Reviewed-by: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-11 04:06:21 +00:00
devtools-ci-autoroll-builder 3d827a331c Update DevTools DEPS. 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/13928b7..fc132e6

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I95f79527b52158f7c583efb6424192f65cec4e73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1995483
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-01-11 03:13:11 +00:00
Michael Liao 9417f6065f [Profiler]: Adding SR functionality for heap size and trends in Isolate Selector list item 
This change affects the IsolateSelector class.  Found in Memory and JavaScript Profiler Tools

Changes:
- Adding Heap size and trend text of isolate list item to accessible label

Image of isolate item to SR text:
https://imgur.com/hmhztWI

Bug: 963183
Change-Id: I2eebdf2516288f16eb3b1d3088f0e6a26ae98556
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1990473
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-01-10 19:12:28 +00:00
Kalon Hinds d01eb543e7 Animation Timeline keyboard focus and interactivity 
The Animation tool allows users the ability to change animation duration,
start time, and keyframe length via the mouse.

This patch adds keyboard interactivity to the scenarios above. Due to the
dependence of the `MouseEvent` type in the `elementDragStart`,
`elementDrag`, and `elementDragEnd` callbacks passed to
`UI.installDragHandle()`, I had to create an AnimationUI specific method
to set the keyboard event listener. This also required creating a keydown
handler that is a combination of the `_mouseDown`, `_mouseMove`, and
`_mouseUp` instance methods functionality sans calls to `MouseEvent`
specific properties.

One such property was `clientX`, which was used to determine the next
draw location on the timeline for an element being dragged. For
keyboard interactivity a new instance variable
`_keyboardMovementRateMs` was created to set the movement rate.
This is currently a constant set to 50ms, but we may want to listen to
feedback to see if we need to create a variable rate based on animation
properties.

GIF: https://i.imgur.com/RlEQEga.gif
Bug: 963183
Change-Id: Ib5c94162a582a06729cf71f0afd965b0c2465347
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1920984
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
 2020-01-10 18:11:48 +00:00
Tim van der Lippe 2ef3661d27 Migrate mobile_throttling/ to ESM internally 
Bug: 1006759
Change-Id: Id30902e0f3341870e0d2b26a075ba450f15ed01a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994970
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-10 16:02:17 +00:00
Tim van der Lippe c86c0d9120 Migrate heap_snapshot_model/ to ESM internally 
Bug: 1006759
Change-Id: Ia23b343f061db22853f2cfe762b44f42e7cb95bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993465
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 14:45:36 +00:00
Tim van der Lippe 678f13988c Migrate console_counters/ to ESM internally 
Bug: 1006759
Change-Id: I926a7693872c7e07b80e1632143d7a8d27810e75
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991516
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 14:42:47 +00:00
Sigurd Schneider 4784784e26 [coverage] Refactor backlogging in the CoverageModel 
Bug: chromium:1022031
Change-Id: I1c137387d2f44d63d3e8a071c278a8f98eafd74f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991510
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-01-10 14:20:07 +00:00
Tim van der Lippe eaacb72383 Migrate console/ to ESM internally 
Bug: 1006759
Change-Id: If15f5741c87ff711976a317910cbf01489db1d3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991515
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 14:03:57 +00:00
Tim van der Lippe d3c3b72021 Migrate formatter_worker/ to ESM internally 
Bug: 1006759
Change-Id: I895bd53ff3f5381cc7e159f0813b426f34e8fef7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991638
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 13:59:37 +00:00
Tim van der Lippe a611092efe Migrate extensions/ to ESM internally 
Bug: 1006759
Change-Id: I5a21c9cc7510dad06903f24f06a0cde23473f532
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991633
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 12:44:46 +00:00
Tim van der Lippe 084cdcea89 Migrate event_listeners/ to ESM internally 
Bug: 1006759
Change-Id: Ia21eb0f3ac4f5edda59e3e3b93d9a7cdc129ab19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993348
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 12:41:27 +00:00
Tim van der Lippe 5d1c0dd1f6 Migrate components/ to ESM internally 
Bug: 1006759
Change-Id: I1b7ad16f09ef1c7fe3a404f073953baf739ec8e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991513
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 12:37:57 +00:00
Tim van der Lippe c37085a1eb Migrate har_importer/ to ESM internally 
Bug: 1006759
Change-Id: Ie4ee517b99829db624580d81d0f52ffd5f0d33c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993464
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-10 12:06:17 +00:00
Paul Lewis 95eeb30b5f Migrates changes/ to ESM internally 
Bug: 1006759
Change-Id: I6543c6eddbba6b01b9e096c5ae813bde9add9d9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991639
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-10 11:45:16 +00:00
Paul Lewis 23455aad24 Migrates browser_sdk/ to ESM internally 
Bug: 1006759
Change-Id: I27e5a31ea0cc390b8d3413002bfb9d4325d35605
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991636
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-10 11:40:56 +00:00
Paul Lewis ef05f96d6d Migrates bindings/ to ESM internally 
Bug: 1006759
Change-Id: I24fa605a4aa9dcc25cf7ff76609b8ae86cf09905
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993350
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-10 11:37:56 +00:00
Simon Zünd 5a8f4d89e1 Revert "Migrate accessibility/ to ESM internally" 
This reverts commit 785c6a4f1c.

Reason for revert: Suspected to break "run_type_check.py" on the bot.
https://ci.chromium.org/p/chromium/builders/try/linux-rel/279842

Original change's description:
> Migrate accessibility/ to ESM internally
> 
> Bug: 1006759
> Change-Id: I9d801349fd73a06d7f72933acfa65b103531a278
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991511
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

Change-Id: Ie4fe54b84cf91cd034bfdb21c20b97eaacdb3599
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994960
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-01-10 06:01:18 +00:00
devtools-ci-autoroll-builder e3dbd98a91 Update DevTools DEPS. 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/081c5b5..13928b7

Rolling third_party/inspector_protocol: https://chromium.googlesource.com/deps/inspector_protocol/+log/dee0c0c..32a87e9

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ia848a0c7a04859ebd29a92dda2220b311ea23b43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994224
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-01-10 03:13:56 +00:00
Rob Paveza 6ec46b96fc Defensive null check in StylesSidebarPane 
Error reports indicate that there are occasional non-fatal errors
related to attempting to call the 'addRule()' function against
a null reference. Investigating, I found that there are three cases
in which Closure is not detecting that CSSModel#addRule was being
called without checking whether the CSSModel reference was null,
because it was not honoring the nullability declaration of
ElementsSidebarPane#cssModel() (which is declared to be of type
{?SDK.CSSModel}).

There are actually a number of other cases in this file which check
for this condition, which suggests to me that it's not actually
an expected invariant.

Change-Id: I287e22490836cc1194bee218f62e2474cefe80d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994118
Reviewed-by: Leo Lee <leolee@microsoft.com>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-10 00:06:45 +00:00
Paul Lewis 51474196c0 Migrates audits/ to ESM internally 
Bug: 1006759
Change-Id: I8a8d88f00c2c039dd9effe8335f3e7c1bc5bb4a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993343
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-09 17:12:21 +00:00
Paul Lewis b4e2a0741b Check for self.X = self.X || {} in migration script 
Bug: 1006759
Change-Id: I741093c412e6ef47b0154b0202bda56ffd07328c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993460
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 17:11:01 +00:00
Simon Zünd 7bb6041dac Prepare CoverageDecorationManager.js for source map asyncification 
This CL prepares CoverageDecorationManager.js for the upcoming
asyncification of {DebuggerWorkspaceBinding.uiLocationToRawLocations}.

R=mathias@chromium.org

Bug: chromium:1032016
Change-Id: I4b275d535f2f7c9a598ef9e5f5994060f524e2e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991634
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-09 17:08:21 +00:00
Paul Lewis 785c6a4f1c Migrate accessibility/ to ESM internally 
Bug: 1006759
Change-Id: I9d801349fd73a06d7f72933acfa65b103531a278
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991511
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-09 17:06:11 +00:00
Tim van der Lippe fe5c3f7d1d Migrate formatter/ to ESM internally 
Bug: 1006759
Change-Id: I1f5d50e3b42eae77dee3188c3c64215e57a68ea5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991635
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 16:56:41 +00:00
Paul Lewis 2a4f9fe07d Migrates browser_debugger to ESM internally 
Bug: 1006759
Change-Id: Iae67cbad44cfebe3ceb4353f32d9e2e4024b41bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991631
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-09 16:21:21 +00:00
Tim van der Lippe e8e8087021 Migrate emulation/ to ESM internally 
Bug: 1006759
Change-Id: I97735cd8b0e13fd82704537f01fab3c0c690a0b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993347
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 15:56:51 +00:00
Simon Zünd 7a79ca170c Cleanup early returns in SourcesPanel.js 
The big 'if-with-braces' CL made some early return statements less
readable. This CL fixes that by flipping the logic and removing early
returns, as well as some other minor cleanups in SourcesPanel.js.

R=mathias@chromium.org

Change-Id: Iecc8da4177a175d5a42413668f22497d3d7ad096
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993346
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-01-09 15:39:04 +00:00