zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-02 18:11:04 +08:00
Code Issues Packages Projects Releases Wiki Activity
5,218 Commits 43 Branches 79 Tags
7f2002c598a90ca35dd8f2290cde010d9dfd0d7f
Commit Graph
5218 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim van der Lippe 7f2002c598 [globals] self.runtime 
Migrate all usages of self.runtime to Root.Runtime.Runtime.instance().

This also requires various type updates, as now Closure/TypeScript
can better understand the code and discover issues.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ice07aa0ca959e61a6acdf4618b9a272d8c1096b8
Fixed: 1081614
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434339
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-29 10:52:39 +00:00
Simon Zünd 5c1904772b [ts] Type-check timeline/TimelineDetailsView.js with TypeScript 
R=petermarshall@chromium.org

Bug: chromium:1011811
Change-Id: I162117bb6555a0e9fffba5aed2e8a2b714caf2d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436815
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-29 09:22:28 +00:00
Simon Zünd 5ef41c8b63 [ts] Type-check timeline/TimelineLoader.js with TypeScript 
R=jacktfranklin@chromium.org

Bug: chromium:1011811
Change-Id: Ib47e3978bda11c079076859a5a9195bc775f6dda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436813
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-29 09:06:29 +00:00
Alex Rudenko 27ad3e764a Set up ThemeSupport in component-server to allow importing CSS 
Change-Id: Ia407aa70fdbf4ad227f5a758f032744e760507b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436812
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-09-29 09:01:08 +00:00
Simon Zünd 2ab7821a13 [ts] Type-check timeline/UIDevToolsController.js with TypeScript 
R=jacktfranklin@chromium.org

Bug: chromium:1011811
Change-Id: Ic9ab020e95fb006d607e6046d33dffdc848be2a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436731
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-29 08:23:48 +00:00
Simon Zünd eba79261ba [ts] Type-check timeline/TimelineLayersView.js with TypeScript 
R=petermarshall@chromium.org

Bug: chromium:1011811
Change-Id: I0fac447a7b3f03bf23c55933b1f4c74fc4890450
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436734
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-29 08:18:58 +00:00
Jan Scheffler d9863f1407 [WebAuthn] Store available authenticators 
This patch will enable the WebAuthn panel to persist
created authenticators (without the generated credentials).

Bug: chromium:1131055
Change-Id: I25406d7f64694883b6ccb9a373cde81a05352371
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431508
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
 2020-09-29 08:16:01 +00:00
Simon Zünd 0428ffbf9f [ts] Remove unnecessary @ts-nocheck from timeline/TimelineFilters.js 
TBR=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: I30e3a4ae009add1f2017468954b5c3c37590eba2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436733
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-29 07:55:18 +00:00
Simon Zünd 4ecb794327 [ts] Remove unnecessary @ts-nocheck from timeline/CLSLinkifier.js 
TBR=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: Id6331ea7e97d23a036dc180e932e0a277b9ca99c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436730
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-29 07:48:58 +00:00
devtools-ci-autoroll-builder bd99a610db Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I82b1ac7ea80bd52386eb1ccafd836d4807256355
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436472
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-29 06:21:08 +00:00
devtools-ci-autoroll-builder 0d33d0e062 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/8f04da0..38a49c1

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/77397c4..1099c11

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I21268b479a25c14958440f41474fea3136b0bea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436471
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-29 03:17:58 +00:00
vidorteg 306abde46d Locking user agent shadow dom from translation 
User agent shadow DOM is a technical term that should not be translated.

Change-Id: I971705411b57754f0708006ad5651742d363451b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434993
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2020-09-28 20:34:53 +00:00
vidorteg 29d2aa6ec8 Changing tone on a settings screen string. 
We have received some feedback around the tone of a specific string
in the settings panel. Some users feel the right intention is to warn
users of "unstable features" instead of "dangerous".

Change-Id: Id3468464e2a6b4a0605a855fcfeeedd249189b98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391912
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Christy Chen <chrche@microsoft.com>
 2020-09-28 18:31:13 +00:00
Alex Rudenko f4de8bffbc Refactor highlight and grid tools 
Refactors overlay to avoid using global variables. Note: the grid
label helpers still rely on a few global variables.

Bug: 1131801
Change-Id: Idb862c340cbc6c155549f2dfc0bdafdcadaee1ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2429775
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-28 18:05:13 +00:00
Christy Chen f6e093325b [Loc] Dont localize "top" and "iframe" when used as Javascript context 
Removed the Loc API calls for those titles, or locked the terms when they are used in a sentence as the names of Javascript context.

Bug: 941561
Change-Id: Ia77102fd96715614a63d8e13cb8a097554ff16d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2373991
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-09-28 16:56:42 +00:00
Wolfgang Beyer 029487f3ed Fix bug where FrameTreeNode is selected despite clicking elsewhere 
Prevent automatic selection of a node in the frametree which is already
in the selected state. This fixes a bug in which a node is re-selected
after clicking on the device emulation button.

Fixed: chromium:1129765
Change-Id: I90c947b7ac17dc933cebafb74d3a5bf86fdc550a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2435208
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-09-28 16:05:33 +00:00
Wolfgang Beyer 5ac564dd65 Fix horizontal scroll/overflow for frame details view 
Fixes the horizontal scroll behaviour so that dividers are shown
correctly. Fixed the same issue for the service worker details view.

Before: https://i.imgur.com/RljvLWd.png
After: https://i.imgur.com/l8hSBiD.png

Bug: chromium:1066415
Fixed: chromium:1128923

Change-Id: Ie5383fedaa93152d188756d1edb491836a5bef92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431507
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-09-28 14:15:22 +00:00
Tim van der Lippe 58ceb60bf6 Move compiler options into tsconfig.base.json 
These settings are the same for all ts_libraries. To make sure that
the configuration IDEs uses is the same as the ts_library uses,
let's move them into the tsconfig.base.json

DISABLE_THIRD_PARTY_CHECK=tsc update
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: Ia346620cd5b12c607b69bbae5bc9c83c1d56a3e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431511
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-28 13:03:22 +00:00
Benedikt Meurer d6a1e62cd0 Improve error reporting for the language plugins. 
Previously we accidentally swallowed the errors from the language
plugins instead of showing them. Now they are shown as errors in
the console.

Drive-by-fix: Remove the `DebuggerLanguagePluginError` class and use
plain `Error` for now.

Bug: chromium:1132281
Change-Id: I3cfa38ab3af6a18b6d1d09765f830c0cc3d039e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431509
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-09-28 12:38:23 +00:00
devtools-ci-autoroll-builder ba3d5932bb Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/c03908f..8f04da0

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0081a12..77397c4

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I81dc10e8d5dd74bf1f6306afa4876c79ef6011c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2435466
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-28 12:24:32 +00:00
Jack Franklin 77e014ad41 Migrate TimelineFrameModel to TypeScript 
Bug: 1011811
Change-Id: I7915a3f4571f87cbc6167c02b5eda0df5dc21d8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428888
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-28 12:15:52 +00:00
Jack Franklin 478d46836b Fix rendering of NodeText in LayoutPane 
The `new NodeText` pattern causes inefficient re-renders, which we
discovered on the breadcrumbs component.

Whilst fixing that bug I noticed that the LayoutPane tests don't run in
isolation due to having no ThemeSupport instance. I've updated the test
setup to create one at the start of all the tests.

Bug: 1129881
Change-Id: I30a48f50e93738a74bd0f17258d3b9c07d47ed6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431510
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-09-28 12:04:42 +00:00
Tim van der Lippe 5ae0cd6c31 Remove one gradient from iPhone5 device emulator images 
The iPhone5 graphics in the device emulator has a small gradient on the
one of the layers that looks broken in the UI, this change removes that
gradient.

Example: https://imgur.com/a/Uln06Id

Avif files compressed using squoosh.app according to
https://jakearchibald.com/2020/avif-has-landed/

R=brgoddar@microsoft.com,mathias@chromium.org,tvanderlippe@chromium.org

Change-Id: Ic54eea7223ab74b9e2c5962f1c5208e6fb301643
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2408652
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-28 11:12:12 +00:00
Mathias Bynens 601f7f247f Migrate ChangesView to TypeScript 
Preparatory CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2426531

Bug: 1011811
Change-Id: I86d72b61805fc15b7f819a708f88d5e484ec3593
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431505
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-09-28 10:49:52 +00:00
Jack Franklin 125dc7c158 Migrate diff/DiffWrapper to TypeScript 
I also tackled the diff_match_patch function...it does not seem worth getting
that into TypeScript, so I've left the nocheck. I did consider updating the code
to export the function rather than have the global, but it's depended on by
CodeMirror and changing it seems risky.

Bug: 1011811
Change-Id: Iffbe69d7dbc424e9d9a6bb1527f218f3e4998326
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431506
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-28 10:05:22 +00:00
Wolfgang Beyer 83ae1017c0 Fix focus ring when tabbing through service worker details 
Make focus ring styles consistent for 'Service Workers' in 'Applicaton
Panel'.

Before: https://i.imgur.com/CzOOlGv.mp4
After: https://i.imgur.com/3XI5OU6.mp4

Bug: chromium:1130980

Change-Id: Ifcbc3851df06416292e9e5a86df7eab9a67e5046
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2422950
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-28 10:02:52 +00:00
Simon Zünd 1fb6b3e1b5 [ts] Type-check devices/DevicesView.js with TypeScript 
R=jacktfranklin@chromium.org

Bug: chromium:1011811
Change-Id: I4d3f1dabf4325040739faa88891b6971d66cdb20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2426530
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-28 09:03:37 +00:00
Patrick Brosset 09cdd5489a Guard against malformed URIs when creating a binding for a resource 
In Automapping._createBinding, we already guard against malformed URIs
when those are snippets or file URIs, but we don't otherwise.

This can sometimes lead to silent exceptions as described in bug 1132305.
This change simply adds the same guard in place to avoid the exception.

Bug: 1132305
Change-Id: I02cb33669f3dc5adabac852e3c87dc475c6d0245
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431808
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
 2020-09-28 09:02:32 +00:00
Jan Scheffler 131d306fc1 [WebAuthn] Disable invalid options 
Bug: chromium:1131055
Change-Id: Idf595ad1068c4b4ed166acfa5e2d01bb516a690a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2424200
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
 2020-09-28 08:41:52 +00:00
Simon Zünd f6444c8257 [ts] Remove unnecessary @ts-nocheck from sources/SourcesNavigator.js 
TBR=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: I2c15e0f244065fd9e1c5854935835239b1266939
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2424205
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-09-28 06:51:22 +00:00
devtools-ci-autoroll-builder 0140c639c0 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I0321d7bc2f4e0fad62e20f129c6d72c916816197
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434574
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-28 06:22:22 +00:00
devtools-ci-autoroll-builder 68998788de Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/eb1941b..c03908f

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ic01b0c32650652109f2867a10a86b4c57acd22c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434570
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-28 03:28:42 +00:00
devtools-ci-autoroll-builder d6aeaf33af Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/dd39f85..eb1941b

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ic5779f76c6af7e1a3c6f99c82191460b0471f5d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431596
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-27 12:28:11 +00:00
devtools-ci-autoroll-builder aaed4d1339 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Iec026ba6d5930cb5a5d3c60ac310ce549898544c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431595
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-27 06:26:01 +00:00
devtools-ci-autoroll-builder c28560a539 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/e919b28..dd39f85

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5b4d110..0081a12

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I28cf6b915212b9bfe8c6ec1663078f52ed1ea169
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431594
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-27 03:33:42 +00:00
devtools-ci-autoroll-builder 7950eb55c0 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/bba4b33..e919b28

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d08de19..5b4d110

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I14caf4ddd28fce9e77799842790a33535306e685
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431593
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-26 12:24:30 +00:00
devtools-ci-autoroll-builder a8e978ac76 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Iabebffb37b0c7200d5657b42ae17536d08138502
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431592
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-26 06:27:30 +00:00
devtools-ci-autoroll-builder 2841e0538b Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/afd9a1a..bba4b33

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c39ab99..d08de19

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I48be30f1432fc6757e20542764b01e6bf05fddbc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431591
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-26 03:20:50 +00:00
Michael Liao 236c96a322 [Accessibility]: Adding alert message to Application Cookies table to read how many cookies are shown after modifying the entries through filters/clear/etc. 
Issue:
- Screen reader users are given no feedback information when clearing or toggling the "Only show cookies with an issue" checkbox

Changes:
- Added alert message for when the cookie table is updated to announce the # of cookies shown.
- This provides a better working experience for screen reader users.

Bug: 1131142
Change-Id: Ia52d45caa3f04aefc09ffb5a387adabbdfd3c201
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2424850
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-09-25 19:01:48 +00:00
vidorteg b6c8813f82 Locking property names in the styles box diagram 
The box diagram in the styles pane should have the labels locked to
avoid translation as they represent a tech term (property name).

Change-Id: Ie789d1ec2227833655ea79066955231dc7fb8692
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428756
Reviewed-by: Christy Chen <chrche@microsoft.com>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
 2020-09-25 18:01:38 +00:00
Jose Leal Chapa 461253b844 Remove experiment for movable tabs 
Bug: 1075732
Change-Id: Idf5f1ffa893bedcd4adc6f4adfb04e5d2ba1df59
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2350088
Commit-Queue: Jose Leal <joselea@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-09-25 16:58:08 +00:00
chait pinnamaneni 201e53297f manifest icon title fix for long strings 
In Application pane, label `as used by browser` is getting
cut off by manifest icon.

Edge
Before: https://i.imgur.com/ScpeS4J.png
After: https://i.imgur.com/eE4xsn7.png

Chrome
Before: https://i.imgur.com/vEgnhUL.png
After: https://i.imgur.com/KQALPXm.png

Bug: 1131659
Change-Id: I3e525aa9e4111b9a8e0188593c858022c5921ba4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2426979
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Michael Liao <michael.liao@microsoft.com>
 2020-09-25 16:42:58 +00:00
Alex Rudenko d3ba0ee3a4 Show contrast ratio and preview for each element in CSS Overview 
Screenshot: https://i.imgur.com/QaAihyk.png

Bug: 1120316
Change-Id: Ia20d7cec004fff23213a3b8931f86d7e413e4dfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428335
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-25 14:52:38 +00:00
Jack Franklin 5e7f66abad Migrate SearchConfig.js to TypeScript 
Bug: 1011811
Change-Id: I2f4197739053361242c958c9e8f7e976825821f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428332
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-25 14:34:38 +00:00
Jan Scheffler bec7b6c745 [WebAuthn] Format keyfile 
This patch limits the maximal line length in the exported
key file to 64 byte to conform to the spec [1].

[1]: https://tools.ietf.org/rfc/rfc4716.txt

Bug: chromium:1131055
Change-Id: I70ea06cf0ced992211ed86edcbc20cdf05f2843e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428883
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-09-25 14:27:38 +00:00
Tim van der Lippe 31c5354707 Typecheck network/NetworkPanel.js with TypeScript 
R=szuend@chromium.org

Bug: 1011811
Change-Id: I88424749fec8af4b1a85220c6cc85068223ada8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2424197
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-09-25 14:04:08 +00:00
Jack Franklin 536a31d8c4 Migrate DOMBreakpointsSidebarPane to TypeScript 
Bug: 1011811
Change-Id: Ibfd0fc79847eb505e128b954a9d03f762fd1eee1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2431424
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-25 13:41:08 +00:00
Philip Pfaffe f56f06bae0 Delete back_end 
Work on the external symbols backend is discontinued, so delete
it from the repo.

Change-Id: Id590f849a98bf8feb1ba31e81912c575ea0aedfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2429774
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-09-25 13:28:48 +00:00
Jack Franklin 830dfc1262 Migrate EventListenerBreakpointsSidebarPane to TS 
Bug: 1011811
Change-Id: I1559628f538d74470aec9ad7f1bc9e7b24f3b8fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2429770
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-25 13:20:48 +00:00
devtools-ci-autoroll-builder ea6151a655 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/c00314d..afd9a1a

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3eb2555..c39ab99

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ib1a5bc1d806fd76e4d58c15a0111e53e0028001a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428759
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-09-25 12:25:58 +00:00