zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 14:14:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,069 Commits 45 Branches 79 Tags
86e4bd2600ce163cbf69910fdee34500a70eb355
Commit Graph
7069 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jan Scheffler 86e4bd2600 [JSDOC2TS]: Migrate input 
Bug: chromium:1158760
Change-Id: I750a19ecfdfc7ca59929cb3d178f06b33d8b084d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630946
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 19:00:19 +00:00
Jan Scheffler 5bba5fdb77 [JSDOC2TS]: Migrate help 
Bug: chromium:1158760
Change-Id: Ie50704b20abd89450ecf5f0f7602826eb0225d3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630945
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 18:15:39 +00:00
vidorteg 1502a9ec07 [Loc] Migrate event_listener pane to Localization V2 
- Migrate event_listener to use Localization V2 APIs.
- Removed event_listener grdps

Tested with en-XL.json
https://imgur.com/a/hm7nJ9k

Bug: 1136655
Change-Id: I401023ddda8c557732cc25943b6062f59f1b6ca8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632158
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-15 17:20:09 +00:00
Andres Olivares 3100aca993 [module.json extensions] inspector_main views 
Bug: 1134103
Change-Id: I469e5c7799f8286a41d7ecd59354ac6a91aaa8d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629730
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:45:10 +00:00
Andres Olivares 89be7404b9 [module.json extensions] Add unit tests for new setting extensions registration infrastructure 
Bug: 1134103, 1153091
Change-Id: I2f2f359e1629bfb026b5bc0b8defbe2bc082a1b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2607725
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:37:10 +00:00
Andres Olivares f125cbd2cc [module.json extensions] input views 
Bug: 1134103
Change-Id: Ia9ea0ccad3064a3c80a9902206a4b977b908df86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629729
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:33:00 +00:00
Andres Olivares 6d70b13800 [module.json extensions] Add unit tests for new action extensions registration infrastructure 
Bug: 1134103, 1153091
Change-Id: I538c167ad87dd5e4eee1b1dc23c360e4ae3178f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2606493
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 13:49:11 +00:00
Simon Zünd 31e1a68523 Disable flaky linear memory inspector e2e test 
Observed the test over the course of the week and it flaked
comparatively often (peak rate was 3 times in 11 runs).

R=bmeurer@chromium.org

Bug: chromium:1166106
Change-Id: I22cf02dc757ca7ef1916fb5694c4091e60637995
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631111
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-01-15 13:42:44 +00:00
devtools-ci-autoroll-builder 4ad0cccbc0 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d64e599..e3bf8c4

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c603339..f79e432

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I381779f4807604fa19ae33c9439c251a5e1c3807
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632911
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-15 13:20:10 +00:00
Sigurd Schneider b15de2ee0a Fix height of icon component 
The new icon component used a display: inline-block span in its
shadow DOM to display the icon as background of said span. The
problem is that inline elements have two heights: a line box
and a content box. The content box is correctly sized, but the
line height is dependent on other factors (some outside of the
actual component) such as font selection and line leight. This
resulted in the icon component getting a /different/ height that
what was specified. See the screenshots at here for an example:
https://imgur.com/a/reKweWU
This alignment problem was mitigated in the code-base by all kinds
of paddings and margin setting (some of which are undone in this CL).

This CL changes the span in the shadow DOM that has the actual
icon as background to a div by setting the display: block style.
This ensures that the height of the icon component is computed
as intended, and in turn, a bunch of "correction" values in a
bunch of places can be removed.

Screenshot: https://imgur.com/a/reKweWU
Bug: chromium:1126031
Change-Id: Ibe26f81817e0ef6e9564553ace070e61d75006c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629550
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-15 13:14:40 +00:00
Simon Zünd 6efb6287b5 Reland "[module.json extensions] Migrate @ViewLocationResolver in elements/" 
This reverts commit 3abe4703fa.

Reason for revert: The original CL was reverted in the course of investigating a CQ Tree closure. As the CL was not the cause we can safely reland.

Original change's description:
> Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/"
>
> This reverts commit 29da6d23a9.
>
> Reason for revert: Reverting due to red tree. Low chance that this CL is the actual cause for the outage but we should confirm we reverting.
>
> Original change's description:
> > [module.json extensions] Migrate @ViewLocationResolver in elements/
> >
> > Bug: 1134103
> > Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Auto-Submit: Andres Olivares <andoli@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: Ibc9cadba9680e65355801359f42960ea4d6b4921
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631107
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,tvanderlippe@chromium.org,andoli@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1134103
Change-Id: I0585f3deab8c7140b5e0668cf8dc79b214b76873
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631110
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-15 13:12:30 +00:00
Jan Scheffler bc5d1e34e2 [JSDOC2TS]: Migrate js_profiler 
Bug: chromium:1158760
Change-Id: I8ee883c88291c43b0b0d2b41cfdf5051fceb9e9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630947
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 12:54:55 +00:00
Tim van der Lippe 05149e9772 Remove ls from legacy-defs 
This adds all missing imports for `ls` to all files. After this change,
all usages of `ls` will now properly be resolved to a LocalizedString
rather than a normal string.

R=jacktfranklin@chromium.org

No-Presubmit: True
Change-Id: Icf6d8c3b8bea1f9e66f4b6b58e4ae4c7f99e6f9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629554
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-15 12:53:50 +00:00
Benedikt Meurer b6901af509 Fix display of floating point values with scientific notations. 
This removes the special casing for the scientific notation, which
wasn't working as designed (likely), and instead uses the general
formatting for number values consistently now.

Also-By: alexrudenko@chromium.org
Before: https://imgur.com/fb46SeU.png
After: https://imgur.com/XHGIFro.png
Fixed: chromium:1167032
Change-Id: I8dee6308122d5c1ac88253dde6a518023da61733
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631108
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-15 12:24:06 +00:00
Jan Scheffler eaa61fcb0f [JSDOC2TS]: Migrate devices 
Bug: chromium:1158760
Change-Id: Iac3f59bf9f17a372579f58a1426195a1f809749f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629556
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 11:40:16 +00:00
Simon Zünd 3abe4703fa Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/" 
This reverts commit 29da6d23a9.

Reason for revert: Reverting due to red tree. Low chance that this CL is the actual cause for the outage but we should confirm we reverting.

Original change's description:
> [module.json extensions] Migrate @ViewLocationResolver in elements/
>
> Bug: 1134103
> Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Auto-Submit: Andres Olivares <andoli@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: Ibc9cadba9680e65355801359f42960ea4d6b4921
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631107
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-15 09:01:18 +00:00
Sigurd Schneider 57654f96e3 Import ls in NetworkConfigView 
Bug: chromium:1136655
Change-Id: I7ea33934c1743fded49c2ff0dbe479c0425ea769
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626300
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 08:07:05 +00:00
Andres Olivares 29da6d23a9 [module.json extensions] Migrate @ViewLocationResolver in elements/ 
Bug: 1134103
Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2021-01-14 22:03:38 +00:00
Andres Olivares 49de8bac91 [module.json extensions] Add unit tests for new view extensions registration infrastructure 
Bug: 1134103, 1153091
Change-Id: I773fb7dedb140df62a9e056169ad794517a809e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2606492
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-14 21:20:17 +00:00
vidorteg 18a45a67b2 [Loc] Migrate screencast panel to Localization V2 
- Migrate screencast to use Localization V2 APIs.
- Removed screencast grdps

Tested with en-XL.json
https://imgur.com/a/0i8xOyL

Bug: 1136655
Change-Id: I71fcaca0426e116a4466cc4f78b11bce8d692a44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2628579
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-01-14 20:27:27 +00:00
Maks Orlovich fd433ed48a Emulation UA-ch editing: make help button tabable 
... And also give it a focus ring in CSS

Bug: 1164345
Change-Id: Id0fbfbaaf0c965f64e9bcde0434c4c7614e4c622
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2627090
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-14 18:35:18 +00:00
Andres Olivares 786a9e746b [module.json extensions] Add support for ViewLocationResolver 
Modules can now register extensions of type 'ViewLocationResolver' in
their meta files.

Bug: 1134103
Change-Id: I07eb5034634128c941d15507f72dcc53016ead5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2606489
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 17:39:57 +00:00
Tim van der Lippe 4245bc26b1 Fix issues with localization presubmits 
In https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2623940/4/front_end/i18n/locales/en-US.json
these messages were erroneously added to the `en-US.json`, yet the
presubmits on that CL didn't prevent the CL from being submitted.

R=janscheffler@chromium.org

Change-Id: Ia7894ac1020117c4ec3ad72c0022de00e710026e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629549
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2021-01-14 17:08:55 +00:00
Jack Franklin 9f1d0d5811 Create a helper for setting CSS props inside custom element 
Just tidies up the code a bit but mainly removes everyone from having to do that
typecast of `shadow.host`.

Bug: chromium:1166108
Change-Id: Iee55c9aa7453b7f8ee3623cc1bbc349e15edc400
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 16:17:56 +00:00
Jack Franklin 65c824b5ad Create Node version of devtools_paths.py 
This is not complete in that it doesn't expose all the same paths, but
I'd rather have people add to them as they go. I've defined the main
paths we'll need - third_party, node and devtools root.

I tested this locally by having it print out the paths and I updated the Python
equivalent to do the same. I ran the commands both locally in my devtools repo
and from the Chromium repository.

Bug: chromium:1166572
Change-Id: Ia0403b9b861d5cf58234bcf16d7ad247184233a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626301
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 15:02:15 +00:00
Jan Scheffler 3e95cfb4ae [Recorder] Keep focus on the inspected website 
Fixed: chromium:1161453
Change-Id: I77981ca8309d676875610089ce86ebdf24c9a9d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2601922
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-01-14 14:34:25 +00:00
Jan Scheffler 4c33ac288f [JSDOC2TS]: Migrate changes 
Bug: chromium:1158760
Change-Id: I696fb9d21431d73620f299516881f77a44c594af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2623940
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
 2021-01-14 14:02:45 +00:00
Tim van der Lippe 1d2c461aa7 Move ordered merge and intersect into array utilities 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I05c155d49aca527de93cf83dac6f674ed3b6c988
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626296
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-14 13:57:55 +00:00
Simon Zünd 6d32fb19b0 [ts] Update TypeScript to 4.2.0-beta 
TypeScript now ships type definitions for `ResizeObserver` so this
CL also removes the resize_observer.d.ts file and references to it
from build rules.

DISABLE_THIRD_PARTY_CHECK="TypeScript update"

R=tvanderlippe@chromium.org

Bug: chromium:1166169
Change-Id: I4dff6ed9aa4937f0183210cc735405cb2b8abaf6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626298
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-14 12:42:25 +00:00
Jack Franklin 3522dcff65 Style component doc breadcrumbs with class 
Styling it with just `ul` meant it applied to any `ul`s on the page (as
it's not in a shadow root) and it broke some examples. Added a class
instead.

Change-Id: I428b0db2aeeae507c9254e49cc3643b809aee5a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626305
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 12:32:20 +00:00
Jack Franklin 5a6329a6fa Fix IssueSurveyLink component example 
This example was importing Issues before the test environment was fully setup which caused it to break.

I suspect other component docs might have similar issues, so I'm going
to go through all the examples and will follow up in other CLs.

Change-Id: Ie245516a5672b6b5444cb72254873caee1d99547
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626304
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 12:31:15 +00:00
devtools-ci-autoroll-builder 81eee879ea Update DevTools DEPS. 
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/64d94de..c603339

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I410f22ebb37ab0fa75643c2f8f4b67792837eccd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629262
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-14 12:26:25 +00:00
Jack Franklin 9e71e6a50f ESLint rule to ban interpolation within <style> tags 
LitHtml strongly discourages this approach and it's one that often can
be avoided using CSS custom properties that are set from JavaScript, so
we're going to try to avoid its usage creeping into our codebase. We can
revisit if we hit upon a case where it's really needed.

Bug: chromium:1166108
Change-Id: Ib8c60d8670707b8f0e239d911ec569c64a3b1846
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626294
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-14 09:34:54 +00:00
Jecelyn 362d399d69 Fix typo in What's New update 
Change-Id: I27143e99c174946ab9ab1e16af70b9522f299119
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2628819
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2021-01-14 09:22:04 +00:00
Jecelyn d9ed698074 Update What's New UI for Chrome 89 
Change-Id: I13d1e04945f4a88851049852a59a26d57313c874
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626718
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2021-01-14 07:57:26 +00:00
Songtao Xia 0a3264351b [DevTools Frontend] Resync debugger id after navigation 
DebuggerModel maintains a static table between debugger id and
DebuggerModel. This table is consulted by CallStackSidebarPane to
display call stack. If the mapping is not updated, call stack information
may not be displayed correctly, especially for async stack. There is a
need to resync the mapping, as a debugger id is mathematically based on
an isolate while a debugger model may work on different isolate.

Previously, we resync the mapping when we cannot find a debugger model
corresponding to an id. This change resync the id to model mapping when
responding to FrameNavigated event.

The work is based on conversation related to this CL:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466642

Change-Id: I605e811b643ae154afb73024ea062f15b7872505
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610136
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-14 07:52:26 +00:00
devtools-ci-autoroll-builder e5adc63d7c Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I89494d142ed482660d8c0932700a38958e6aa6ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2628796
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-14 06:30:53 +00:00
Benedikt Meurer b0279c6800 [e2e] Rebaseline test expectations after Chromium roll. 
Bug: chromium:1165304
Change-Id: I8b807769cfada7aec66bd99e35b45f6a424a49a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626297
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-01-14 06:07:23 +00:00
Annabel Zhou fb0f3c75c8 Add AccessibilityNode web component and display non-interactive tree 
This change is hidden behind experiment flag "fullAccessibilityTree".

Design doc: https://goo.gle/devtools-a11y-tree
Follow-up CLs: expanding/collapsing of child containers, adding click
handlers for adding new children into the model if they haven't been
requested, tying it to the DOM inspector.
Screenshots linked in bug.

Bug: 887173
Change-Id: I62a35bb913fff46856fa87c7030be16631d2dbc7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2613072
Commit-Queue: Annabel Zhou <annabelzhou@google.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
 2021-01-14 05:11:13 +00:00
devtools-ci-autoroll-builder 1169b2e38c Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d68ac97..d64e599

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fdd8946..64d94de

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I6d85b5656cd743229630289e20de5d03e26a3c7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2628727
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-14 03:27:42 +00:00
Connor Clark 5135af05fe Fix Lighthouse locale fetching. 
Bug: 1131516

Change-Id: I0e4ec95618ba33fff59f03970ff1df297f98d2ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2426783
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-14 02:19:42 +00:00
Maks Orlovich c593077f72 Device emulation: re-apply changes after edit 
When the UA list changes, re-apply the current device, in case it's
what got edited --- previously the changes would not apply unless one
switch away from the device and back to it again.

This also adds an integration test for the editing functionality,
including that it applies without any fiddling of switching devices
back and forth.

Bug: 1158834
Change-Id: I6bd83b26a00e2fc742fbef6b30c26e06c8ff9c20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2625167
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-13 16:11:22 +00:00
Jack Franklin 056c40022b Migrate String#compareTo to utilities 
Renamed it to `compare` as `compareTo` doesn't make sense when it's not on the
prototype.

Bug: chromium:1050549
Change-Id: I5175db423fecf0ec74ad148b44d962f629d146de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2627267
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 14:29:02 +00:00
Jack Franklin 8f7d25004e Use custom CSS property rather than string interpolation 
Within LitHtml components we should try to avoid interpolation inside
`style` tags and instead use custom properties that we can set with
JavaScript.

This CL moves one example of this over as a proof of concept, and I will
follow it up with a CL that enforces this pattern by linting against
interpolation, and updating the component docs we have accordingly.

Bug: chromium:1166108
Change-Id: I304df148194b750e1377785a78855a070587a38e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626293
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-13 14:19:32 +00:00
Tim van der Lippe 779b46bac3 Inline and remove peekLast() 
In the future we can use `.at()`, but that has not been shipped yet.

R=szuend@chromium.org

Bug: 1050549
Change-Id: I89e760db277ffb91bfbba93106e6e11d3ece91d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624711
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 14:09:52 +00:00
Tim van der Lippe bcd6b5c3ff Inline and remove isEnterKey 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I7242fa3b0c2a69d2e4b4dd7c642ba09a5f4dc9bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624713
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 13:02:42 +00:00
Tim van der Lippe 6d5bdf4f7e [module.json extensions] developer_resources 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I433c9a8d02541ace0fbf7662f6689faaa7f0607a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612856
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 12:40:02 +00:00
devtools-ci-autoroll-builder 09c9268401 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/787a10d..d68ac97

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8149a96..fdd8946

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I03c9649281de3fa754c729483c9bbf8a4a26bcce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2625866
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-01-13 12:28:42 +00:00
devtools-ci-autoroll-builder 95ab239e91 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ia21e4b03926cb7522a723f03d819ccf02277b79f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2625861
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-13 11:41:42 +00:00
Jack Franklin 0771fdcbac Fix report view component doc 
Because the import was only used for types, it got dropped. We need the
side-effect and the `type` import to ensure the component code gets
pulled in.

Change-Id: I1dd8bf686c41f19412e997a7419f1ba799717000
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2626289
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-13 11:10:42 +00:00