zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-11-01 02:43:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
9,624 Commits 44 Branches 79 Tags
907dfdffa300ba5580da7eef717930396d763b4e
Commit Graph
9624 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Changhao Han 907dfdffa3 Update protocol resources 
This CL updates protocol resources from these CLs:
https://crrev.com/c/2988302
https://crrev.com/c/2951908
https://crrev.com/c/2987822
https://crrev.com/c/2935645
https://crrev.com/c/2840423
https://crrev.com/c/2964539

Bug: chromium:1146422
Change-Id: I993f2e4469988d6c9854a8f26d0ba5e65580c0e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2992876
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2021-06-29 12:23:52 +00:00
Alex Rudenko 3812c7134c [Recorder] Explicitly record beforeUnload events to record navigation 
Current solution relied on a timeout which what somewhat flaky in
some cases.

Fixed: chromium:1224371
Change-Id: I3854b0bb7d6ae05853c01bec4f7c961f1e24d4d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988309
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-06-29 12:01:16 +00:00
Kriti Sapra 80d221466c [CSS Migration]: Migrated Console contextSelector and removed resources from module.json in front_end/panels/console 
Bug: 1106746
Change-Id: I109f151b18c68c647e7be042d58076c959340949
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987785
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-06-29 11:56:02 +00:00
Jack Franklin 84442c6766 [DarkMode] remove enableLegacyPatching option 
The option was only allowed to be set to `false`, so it's not been
used at all, so now we can remove it, given that we've had the dark
mode legacy patching disabled without any major bugs in the past few
weeks.

Bug: chromium:1152736
Change-Id: I1e794d75f9c354a0d16b1b3975f7ebdf82b3448b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-06-29 10:07:32 +00:00
Kriti Sapra ef6988a729 [CSS Migration]: Added ESLint rule to ensure wasShown methods contain call to super.wasShown() 
Bug: 1106746
Change-Id: I7c1289f29e8b8c40e25ba37098d8c7d69e781d50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988310
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-06-29 09:22:02 +00:00
Jack Franklin 74b5c22a24 [Dark Mode] Improve contrast of soft context menu highlight 
The default --color-primary is a bit light to use for this - will ping
the UX folks to ask what they'd like long term, but for now I've
changed it back to the color it was before softContextMenu.css was
migrated as part of the dark mode work.

Fixed: 1222956
Change-Id: Ie25f5c2889ef7dd8944d59b304d11b98adfaed24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988305
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-06-29 09:03:26 +00:00
Sigurd Schneider 302dd71f4b Document issue kinds 
Bug: chromium:1072335
Change-Id: I3b8c22406b976db1fd2c4e19b03bea10ea5de02e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2992875
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-29 08:04:56 +00:00
devtools-ci-autoroll-builder 6eb2976c0c Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I93b7ea764b6fec8d6b72986a83d74bf3940fe9a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2993985
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-29 06:38:06 +00:00
devtools-ci-autoroll-builder e0033716ed Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/a1ffc8d..73a9443

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2a6dffa..a806594

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I6219c457ce58109df28dcda128063f8a72fd7e5d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2993979
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-29 03:43:16 +00:00
Brandon Walderman 153b8d71e8 Set user-agent and cookie headers for 'copy as powershell' command 
Updating the _generatePowerShellCommand function in NetworkLogView.ts to
generate a command that can successfully set the user-agent and cookie
headers.

According to the docs for the Invoke-WebRequest PowerShell command, the
-Headers parameter cannot be used to set these headers.

The fix is to create a WebRequestSession session object, populate it
with the user agent and cookie values, and then pass this object to
Invoke-WebRequest using the -WebSession parameter.

I've verified that the new command output works as expected and that a
test server will see the correct request headers.

Bug: 932971
Change-Id: Id5441137a311b223fcfab48bbd2075598a2879e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2910443
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jose Leal <joselea@microsoft.com>
 2021-06-28 19:20:36 +00:00
chait pinnamaneni 318bdfe633 Fixes outlines in network overview and color-code setting in network panel 
In network overview page, a deprecated CSS variable "--neutral-layer-l4" was being used to draw outlines. Because the CSS variable was missing, it was drawing black lines. Updated the CSS variable color to "--color-background-opacity-80" from theme colors.

Also color-code setting is assigning a fill color instead of CSS color variable which _drawLayers was previously using to set the fill color. Updated the function so that when the setting is toggled on, instead directly use the hex colors instead of using CSS color variable to look up color.

https://imgur.com/a/wKZDDlz


Bug:1216849,1213595
Change-Id: Ie61ee3198873583415ad992cd5b80ce16479f82b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2991189
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
 2021-06-28 17:52:25 +00:00
Kriti Sapra c5e02d3b66 [CSS Migration] Migrated ConsoleSidebar to use new CSS infrastructure 
Bug: 1106746
Change-Id: Ia3a8b5ded8c58fc73e9dfde6a231593636ee4e8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987783
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-06-28 14:37:51 +00:00
Sigurd Schneider e0ab5f1fcc [cleanup] Improve types in ConsoleModel 
Follow-up to https://crrev.com/c/2987959 that changes semantics
slightly: In a couple of places we don't convert the empty string
to undefined anymore, and we use undefined instead of null in a couple
of other places after this CL. Our educated guess is that it doesn't
matter.

Bug: chromium:1213393
Change-Id: Ie98059d328cc20d2ecde771ce29de929cf2c0fe2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987962
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-06-28 13:33:41 +00:00
devtools-ci-autoroll-builder 9e9a146b12 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/aeb5c9d..a1ffc8d

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: If35043d8e06ef310516a95595ec9910cd58d68aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2992733
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-28 12:59:02 +00:00
Kriti Sapra 5c3434c51b [CSS Migration] Added ESLint rule that bans <style> tags being used in LitHtml templates 
Bug: 1106746
Change-Id: I0701fdb0c38c2fdb43df60bb80f54075ad58f592
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988306
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-06-28 11:35:20 +00:00
Sigurd Schneider 40eaa83b4c Link to requests from exceptions in console 
Bug: chromium:1213393
Change-Id: I4b4386ac2963a46aed930ab994771c995b445bb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987975
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-28 10:32:20 +00:00
Jan Scheffler 89ecda69bd Fix overflow issue by applying correct min width 
Fixed: 1223714
Change-Id: I82ea1d6519b30278d6e3fe8059aa8ab7edf378cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988304
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-06-28 10:00:22 +00:00
Jan Scheffler d5c0324dee Fix network waterfall height 
This patch fixes a missalignment between the network panels rows and
the waterfall on its right by making sure its probably redrawn when
the calculated height of the header changes.

Fixed:1200288
Change-Id: I0d4db7ee783578dc33b3632e204564f93e102e90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987789
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-06-28 08:33:21 +00:00
Sigurd Schneider 5b85fc51fe Use await pattern in TWA issue e2etests 
Bug: chromium:1223300
Change-Id: I90a099ced835619fc94054eb03f6c0a26da35790
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987967
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-28 08:09:10 +00:00
Alex Rudenko fde72bcc0e Visualize visual viewport if provided 
Backend CL: https://crrev.com/c/2988300

Bug: chromium:1064297
Change-Id: Ibb407f51d2c48ac47a1bfa36380fb6e65da4eea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987786
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-06-28 07:47:50 +00:00
Sigurd Schneider 20ec8a5f2d Use await pattern in sab issue e2etest 
Bug: chromium:1223300
Change-Id: I6c7793aa3d9891e5dc1dcb08010cc1b78ca7006f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987966
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-28 07:45:50 +00:00
devtools-ci-autoroll-builder 71cc7b6cf5 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I60b052565ec5fbf0fd56f6339dd51706a0c4e809
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2991432
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-28 07:42:31 +00:00
Sigurd Schneider 6e7618301a Use await pattern in quirks mode e2etests 
Bug: chromium:1223300
Change-Id: I08e7bae7250c0d9d6bea4babd00c7167a8997cc0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987965
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-28 07:10:30 +00:00
Sigurd Schneider 3135ebe53e Store affected resources on ConsoleMessage 
This CL extracts the affected resources associated with a console
message from the exception meta-data and makes the information
available on the ConsoleMessage.

At a later point in time we may unify this with the logic of
Logs.NetworkLog.NetworkLog.requestForConsoleMessage

Bug: chromium:1213393
Change-Id: I502522fa4bb160950b642b7aa8d193b3d460c70d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987963
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-28 07:01:00 +00:00
Alex Rudenko ceb3f99bbe Improve i18n types 
Bug: none
Change-Id: Iaf866fda1c563d1aa76ebf3a90ead6e0a897b1e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982145
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-06-28 06:48:00 +00:00
Sigurd Schneider 77d9eb1c72 Await resouce section in navigator-user-agent-issues e2etest 
Bug: chromium:1223300
Change-Id: Ia6c738d0fa318b36aeeaed5302f7fca825de5746
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987964
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-28 06:41:30 +00:00
devtools-ci-autoroll-builder 48362bae65 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/f8a6922..aeb5c9d

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a73eec2..2a6dffa

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ic8cb306750fb283a5821bd80dae65152ac3b84a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2991430
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-28 03:48:30 +00:00
Songtao Xia 2c466f3376 Add accessibility alert when adding a row in datagrid in devtools 
Previously, when user adds a new row to a datagrid, for example, adding
a row to Local Storage in Applications panel, the voice over announces
the content of the row, namely, column names followed by column values
while column values are empty. There is no indication that a new row is
added and there is no indication what can be done next.

We add an aria alert to let the user know that an empty row is added and
that they may edit values of the cells on this row.

Bug: 1223875
Change-Id: I3a0c6d53d60aaa34cc910d3b48bada106ed8b156
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987742
Reviewed-by: Jesus David Garcia Gomez <jegarc@microsoft.com>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Songtao Xia <soxia@microsoft.com>
 2021-06-27 07:04:28 +00:00
devtools-ci-autoroll-builder c18f600980 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/78cd6d9..f8a6922

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I283be0a0a1defec8e375311f453b3c2f522a359d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2991506
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-27 03:54:09 +00:00
devtools-ci-autoroll-builder dc8a5e19ad Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/d3674b9..78cd6d9

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I7adbe2038e6bc7847333bf536d3520b96a18dbfa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2991609
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-26 12:36:46 +00:00
devtools-ci-autoroll-builder 333758263a Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I6349be387a25ec240311b212f03f1d9a222f4658
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2991429
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-26 06:42:46 +00:00
devtools-ci-autoroll-builder 4b20cbb120 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/6edbf0a..d3674b9

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/46bcd59..82a4d60

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6f0df68..a73eec2

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I32766d34f4337bd32d548d9db93c5a5358531850
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2990167
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-26 03:45:26 +00:00
Jan Scheffler 1270e76c13 [Underscore Migration] Migrate common/Progress 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I64fdc84cbd85017b8379576a5e87df2f1cdcf80a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2969428
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-25 20:36:08 +00:00
Olivia Flynn 7a4af72f77 [Accessibility] Announce selection when accepting suggestions 
This CL replaces the anouncement made when accepting a suggestion from a
suggestion box. Instead of announcing the title of the suggestion and
the position in the suggestion list, the screen reader will now announce
the title of the suggestion and that the suggestion has been selected.

Bug: 1223227
Change-Id: Ie9a6e515db76437cb7655cb95ddb3d9c8ca460e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2984362
Commit-Queue: Olivia Flynn <flynnolivia@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-06-25 19:13:38 +00:00
Kriti Sapra 736df80db6 Renamed all .css.js to be lowercase and added parent's wasShown call in widgets 
Bug: 1106746
Change-Id: I8a90e44ad5feb59c91dc196ef2c9ad285e21b1a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987782
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-06-25 14:45:58 +00:00
devtools-ci-autoroll-builder 0befa31517 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/db1bde8..6edbf0a

Rolling buildtools/linux64: git_revision:d924640c25f9d90386716116a53957f24d709042..git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ia0005fa9594357093114d4f60f63b02e4668335b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987618
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-25 14:23:50 +00:00
Rahat Muneeb e03b1ce27d Refactored AffectedSourcesView from IssueView.ts to AffectedSourcesView.ts file, changed underscored methods and variables to private methods and variables 
Bug: 1072335
Change-Id: Ieb39b3da50836de1b0433d13889fc43fc03fd015
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2953263
Commit-Queue: Rahat Muneeb <irahatmuneeb@gmail.com>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-25 13:20:08 +00:00
Sigurd Schneider 9028e9a9ca Await resource section in low text contrast tests 
Bug: chromium:1223300
Change-Id: Ia12aa07e859f91ac5d73ef99ca185de1a31f6b91
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983023
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-25 11:58:16 +00:00
Jack Franklin 6c391a0969 [DarkMode] remove cmdevtools.darkmode.css 
This CL re-writes `cmdevtools.css` to migrate all the colors over to
CSS variables, and defines those colors in dark mode also. To generate
this CSS I wrote a very hacky script that parsed the original CSS,
found all the colors, and then generated the variable names and
values. It used the original legacy color patching code to generate
the dark mode values.

Given `cmdevtools.css` now contains all dark mode overrides, this CL
removes the darkmode stylesheet for `cmdevtools.css`. Given that it's
the only dark mode CSS sheet, this CL also removes all the
infrastructure for generating and checking these sheets are up to
date.

The motivation for doing this work is that maintaining the darkmode
CSS stylesheets means we have to keep the legacy patching around in
order to (re)generate the stylesheets. Doing this one off script to
move all the overrides into the original file means we don't need to
keep the legacy patching around.



Bug: chromium:1152736
Change-Id: I0cf07d54370716299819478356b42728e0e3aadb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982137
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-06-25 10:53:26 +00:00
Sigurd Schneider 6cf1fdb535 Use options bag for ConsoleMessage constructor 
Depends on test update CLs:
Disable tests in https://crrev.com/c/2988019
Update and reenable tests: https://crrev.com/c/2988020

Bug: chromium:1213393
Change-Id: I12478e4906e31226e2fc31696f8f03c01dd02a9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987959
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-25 10:11:17 +00:00
Sigurd Schneider c6edb07a29 Fix waiting logic in e2e test 
The test application/frame-tree_test.ts:
  The Application Tab shows stack traces for OOPIF
did not properly wait for the stacktrace to get populated.

Bug: chromium:1202024
Change-Id: I6b38c0de3616e082269f2858a78b72d1d3d1210b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987960
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-25 08:05:16 +00:00
devtools-ci-autoroll-builder deabdfb6bd Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I4cf8c521a8ec01574914296e7edd58728da7caaf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987605
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-25 07:17:36 +00:00
Sigurd Schneider 423b2bec97 Reland: Add component for linking to network requests 
This CL adds a component that can be used to link to a network request.
The component optionally uses a RequestResolver to resolve the request
if only a requestId (in the form of an affected request) is provided.
The component updates its state once the request becomes available,
thereby supporting plasticity of the UI.

This is a plain reland of https://crrev.com/c/2960617. Landing
the CL originally uncovered a deficiency in the way our tests
were written, see crbug.com/1223300.

Bug: chromium:1217975
Change-Id: Ideccf4f9e64cf451a8c28583a9d72e717ff6706f
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_mac_rel
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983021
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-25 07:11:56 +00:00
Benedikt Meurer 617610bc4d Revert "Don't treat accessor properties on prototypes like own properties." 
This reverts commit 112e9b8b86.

Reason for revert: crbug.com/1222114

Original change's description:
> Don't treat accessor properties on prototypes like own properties.
>
> Previously DevTools front-end made it look like accessor properties on
> prototypes were own properties (as long as they had a `getter`), which
> is highly confusing to developers when analyzing their prototype chains
> (despite being convenient in a few cases).
>
> Before: https://imgur.com/Q2d66S2.png
> After: https://imgur.com/JQJXTiK.png
> Change-Id: I74a347747b36ce53a892dbfb8d399391ebfdea06
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2947243
> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>

Bug: chromium:1222114, chromium:1076820
Change-Id: I17763eeea65fca05d9d29360e7b005dd7c26e5de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2979697
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2021-06-25 05:05:16 +00:00
Tim van der Lippe 25f1108994 Reland "Cleanup path handling in collect-strings" 
This reverts commit 29fe69257e.

Reason for revert:
1. Fix Windows compatibility by fixing the various
path separators to use UNIX when they need to be UNIX.
2. Ensure that whenever we change this script, we run the corresponding
PRESUBMIT. Otherwise, you can submit a CL that passes presubmit, but
starts failing on a later CL.
3. Lastly, let's output the full `git diff` so that it makes it easier
to investigate these kind of problems. Example git diff I used:
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8843531480879659408/+/u/presubmit_py3/stdout

DISABLE_THIRD_PARTY_CHECK=Fixes in presubmit and presubmit script

Original change's description:
> Revert "Cleanup path handling in collect-strings"
>
> This reverts commit 7b72fbf5d6.
>
> Reason for revert: speculative revert based on https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_win64/b8843551589142089360/overview
>
> Original change's description:
> > Cleanup path handling in collect-strings
> >
> > While reading through this script I spotted a lot of duplication
> > of `front_end` in its path handling. Since we assume that all
> > strings are collected from `front_end/`, we can pass in that
> > path and use that, cleaning up most of the path concatenation
> > in the script.
> >
> > DISABLE_THIRD_PARTY_CHECK=Path handling fixes in collect-strings
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: I0e7d004ad4d1d16f92cd88f3fed94dfe4c4108b0
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982134
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: none
> Change-Id: I6e1ac7046950f78aa7339efb21559ff60f3d50f7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982147
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: none
Change-Id: Ia42890a67e53abdc9bacfb9e98cf06a975148bde
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983032
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-06-25 04:52:17 +00:00
devtools-ci-autoroll-builder d9a3f30005 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/2b4952d..db1bde8

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf60c0a..6f0df68

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Iaefd0c241f24bcfe0023b3e669bbe276d04cebcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987380
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2021-06-25 03:50:06 +00:00
Michael Liao 0147f11152 [Accessibility]: Adding screen reader alert for # of entires for DOM Storage view 
Issue:
- Nothing is announced to screen readers when filtering entries in the DOM Storage View

Changes:
- Adding alert call whenever entries are refreshed in the DOM Table


Example SR alert:  "Number of entries shown in table: 12"
GIF: https://imgur.com/7tFRdnZ

Bug: 963183
Change-Id: I54e71e4b9cfc166d77d40928dccf91ee254034b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983651
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2021-06-24 16:45:19 +00:00
Michael Liao 70b5b02df5 [Accessibility]: Marking styles container as list and styles sections as listitems 
Issue:
- Styles container is marked as a tree containing treeitems
    - The structure is better represented as a list with the styles sections being list items
- VoiceOver is giving instructions on how to navigate the styles container under the assumption it is a valid tree
    - instructions relate to using control + option + arrow keys to navigate the tree

Changes:
- Marking the container as a list and the styles sections as listitems

Picture of Styles Container: https://imgur.com/a/IPE8c4O

Bug: 963183
Change-Id: I38556055ef567555aad4de89546cf26ce5f163bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2981126
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-06-24 16:37:47 +00:00
Kriti Sapra 1c4dcd75b3 Fix for toolbox.html 
Removed change to move global stylesheets to be adopted

Bug: 1106746
Change-Id: I55ff833b525f2522253b01304de28e0f5fe4ab60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982150
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Kriti Sapra <kritisapra@google.com>
 2021-06-24 15:25:17 +00:00
Dan Clark 905f814dba Show source for constructed stylesheets with sourceUrl.length > 0 
A CSSStyleSheet imported as a CSS module script has the constructed
flag set
(https://wicg.github.io/construct-stylesheets/#cssstylesheet-constructed-flag).
This is because it is useful to treat imported CSSStyleSheets the same
way as stylesheets created via `new`. For example we want to be able
to add both to document.adoptedStyleSheets, and we want both to treat
@import rules the same way.

Up to this point DevTools didn't show sources for constructed
stylesheets because they were all assumed to be sheets created
with `new`. But, we do want to show sources for constructed sheets
created for CSS module script imports.

So, this change checks for an empty sourceURL when deciding whether
or not to show source for a constructed stylesheet.

This requires the Blink change [1], which starts passing an empty
sourceURL for `new`ed stylesheets.

[1] Blink change: https://chromium-review.googlesource.com/c/chromium/src/+/2964539

Bug: 1125357
Change-Id: I7163966c66c990647e40a72d0ef9d6ba30f41cfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2964580
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
 2021-06-24 15:18:37 +00:00