Commit Graph
9 Commits
Author SHA1 Message Date
Jack Franklin 84442c6766 [DarkMode] remove enableLegacyPatching option
The option was only allowed to be set to `false`, so it's not been
used at all, so now we can remove it, given that we've had the dark
mode legacy patching disabled without any major bugs in the past few
weeks.

Bug: chromium:1152736
Change-Id: I1e794d75f9c354a0d16b1b3975f7ebdf82b3448b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-06-29 10:07:32 +00:00
chait pinnamaneni 750a2d1627 Adds fields for client hints form in Device settings and added the same form in network conditions panel
Improves UX for adding client hints in device settings screen. Instead of adding semi-colon separated value for brands, users will be able to input in different fields. Also added the same form to network conditions panel, so users can easily change client hints from network conditions. In network conditions, user agent client hints gets automatically updated when user changes device from dropdown.

Device settings:
Before: https://i.imgur.com/sn3E1dV.png
After: https://i.imgur.com/rBMNjQt.png

Network conditions panel:
https://i.imgur.com/Sk9k3Bb.png

Bug:1215598
Change-Id: Ie9f75456c67e30bb133675bef756a828fa117719
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933920
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Brandon Walderman <brwalder@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
2021-06-16 18:26:58 +00:00
Sigurd Schneider 79e812efee Move Target to its own file
Bug: chromium:1213943
Change-Id: I309436e8608c3f89ac42a117a3f454b5e43eef16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933138
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-06-04 07:24:06 +00:00
Sigurd Schneider b9f6c7910e Move TargetManager to its own file
Change-Id: I4708a6303198bc5c4ff6aa8e2b2a2f5e4530725f
Bug: chromium:1213943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919763
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-05-31 11:24:26 +00:00
Tim van der Lippe e3b4125e02 Import protocol types in remaining files
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: I752ecd48a3f0ccac1e15e3bc8e5d6774c9a94891
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897518
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-17 13:09:52 +00:00
Tim van der Lippe 03ca595765 Import protocol proxy api directly
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: I1c7f6e6320fb28f7ac8beffede5bf507562886d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2891759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-13 10:24:58 +00:00
Tim van der Lippe 6892da0014 Add GN visibility to entrypoints
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I5ff52856d177529c26655e79f1fa5db96fa06196
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2856775
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-29 08:54:21 +00:00
Tim van der Lippe 3fff977fdd Add GN visibility to all meta targets
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I7be4bd13a731065a9291cc4b37b830130b0873e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854676
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-28 09:10:13 +00:00
Tim van der Lippe cc6e7523bd Move node_main to entrypoints/node_main
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I26a1db130ebb61b2c5b98a72f28116d4ed17cc88
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843314
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-21 13:52:35 +00:00