Commit Graph
25 Commits
Author SHA1 Message Date
Tim van der Lippe 727227900c Dynamically optimize svgs
Currently, we optimize our SVGs out-of-sync and have a Python
script and PRESUBMIT check to make sure that the SVGs are correctly
optimized. This means that the SVGs are duplicated in the Images
folder and requires developers to install `svgo` on their command
line, which could be using differing versions.

Instead, we can optimize the SVG images (which is computationally
cheap) during build time using the rollup-plugin-import-meta-assets
and svgo packages. The rollup plugin traverses the required SVG
image files and puts them and rewrites them to the Images/ folder
(rather than in src/), while also allowing us to optimize them
along the way.

DISABLE_THIRD_PARTY_CHECK=Removing script from package.json
R=jacktfranklin@chromium.org

Bug: 1216402
Change-Id: Ieb6932b9a81753be5ecbccd00a5d84bd0efa23f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2939994
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-06-10 10:09:30 +00:00
Tim van der Lippe 6892da0014 Add GN visibility to entrypoints
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I5ff52856d177529c26655e79f1fa5db96fa06196
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2856775
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-29 08:54:21 +00:00
Tim van der Lippe 2211a5f79e Remove unused legacy files
All of the symbols declared in these legacy files are no longer used
by the legacy layout tests.

R=alexrudenko@chromium.org

Bug: 1174013
Change-Id: I8e040047e0f6044d1fd3e4e3eacf9b5b0ce0391c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2848223
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2021-04-23 13:23:18 +00:00
Tim van der Lippe e083e41023 Move cm/codemirror.css to third_party/codemirror
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I29f75e79fe47b5c4c21cee7fd1ae04b444d36954
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843312
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-21 13:46:45 +00:00
Tim van der Lippe 339ad2698a Move components to ui/legacy/components/utils
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ib55515e9a436e21c4b1e7a014a95220b46021136
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843311
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-21 13:42:05 +00:00
Tim van der Lippe 4c592ddd16 Move workspace_diff to models/workspace_diff
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I38bb15a1df8652f86e10737528c3f7b48457ff0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-20 14:37:25 +00:00
Tim van der Lippe 48f46804a1 Move main to entrypoints/main
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I4c22f094bcf91f13a71c04fb8ea0b4b5b0489d98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831980
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-20 09:16:53 +00:00
Tim van der Lippe 945c4b77aa Move settings to panels/settings
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I8398fe6f219d26ba799cc6d5154f8807f2e521b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831972
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 12:59:09 +00:00
Tim van der Lippe eb75111549 Move snippets to panels/snippets
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I5c9c27398f331fb853eabfe6c278ddc4cc306034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831971
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 12:49:39 +00:00
Tim van der Lippe 021c75731a Move sources to panels/sources
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I9a783dc6a0f359d75cb3b3354cc2c804ea629969
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831450
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 11:35:31 +00:00
Sigurd Schneider 7670c3304e Move LogManager to models/logs
This removes the browser_sdk/ library. In a follow-up, I want to move
NetworkLog to models/logs as well, but this is currently blocked on
tests in chromium.

Bug: chromium:1199668
Change-Id: Ibc263b6536f84c82499b68837177b112def2f359
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831446
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-04-16 14:47:35 +00:00
Tim van der Lippe ded8282ae3 Move quick_open to ui/legacy/components/quick_open
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ia923d20bdfbe8452ae0d292cff51ddb2ab895587
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828292
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-16 13:53:15 +00:00
Tim van der Lippe dbb97be22a Move startup to entrypoints/startup
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: If71a7d4eeda376e240fe7b1e12f94c853b3cba53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828129
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-15 16:45:15 +00:00
Tim van der Lippe 22cf52b9f5 Move search to panels/search
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I158380494ded60f533c554a948dcfb11acff1bfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828127
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-15 16:17:45 +00:00
Tim van der Lippe 5d37362b4d Move inline_editor to ui/legacy/components/inline_editor
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ie930d26fe059b9535b0c32cc44b3d2d86aaf0085
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828121
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-15 16:14:24 +00:00
Sigurd Schneider f6e47df27c Move issue descriptions to models/issues_manager/
This resolves a dependency conflict that previously was solved by
code duplication.

This also removes the module.json from browser_sdk, as it is not
needed anymore.

Bug: chromium:1192078
Change-Id: Ie77c1dd05bf58605ea2a8d43131bf2cb84604534
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828113
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-04-15 15:01:03 +00:00
Tim van der Lippe 9a1c973dd7 Move text_editor to ui/legacy/components/text_editor
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I1cdad3b03212be4870a9b6889b1e03b364414eb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2825799
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-14 15:01:22 +00:00
Tim van der Lippe 42dae5a072 Move linear_memory_inspector to ui/components/linear_memory_inspector
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: I2f357be388db1a47ec30392713f4dbd69cc9687e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2821818
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-14 09:58:11 +00:00
Tim van der Lippe 51ae9e1b3f Move color_picker to ui/legacy/components/color_picker
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ib593c9e50a2018dfa21f2dcaabd311471c5100b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2823694
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-13 15:55:18 +00:00
Tim van der Lippe 91799ee070 Move source_frame to ui/legacy/components/source_frame
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I10d60af7bf9c79dc23a5e927ad83c0bb6a031fe8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2823693
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-04-13 15:24:48 +00:00
Tim van der Lippe 3167ffee9b Move perf_ui to ui/legacy/components/perf_ui
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ibe15d5bdaef890c99251051840024c86fb7e60d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2821874
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-12 17:57:44 +00:00
Tim van der Lippe 0dd7a057c4 Move object_ui to ui/legacy/components/object_ui
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I1a3a81983c6eb995a21b328120e16350d36ce97c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2821873
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-12 17:24:53 +00:00
Tim van der Lippe 8499fe2ad0 Move data_grid to ui/legacy/components/data_grid
It also updates the ES Modules ESLint rule to allow for the import
from DataGrid to the legacy UI folder, as they are now nested.

R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I8a6a577b10464216efafed10e62f24ca0c06e194
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2821870
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-12 17:21:23 +00:00
Tim van der Lippe b276117f81 Bundle meta files into separate entrypoint bundles
By bundling all meta files (which happens automatically, as Rollup
only treats filenames that are equivalent to the direct folder
they are in, which `-meta.ts` files by definition do not), we
reduce the amount of network requests performed at startup.

Before this CL:

Mean boot time: 1115.99ms
50th percentile boot time: 1115.28ms
90th percentile boot time: 1122.66ms
99th percentile boot time: 1159.44ms

After this CL:

Mean boot time: 1105.17ms
50th percentile boot time: 1072.34ms
90th percentile boot time: 1111.8ms
99th percentile boot time: 1442.42ms

Note that this is a marginal difference, but run on good hardware.
The theory is that this change will be more benificial for users
running slower hardware.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I24aa02d9f162d1ac07ceae5df2beaa0a61a7dd43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2790878
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-12 14:52:53 +00:00
Tim van der Lippe 7b347ca16f Move entrypoints to sub-folder
All JavaScript files for each entrypoint are put in their respective
sub-folder of front-end. The HTML files load from the new location and
build_release_applications has been updated to load from the correct
location.

R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I4b93f3a2127ef2d3ce7dccefe03f70e79dac1c19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2818379
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-12 12:04:18 +00:00