zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-18 12:34:44 +08:00
Code Issues Packages Projects Releases Wiki Activity
19,643 Commits 45 Branches 79 Tags
ab05f953ced8a3c4adaeb7287c776618b67f032e
Commit Graph
19643 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
devtools-ci-autoroll-builder ab05f953ce Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8755393400628921185

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: Ic86dbe2d28a43e81a21d90d7517c7dfe2f9b1157
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5317490
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-02-22 12:42:50 +00:00
devtools-ci-autoroll-builder 687677a34e Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/9ed84eb..6526460

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9c56236..03821ae

Roll created at https://cr-buildbucket.appspot.com/build/8755393400628921185

Bug: none
Change-Id: Iae5dd0a9f1ce7a7cbfd04184b00361d769cae6f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5317529
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-02-22 12:32:59 +00:00
Andrés Olivares 091f2cc50f Fix and reenable UserInteractionsHandler unit tests 
These were always failing silently because they were never run as they
were nested tests (`it` inside `it`) and this doesn't work. When
crrev.com/c/5309877 landed it forbidded nested occurrances in the
codebase and revealed these tests were actually failing.

This CL fixes the tests and enables them again

Fixed: 326206427
Change-Id: I9996a93da6912fa63235cd5ad125c94522a4bd2b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314349
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2024-02-22 10:39:08 +00:00
Benedikt Meurer 34b720296b Add some DIR_METADATA files to make bug routing easier. 
In Chromium the DIR_METADATA files are used consistently to make it easy
to route bugs to the right components immediately. We should make use of
this for the obvious cases.

Bug: none
Change-Id: I225a1522dcd93eea1329e3b0c0092a77d485d04d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314348
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-22 09:46:35 +00:00
Benedikt Meurer f916ce2ace [eslint] Disable custom component checks for unit tests. 
The ESLint checks rulesdir/custom_element_definitions_location and
rulesdir/check_component_naming aren't relevant to custom components
defined for testing purposes only, and just lead to unnecessary noise.

Bug: b:319814509
Change-Id: I00d1e7e20fa561620e04536b5a96fa13247fd434
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314347
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-02-22 09:23:56 +00:00
Paul Irish 7cedcab1db RPP: Restore broken JS Profiler warmup when tracing 
Immediately after Tracing.start is invoked, we do a small JS evaluation.
This should place any 'Profiling Overhead' event at the start of the
trace and of any critical path.

Some tab target refactors (crrev.com/c/4797743) silently broke the
functionality. runtimeModel is only availavble on page target, not tab.

Bug: 1358602
Change-Id: I5c1c3fa2717ccdeff1d3be5c962c24cc90ece792
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5316134
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2024-02-22 09:20:53 +00:00
Benedikt Meurer ddd9b75418 [test] Move front_end/ui/ tests next to the source. 
DISABLE_THIRD_PARTY_CHECK=Moving unit tests.

Fixed: b:325903709
Bug: b:323795674
Change-Id: I60b5d23127bdc33bfaef100440894450606d860d
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314361
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-02-22 09:12:20 +00:00
Danil Somsikov fbf718fb05 Report ratings to AIDA 
Bug: b:295119680
Change-Id: I95859d69170a0060bda8753c942b5ce9f20d37b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309880
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-02-22 08:19:56 +00:00
Benedikt Meurer 7a6f757cc0 [test] Move the rest of front_end/panels/ tests next to the source. 
DISABLE_THIRD_PARTY_CHECK=Moving unit tests.

Bug: b:325903709, b:323795674
Change-Id: I780bd0276938611280af7b24b7ed0dbf4eb88369
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314345
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-22 07:33:03 +00:00
Danil Somsikov 0b1b22ad95 Fix AIDA error reporting 
Bug: b:295119680
Change-Id: I6fed0229c7d567306ea5fc438db5d415551df234
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5310119
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-02-22 07:10:51 +00:00
Benedikt Meurer 867e9ab1d7 [eslint] Remove const_enum rule. 
Following up on https://crrev.com/c/5222921 we use the `const_enum` rule
anymore and we can thus delete the relevant files.

Bug: b:319814509
Change-Id: Iea1fa3bfb45e7625a0b50d30d248d79633cb968b
Doc: http://go/chrome-devtools:eslint-pain-points-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314344
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-02-22 06:12:08 +00:00
Benedikt Meurer b78f8fbf87 [test] Move more of front_end/panels/ tests next to the source. 
DISABLE_THIRD_PARTY_CHECK=Moving unit tests.

Bug: b:325903709, b:323795674, b:326214132
Change-Id: I70aced8ca3f7024f3a3a6b191e3451fb8c7674c9
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309878
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-22 05:29:40 +00:00
Benedikt Meurer a948ee0460 [eslint] Teach eslint-plugin-mocha about itScreenshot. 
Bug: b:319814509
Change-Id: I2b1bb2414f3ab30d0397998bbcd920e99e94b2ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314342
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-22 05:22:42 +00:00
Danil Somsikov 886dd31165 [ve] Kebabize column IDs used as a context. 
Event though most of the column descriptors have been migrated to the
kebab case, the HeapSnapshotDataGrid cannot be migrated as the columnIds
need to match the underlying snapshot data

Bug: chromium:1467464, b:320405843
Change-Id: Ib8cea9aef5951e20601d2ab2839c500dbd38771b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314359
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-02-22 05:18:29 +00:00
devtools-ci-autoroll-builder f911a984b5 Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/9368e7e..9ed84eb

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ae5d810..88acf0d

Rolling buildtools/linux64: git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7dc148f..9c56236

Roll created at https://cr-buildbucket.appspot.com/build/8755427373036868337

Bug: none
Change-Id: Iaf6440da2f5e2763f585ca87a9f4ec9e8cdcbe1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5316556
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-02-22 03:37:22 +00:00
Adam Raine ad6342fa9a [Lighthouse] Roll Lighthouse 11.6.0 
Bug: 772558
Change-Id: Ic86e955d376ce94edd980e490982414fb5dd7ac3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5315403
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2024-02-21 23:55:50 +00:00
Jonathan Hao c338781d45 [Private Network Access] Update timeline in issue description 
The timeline was outdated.  We need to update it so the warnings shown
by https://chromestatus.com/feature/4869685172764672 is accurate.

Change-Id: If8e309c8700c3fc3a1a5cd7ae3a15af440315fd2
Bug: 41497295
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314339
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-02-21 23:22:11 +00:00
Elorm Coch de96647223 Kebabize autofillView in userMetrics.ts 
Bug: None
Change-Id: Ifd68e21250de5f79d3070d7c142b2189e886d947
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5311335
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Sylvester Elorm Coch <elormcoch@microsoft.com>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2024-02-21 17:50:32 +00:00
Philip Pfaffe 5e38c00beb [elements] render bezier swatches with an ast matcher 
Drive-by: Simplify StylePropertyTreeElement tests

Bug: 40945390
Change-Id: Ie670717b587f012c2f5857dad3a14c5e578d4cd8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5310116
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-02-21 17:44:45 +00:00
Danil Somsikov c856d2cf6d [ve] Fix logging of native submenus 
Bug: chromium:1467464
Change-Id: I05797d5f191d1ff65a2801a1659fa7fd3f810ff7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314343
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-02-21 17:36:14 +00:00
Danil Somsikov cc772e1735 Kebabize chrome link jslog context 
Bug: chromium:1467464, b:320405843
Change-Id: Ia9cdea11533739e5e1dda322a5ba9cd8886cf642
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5314340
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-02-21 17:12:46 +00:00
Philip Pfaffe 479dc5f64d [elements] Show a color value popover for the color-mix icon 
Drive-by: Propagate color update events to outer color mixes

Fixed: 40256889
Change-Id: I5525af6b7d54111766c2e5187aa9ee6e58df9230
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5300218
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2024-02-21 15:43:29 +00:00
Ryan Puhalovich cede18e204 Fix authenticator-option-label alignment using flexbox 
authenticator-option-label was aligned using padding-top rather than
flexbox. This fix implements flexbox.

Below are replication steps, copied from the linked issue:

1. Launch Chrome and right click inspect
2. Click on More tools select WebAuthn
3. Check the box of Enable Virtual Authenticator
4. Notice the labels are not aligned with the checkboxes

Fixed: 40066880
Change-Id: I09e60fa1531e859dc0b2fb4fe468a2565f30e143
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309155
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-02-21 15:16:50 +00:00
Shuran Huang 5857a8c166 Add partitionKey field to CookieDTO object for partitioned cookies 
Bug: none
Change-Id: I50798f7a658a6d84afad988896b86bf3513ec55b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309416
Auto-Submit: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2024-02-21 15:12:29 +00:00
Philip Pfaffe 7122f7c41a [elements] Parse properties with linkable names with an AST matcher 
Bug: 40945390
Change-Id: Id18b3e14705004557f994c0cd63ffd732d1a5235
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5300857
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-02-21 14:54:11 +00:00
Danil Somsikov 64855dbed3 [ve] Add missing and remove redundant resizeable pane annotations 
Bug: chromium:1467464
Change-Id: I1d5c71bd37dab57499d600c71ac974aa24d3a61d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5272390
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-02-21 14:23:17 +00:00
Benedikt Meurer cb7952fda5 [eslint] Enforce stricter rules for mocha tests. 
- Disallow passing async callbacks to describe, as that's a great source
  of bugs (anything defined after an `await` will not run).
- Disallow global tests.
- Disallow nested tests, as those will not run (and we had a few of
  them).

Drive-by-fix: Use the proper mocha/no-exclusive-tests plugin instead of
our homegrown one, and teach the mocha plugin about the various describe
versions (which consistently works for all the other mocha eslint rules
then as well).

Bug: b:319814509, b:326206427
Change-Id: Icfa9caf468882a226a5dbdd3be27b0f66fe4479f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309877
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-21 14:00:27 +00:00
Philip Pfaffe e0d9508fc1 [elements] Render angle swatches with an AST matcher 
Drive-by: Move the checks whether the matcher applies out of matching
to avoid some redundant work.

Bug: chromium:1504820
Change-Id: I351c99d0d621b92db64087330f572f8e4c0b25c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5238548
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2024-02-21 13:42:07 +00:00
Philip Pfaffe 5f97fbbf9a [elements] render color-mix with an ast matcher 
Bug: chromium:1504820, chromium:1515931
Fixed: chromium:1504756
Change-Id: I6a0e5bffd528ecb18b32119520967992b589cae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5190117
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2024-02-21 13:39:22 +00:00
devtools-ci-autoroll-builder 46e97accac Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/33cc0d5..9368e7e

Rolling buildtools/linux64: git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32..git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc

Roll created at https://cr-buildbucket.appspot.com/build/8755483998340305537

Bug: none
Change-Id: I82ebccbd674943faee577cf9a4714117d4024dba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309288
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-02-21 12:33:25 +00:00
devtools-ci-autoroll-builder e999048166 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/RECORDER_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8755517967547708209

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: I6725edcdc20fb2599e03495d383f5ff3a2dae6c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309420
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-02-21 10:42:27 +00:00
Alina Varkki 6f2abd8d77 [RPP] Change initiator 'reveal' links to entries names 
Let's add useful information by showing the name of the entry that initiated/was initiated by instead of a 'reveal' word.

Bug: 326055289
Change-Id: I099a4e3bb83f0ed639219a9edb364222f4b29345
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309875
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
 2024-02-21 10:16:15 +00:00
Benedikt Meurer 8e4e727722 [eslint] Fix configuration for tests. 
Bug: b:325903709, b:323795674
Change-Id: I70369488f6b719aa4458b458bb2e1bd10e0fb3f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5310118
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-21 10:01:10 +00:00
Kim-Anh Tran cae650cc8a Report resources loaded through extension to PageResourceLoader 
This extends the LanguageExtensions API to include a mechanism
for extensions to report loaded resources. These resources will
be registered by the PageResourceLoader, so that resources
loaded through extensions will also show up in the Developer
Resource Panel.

Also-by: pfaffe@chromium.org
Bug: 40746829
Change-Id: I03d90ac57a9155eeca9e3f16377007735f092ba0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5291295
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2024-02-21 09:29:56 +00:00
Simon Zünd 8eb3356b59 [sdk] Implement decoding of original scope information 
This CL implements half of the scope decoding logic: Decoding
"authored" scopes. Decoding "generated" scopes/ranges will happen
in a follow-up.

The implementation is split into two parts, the first is a generator
that produces "start"/"end" scope items via VLQ decoding. The second
part turns the flattend "start"/"end" array into a proper scope tree.

R=pfaffe@chromium.org

Bug: 40277685
Change-Id: I1bc6701134012a9601ae5b1929a8dd74c8f684ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5307620
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-02-21 08:56:22 +00:00
Camillia Smith Barnes 8743bf3931 Shared Storage: Display bytes used in SharedStorageMetadataView 
We display the total bytes used by an origin in the application
panel's `SharedStorageMetadataView`. We recently started tracking this
value in the database (https://crrev.com/c/5278559) and added it to the
metadata retrieved through the DefTools Protocol
(https://crrev.com/c/5283142).

Bug: 324464353
Change-Id: I497ec27270d6bec068c591d0b5f78d1d67710808
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309418
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-02-21 07:43:25 +00:00
sisidovski fad70d9e19 [ServiceWorker] Add transferred size in the network panel 
This CL adds the network transferred size information to the network
panel for the service worker static routing API [1]. When the service
worker has routers, and incoming requsts matched to the router which
lets requests go directly to the network, currently DevTools doesn't
show the network transferred size, while developers can see it on other
regular network requests.

This CL add the info to the entry in the network panel when developers
hover the cursor to the size column.

Here is the chromium side CL: crrev.com/c/5297354

Other router sources:
For `cache`, we don't need to show the transferred size, as there is no
network transfer. This is consistent with the diskcache case.
For `fetch-event`, another entry in the network panel, from the service
worker to the network, should show the info as the regular SW fetch
handler does. The current behavior is not consisntent with that, but
that should be supported in a separate CL.
For `race-network-and-fetch-handler`, TBD. Maybe we should have a plan
after supporting `fetch-event`.

[1] https://groups.google.com/a/chromium.org/g/blink-dev/c/-SEMMttEqz4/m/ogpF3VZsAAAJ

Bug: 325120866
Change-Id: I392f9d7743abe10f0a0738d9a630c5f892052310
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5303228
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
 2024-02-21 07:13:29 +00:00
devtools-ci-autoroll-builder a2d539b70a Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/6d07599..33cc0d5

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/b997508..ae5d810

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/280bb93..7dc148f

Roll created at https://cr-buildbucket.appspot.com/build/8755517967547708209

Bug: none
Change-Id: Ib5f9fb3f3ecccfe614b0cdc95b68125ed96cc741
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309287
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-02-21 03:41:31 +00:00
Peter Müller 50cbbe8664 Update --ref-palette-purple99 with the correct color value 
We accidentally entered a color value from the cyan palette for purple99.

Old: rgb(249 253 255 / 100%);
Updated: rgb(255 251 255 / 100%);

Bug: 326027071
Change-Id: Id4d211b9a557376beac9afc781d149e4ecb3d991
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5308067
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Peter Müller <petermueller@chromium.org>
 2024-02-20 17:25:16 +00:00
Peter Müller 6098f449e7 Add dark theme definition for --sys-color-pink and --sys-color-on-pink 
Bug: 325935771
Change-Id: I99c542bd83a35e59a319cbc9faed01fa6c7549d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5307617
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Peter Müller <petermueller@chromium.org>
 2024-02-20 16:54:23 +00:00
Peter Müller 50b7720ad5 Add sys-color-pink-bright definition for dark theme 
Bug: 325932600
Change-Id: I21e983f7cb1d1687f2d04cd2c61ecb63401874c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5308057
Commit-Queue: Peter Müller <petermueller@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2024-02-20 16:49:18 +00:00
Peter Müller b106a5e7b9 Update --sys-color-green-bright 
Currently --sys-color-green-bright references --ref-palette-tertiary70, however it should reference --ref-palette-green70.

Bug: 325934130
Change-Id: Ib0f3949423b41a5a957174ad115092aa2357d870
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5308056
Commit-Queue: Peter Müller <petermueller@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2024-02-20 16:48:11 +00:00
Benedikt Meurer 7fea8f5a97 [test] Start moving front_end/panels/ tests next to the source. 
DISABLE_THIRD_PARTY_CHECK=Moving unit tests.

Bug: b:325903709, b:323795674
Change-Id: Ib92c242f801a555816ecb52196c03b59961ef941
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5310115
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-02-20 15:56:33 +00:00
Danil Somsikov 4af5edc821 [ve] Report disappearance as resize to 0. 
We generally don't track when VE disappear which is a conscious design
decision making the implementation simpler and more efficient.

However this poses some difficulties for the generic logs analysis I
have in mind: at every moment we can say that user finds themselves in a unique state
defined by a set of VE seen so far. This is good for understanding the
user journey in details, but too specific for a generic user analysis.
Therefore we should be agregating these states based on top K largest VEs.
This works, except we can't tell the difference between the panel user
is seeing right now and the panel they saw earlier. It is still
important that they saw something earlier for a detailed analysis but
not for generic one. To solve this, we can extend the notion of a small
VEs to the invisible VE and consider them to have the size 0.

This comes in handy in our implementation of panels where we don't
remove previosly seen panel from the DOM. User might have interacted
with one panel, made some changes, switched to another panel and then go
back. If we were to log disappearance and a new impression, it would be
hard to associate the VE interactions they had before the switch with
the ones they did after. Logging resize to zero gives us enough
information to understand that VE is not visible without loosing the
history.

Logging disappearance of only those element with 'track: resize' is
somewhat arbitrary but in practive is exactly what we need: we don't
care neither about resize or disappearance of say tree elements but we
do care about these events for a panel or pane.

Bug: chromium:1467464
Change-Id: I52c2658f33bd9496872926736fbcd5a82bcb0963
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309834
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-02-20 15:38:42 +00:00
Yang Guo ec206f0a77 Use consistent icon size for command menu 
Bug: b/326046358
Change-Id: Ia6828b0c739f813f3153137756b1902cabdd711b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5310114
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2024-02-20 15:33:35 +00:00
Danil Somsikov 0ce3e2b1dd Add resize tracking to sidebar annotations 
Bug: chromium:1467464
Change-Id: Ie7dc2185d24d6671abf3cebca6ca8b7a854d189d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5308055
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-02-20 15:11:04 +00:00
Benedikt Meurer c4c053b337 [test] Put more front_end/ unit tests next to the source code. 
This moves `front_end/entrypoints/`, `front_end/third_party/` and
`front_end/services/` unit tests next to the source code. There are a
few unit tests left in `entrypoints` that need to be adjusted to match
the pattern first, so they'll be done in a separate follow-up CL.

DISABLE_THIRD_PARTY_CHECK=Moving unit tests.

Bug: b:325903709, b:323795674
Change-Id: I892077ce64c4969832b2caba1c0f6c8b7f33ffaf
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309874
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-20 15:06:09 +00:00
Benedikt Meurer 00dd2992ab [eslint] Ensure that *.test.ts files only import module entrypoints. 
For `foo/Bar.test.ts` we cannot allow `import {Baz} from './baz.ts'`,
but we need to enforce `import * as Foo from './foo.ts'` to not break
with the module system in Release builds.

Bug: b:325903709, b:323795674
Change-Id: Ibd41dea9e660289508202efbb9c30808c6461dd4
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5308068
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-02-20 14:04:26 +00:00
devtools-ci-autoroll-builder 2ea7547b77 Update DevTools DEPS (trusted) 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/05c489d..6d07599

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/36dc95f..b997508

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9d7c8e7..280bb93

Roll created at https://cr-buildbucket.appspot.com/build/8755574595493381169

Bug: none
Change-Id: Id389b6d51c7e10d71dcb317fbcc1acec5d1fc95a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309276
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-02-20 12:29:06 +00:00
devtools-ci-autoroll-builder 171958dde3 Update Chrome (for Testing) PIN 
Chromium pin updated to 123.0.6312.0

Roll created at https://cr-buildbucket.appspot.com/build/8755574595493381169

Bug: none
Change-Id: I1ba77f473533a33b66e5b4ea34360c22d1c63907
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5309414
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2024-02-20 12:28:01 +00:00