zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,420 Commits 43 Branches 79 Tags
b12601e9960b35d6ff9aa2a358a0be3c63da2a83
Commit Graph
25420 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jack Franklin b12601e996 RPP: skip layout shift cluster unit test 
Bug: 406981939
Change-Id: I0033bff92181ed9541b0dc05e1bedad07c5e2bd2
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408652
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
 2025-03-28 09:48:18 -07:00
Jack Franklin d8698b71e3 Annotations: new prompt to reduce "responsiveness" 
The mention of responsiveness in the prompt really made the AI use
it...a lot! This version seems better. By asking the AI to not focus so
much on "user visible impact" we reduce how much it talks about "user
interaction responsiveness" which really isn't helpful.

Bug: 400357484
Change-Id: Id9f594b3af34bd733e6a3fe61c21aeef0cb1a1ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408872
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 09:44:33 -07:00
Andrés Olivares cee49a9b62 [RPP] Fix network request details layout 
Margins and spacing between items was off.
Before: https://screenshot.googleplex.com/3Rz759PHWKxbFqp
After: https://screenshot.googleplex.com/3xTGaLkE2E5dqco

Fixed: 406990013
Change-Id: I5f7ec7f1bb2ad5b5a2fab0acf5fc6eae3edfedb8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404821
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 09:27:48 -07:00
Philip Pfaffe cb1e1ed98e Automatically reopen tooltips on rerender 
When a tooltip gets detached without being closed and then gets replaced by a tooltip with the same id, the new tooltip is automatically reopend once connected. This addresses an issue in the styles tab where property values are rerendered entirely on changes.

Fixed: 404720158
Change-Id: I9e0f40f42898343faf112dc92127463fc7cab7f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387117
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-28 08:28:05 -07:00
Mike West 0a15a0f000 Refactor SRIMessageSignatureIssue. 
This CL doesn't introduce any behavioral change, but simply reworks the
implementation of `SRIMessageSignatureIssue` for clarity and concision.

Bug: 381044049
Change-Id: I726aa4e5f9249f1d2f1992f64c1b9821cf3ac8c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395499
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-03-28 08:13:19 -07:00
Kim-Anh Tran 7de602ae97 [GM3Restyling] Update swatch popover helper and CSSPlugin 
Both open the color picker in different environments (GlassPane, and Codemirror Tooltips).

Screenshots: https://imgur.com/a/js6wjcU
Bug: 406706611
Change-Id: I14e78949c6246dada6897604e9d1f5c6169d398e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400616
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-28 07:56:51 -07:00
Eric Leese 3dffede8b4 Change error path rewriting to work in full chromium checkout 
Instead of calculating the path relative to the root of the
DevTools source tree, we now just remove "../../" to get the
relative path. This makes terminal links in vscode work in
full Chromium checkouts as well as devtools only checkouts.

Bug: None
Change-Id: I7bf410c353c5929bc9a0ef064449fa88f3bc1264
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405079
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 07:14:10 -07:00
Kateryna Prokopenko 4ec68419bb [GM3Restyling] Update GlassPane tooltip styles 
Screenshot: https://imgur.com/a/rhQmTVl

Bug: 406466030
Change-Id: I0444c3f8bd029b277ba17a0e8c445d5fc3827754
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403633
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-28 07:12:28 -07:00
Mike West 3fd2e5f67c [SRI Message Signatures] Add an issue for integrity mismatches. 
We're now emitting a devtools issue when blocking a response due to
signature-based integrity mismatches. This CL allows devtools to render
those issues when they appear.

This is the Devtools side of a two-sided patch:

1.  (Chromium) https://crrev.com/c/6394978
2.  (Devtools) https://crrev.com/c/6396680 [You are here]

Bug: 406424762
Change-Id: Iab6817bc42e96ddb080324183c8ba8668b773b41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396680
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
 2025-03-28 07:06:25 -07:00
devtools-ci-autoroll-builder f8ac7f1115 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8719154614336360705

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: Icce628cee263057ad4833e080d972a50749ad771
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405895
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 07:01:21 -07:00
Benedikt Meurer 1022e32645 [npm] Allow to select (unstable) features with npm start. 
This adds an option `--enable-unstable-features`, which now also turns
on multimodal support for Freestyler.

It also adds `--enable-features` and `--disable-features`, to allow more
fine-grained control over the exact feature set when necessary.

Fixed: 406941932
Change-Id: I7fcecbba833a2e0a66166890aa5af218ae2a8f7e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404318
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 06:40:16 -07:00
Wolfgang Beyer 6353dded50 [Patch agent] Remove first-run-disclaimer 
The disclaimer was only needed for connecting workspaces from within
the patch agent UI. Since the patch agent now only uses workspaces if
they have already been set up before via the Sources panel, the
patch agent's first-run-disclaimer can be removed.

Fixed: 406686142
Change-Id: I18b28475ac9904fd65a8041f96d36986804169c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405319
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2025-03-28 05:55:58 -07:00
devtools-ci-autoroll-builder ea6ee6962f Update Chrome (for Testing) PIN 
Chromium pin updated to 136.0.7095.0

Roll created at https://cr-buildbucket.appspot.com/build/8719154614336360705

Bug: none
Change-Id: I0d6b6042aad05959fb0e59d209a92f9a66284584
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405894
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-28 05:43:41 -07:00
Ergun Erdogmus d0889db8ba [Memory] Release all animations before memory operations 
This is a workaround to remove user facing issue of having detached
elements in the profiles because of the animations panel.

What happens is, we keep the animations for replay in the animations panel.
However, when a DOM node is removed; we still keep the
animation related to the DOM node in the animations panel and
this causes the node to be retained and show up in the memory
profiles as detached elements.

Fixed: 400635410
Change-Id: I686799c1069978fbb78250d88ae6459a5ee26572
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406316
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-28 05:27:11 -07:00
Jack Franklin 2dfe19495e RPP: disable flaking LayoutShiftDetails test 
I will follow-up and investigate but disabling to get tree green.

Bug: 406981939
Change-Id: I7e2a546795ef26f218d4fea35086bf9e4ac77d7a
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406895
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-28 05:25:01 -07:00
Connor Clark e7a6489e5c Enable projectService for TypeScript files in eslint config 
Enabling this is required for rules that need to use the types as
resolved by the TypeScript compiler.

The no-floating-promises rule was missing some stuff due to missing
types, so this CL resolves that too. Also, return-await kicked up more
stuff.

A warm run of `npm run lint` went from ~23s to ~35s on my M1 Mac.

Bug: 406518012
Change-Id: I0c413e2ca14ee903851fd8404e490335c7f8aae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397499
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 05:02:27 -07:00
Nikolay Vitkov acf22bf573 Move to build deps to devDeps 
This is not part of the bundled part.
Make that separation.

Bug: none
Change-Id: I9f8dda77b0526cb2b2f0cb7e8d4ac2469137894d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406322
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 05:01:24 -07:00
Jack Franklin 5c9a3b6b59 Karma: apply patch to prevent timeouts after test complete 
In github.com/karma-runner/karma/pull/3852 it is suggested that the 30s
timeout issue with Karma can be seen when:

1. All the tests complete, which sets the state of Karma to
   "disconnected"
2. But there is some async activity which logs, or something. This
   causes Karma to restart its 30s timeout, but no more messages will be
   received.

This is a bit experimental, but trying this patch to see if it has a
positive impact on CQ.

Bug: 406729910
Change-Id: Iaaa9247c801e193e5782a0da4857d804bcc45a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407593
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 04:41:42 -07:00
Philip Pfaffe a792c7efee Revert "[css value tracing] evaluate percentages in longhands" 
This reverts commit a0c4c4a06c.

Reason for revert: The change breaks a bunch of non-percentage evaluations.

Original change's description:
> [css value tracing] evaluate percentages in longhands
>
> This adds support for evaluating <percentage> units in css value
> tracing, but only for longhands. For shorthands, we need additional reasoning about which longhand the unit pertains to in order to understand whether it's relative to a width or a height.
>
> Bug: 401213719
> Change-Id: I823ef9d52bb12ab40e7bcabce770733ad36a51b7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376104
> Reviewed-by: Eric Leese <leese@chromium.org>
> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
> Commit-Queue: Eric Leese <leese@chromium.org>

Bug: 401213719
Change-Id: I19d3567542f9b53e57efa9747f70d3aa529acec2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405417
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-03-28 04:38:07 -07:00
Danil Somsikov d3465fc604 Replace top-level variables with a lit template 
Bug: 400353541
Change-Id: Iab1b2a5b596ca7efe4922124253947419d41a2d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407493
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-28 04:29:23 -07:00
Danil Somsikov f83ed266a9 Support external expressions as children of DOM fragments 
Bug: 400353541
Change-Id: Id29c4fa82500507fcde454afe21de6e0cac9d1e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405673
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-28 04:19:35 -07:00
Danil Somsikov 282ff278ad Only remove processed references to DOM fragments 
Bug: 400353541
Change-Id: I9b93a605c7ae90705539a9293c4c9b1a9c998582
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405493
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-28 04:15:41 -07:00
Nikolay Vitkov 0fa4f1a476 Support all Chrome channels 
Also add support for binary to point to executable of your
choice.

Bug: none
Change-Id: I122ad4fd117241c0c0106e2896e4fca602791958
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397059
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 04:02:57 -07:00
Jack Franklin 5211c836ea Revert "RPP: create new annotations AI agent" 
This reverts commit 9995b96203.

Reason for revert: I forgot that the backend CL needs to land before this can land!

Original change's description:
> RPP: create new annotations AI agent
>
> Required mostly for metrics so we can track its usage accurately rather
> than bundled in with the existing "Ask AI" integration.
>
> (Googlers: see the attached bug for a link to the backend CL, this needs
> to land first before this can land).
>
> Bug: 406795908
> Change-Id: Ibf0fff042f72a6e622e9d9d9e87769a71feb23af
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407494
> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Bug: 406795908
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic85d030aa8542818168b23b6c60f582aa68eaf52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405418
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-03-28 04:01:14 -07:00
Jack Franklin 9995b96203 RPP: create new annotations AI agent 
Required mostly for metrics so we can track its usage accurately rather
than bundled in with the existing "Ask AI" integration.

(Googlers: see the attached bug for a link to the backend CL, this needs
to land first before this can land).

Bug: 406795908
Change-Id: Ibf0fff042f72a6e622e9d9d9e87769a71feb23af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407494
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 03:57:43 -07:00
Eric Leese 5f7e033b32 Fix npm run start and build scripts to work in full Chromium checkout 
Also simplified code for test script to use devtools_paths.js

Bug: none
Change-Id: I699808267782f55150eabaacf9f86298ab3741d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403238
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-28 03:39:01 -07:00
Nikolay Vitkov 1ffa94db7a [cleanup] Build third_party with common tools 
Bug: none
Change-Id: Ib87452b075ec3accf305c84dd97c4dc180b9311b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6402073
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-03-28 03:37:58 -07:00
Danil Somsikov 1675d4de76 An abstraction to track class members and distinguish the class they belong to 
Bug: 400353541
Change-Id: I5f8c6577407299d2c91980b40e1cc93ca74ef043
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403237
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-28 03:36:29 -07:00
Wolfgang Beyer 32caf01d79 [Patch agent] Add saving to workspace 
If all modified files have a binding to a file on disk, allow
saving the changes to disk.

Bug: 406217277
Change-Id: Ib2f0adffc885b467ba885eb00d7b8765a0ba2d9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403240
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
 2025-03-28 03:24:43 -07:00
Philip Pfaffe 48963ad553 [css value tracing] Fix highlighting in BinOps 
Fixed: 404538338
Change-Id: Ic15007e85a415973057579db3d77c011b44015e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368598
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-28 03:07:32 -07:00
Nikolay Vitkov cf70a057cf [test] Fix types for selectors 
Bug: none
Change-Id: I84974d640a005fbbf0f1aed3c802202731b40381
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404073
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-28 02:25:44 -07:00
Ergun Erdogmus 0a63c31c96 [Workspace] Remove resetting working copy after text change 
We started using `setWorkingCopy` to update UISourceCodes
programmatically from other parts of DevTools (e.g. Styles tab & PatchWidget).

Because of this, the logic for comparing the cleanliness of the
code needs fixing and crrev.com/c/6381859 attempted doing it.
However, somehow, with that change; updating styles from styles tab
and calling `setWorkingCopy` do not update the `UISourceCode` at
all and there are test failures attached to that CL.

Until we figure out what's going on, it's best to disable the logic
for resetting working copy when `isClean()` reports true on text change.

There is one more place where we have a similar logic:
activating the pretty toggle when the `isClean()` reports true on
text change but that's a smaller bug that we can afford right now.

Bug: 402699175
Change-Id: Id175cfaeb44ffa7728f30b28893654d73af6dd8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405494
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-28 02:15:20 -07:00
Simon Zünd fca5397836 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8719188589721198481

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: I4a2bb839b39222597520735b1ce5cb808363c1dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406914
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2025-03-28 02:00:57 -07:00
Nikolay Vitkov 1814397dc3 Update recommended GN extension 
This extension is much more powerful as it provides more useful
information.

Bug: none
Change-Id: If7f81a0da236418225ef3f93acce347161ea65c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404754
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 00:13:04 -07:00
Mike West 770cde9518 [SRI Message Signatures] Improve the network panel status. 
This CL shifts the text in the network panel's status column from
"(blocked:other)" to "(blocked:integrity)", and causes clicks on that
column to expose the set of headers sent along with the response.

Bug: 381044049
Change-Id: Ifbb493030cf3327cfd6954ba9f9b61a46a7b0648
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397062
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-03-28 00:03:51 -07:00
devtools-ci-autoroll-builder bda3d992bf Update Chrome (for Testing) PIN 
Chromium pin updated to 136.0.7093.0

Roll created at https://cr-buildbucket.appspot.com/build/8719188589721198481

Bug: none
Change-Id: Ifd8de4711a0627f4153b8926b6f68176035b9a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6406913
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-27 20:47:34 -07:00
Connor Clark cfa11f3ba5 [RPP] Add estimated byte savings to Duplicated JavaScript insight 
Also fix #shouldShowTreemap

Bug: 394373632
Change-Id: Ia34504bfa8a99c6c5d5d12212ddcae463490b0dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404285
Reviewed-by: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-27 15:30:10 -07:00
Changhao Han 3a037adc16 Remove unnecessary changes hints in the Styles tab code 
Bug: 406453050
Change-Id: If12eb77019be34ab8f62c903009766ce57d85c3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400619
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-27 14:31:41 -07:00
Connor Clark 05b6ebf24a [RPP] Compute estimated savings for Duplicated JavaScript insight 
- Ported Lighthouse's estimateCompressedContentSize
- Ported Lightouse's isRequestCompressed - this was inlined within the
  DocumentLatency insight, except it did not handle Lightrider/PSI. I
  changed that insight to call the new helper function.
- Moved the part of Trace Processor that deferred resolving cached maps
  to the provided `resolveSourceMap` option, to instead be handled
  internally within ScriptsHandler. In these cases, resolveSourceMap is
  still called w/ the cached raw source map, but all it does is create
  an SDK.SourceMap.
- The testing/TraceLoader was not resolving cached source maps stored
  in the metadata. Now it is.
- Fixed a crash when loading an enhanced trace containing a source map
  that cannot be encoded via btoa. For now, just ignore the error.

Bug: 394373632
Change-Id: I49104aee7fbe5f4b9dfc5061973b7e941f3a2911
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404895
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2025-03-27 13:42:14 -07:00
Connor Clark 75529f1cd9 [RPP] Add LH Treemap button to Duplicated JavaScript insight 
This lifts a bunch of code from Lighthouse[1] needed for opening
the Lighthouse Treemap webapp[2], a treemap visualization tool
for JS bundles. It shows all the scripts found on the page,
augmented with source map and any other data we send it (like
what large modules are duplicated on the page).

A couple refactors were necessary:

- The DuplicatedJavaScript model has a few new properties
  needed to assemble the data for the treemap
- computeGeneratedFileSizes moved from ScriptDuplication to
  ScriptsHandler, so it can be cached
- Add `inline` property to Script trace model

[1] https://github.com/GoogleChrome/lighthouse/blob/04f43865487b77384d5bfb02f774397ead5e3db2/core/audits/script-treemap-data.js
[1] https://github.com/GoogleChrome/lighthouse/blob/04f43865487b77384d5bfb02f774397ead5e3db2/report/renderer/open-tab.js#L102C10-L102C18
[2] https://googlechrome.github.io/lighthouse/treemap/

Bug: 394373632
Change-Id: I1c873e298d8ff0611f325a1752110d7682182f5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6398204
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-03-27 12:19:22 -07:00
Jack Franklin 92e3000ebd RPP: track annotation label change events 
Bug: 406497770
Change-Id: I4fe1798468a1591d5bce6a841b29fc277f124190
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404753
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
 2025-03-27 12:18:19 -07:00
Jack Franklin 849d7770bc RPP: improve visual look of annotation input with consent flow 
When the consent flow popped up, the input lost focus and it renders as
a black rectangle (as it has no content). This CL updates it to maintain
the same visual state.

It also fixes a bug where focus was not properly restored; the early
exit condition in the setLabelEditabilityAndRemoveEmptyLabel function
meant that we wouldn't call focus, so I removed that. It's a pretty
cheap function that is not triggered that much so any theoretical boost
by early exiting is not worth it given it caused a bug.

Bug: 393063467
Change-Id: Id377a6ebee5b4ce0d4649e09f8fe7cbd5ed8d128
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403241
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-27 12:16:01 -07:00
Jack Franklin e003c5848c RPP: make the perf panel UI inert when consent dialog shows 
This CL makes the UI inert (it will not respond to user events) when the
dialog is showing, so you cannot tab around elements in the background.

We might want to expand this to a higher component so all of RPP is
covered, but this is enough for now.

Fixed: 406541486
Change-Id: Ie95ff549ba2392f6bdafeeff69c66e9ccd18ff7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403235
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
 2025-03-27 12:00:45 -07:00
Paul Irish 109655405f RPP: Polish UI 
- Reduce insight sidebar whitespace
- Drop transition on insight hover button.
- Make Magic pen animation smoother

Change-Id: I6a1cc2d83e73db66472d945bd51960c5417da547
Bug: 395797366
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395296
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-27 10:52:20 -07:00
Nikolay Vitkov bcd8cd9979 [eslint] Allow !! instead of Boolean 
This provides better type inference when using TypeScript,
specifically the .filter methods
Also allowed by Google style guide.
https://google.github.io/styleguide/tsguide.html#type-coercion

Change-Id: I79745812f57670a0057145609b7949b2a12d9fbe
Bug:397260638
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403239
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-27 10:49:17 -07:00
Philip Pfaffe f2a6d0ed54 Add elements.css-value-trace known context value 
Bug: 406422580
Change-Id: I15db46d85880ab9be201a5c4897f863c0ef6444b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403234
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-27 09:46:25 -07:00
Alina Varkki 64180fcdd8 [RPP][AI] Make the 'settings panel' link in the fre dialog accessible by keyboard 
Bug: 406549032
Change-Id: I3430367f331a96530f1c6f872bf2fb8ad1feab57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403236
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-27 09:45:21 -07:00
Alina Varkki 49b2a98601 [RPP][AI] Add error state for when generation failed and rename setting 
video: http://screencast/cast/NTE5NTMyODgxMzc5MzI4MHw3NTMzNGFmNy1mNQ

I think at this point we have so many button states that we should create an enum with states and track the current state.
I started doing it, but realised it won't be super straightforward so let's refactor it later.

Also changing the setting name.

Bug: 405354265
Change-Id: I203e80d86ac6788949a813b5d2f91eb3c0e2cfb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403233
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-27 08:55:26 -07:00
Nikolay Vitkov 77ba8df5a3 [stylelint] Run test on Presubmit 
We missed running this test and thus didn't catch some changes.

Bug: none
Change-Id: I4781780c6df539671bf3191b888fb8ca8ae436b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-27 08:40:23 -07:00
Jack Franklin eb541d6436 Tooltip: ensure tooltip stays if focus moves from anchor into content 
The tooltip has behaviour to ensure that when the focus
moves from the anchor to the tooltip that the tooltip does not hide,
however it only worked if the focus was the immediate child of the
tooltip. In our case (see attached bug) the focus was moving into a link
deeply nested within the contents of the tooltip.

This CL updates the code to make use of the blur target & relatedTarget
properties to detect this case and not hide the tooltip.

Fixed: 406543379
Change-Id: I7ad19fbde17e275663465e0bb86f8b2ea8ba768e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6402534
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
 2025-03-27 08:37:19 -07:00