zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-30 09:17:09 +08:00
Code Issues Packages Projects Releases Wiki Activity
6,677 Commits 43 Branches 79 Tags
bbdf7342fee4e6ff7425b6646475fa586bbc8e2d
Commit Graph
6677 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Christy Chen bbdf7342fe Make collect-strings work with .ts files 
The current collect-strings only scan .js file extension. This CL enables string collecting in .ts files.

Bug: 1136655
Change-Id: Ia6b4aa364496a80288edad49a471017923f71f05
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575514
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Commit-Queue: Christy Chen <chrche@microsoft.com>
 2020-12-09 18:27:57 +00:00
Christy Chen 87d9ffc323 [Loc] Migrate input to Localization V2 
Bug: 1136655
Change-Id: I7d8b1c34aaea07b896ec913faf141381422c3bd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580848
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 17:59:07 +00:00
Tim van der Lippe 53c2ae23b7 Add tests for javascript_metadata 
R=jacktfranklin@chromium.org

Bug: 1009443
Change-Id: I03f0a2c5bf0aed628b6097d419586d8ad07a9f3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581924
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-09 17:06:26 +00:00
Benedikt Meurer 77a02250d6 Hide "Add breakpoint" menu item for non-breakable lines. 
Also-By: pfaffe@chromium.org
Bug: chromium:1136484, chromium:1142275, chromium:1156075
Change-Id: I9ece7f66bb26aaf85398112c300825ceacf5f083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581923
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-12-09 16:50:17 +00:00
Tim van der Lippe 40440d9840 Add tests for HTMLFormatter 
R=jacktfranklin@chromium.org

Bug: 1024752
Change-Id: I92dedd0efd1d3ca1574b21eecd13eef6cc8126bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581919
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-09 16:47:27 +00:00
Philip Pfaffe 7e36e27564 [Wasm debug] Add a new plugin method to retrieve breakable lines 
With this CL we can check in language-plugin mapped source files which
lines are actually mappable akin to sourcemaps. With this, we prevent
setting breakpoints on un-mapped lines and avoid lots of unpredictable
breakpoint sliding.

Fixed: chromium:1156075
Change-Id: I8b21b998727a0d4f964430949b7c6ddcd0896d57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581549
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-12-09 16:10:36 +00:00
Yeol Park 67f7197d74 Changed to WheelEvent instead of non-standard MouseWheelEvent in screencast 
Bug:1145518
Change-Id: I467a5535a852bb6e0223eb4c478daf9e321ebcba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2550766
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-09 15:04:56 +00:00
Jack Franklin 75b0efc9b9 Ban "front_end" imports from front_end directory. 
If you're in the front_end directory and you mistakenly include
front_end in an import, e.g:

import * as UI from '../../front_end/ui/ui.js';

instead of:

import * as UI from '../ui/ui.js';

It will cause problems in a release build. This CL lands an ESLint rule
to ban these, but still allows it for unit tests.

Fixed: 1157057
Change-Id: Ia49279794616568f9e88241152e3412fcd9a8b36
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581547
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-09 15:00:16 +00:00
Maks Orlovich 4d873174c4 Add a utility for structured header handling (1/3) 
This is a prerequisite for support for custom UA-CH in device emulation;
and will be used to convert between text and internal representations.

This portion includes the item parsing algorithm + its tests.

Bug: 1073909
Change-Id: I196a4fda0790ff6f62e0ca97a79cb75f7c7acb99
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2571441
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 14:55:56 +00:00
Philip Pfaffe caa87a6e1e [Wasm debug] rename formatter error 
This cl renames the badly named EvalError to FormatterError and passes
the error message to the base class for nicer printing.

R=bmeurer@chromium.org

Bug: chromium:1148179
Change-Id: I2b026f8645652e2ae37f2ac87a722b0ca5562d56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581548
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-12-09 14:34:16 +00:00
Tim van der Lippe ec534b82b6 Add CSSFormatter tests 
This ports the http/tests/devtools/sources/pretty-print-css-*.js
to Karma. Note that the expected output is the current output.
In a follow-up CL I will attempt to improve the formatting.

R=aerotwist@chromium.org

Bug: 1024752
Change-Id: Icbddd18ea7ef15ec97ad3ea70cb92a08e909a1f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577572
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-09 14:01:16 +00:00
Alex Rudenko 34e5f31b2c Click on a tree element to make sure the element is focused 
It appears that the test if flaky because the element is not getting
focused depending on the startup time of DevTools. As a wordaround,
we click at the selected tree element to make sure it will receive
keyboard events.

Change-Id: Ia400846bacfbf39967b15a69faf7c2db883ddb3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2579918
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-09 13:12:26 +00:00
devtools-ci-autoroll-builder b1f0d11f42 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/68a1580..7c664f9

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/99b0e4a..0e323e7

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I36f4d4a43a597148c5f9102bc6ffe4fa3d9189a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581156
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-09 12:37:16 +00:00
Philip Pfaffe 9d57b11687 [wasm debug] Scope view: Show optimized-out values as undefined 
Drive-by: When a formatter throws an exception, print that as a warning.

R=bmeurer@chromium.org

Also-by: bmeurer@chromium.org
Bug: chromium:1156981
Change-Id: I770fd1a40c01bfff0d6afc0e1f768f08e1afa9e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581540
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2020-12-09 10:40:46 +00:00
Tim van der Lippe 34032f2e6d Fix Remote Devices view 
The removal of namespace initialization broke the Remote Devices
view, which was directly setting the DevicesView on the global
scope.

R=aerotwist@chromium.org

Fixed: 1156952
Change-Id: I6e938d981500f844119a326016ae56984d48c2d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581539
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-09 10:32:27 +00:00
Simon Zünd 1edfa2693a Leave TODOs on all use-sites of legacy ReportView widget 
We want to replace use-sites of the legacy widget with the new
component version of ReportView.

R=sigurds@chromium.org

Bug: chromium:1156978
Change-Id: Iff980575a2fdd803449814731f628bfc065f7ef9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2579920
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-12-09 09:37:07 +00:00
Benedikt Meurer 99b14a9556 [debugger] Log timings of language extension plugin methods. 
This is a (temporary) measure to gain a better understanding of the
timing of the various language plugin methods, and how these affect the
overall experience. By adding this to the frontend itself (the log
messages will only show up in DevTools on DevTools), we also gain the
ability to ask partners / other developers to look at them in case of
performance issues.

Bug: chromium:1083146
Change-Id: I444c48f20be72c0f2b57f7dc821a772e97c5e86f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2579919
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2020-12-09 08:45:16 +00:00
Peter Marshall 34717e17dc [surveys] Add survey triggers for the remaining Issues surveys 
These are not enabled via a Finch config yet so won't start showing
until that happens.

These triggers were added to chromium in http://crrev.com/c/2560099

Bug: 1112738
Change-Id: I38b5c5d2880ac3e69a21e6a15a79741485544e69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560252
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 07:57:56 +00:00
devtools-ci-autoroll-builder 406bc33203 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I089353ab7b2733e142723422ca2a63b9916e05b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581378
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-09 06:21:26 +00:00
devtools-ci-autoroll-builder 7cbfe50ac1 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/7004e93..68a1580

Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6302c11..86a7f72

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1742f98..99b0e4a

Rolling third_party/inspector_protocol: https://chromium.googlesource.com/deps/inspector_protocol/+log/351a2b7..94298ce

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I1501201f3ef19eaec1664c115bf9ba80fc3de65a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581069
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-09 03:22:26 +00:00
Christy Chen 19739b881b [Loc] Migrate help to localization V2 
migrate help directory

Bug: 1136655
Change-Id: Ib361747d53faa0a5cc860d331238e08d327031cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577943
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-08 21:25:02 +00:00
Yang Guo cf421416ff Save search term in Search panel on keydown rather than on enter. 
R=changhaohan@chromium.org

Fixed:1155532
Change-Id: Ief28415a14bd56e30db059bc78349cd494d26a69
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577568
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2020-12-08 20:47:42 +00:00
Christy Chen cebafe7ed6 [Loc] Migrate workspace to localization V2 
Bug: 1136655
Change-Id: Ia6a4ff1c043f1b02656a9d7edf640f04f2f1e9a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577936
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-08 20:19:22 +00:00
Mingjing Zhang 63a9ee3c44 Add visualization of dropped frames in devtools 
This CL implements the visualization of dropped frames as red boxes
on the Frames timeline in devtools (imgur.com/a/cC9ufi7).

Bug:1075865
Change-Id: I18ef1419d535cc2168bf35d5a923a817c62abef5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517975
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2020-12-08 18:53:42 +00:00
Changhao Han 12b3841881 Fix flashing metrics widget when changing nodes 
This CL fixes the render flash of the metrics widget (box model) while
changing inspected nodes in DevTools Elements tab.

The issue is an inherent side effect of how the metrics widget and the
matched styles widget are designed to render. They are separate widgets
that are put together under the same parent widget, and no render
timing is synced between. Whenever the inspected node is changed, they
both will fire some CDP calls and re-render when the calls resolve.
This means any one of them can be rendered first while the other waits
for CDP calls, and usually the metrics widget wins.

This issue did not exist before https://crrev.com/c/2562851 because it
didn't clear previous matched styles sections while changing nodes. Now
that previous styles sections are cleared, the metrics widget will
re-render first while the styles section is empty, resulting in this
render flash.

This CL introduces a StylesUpdateCompleted event that fires when the
Styles sections are re-populated, so that the render timing can be
synced and thus ordered between the matched styles widget and the
metrics widget.

Fixed: chromium:1155456
Change-Id: I2f5d64dd046f39e483f7501a4b17d6358cd8d5df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577564
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-12-08 16:27:02 +00:00
Michael Liao d9d73bd898 [Application]: Ensure separators in report views extend with horizontal scrollbar present 
Issue:
- Separators for Manifest and Indexed DB report views are cut off when there is horizontal overflow

Changes:
- adding a min-width property for the report view element
- adding an overflow property for the content element for the Manifest/Indexed DB views

Before: https://imgur.com/w5jw7YS

After: https://imgur.com/ZqREl1f

Bug: 1154124
Change-Id: I926fcbf58e416a7f1c144a293621a9fd64b49051
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575540
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-08 15:39:42 +00:00
Michael Liao 07a11ed089 [Telemetry]: Adding CSS Editor Opened telemetry 
This CL adds telemetry for CSS editor openings.  The telemetry event triggers when a user clicks on a swatch or the font editor button.  The different CSS editors pass in a different ID to differentiate the telemetry events from different swatches/buttons.

chromium/src change: https://chromium-review.googlesource.com/c/chromium/src/+/2410650

Bug: 1149589
Change-Id: I7309591c6fc6ea6524f43a6e3924278446fcf194
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2410431
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
 2020-12-08 15:27:43 +00:00
Asami Doi 707979143b Show a warning message in Application > Manifest > Installability in DevTools 
This CL updates DevTools to show a warning message when a PWA is not
installable due to the failure of the offline capability check.

Backend CLs:
- https://chromium-review.googlesource.com/c/chromium/src/+/2567057
- https://chromium-review.googlesource.com/c/chromium/src/+/2576980

Bug: 965802
Change-Id: Ie89d2cf332e3a8c64597afab38b583e072058d5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2573849
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
 2020-12-08 14:38:52 +00:00
Kim-Anh Tran 0f9bf8aa6b [e2e] Re-enable wasm scope test 
This updates the test after a change in the v8 backend that
changes the scope view for Wasm.

Bug: chromium:1156555
Change-Id: I6c3c6d21ea9829ea9276e5a57681e52ad82c61b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577575
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2020-12-08 14:32:42 +00:00
Jack Franklin ec064415e7 Fix network category filter being reset if text filter is persisted 
This fixes a bug where if the user filters the network panel for the
text "foo", and filters by resource type (e.g. to "XHR"), when they
close and re-open DevTools the search text "foo" is persisted and added
back, but as a side-effect the resource type filter is lost.

I discovered this is true for all the additional filters; the moment you
restore a text filter every other setting is lost. To fix this we avoid
calling the `setTextFilterValue` function, which resets everything else,
and instead set the value of the filter input directly, with no other
side-effects.

Fixed: 1155564
Change-Id: I9fa1db634e9e5ec71e84b220c66503a4ab3e4be5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577574
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-12-08 13:48:02 +00:00
devtools-ci-autoroll-builder c21a8d9a59 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: I2f5a958f709cbb72a0f88c8c834207f981d45995
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578049
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-08 13:44:42 +00:00
Mathias Bynens 4897412c85 Remove unnecessary Clipboard API fallback 
navigator.clipboard.writeText has been supported since Chrome 66, so
we can now drop the fallback code.

Since [1] we can also drop the error logging case.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1068946

Change-Id: I0edb3ad0207a8f4dca77ae49ba7e814af58b9da7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578937
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-08 13:32:02 +00:00
Alex Rudenko 3c52c9aca3 Attempt at improving color swatch tests 
Change-Id: I8bc2f1a7809155ff17050159dc5e46fde9fc4eb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578936
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-08 13:30:12 +00:00
Andres Olivares c21938dd6e [module.json extensions] Add "Duplicate element" action to elements-meta.ts 
This action was missing during the migration of actions in elements/ so
this includes it.

Bug: 1134103
Change-Id: I3130d8807e60876824213411603f96fdc4365e41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575256
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-08 13:10:12 +00:00
Kim-Anh Tran e23234458f [LMI] Refresh data in LMI on Debugger.pause and on revealing the tab 
This updates the data whenever there may be a new change to the
memory that is currently inspected.

Bug: chromium:1110202
Change-Id: I77d0579186f40f581fc20b678d73307bba060833
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577570
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2020-12-08 12:49:22 +00:00
Andres Olivares 344120f2ae Change extensions' tags field to array 
Tags for an extension are declared in a single string and are
localized one by one at runtime. Tags to localize are provided to
the localization system by a static analysis done on module.json
files. However, with the new system for extensions, we cannot opt
for dynamically localizing tags because UI strings must be declared to
the localization system beforehand.

A workaround, implemented in this CL, is to provide an array of localized
strings as the tags of the extensions, where applicable.

Bug:1134103
Change-Id: I0760d47e25d346d4e52afad2ebdca8c014d63d86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577168
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2020-12-08 12:38:52 +00:00
devtools-ci-autoroll-builder fa1e3b6fbc Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/115823d..7004e93

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3b055d3..1742f98

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Id7ab39ce283a334566763e06482a9dba313fd8e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578651
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-08 12:36:42 +00:00
Tim van der Lippe 460e19b668 [module.json extensions] Add support for ContextMenu providers 
Modules can now register their contextMenu providers in the meta
files. The ContextMenu will now request each registered provider
alongside the previously registered providers from the runtime.

Note that a contextmenu provider will eagerly load its module, to
load the definition of the provider itself. Ideally we don't perform
this work at once (we currently load *all* modules that have a
contextmenu provider as soon as the user opens a contextmenu), but
we will punt that to a follow-up to clean up.

Lastly, some cleanups were performed in `show()` to use async-await
and handle the array of Promises that return an array of Providers.

R=andoli@chromium.org

Bug: 1134103
Change-Id: Idb15be2b6f4c9d8c6fb663f548580620500b076d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569768
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-12-08 12:15:12 +00:00
Wolfgang Beyer 9e7836c35d [DarkMode] serviceWorkersView.css 
Bug: 1152736

Change-Id: Ia80d15e2f1c71ea4755c24ddfa9fd55e116a25d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577571
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-08 11:55:22 +00:00
Tim van der Lippe fd6e13bee3 Fix proxy configuration for images when debugging Karma tests 
When debugging Karma tests, all network requests for /Images would
return 400 errors. It turns out that the proxypath we were redirecting
towards should include the full base url, including the target dir,
like we did for locales.

R=szuend@chromium.org

Fixed: 1153339
Change-Id: I34b39f28254f1e0011ce96a34a22f0f31468b064
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2571463
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-08 11:13:32 +00:00
Jack Franklin 57d1ed513a Fix keyboard usage of docking menu 
This problem was caused by the TS-ificiation and restructuring of the
code which lead to events being too eagerly consumed by the soft context
menu. In the event that part of the menu is a custom element, we need to
do nothing and _not_ consume the event, so that the custom element gets
the event to consume and process.

Fixed: 1156022
Change-Id: I9889a295d5e7181f53dd9a09ea2fc360f5daae29
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577569
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-08 11:06:42 +00:00
Sigurd Schneider 2e018a8f25 Mutually link requests with their prefetch requests 
Bug: chromium:1141824
Change-Id: Ic5dbb76e014d3dcb3d69e5e00de654e7dc53ec2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2563618
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-08 10:48:52 +00:00
Changhao Han 56516d18ad Temporarily disable two wasm-related tests. 
Bug: chromium:1156555
Change-Id: I15c64a7df6078431c8dc93f74e2ce466a530a490
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577566
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-12-08 09:50:47 +00:00
Sigurd Schneider 9e11913c4d Prevent name-clash of CSS class names 
This lead to a style unintendedly applying to an element and
causing a display bug.

Fixed: chromium:1156048
Change-Id: I919521803a77b2079ce65f89f9212d6c76b2649f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577557
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
 2020-12-08 09:49:41 +00:00
Sigurd Schneider 53fee9259f Improve types in front_end/sdk/SDKModel.js 
Bug: chromium:1011811
Change-Id: I725844cf42122ea5634b994a56c2d4d17bbb2038
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575095
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-12-08 08:41:51 +00:00
Tim van der Lippe 7843c257db Upgrade third_party/marked to 1.2.5 
R=szuend@chromium.org

Change-Id: I73fcfbcdd24cf3db4a2c7fc36bdf45426ef6cabf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2573375
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-08 08:10:31 +00:00
Yoichi Osato 2d4ece5291 Protocol update 
Related changes in chromium:
 crrev.com/c/2576862
 crrev.com/c/2505345

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1152290
Change-Id: I7ce0da4187d515ac29a4064f86d563a4d09ab97f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2576992
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-12-08 06:48:51 +00:00
devtools-ci-autoroll-builder 2b3b0f567d Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/a2380ac..115823d

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/55e9ddf..3b055d3

TBR=machenbach@chromium.org,liviurau@chromium.org

Change-Id: Ie4eba1e1a3f13a862d177e763c1040f65378666d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2578161
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2020-12-08 03:48:25 +00:00
Connor Clark 5921e781cd [Lighthouse] Roll Lighthouse 6.5.0 
Bug: 772558
Change-Id: I8a9283c0b555caa63c7c331593437fb551fc8fd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575515
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2020-12-08 01:54:15 +00:00
Eric Leese 57c86890de Clean up type definition for RawLocation 
Fixes: 1134110
Change-Id: I150b7e6b185a70facbc0e431130227439f1ac435
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577558
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2020-12-07 17:30:01 +00:00