Jack Franklin
fa050212ad
Typecheck Common/JavaScriptMetaData.js
...
Bug: 1011811
Change-Id: Ib02677b3d65c17c905dfe0171af4b6b5ed2dd3d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074770
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-02-27 12:37:36 +00:00
Paul Lewis
d8146840ca
Reland "Reland "Updates common/ legacy; resoves internal refs""
...
This reverts commit dca9ea19e0 .
Reason for revert: Trying again now that https://crrev.com/c/chromium/src/+/1962191 has landed in Chromium
Original change's description:
> Revert "Reland "Updates common/ legacy; resoves internal refs""
>
> This reverts commit cea2ead2fb .
>
> Reason for revert: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8894363207681558512
>
> Original change's description:
> > Reland "Updates common/ legacy; resoves internal refs"
> >
> > This is a reland of 1309e5c39a
> >
> > Original change's description:
> > > Updates common/ legacy; resoves internal refs
> > >
> > > Bug: 1006759
> > > Change-Id: If67d6626f45ae7fc6b5f7da3f04a74fd1362b058
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960455
> > > Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> > > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
> >
> > TBR=tvanderlippe@chromium.org
> > Bug: 1006759
> > Change-Id: Ia656aff34ccae0ef9b1819670906ff74b04eb580
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1959983
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org >
>
> TBR=aerotwist@chromium.org ,tvanderlippe@chromium.org
>
> Change-Id: I18857c0d060e83584a8f643efbe65f90cbd814fe
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962285
> Reviewed-by: Paul Lewis <aerotwist@chromium.org >
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
TBR=aerotwist@chromium.org ,tvanderlippe@chromium.org
Change-Id: Id996b598ed5903b7a74be83424a862e43283d0eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962286
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-12-11 16:06:17 +00:00
Paul Lewis
dca9ea19e0
Revert "Reland "Updates common/ legacy; resoves internal refs""
...
This reverts commit cea2ead2fb .
Reason for revert: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8894363207681558512
Original change's description:
> Reland "Updates common/ legacy; resoves internal refs"
>
> This is a reland of 1309e5c39a
>
> Original change's description:
> > Updates common/ legacy; resoves internal refs
> >
> > Bug: 1006759
> > Change-Id: If67d6626f45ae7fc6b5f7da3f04a74fd1362b058
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960455
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
>
> TBR=tvanderlippe@chromium.org
> Bug: 1006759
> Change-Id: Ia656aff34ccae0ef9b1819670906ff74b04eb580
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1959983
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> Reviewed-by: Paul Lewis <aerotwist@chromium.org >
TBR=aerotwist@chromium.org ,tvanderlippe@chromium.org
Change-Id: I18857c0d060e83584a8f643efbe65f90cbd814fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1962285
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-12-11 14:33:08 +00:00
Paul Lewis
cea2ead2fb
Reland "Updates common/ legacy; resoves internal refs"
...
This is a reland of 1309e5c39a
Original change's description:
> Updates common/ legacy; resoves internal refs
>
> Bug: 1006759
> Change-Id: If67d6626f45ae7fc6b5f7da3f04a74fd1362b058
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960455
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
TBR=tvanderlippe@chromium.org
Bug: 1006759
Change-Id: Ia656aff34ccae0ef9b1819670906ff74b04eb580
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1959983
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2019-12-11 13:23:05 +00:00
Tim van der Lippe
89c7ef6c36
Revert "Updates common/ legacy; resoves internal refs"
...
This reverts commit 1309e5c39a .
Reason for revert: Appears to break the HeapSnapshotWorker: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8894437866483043312
Original change's description:
> Updates common/ legacy; resoves internal refs
>
> Bug: 1006759
> Change-Id: If67d6626f45ae7fc6b5f7da3f04a74fd1362b058
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960455
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
TBR=aerotwist@chromium.org ,tvanderlippe@chromium.org
Change-Id: I4400c2c92eee0b350c3af2d2436c0e32e23a961f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960459
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2019-12-10 19:09:38 +00:00
Paul Lewis
1309e5c39a
Updates common/ legacy; resoves internal refs
...
Bug: 1006759
Change-Id: If67d6626f45ae7fc6b5f7da3f04a74fd1362b058
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960455
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-12-10 17:47:15 +00:00
Tim van der Lippe
b336f0440a
Add import-statements to common/
...
This removes the need for having a specific ordering of side-effecty
imports in `common.js`. `common/` should now be self-contained as a
whole.
Bug:1006759
Change-Id: I895ad13ce27a01228e9963c317a7b582f4386619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1899516
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2019-11-07 15:56:40 +00:00
Paul Lewis
0cd45e3e49
Reland "[DevTools]: Moves common to ES modules"
...
This reverts commit 25a9b3bd7404d49e55772ffba046ed8df65ad14e.
Reason for revert: Memory snapshots work again
Original change's description:
> Revert "[DevTools]: Moves common to ES modules"
>
> This reverts commit e064553334d4b0c925f0b1f0e2e0234be66b71be.
>
> Reason for revert: Memory tool fails to take heap snapshots with this
> error: https://imgur.com/hzR9Eqw
>
> Original change's description:
> > [DevTools]: Moves common to ES modules
> >
> > This CL converts the contents of the common/ folder over to ES modules
> > from the current custom module system. It includes statements in each
> > file that will pollute the global namespace, allowing the non-ESM code
> > to continue working as before.
> >
> > Bug: 1006759
> > Change-Id: Ib591e49155000381f85999a5da6c467ad0160996
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563
> > Reviewed-by: Yang Guo <yangguo@chromium.org >
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> > Cr-Commit-Position: refs/heads/master@{#699728}
>
>
> Change-Id: Ic0d526780451e8bb4de538f11c85859a3badfb0f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825463
> Commit-Queue: Yang Guo <yangguo@chromium.org >
> Reviewed-by: Yang Guo <yangguo@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#699835}
Bug: 1006759
Change-Id: I48c7e84262bb295e5830cac8a79a274226df046c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825420
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#699981}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75a39ca7ac8dcfc6a830db07a5a389ca9ab27b1d
2019-09-25 22:19:27 +00:00
Brandon Goddard
52dd33a0b0
Revert "[DevTools]: Moves common to ES modules"
...
This reverts commit e064553334d4b0c925f0b1f0e2e0234be66b71be.
Reason for revert: Memory tool fails to take heap snapshots with this
error: https://imgur.com/hzR9Eqw
Original change's description:
> [DevTools]: Moves common to ES modules
>
> This CL converts the contents of the common/ folder over to ES modules
> from the current custom module system. It includes statements in each
> file that will pollute the global namespace, allowing the non-ESM code
> to continue working as before.
>
> Bug: 1006759
> Change-Id: Ib591e49155000381f85999a5da6c467ad0160996
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563
> Reviewed-by: Yang Guo <yangguo@chromium.org >
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#699728}
TBR=yangguo@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org
Change-Id: Ic0d526780451e8bb4de538f11c85859a3badfb0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825463
Commit-Queue: Yang Guo <yangguo@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#699835}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 25a9b3bd7404d49e55772ffba046ed8df65ad14e
2019-09-25 16:58:21 +00:00
Paul Lewis
69d7770a96
[DevTools]: Moves common to ES modules
...
This CL converts the contents of the common/ folder over to ES modules
from the current custom module system. It includes statements in each
file that will pollute the global namespace, allowing the non-ESM code
to continue working as before.
Bug: 1006759
Change-Id: Ib591e49155000381f85999a5da6c467ad0160996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563
Reviewed-by: Yang Guo <yangguo@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#699728}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e064553334d4b0c925f0b1f0e2e0234be66b71be
2019-09-25 13:14:47 +00:00