Commit Graph
2 Commits
Author SHA1 Message Date
Alex Rudenko 982cb54086 Improvements for the Icon component
- removed mentions of someIcon in the code.
- unified the source for styles and (subjective) made the data flow
more top-down.
- added support for changing the icon color via CSS as I have started
to use it and it is not always possible to change it via JS + it feels
like setting the color can be done without a rerender.

Follow-ups:
- explicit API for masked and background image components
- setting colors only via CSS?

Change-Id: I3b15dc3a1b1039a59fd5e2c5e8d2136e696f7989
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489422
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-10-22 16:10:30 +00:00
Kateryna Prokopenko 704e6d67c1 Icon component
Add a new web-component to simplify adding new/working with icons in DevTools

Bug: chromium:1126031
Change-Id: I37462cad34dae443ea2949fc8f736aa1614b3aa8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2401167
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
2020-10-14 15:04:42 +00:00