zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 09:47:56 +08:00
Code Issues Packages Projects Releases Wiki Activity
6,677 Commits 43 Branches 79 Tags
bbdf7342fee4e6ff7425b6646475fa586bbc8e2d
Commit Graph
23 Commits
Author SHA1 Message Date
Tim van der Lippe 2e38eeaf9f Remove all comments with only the unrestricted annotation 
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 15:25:32 +00:00
Alex Rudenko 69c377e2ad Add APCA to CSS Overview 
Screenshot: https://i.imgur.com/U78yQTJ.png

Bug: 1121900
Change-Id: Id55b8d2a27a44e72db056139df8df71695d08f91
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562701
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-11-30 09:28:08 +00:00
Alex Rudenko c88c76b465 Implement APCA contrast in inspector overlay 
This CL adds APCA contrast to the overlay and reduces some code
duplication between the frontend and the overlay.
APCA contrast will be shown if the experiment is enabled.

Depends on the backend CL: https://crrev.com/c/2545509

Bug: 1121900
Change-Id: I663116289cf4df6358f2aff83a857de06aac901d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546705
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-11-20 17:03:21 +00:00
Alex Rudenko d55e18c512 Add Contrast Issues section to CSS Overview 
This CL adds a new section for contrast issues to CSS Overview.
A follow-up CL will add the contrast information for particular
elements in the grid view.

Screenshot: https://i.imgur.com/8tLlJWF.png

Bug: 1120316
Change-Id: I12dcd269454a43567619c811e4107c00dc8ee654
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2421696
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-09-24 07:24:05 +00:00
Andres Olivares 1e6d9c6358 [ts] Typecheck css_overview/CSSOverviewModel.js with TypeScript 
Bug: chromium:1011811
Change-Id: I7bb1096c6a4e4969f3a849873982c7b66600ff97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2390572
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-07 10:21:09 +00:00
Jan Scheffler e348fe9424 Migrate front_end/css_overview to devtools_entrypoint 
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I406acc5e456237fda0d5c6b468f66d6c0b66fbc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323621
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-28 19:16:12 +00:00
Paul Lewis be87feda70 [CSS Overview] Adds checks for null / undefined 
There are some cases where we don't get back values for styles in the
page, which the CSS Overview code does not handle gracefully. This CL
introduces a couple of checks to handle non-existent values.

R=jec@chromium.org

Bug: 1102704
Change-Id: I689e3245584bec9ef37c5b12f451054128c4bd41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2284822
Commit-Queue: Jecelyn Yeen‎ <jec@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jecelyn Yeen‎ <jec@chromium.org>
 2020-07-07 14:41:03 +00:00
Tim van der Lippe 7946bbcb95 Migrate css_overview/ to import cross-module 
Bug: 1006759
Change-Id: I2130d4ba17bb592090c202cfe2b97da2558e72ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2054544
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-13 17:06:10 +00:00
Tim van der Lippe 9d0cb5f9ee Migrate css_overview/ to ESM internally 
Bug: 1006759
Change-Id: I9119e12293f3765cae9432201d7e94f11352e552
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993340
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 14:58:01 +00:00
Paul Lewis 4da3b30c38 Migrates css_overview/ to esm 
Bug: 1006759
Change-Id: Idf78688fa354b7e169edd508667dd2e298eacea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928914
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-21 14:37:54 +00:00
Paul Lewis 7d10a733de [CSS Overview] Adds font info 
Change-Id: Ia7ed1eccd6a3440e3dbf5b1e98b887ffdaf2b574
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1901387
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-11-07 11:04:05 +00:00
Paul Lewis ed808ce4cf [CSS Overview] Updates UI 
Change-Id: Ifdc7645399b9a5b8dd5d13c8d4dacaf8a67fc5bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1899518
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-06 14:44:25 +00:00
Paul Lewis aae7b10cff [CSS Overview] Adds support for vertical-align 
Change-Id: I1c8b16be97b057b705d2d31a7ed5da25ca815a46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1890672
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-10-30 16:28:56 +00:00
Mathias Bynens fed40c5aa6 [CSS Overview] Normalize valid node names to lowercase 
This fixes a typo that snuck in with https://chromium.googlesource.com/devtools/devtools-frontend/+/69fb9b6aa1c73f942e705aa89d5a94f26429565f.

TBR=aerotwist@chromium.org
Change-Id: I97fdddda3341ff1c82e7fa33fc583d23035273d8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1888210
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2019-10-29 18:36:38 +00:00
Paul Lewis 69fb9b6aa1 [CSS Overview] Broadens ignore list for unused width & height 
TBR=tvanderlippe@chromium.org
Change-Id: I4de339d94e3a06ddce5d660581cb4c45388ae954
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1886825
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-10-29 17:57:28 +00:00
Paul Lewis bcaccf1aae [CSS Overview] Ignore SVGs for unused width & height 
TBR=tvanderlippe@chromium.org
Change-Id: I500b9b6308d495d41714d831c4f48b23479b7524
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1886823
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-10-29 15:22:57 +00:00
Paul Lewis 8aef901f3f [CSSOverview] Add unused rules 
This is the first pass at adding unused rules to the CSS Overview.
The CL adds support for checking width & height to inline elements
as well as position values to static elements. Further CLs will
add additional checks for other cases, e.g. the use of flex or grid
values against non-flex and non-grid elements respectively.

Change-Id: I2fb4fd557d67065a5753587624195920c22b3edc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1886818
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-10-29 14:36:57 +00:00
Paul Lewis 4ab492e695 [CSS Overview] Fixes color values of 'none' 
We currently try and parse computed color values from Blink to
power the CSS Overview. A possible value for the computed value
is 'none', which breaks the capture. This CL skips over 'none'
values since Common.Color will not parse it, and will therefore
return null.

Bug: 1018593
Change-Id: I2c8adb6352c21d52500e0a558ed0627c5824c580
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881557
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-10-28 12:26:09 +00:00
Paul Lewis 12bc63edcd [CSS Overview] Adds support for fill and border colors. 
Change-Id: Iea5c20d1a7b6c3ae6673053e05ff52faee48e69f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1875709
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-10-23 12:00:20 +00:00
Paul Lewis de0224ccdd [CSS Overview] Uses snapshot; adds element highlight 
Change-Id: If58dd20c6f4b3c8f730b39c48c14826e402018a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1873759
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-10-23 09:55:00 +00:00
Paul Lewis ebc4719819 [DevTools] Adds media queries to CSS Overview 
Bug: 1007284
Change-Id: I8c24adddf91da3bd621b61db6eac49233b8a1db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849671
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#704192}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 193ed603a6eaec431f9d0f339f697ab03f99c838
 2019-10-09 15:06:41 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements 
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
 2019-09-30 11:55:34 +00:00
Paul Lewis 8cddf9931f [DevTools] Adds CSS Overview Panel 
Creates a panel that steps through the page to build statistics on CSS
used, such as colors, fonts, specificity, and other items of note.

Note: this is a DevTools experiment.

Bug: 1007284
Change-Id: Ib8d8b2af6bb65d6ff4816ca23b48b76980cd80db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806736
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#700745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e4a3c81f343d15e2121280d332659778ad07323
 2019-09-27 16:40:07 +00:00