Tim van der Lippe
2e38eeaf9f
Remove all comments with only the unrestricted annotation
...
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.
R=szuend@chromium.org
No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
2020-12-02 15:25:32 +00:00
Jack Franklin
60eb00cd2e
[DarkMode] turn off legacy patching in CSSOverviewStartView
...
It has no colours declared in the CSS so we can disable the patching
with no further changes required.
Bug: 1152736
Change-Id: I7d66e17975990276d3342e38edd812a0e7335579
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560243
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-11-25 11:56:27 +00:00
Jack Franklin
71519f8efb
Introduce enableLegacyPatching flag for CSS patching
...
As part of the dark mode migration we are adding
`enableLegacyPatching:true` to all call sites of `appendStyle` (and
related methods). If a user passes `false` for that flag, no CSS colour
patching will occur.
This CL is therefore a no-op from a user's perspective as we pass `true`
on every call to maintain existing behaviour, but once we start
migrating we will turn the option to `false`. Long term, once all code
is migrated and the old patching is removed, we will remove this flag
entirely once again.
Bug: 1122511
Change-Id: I76b818e83b7d5ee0175e1548759373f53481e0ab
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2516345
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-11-03 14:11:46 +00:00
Andres Olivares
3c35a0c13e
[ts] Typecheck css_overview/CSSOverviewStartView.js with TypeScript
...
Bug: chromium:1011811
Change-Id: Ib3676b4182d162724e57718954abe3ff1b96e2a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2396042
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Andres Olivares <andoli@chromium.org >
2020-09-10 16:23:33 +00:00
Jan Scheffler
e348fe9424
Migrate front_end/css_overview to devtools_entrypoint
...
R=aerotwist@chromium.org , jacktfranklin@chromium.org
Bug: 1101738
Change-Id: I406acc5e456237fda0d5c6b468f66d6c0b66fbc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323621
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
Auto-Submit: Jan Scheffler <janscheffler@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-07-28 19:16:12 +00:00
Tim van der Lippe
7946bbcb95
Migrate css_overview/ to import cross-module
...
Bug: 1006759
Change-Id: I2130d4ba17bb592090c202cfe2b97da2558e72ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2054544
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2020-02-13 17:06:10 +00:00
Tim van der Lippe
9d0cb5f9ee
Migrate css_overview/ to ESM internally
...
Bug: 1006759
Change-Id: I9119e12293f3765cae9432201d7e94f11352e552
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993340
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-01-09 14:58:01 +00:00
Paul Lewis
4da3b30c38
Migrates css_overview/ to esm
...
Bug: 1006759
Change-Id: Idf78688fa354b7e169edd508667dd2e298eacea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928914
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-11-21 14:37:54 +00:00
Paul Lewis
8cddf9931f
[DevTools] Adds CSS Overview Panel
...
Creates a panel that steps through the page to build statistics on CSS
used, such as colors, fonts, specificity, and other items of note.
Note: this is a DevTools experiment.
Bug: 1007284
Change-Id: Ib8d8b2af6bb65d6ff4816ca23b48b76980cd80db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806736
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#700745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e4a3c81f343d15e2121280d332659778ad07323
2019-09-27 16:40:07 +00:00
Tim van der Lippe