Commit Graph
6 Commits
Author SHA1 Message Date
Jecelyn Yeen 260d12cc33 Fix stylelint-config-standard issues help/releaseNote.css
Bug: 1083142
Change-Id: Iefed277ca071e49bfabce21f108c2cca694fc34a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279515
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jecelyn Yeen‎ <jec@chromium.org>
Commit-Queue: Jecelyn Yeen‎ <jec@chromium.org>
2020-07-03 05:28:10 +00:00
Mathias Bynens ca9fa2d73f Consistently format CSS color and opacity values
- Prefer the modern comma-free CSS color function syntax over the
  legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
  clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
  the value as a number, again to clarify the range.

[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color

Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
2020-05-19 16:50:26 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-05-15 17:05:27 +00:00
Brian Cui b3a40936b9 Add high contrast support to the What's New tool (Help module)
The What's New tool (internally known as the Help module)
features a list of release notes where each release note is a link to
an external document.

Before: https://imgur.com/a/nJNVMb9

After: https://imgur.com/a/81FLMr3

A light border and margin have been added to each entry in the list
to better distinguish the individual entries. In high contrast mode,
the border color changes to blue on hover to mimic button behavior.
The text color has also been changed to hyperlink text color to
indicate each note is an external link.

Change-Id: Iaa7514a2a2b86ec3e08b50c36b5ae26972310f96
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2032381
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
2020-02-24 19:33:02 +00:00
Brian Cui f0ff36f6b2 Improve What's New Tool Accessibility
This CL improves the accessibility of the What's New Tool
to better support keyboard navigation and screen readers.

 - Release note list now has a label corresponding to the release note
   header that is read aloud when the list is accessed.

 - Release note list item contents have been modified to be a single
   x-link element that wraps both the title and subtitle,
   instead of two x-link elements for title and subtitle.

   This allows the title and subtitle to be treated as a single list
   element accessible by pressing the tab key and read aloud together,
   instead of two list elements read separately and requiring
   the tab key to be pressed twice.

 - Keyboard access to the image link is disabled, as clicking on it
   links to the same page as the Learn More button but otherwise
   lacks a description of its own.

Before: https://i.imgur.com/CeUE3it.gif

After: https://i.imgur.com/sX9lW1E.gif

Bug: 963183
Change-Id: I0e209c445f9ee6915f7dc0274437d70d9d9adf0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1968014
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
2019-12-19 18:37:38 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00