Commit Graph
3 Commits
Author SHA1 Message Date
vidorteg c1aeb6318c Reland "Localization: Migrating Settings Folder"
Relanding the migration of the settings folder that was reverted in here:
2479923: Revert "Localization: Migrating Settings Folder" | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479923

Also including this fix that is required but was also reverted here:
2476336: Fix missing settings/ModuleUIStrings.js in build config | https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2476336

Change-Id: Ie2335e8943e8be3f8363a45d14c93f3b695222e4
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2481510
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
2020-10-22 16:18:20 +00:00
Tim van der Lippe 797136071d Revert "Localization: Migrating Settings Folder"
This reverts commit 392581f676.

Reason for revert: Windows presubmit broke: https://ci.chromium.org/p/devtools-frontend/builders/try/dtf_presubmit_win64

Original change's description:
> Localization: Migrating Settings Folder
>
> This CL is part of the Migration phase, it:
> - Registers i18n locale in main module.
> - Migrates settings folder to localization v2.
>
> Change-Id: I4c20e4a907acacbf41f6dfa84a0dca10cca3a173
> Bug: 1136655
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2445632
> Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
> Reviewed-by: Christy Chen <chrche@microsoft.com>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>

TBR=petermarshall@chromium.org,aerotwist@chromium.org,szuend@chromium.org,vidorteg@microsoft.com,chrche@microsoft.com,tvanderlippe@chromium.org

Bug: 1136655
Change-Id: I4e11c447ecbdfbdf80aeb5cb335f8e132a771b4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479923
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-10-16 15:28:37 +00:00
vidorteg 392581f676 Localization: Migrating Settings Folder
This CL is part of the Migration phase, it:
- Registers i18n locale in main module.
- Migrates settings folder to localization v2.

Change-Id: I4c20e4a907acacbf41f6dfa84a0dca10cca3a173
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2445632
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2020-10-15 17:57:06 +00:00