zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 17:57:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
6,677 Commits 43 Branches 79 Tags
bbdf7342fee4e6ff7425b6646475fa586bbc8e2d
Commit Graph
3 Commits
Author SHA1 Message Date
vidorteg 8bce4b0b83 Enable ModuleUIStrings as a fallback in i18n 
Root cause:
i18n is designed to work with strings that are declared in a UIStrings
object on the SAME file where they are being used. To my best knowledge
this is done to improve performance when searching for a translation,
but in Devtools there are strings that live in module.json files and
are exposed to i18n via a ModuleUIStrings.js file.

Fix:
There is already a mechanism for this kind of templating in the i18n
library which exposes a small subset of translations that match a
specific pattern, the fix is to change this pattern to match
ModuleUIStrings and to also include this as part of the translation
resolution.
Change-Id: If44a84a9b5892558bf832e6d08ea36d1a8f4ddd1
Bug: 1136655
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2459638
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-10-09 01:57:37 +00:00
vidorteg 3e2942e2b8 Removing i18n-bundle.js generation on build time. 
This PR removes the i18n-bundle.js bundle generation, instead the file
is generated beforehand and checked in so it can be consumed like any
other module.

Bug: 1127204
Change-Id: I79e8369269d0cd1885d6d9fc2346dddf3af1a5a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2411415
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-09-17 17:07:18 +00:00
vidorteg ee1553b7cb Localization: Bundling third_party/i18n 
This CL is part of the Infrastucture phase, it:
- Generates a bundle of the third_party/i18n/i18n/js library
using buildi18nBundle script.
- Creates a target to generate the bundle on build time.

Change-Id: Ibacda39751422f5cf8622d318ebf7f153740a7dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2238616
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-07-06 17:40:31 +00:00