zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 12:01:40 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
12737 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon Zünd bedbd4f3fe [e2e] Bump individual test timeout to 10 seconds 
We are landing the timeout increase separatly from enabling the
pool implementation to collect more data for how the windows bots
behave w.r.t. to e2e test stability.

R=jarin@chromium.org

Bug: 1297458
Change-Id: I62d5c6c906031d0ff73adeeed5700fb3cffb391e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3649881
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2022-05-16 09:23:56 +00:00
devtools-ci-autoroll-builder 4fe3f4db96 Update DevTools Chromium DEPS. 
R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ice2a0f946639765507293cff72c99713d33d0721
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3650267
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-16 06:43:48 +00:00
devtools-ci-autoroll-builder e3f224d5f3 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/bcc0ad7..d599ad6

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I27098346a0204b91732dada0685ac29e0ba9f9c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3649238
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-16 05:00:46 +00:00
devtools-ci-autoroll-builder 3909540acd Update DevTools Chromium DEPS. 
R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I73bc10edf261f2e5daf9baedb1514062d19e950e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3649289
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-15 06:39:16 +00:00
devtools-ci-autoroll-builder a2754f4eec Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/ec5340c..bcc0ad7

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Iad24922350f65c886263bc57ab81b663a0baf146
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3649282
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-15 04:42:55 +00:00
devtools-ci-autoroll-builder c0bfb5992b Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/335ffdc..ec5340c

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I768d929af8415ecb747e750592a7f0de24e6f331
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3648977
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-14 12:45:15 +00:00
devtools-ci-autoroll-builder cb9cf3aba9 Update DevTools Chromium DEPS. 
R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I37e3498511b3a0ee022f220317a72d63a42b8cca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3648444
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-14 06:47:44 +00:00
devtools-ci-autoroll-builder 85b77af3bc Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/47e6ce2..335ffdc

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7d20ae0..f8300fb

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I317fb7f993c297c6f8a30f4ed6f08e7db8f0a29c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3648439
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-14 03:51:24 +00:00
Jacky Hu 977cc58cb5 Display non-Color CSSVariable value in style autocompletions 
Previously, ONLY "Color CSSVariable value" will display in style
autocompletions.

This CL will also display "non-Color CSSVariable" value in
autocompletions, without change list order.


How to test:
1. open empty page
2. open devtools
3. add new style to check style autocompletions work.

Before v.s After screenshots:
- https://imgur.com/a/RSxrvnh

After, screen video record:
- https://youtu.be/4seqbcXPz4I


Note:
  If "non-Color CSSVariable value" without "max-width" limitation, will
take too much space. The UX are bad in some case.

screenshot: https://imgur.com/a/EbVgVbb


Bug: 1285091
Change-Id: I01aa6bea8e7802a03c6922e9b2506e44d916aa1d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3603006
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2022-05-13 16:34:44 +00:00
Dave Tapuska 16bfd6147a Add handling of isOutermostMainFrame. 
https://chromium-review.googlesource.com/c/chromium/src/+/3625434
added support for isOutermostMainFrame to discern the
outermost main frame from embedded main frames.

BUG=chromium:1314858

Change-Id: I4aa181b2a863050d2153d29108b5d7b826d9053b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3627073
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
 2022-05-13 14:31:14 +00:00
Jack Franklin 9de44fcb72 Remove nesting above Animations track 
This CL updates the animations track so that it's no longer nested, and
is a top level track as per all the others.

Bug: 1324090
Change-Id: Id9544ec5520c3589ed87ef38ea638d8f5f097925
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645455
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2022-05-13 14:16:44 +00:00
devtools-ci-autoroll-builder 0f177fcc37 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/5f8e23f..47e6ce2

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9997ceb..7d20ae0

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Ib1117257213cbec892aeaff42519aadd4f7c99e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3647337
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-13 12:46:14 +00:00
Ergün Erdoğmuş c71550c756 Add UMA for replay speed in Recorder panel 
Bug: 1306756
Change-Id: I24753e4dad52aa1698c3a7a391edc246dfbd7e12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624020
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2022-05-13 11:45:23 +00:00
Benedikt Meurer cee5205ae9 [autocomplete] Use consistent property sorting order. 
With https://crrev.com/c/3093151 we made it such that whenever we show
object properties, we'd always show the own properties first, followed
by the inherited properties. Even before that, the object display would
already put more emphasis on enumerable properties. So generally the
order within DevTools front-end is:

(1) Own enumerable properties
(2) Own non-enumerable properties
(3) Inherited enumerable properties
(4) Inherited non-enumerable properties

The JavaScript autocompletion for object properties wasn't following
this pattern, but was only sorting own before inherited properties. With
this change, the autocompletion will now favor enumerable properties
over non-enumerable properties, when computing the fuzzy score.

Before: https://imgur.com/Y2JmJwZ.png
After: https://imgur.com/qGEMa8L.png
Fixed: 1299241
Change-Id: Ibd42da9cf6d2947803d2cc0eca1f67f2f3ada55d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645453
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2022-05-13 11:32:44 +00:00
Simon Zünd 8acb7db049 Revert "Reland: [e2e] Use pre-allocated DevTools and target tabs" 
This reverts commit 056ad78a21.

Reason for revert: Suspected to make e2e tests on the windows bot more flaky.

Original change's description:
> Reland: [e2e] Use pre-allocated DevTools and target tabs
>
> This CL relands https://crrev.com/c/3461563.
> The main difference is that while we enable the pool implementation,
> we configure the pool size to be 0 unconditionally. This way, we get
> the benefit of spinning up fresh DevTools and inspected tabs while
> preserving the old behavior of doing the setup of these tabs right
> before a test executes and not in the background.
>
> Original CL description:
> > [e2e] Use pre-allocated DevTools and target tabs
> >
> > This CL changes the conductor to use new DevTools frontend and target
> > tabs for each individual test. A pool prepares a set of frontend/target
> > tab pairs in the background so the conductor doesn't need to waste time
> > resetting tabs in between tests.
> >
> > For debugging e2e tests we disable the pool and use on-demand tab
> > creation instead. It would be annoying to deal with ~12 open tabs
> > and trying to find the right ones in a debugging session.
> >
> > This CL also increases the general e2e test timeout from 5 to 10
> > seconds. This is because of the more volatile nature of e2e tests
> > now. In some edge cases a tab for the currently running test might
> > not get enough CPU time to run in time. This can happen when a
> > serious of short running tests deplete the pool and multiple
> > Devtools frontend instances have to be prepared in the background.
> >
> > R=​jacktfranklin@chromium.org
> >
> > Bug: 1297458
> > Change-Id: I6b6c4a15e5d83f7e2bdc6082972993df179a5d87
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461563
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
>
> Bug: 1297458
> Change-Id: Iac0294116f1a9e762a3847bcb0738955bba957b2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641403
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>

Bug: 1297458
Change-Id: I4758c4c9cb3e7919f12bccc28c9310ab7225c729
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645451
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2022-05-13 10:06:13 +00:00
Simon Zünd ed27b5e2e0 [webtests] Remove duplicate expectation files 
When fixing the -expected.txt files, I mistakenly copied them a
second time on a nested level. This CL removes all expected files
from `platform/generic/platform/generic`.

R=alexrudenko@chromium.org

Bug: None
Change-Id: I822eeb24f9525dc4c7305c3708905f7f1291a1c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645448
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-05-13 08:49:03 +00:00
Wolfgang Beyer 5b433b0844 Add network request context menu entry for creating header override 
This CL adds the ability to create header overrides from the list of
network requests in the network panel via the context menu.

If a local folder for storing local overrides has already been
configured beforehand, the context menu takes the user straight to the
'.headers' file where header overrides are to be specified. If
overrides have not been configured before, the user has to name a
local folder for storing overrides first.

Video: https://i.imgur.com/kLGlOtL.mp4

Bug: 1297533
Change-Id: I8b31fe41d922e1662da68320fcc188c596c0a058
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542245
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-13 08:27:54 +00:00
Adam Raine 89128af9ea Fix Lighthouse web tests for new panel 
The new panel will refresh it's entire content after a runtime setting
is changed. After the first refresh, the web tests were working with
checkboxes that were no longer in the DOM. This CL updates the web tests
so they are always working with the checkboxes in the DOM.

Follow up to:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636197
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643856

Bug: None
Change-Id: I7b315b3310761f40ce4fe5b1cfacd9debebe0966
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645230
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2022-05-12 20:23:03 +00:00
Simon Zünd c61d52fa5c [uma] Add the 'StackFrameRestarted' action 
Backend CL: https://crrev.com/c/3641766

R=bmeurer@chromium.org

Bug: 1303521
Change-Id: I2d7a01df1ddc3695a5e9a83b74ecf5b93d5b06c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643696
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-05-12 19:10:03 +00:00
Andrew Paseltiner ffc9456230 Add description for invalid attribution reporting header issue 
The description here is vague, but because the issue includes both a reference to the original request and the invalid header value, it
should still be more useful to developers than the situation before this
CL, which was for invalid headers to be silently ignored.

We will add additional metadata, such as the name of the invalid header
and the reason why it was invalid, in future changes.

Screenshot of reported issue available in crbug.com/1302318#c4.

Bug: 1302318
Change-Id: Ie7f3b5e34b25ff56d832bf553ffcac674b5a57ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3644629
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
 2022-05-12 16:39:03 +00:00
Benedikt Meurer 7a4563b400 Correct autocompletion for valid identifiers. 
This regressed with https://crrev.com/c/3310606 where `SPAN_IDENT` was
introduced as a filter for properties to show in the autocompletion box
when using the dot MemberExpression syntax. The `SPAN_IDENT` regex looks
wrong and unnecessarily complicated.

This change uses the ID_Start and ID_Continue unicode property escapes
instead, so we get the right match here.

Fixed: 1324466
Bug: 1275553
Change-Id: I6f0d57771a7370ca761df8a62d488586992e9e3a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3644947
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2022-05-12 14:46:23 +00:00
Simon Zünd 20e371365a [e2e] For debugging, pause when tabs are ready 
Enabling the pool delayed tab creation into the `beforeEach` block.
So when we pause in the `beforeAll` block in debug mode, the DevTools
and target tab are not yet booted up.

This CL moves the pause into the `beforeEach` block but still only
pause once.

R=pfaffe@chromium.org

Bug: 1297458
Change-Id: Ic3f1ddc41696d4e11c6797effc20d1101399d163
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3642145
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-05-12 13:36:43 +00:00
devtools-ci-autoroll-builder 656e9fdf28 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/1c34f36..5f8e23f

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/31bfd51..9997ceb

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Iebf68dfbb1ed6c45cde505b9a13810e54569d7ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3644333
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-12 13:32:44 +00:00
Saba Khukhunashvili 8ebbcde43f Fix the + sign to add a new CSS rule overlaps with text 
This CL changes the height of the new rule toolbar to avoid it from overlapping last CSS rule (crbug/1225603) or CSS Rule Copy button (crbug/1297825).

Before and After changes:
Overlapping the Copy button - https://imgur.com/a/bebtU8S
Overlapping the CSS rule - https://imgur.com/a/3N59D18

Bug: 1225603
Change-Id: I0070dad33d1db29a1aca5a6ae796bcd4ff3d9100
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643698
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Saba Khukhunashvili <khukhunashvili@google.com>
 2022-05-12 11:00:03 +00:00
Simon Zünd 36c54939b9 [web tests] Move expected files to the new location 
Expectation files moved upstream in Chromium so we also have to
mirror the new structure in DevTools.

R=alexrudenko@chromium.org

Bug: None
Change-Id: I934d40bf371c3155ff013d3fc3be59ff734ce51e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643856
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2022-05-12 10:41:03 +00:00
Simon Zünd 88319e1b40 [l10n] De-duplicate deprecation message UI strings 
Locked terms are implemented as placeholders that are always replaced
with the same value. That means that many of the UI strings in
DeprecationIssue.ts are currently duplicates.

The TC does not like importing duplicated strings, so we de-duplicate
them in this CL.

R=kimanh@chromium.org

Bug: None
Change-Id: I79997be64c57107f34622b808b9a9adff34123ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3642144
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2022-05-12 10:27:43 +00:00
Alex Rudenko ce49c72ced add a whitespace 2022-05-12 11:08:38 +02:00
Ari Chivukula f61305e82b [deprecations] cleanup by rolling deps 
Some constants were removed in chromium but not devtools. Let's clean
that up before the M103 branch cut.

DISABLE_THIRD_PARTY_CHECK=AttributionReportingIssue and DeprecationIssue compile fixes

Bug: 1264960
Change-Id: I9e70771f9d6d51860aa7410dee8f18598bee2375
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3642436
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-05-12 08:40:22 +00:00
Simon Zünd 270c221862 [deps] Roll Chromium dependencies 
R=kimanh@chromium.org

Bug: None
Change-Id: If9bfd8662ff3492cf2d40abadadd59e6b48ba37f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641406
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2022-05-12 07:55:23 +00:00
Adam Raine 70d4a90431 Enable FR Lighthouse panel by default 
There really isn't any reason to keep the old panel after this.
Legacy navigation mode will still be accessible through it's option
in the Lighthouse settings. This CL is just the quickest way to enable
the new panel by default.

Bug: 1291284
Change-Id: I332753718e88e3c94ba0bdf493c108846f7ff8b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636197
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2022-05-12 07:05:07 +00:00
devtools-ci-autoroll-builder 08ba08dd2c Update DevTools Chromium DEPS. 
R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I39711cc168da47b891a93299fc6570f97249315e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3643556
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-12 07:04:05 +00:00
Adam Raine 50fb83d1ec [Lighthouse] Roll Lighthouse 9.6.1 
Bug: 772558
Change-Id: I75b6b6b55bf0fdff09c6c6bfd5d4d2ee82afdf10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3642441
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-05-12 07:03:02 +00:00
Andrew Paseltiner 78b18bbe53 Remove obsolete Attribution Reporting issue MD files 
Change-Id: Id54a7fc03b9cc1691ea1deacb9f32bc77ff8701f
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641939
Auto-Submit: Andrew Paseltiner <apaseltiner@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2022-05-12 07:01:59 +00:00
Johan Bay f2ac64a53a Add test for revealing assigned slot elements 
Bug: none
Change-Id: I04c2b99d05c121b7b39733686b5b118ec8edc78a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3642136
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Johan Bay <jobay@chromium.org>
 2022-05-11 15:50:55 +00:00
Kateryna Prokopenko 6fe58b6ee5 [DOMStorage] Generate protocol resources in the frontend 
Fix AttributionReporting and Deprecation issues handling
wrt protocol changes made

DISABLE_THIRD_PARTY_CHECK=<Protocol update>

Bug: 1313434
Change-Id: I7cddbbee4409cbe52181cdd1766013fa001d07c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641418
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2022-05-11 15:44:02 +00:00
Kateryna Prokopenko accc9959c9 Type path and URL variables in part of panels/ to Branded Types 
Bug: 1299786
Change-Id: Ifddd6b24407ff35c00287e28b971a84962065cf5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629864
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2022-05-11 14:26:46 +00:00
Kateryna Prokopenko 39b88f8c2e Type all path and URL variables in ui/components to Branded Types 
Bug: 1299790
Change-Id: Ic9534e960c531b1027d8e4baa98364f16255fb63
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629863
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-05-11 14:13:22 +00:00
devtools-ci-autoroll-builder a05cd6fe66 Update DevTools DEPS. 
Rolling buildtools/linux64: git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35..git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: Iadf65fe6280e88a69205b486cc88bba21f519dbf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3640176
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-11 13:48:28 +00:00
Randolf J 5cbcb68e9a Update puppeteer from 13.1.1 to 14.0.0 
Bug: none
Change-Id: I157e7f5ddff43eb17fe371cc1437a636ad42cd4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641417
Commit-Queue: Randolf Jung <jrandolf@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2022-05-11 13:38:33 +00:00
Saba Khukhunashvili b6327d5184 DevTools: Tidying up the styles context menu 
This CL changes ordering and adds two section in styles context menu to match the UI that was proposed in crbug.com/1317596.

Screenshots
Before making the changes: https://screenshot.googleplex.com/5BfmGY5fsUnrRh8
After: https://screenshot.googleplex.com/3JQHVV2DF5xUtKV

Bug: 1317596
Change-Id: Id29bf33245087b247e5e7df88c33b158921f1048
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629866
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Saba Khukhunashvili <khukhunashvili@google.com>
 2022-05-11 12:31:02 +00:00
Jack Franklin 8920120bff Remove "Interactions=>Input" swimlane in Performance Panel 
Fixed: 1324090
Change-Id: I7eed96829032e45addc9960abf3cb7d538ab12ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3635178
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2022-05-11 11:42:15 +00:00
Wolfgang Beyer 1016a48de6 Avoid separate function for InspectorFrontendHost.clearFileSystem 
Move `clearFileSytem()` functionality into the `removeFileSystem()`
method. https://crrev.com/c/3620364 which initially added this method
caused console errors because `initializeInspectorFrontendHost()`
iterates over all properties.

Bug: 1313436
Change-Id: I3244f8c976daaf093e95d94e9ddb1074a1f08d5c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641411
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-05-11 10:38:28 +00:00
Kateryna Prokopenko fbb2247690 Type all path and URL variables in ui/legacy to Branded Types 
Bug: 1299791
Change-Id: I3648366445238aeb30fa699556fa9d9a4ee937e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3629859
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-05-11 09:39:12 +00:00
Jaroslav Sevcik 481104acc0 Expose and test scope tree parser 
This patch exposes the scope parser for wider use so that we can
reuse it for resolving source map names in scope view.

The parser is currently only exercised by several newly introduced
unit tests.

Bug: chromium:1322115
Change-Id: If3ffe0e87cac7e0cb557f60e83d9266193adde73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3624642
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
 2022-05-11 09:00:52 +00:00
Simon Zünd 056ad78a21 Reland: [e2e] Use pre-allocated DevTools and target tabs 
This CL relands https://crrev.com/c/3461563.
The main difference is that while we enable the pool implementation,
we configure the pool size to be 0 unconditionally. This way, we get
the benefit of spinning up fresh DevTools and inspected tabs while
preserving the old behavior of doing the setup of these tabs right
before a test executes and not in the background.

Original CL description:
> [e2e] Use pre-allocated DevTools and target tabs
>
> This CL changes the conductor to use new DevTools frontend and target
> tabs for each individual test. A pool prepares a set of frontend/target
> tab pairs in the background so the conductor doesn't need to waste time
> resetting tabs in between tests.
>
> For debugging e2e tests we disable the pool and use on-demand tab
> creation instead. It would be annoying to deal with ~12 open tabs
> and trying to find the right ones in a debugging session.
>
> This CL also increases the general e2e test timeout from 5 to 10
> seconds. This is because of the more volatile nature of e2e tests
> now. In some edge cases a tab for the currently running test might
> not get enough CPU time to run in time. This can happen when a
> serious of short running tests deplete the pool and multiple
> Devtools frontend instances have to be prepared in the background.
>
> R=​jacktfranklin@chromium.org
>
> Bug: 1297458
> Change-Id: I6b6c4a15e5d83f7e2bdc6082972993df179a5d87
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461563
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1297458
Change-Id: Iac0294116f1a9e762a3847bcb0738955bba957b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641403
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
 2022-05-11 08:40:14 +00:00
Changhao Han 13849a4722 Add copy changes button conditionally 
This CL adds the copy changes button back only when there are changes to
copy.

Bug: 1313707, 1268754
Change-Id: Ia9aa575f20efef14cc0948c7cf50df1c9703797c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3638000
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-05-11 08:36:32 +00:00
Jaroslav Sevcik 7cf7079ca2 Ignore closed-connection errors in uknown messages 
Chromium newly sends an error after receiving a message for unknown
session ID. This patch ignores unmatched responses if their error
code corresponds to the unknown session ID error.

Bug: chromium:1324237
Change-Id: Ia58a5c39d398aa68a4802d6afdad205686c5969f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3637997
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2022-05-11 07:20:32 +00:00
devtools-ci-autoroll-builder 6f7112d845 Update DevTools DEPS. 
Rolling build: https://chromium.googlesource.com/chromium/src/build/+log/0c23713..1c34f36

Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cb2cef9..31bfd51

R=machenbach@chromium.org,liviurau@chromium.org

Bug: none
Change-Id: I267fd1fd840b9be5d497995a42f4aae681a5819e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641115
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2022-05-11 03:44:31 +00:00
Kent Tamura 9688552c89 Remove the deprecation message for SelectionAddRangeIntersect 
The corresponding Chromium change:
    https://chromium-review.googlesource.com/3631043

Bug: 353069, 1320361
Change-Id: I03b6d7e8ebfd582ed4960d0f6070a8412d2d2e1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636620
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
 2022-05-11 01:24:31 +00:00
Adam Raine e3940b051c Center Lighthouse screenshot overlay 
Bug: null
Change-Id: I5d27424698a7474a1ed18e17551f0f2703930d0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3639664
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2022-05-11 00:02:01 +00:00