zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 20:39:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
28 Commits
Author SHA1 Message Date
Liviu Rau 49c262f1ca Make auto-roller account an owner of DEPS 
Bug: chromium:1235962
Change-Id: If17b9303db522578fba6ae37957d174740176bcb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3161988
Reviewed-by: Tamer Tas <tmrts@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2021-09-15 12:53:29 +00:00
Tim van der Lippe 46244285d4 Cleanup TypeScript configuration files and root OWNERS 
This moves the required TypeScript configuration files into
/config/typescript/, which allows us to cleanup the root OWNERS.
Doing so will make it easier to make infrastructure refactorings
in our TypeScript configuration (if we for example need to add
a new file), while not requiring ENG_REVIEW_OWNERS.

DISABLE_THIRD_PARTY_CHECK=Configuration changes
R=yangguo@chromium.org,szuend@chromium.org

Bug: none
Change-Id: Icffd52d37c37b52651dc8125948dc90b2b79cdf5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2975287
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-22 10:45:59 +00:00
Simon Zünd 607774ad1a [lint] Enable typescript-eslint type checking 
This CL is a rebased version of https://crrev.com/c/2095304 after
we fixed our tsconfig.eslint.json and allows the usage of ESLint
rules that require type information.

DISABLE_THIRD_PARTY_CHECK=Enabling this requires code changes
R=tvanderlippe@chromium.org

Bug: 1057042
Change-Id: I329898c61551da10a67f91b76665e284d56e633e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2963818
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-06-16 12:07:45 +00:00
Tim van der Lippe 732be58da1 Move *.gni files from root to config/gni 
This allows us to clean up the OWNERS as well and add a single
OWNERS file in /config/gni to allow all COMMON_OWNERS to make
changes to these files.

DISABLE_THIRD_PARTY_CHECK=File move
R=yangguo@chromium.org

Bug: 1187573
Change-Id: I989caf2762e75725d22fa80f573c72bcf6570dd8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2817617
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-12 11:06:13 +00:00
Tim van der Lippe 2e143870f7 Move owners files into config/owners 
The separate *_OWNERS files are related and can be grouped together
in a folder to make this distinction clear. This will allow us
to update the PRESUBMIT script to explicitly mark them as
exclusive change directory.

Note that the directory is named "owner", as we can't name it
"owners" as that is case-insensitive equivalent to "OWNERS",
which Windows can't handle in its presubmits.

DISABLE_THIRD_PARTY_CHECK=OWNERS update
R=yangguo@chromium.org

Bug: 1187573
Change-Id: Ib94a544c9dc01f788a8b75a5c8111ab52fbc27b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2814658
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-04-08 12:25:52 +00:00
Tim van der Lippe 20e5ff211a Add ARCHITECTURE.md 
This document describes the high-level architecture of DevTools. While
not complete yet, this version adds the guiding principles and explains
the core-feature model used in the DevTools startup process.

Future updates will include an explanation of how individual high-level
features are implemented and what their building blocks are.

DISABLE_THIRD_PARTY_CHECK=OWNERS update for new file

Bug: none
Change-Id: I589ae3f646094ec92c27336b6282006ab4534d7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2791341
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-04-07 07:00:59 +00:00
Paul Lewis 6c0b15e0dc Adds global list of files expected for the GRD 
We've found that files missed from the GRD cause issues in Chromium,
since it looks to the GRD/pak in order to serve the DevTools frontend.
Standalone builds of the DevTools frontend (as well as using
--custom-devtools-frontend in Chromium) do not present with the issue,
since in those cases the files are loaded directly from disk (rather
than via the GRD/pak file).

This CL introduces two new lists: a global list of files required for
the Release build (is_debug=false) of Chromium, and a second list of
files required for the Debug build (is_debug=true). These lists are
cross-referenced to ensure no overlap, thus in Release we use the first
list, and in Debug we use both.

In the root BUILD.gn we now check that files that are inputted to the
GRD builder action map exactly to the list of files expected for the
GRD, and any mismatch causes a build failure.

R=danno@chromium.org

DISABLE_THIRD_PARTY_CHECK=Adding owners and file at the same time

Change-Id: I5e215eb5dc249123ab07210baa3eeb00da225410
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2324586
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Daniel Clifford <danno@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-30 20:00:00 +00:00
Tim van der Lippe 41a98a8833 Move copy_inspector_images to Images/ 
DISABLE_THIRD_PARTY_CHECK=Update images GN configuration
R=aerotwist@chromium.org

Change-Id: I85eaf0f5c202160831c655fabdae279c770060c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2300108
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-16 10:18:25 +00:00
Tim van der Lippe 30bd62f708 Reset OWNERS of BUILD.gn to INFRA_OWNERS 
This effectively reverts
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2252010

R=yangguo@chromium.org

Fixed: 1097043
Change-Id: I063febf4f9f7c21d14b8cf6844b6b100009aa6f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2294983
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-07-13 15:12:49 +00:00
Tim van der Lippe 334be38e4a Move devtools_module_entrypoints to separate gni file 
DISABLE_THIRD_PARTY_CHECK=Add owner access to new file
R=yangguo@chromium.org

Bug: 1097043
Change-Id: I93f65c9bdd1f0e4418738a3bc27ba6b4fdad1e42
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2256984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-07-13 14:50:59 +00:00
Tim van der Lippe 85f1494179 Move all_devtools_files to separate gni file 
DISABLE_THIRD_PARTY_CHECK=Add owner access to new file
R=yangguo@chromium.org

Bug: 1097043
Change-Id: I577f317ab5371b73bf135aa501594ed7ef6ced3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2256983
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-07-13 14:27:29 +00:00
Tim van der Lippe 5822c1a2fc Move all_devtools_modules to separate gni file 
This allows us to give COMMON_OWNERS edit access, while all other
build scripts remain INFRA_OWNERS access. Moreover, this should
make reading and traversing /BUILD.gn easier.

DISABLE_THIRD_PARTY_CHECK=Add owner access to new file

Bug: 1097043
Change-Id: Ic2d9cfa89bc6f24b7b89817d1118f5b5ffb2d188
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2256982
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-07-13 14:17:39 +00:00
Yang Guo 7ca83b2245 Allow COMMON_OWNERS to review BUILD.gn 
R=tvanderlippe@chromium.org

Change-Id: Idbf11a3aff2553b3aa4ecbb16fe2b6ac17ee9571
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2252010
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-06-19 12:49:11 +00:00
Yang Guo 2b1843a570 Fix ownership of README.md 
TBR=tvanderlippe@chromium.org

Change-Id: I428968ee35cb2d0daf6009323c9918aef303b289
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2203439
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-15 07:57:36 +00:00
Yang Guo 74e1a7aa26 Assign owners to hidden files in root 
R=tvanderlippe@chromium.org

Bug: chromium:1082687
Change-Id: I9cb5df8b2386fa8482b01230b429403651aac6e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201640
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-14 14:00:15 +00:00
Yang Guo b8584478dd More specific OWNERS where appropriate 
DISABLE_THIRD_PARTY_CHECK=no code change

Change-Id: I02f6ae91f7412c287ecf931e5681c1c882faa26c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198956
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-14 06:52:14 +00:00
Benedikt Meurer f450d479cd Add petermarshall@ to OWNERS. 
Change-Id: Ibbd5b9c526c0b890a54f5b92f2b2d0cc3873f8f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2115632
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2020-03-25 08:26:23 +00:00
Yang Guo d8e762cd82 Add Jack to OWNERS 
R=aerotwist@chromium.org

Change-Id: I967bde6842785c20b82b9193304eecf0b8a312ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077177
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-02-27 07:01:26 +00:00
Yang Guo e09835e772 Add more OWNERS 
R=bmeurer@chromium.org

Change-Id: Ibb578dc5817ce5a24cce8ab52849fe2a3aa4f9fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2046546
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-02-10 08:40:20 +00:00
Michael Achenbach 75ba8e350e Add some infra ownership 
DISABLE_THIRD_PARTY_CHECK=true

Bug: 1026215
Change-Id: I068203abb73369aab71c2b9869b984373fe0f8c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1946474
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2019-12-02 20:34:58 +00:00
Yang Guo 699c3a9195 Add more OWNERS 
Change-Id: I52e1a7da743f16a28aefaeba868303ca0bf0994b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881549
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2019-10-28 06:45:59 +00:00
Yang Guo 4fd355cc40 Switch to new repository 2019-10-21 08:08:56 +02:00
Yang Guo 1b0e57d3d2 DevTools: add more OWNERS 
Change-Id: I87d875c4ddc9fe23a7b9c200165443f84818623a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838193
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#703655}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca20c5f635df67838d738ef466788455b3d4d0fc
 2019-10-08 10:56:03 +00:00
Darin Fisher 8b7b7f6c58 Add Yang to DevTools OWNERS files 
Change-Id: I582a045d083c6db25f11bd40f31533f8529c3057
TBR: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803956
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#696570}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 15aeb621986301bbd2696bf44fc5581e6b184d02
 2019-09-13 22:59:20 +00:00
Erik Luo bcf183566d DevTools: update OWNERs 
Bug: none
Change-Id: I7a2ff34e551347750e6c3ed0e79fdd96b72591f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686859
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#674714}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2573ed56a83b39ae26122f061a869cdb98761b98
 2019-07-04 03:38:42 +00:00
Joel Einbinder 81442c5a3b DevTools: add einbinder as devtools owner 
Change-Id: I628655341259d256d98037d8e54cda945dc0e543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626032
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Auto-Submit: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#662361}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a47c9ce53008f74b64404c49ff0998882cf94f93
 2019-05-22 21:52:42 +00:00
Lei Zhang e532bec7e1 Remove gyp entries from OWNERS files. 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4198a7bdd11b350d04436c0048977d13f4f50c88
Reviewed-on: https://chromium-review.googlesource.com/1066323
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560798}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f64c15ce542dfb0d36e0ea358b87413ab8a649ab
 2018-05-22 21:56:52 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00