Commit Graph
27 Commits
Author SHA1 Message Date
Mathias Bynens 54303dcc64 Unify developer-facing and user-facing short URLs
For any shortened URLs:

- Use goo.gle for Google Docs and chromium.org target URLs.
- Use g.co for everything else.

Bug: chromium:1321016
Change-Id: I09099dc62b92a14fa68d62155953262328476db2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613872
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2022-04-29 10:46:23 +00:00
Paul Lewis 2906222f2a Update Chromium source references
Some comments in the code refer to the master branch. This CL updates
those comments to refer to the main branch instead.

Bug: 1226943
Change-Id: Ib01747a447f7fc462ed92ba2fbb961cd12c3e490
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3009819
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-07-07 10:11:57 +00:00
Jack Franklin 870ce573d2 Change links in README to not link from "here"
This is a tiny thing, but whenever I try to find the workflow links, I
_always_ miss the "here" text which is the link to docs/workflows.md. So
I've changed it to make the link name the file to make it stand out more
and hopefully make it clearer.

Bug: none
Change-Id: I59db2882a867613d87c8dd1e2a8010261b4ec41f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2666687
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-02-02 07:52:48 +00:00
Mathias Bynens 1ff270d3e6 Fix typo in link to triage guidelines
Change-Id: Ic053d35942147afa5777d62448585eb02917e968
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2256979
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-06-22 09:15:02 +00:00
Yang Guo 03e780ed1a Update and re-organize documentation
R=mathias@chromium.org, tvanderlippe@chromium.org

Bug:chromium:1095988
Change-Id: I72a27a91b0e8c5455dc851d73b62c9b11594b450
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2249662
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2020-06-17 10:55:47 +00:00
Tim van der Lippe 78f57416d0 Remove debug_devtools flag from devtools-frontend
This removes the build support for debug_devtools, which is replaced
by the runtime flag `--custom-devtools-frontend`.

This depends on https://chromium-review.googlesource.com/c/chromium/src/+/2224216
to land in Chromium first.

DISABLE_THIRD_PARTY_CHECK=Cleanup of build scripts
R=yangguo@chromium.org

Bug: 1087379
Change-Id: I4494e111cab67e752d6dfad83cc9edb90df73a3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2224799
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2020-06-08 11:27:55 +00:00
Brandon Goddard f8f37d164e Automatic Symlinked workflow
This CL introduces an alternate approach to the integrated workflow
that allows users to use a single gclient project to manage both
chromium/src and devtools-frontend.

It also adds a scripts and instructions for how to install as a hook
to ensure that running `gclient sync -D` no longer removes
the symlink to the devtools-frontend when using the integrated workflow

*Note that the hook can be used regardless of using the single gclient
project if the path to the non-symlinked devtools frontend is inserted
in the .gclient project file for chromium/src

Change-Id: I235ff713964fd02d9cec40e07e88e9d7b68dcf16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209366
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2020-05-26 19:38:30 +00:00
Tim van der Lippe ee4594721a Add section on the legacy debug_devtools GN flag
R=yangguo@chromium.org
CC=alexrudenko@chromium.org

Change-Id: Ie7978f92a3d68a30a1a7ca56c0e5ac85fd9d23e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2207321
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2020-05-19 10:30:26 +00:00
Michael Hablich c73ffd7613 Add issue triage guidelines
Bug:1022301
Change-Id: Ibb1e3adec0b4507b1b838a979871a0474a935f6f
R=yangguo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2194878
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2020-05-18 12:39:41 +00:00
Tim van der Lippe 76b3969cd8 Update README regarding rolling of dependencies
This section was previously hidden in the collapse details of the
second workflow. However, it is related to both the first and the
second workflow and therefore should be moved out.

Additionally, explicitly call out that it requires one of the first
two workflows to work, given its dependency on `gclient sync` as
well as the requirement for the DevTools infrastructure versioning
(which is different from the infrastructure as part of Chromium).

R=brgoddar@microsoft.com

Change-Id: I060351116ae79fe35f075f17de043762f486ccfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2162889
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
2020-04-24 15:04:12 +00:00
Tim van der Lippe 9c4cd88341 Update instructions for rolling Chromium dependencies
For the protocol roll, the build artifacts need to be checked in,
which `npm run generate-protocol-resources` does for us.

R=yangguo@chromium.org

Change-Id: I65bdb0b2e863772f397f345dc2d4da00334aa71b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144167
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2020-04-14 15:54:55 +00:00
Benedikt Meurer 9b87180127 Fix DESIGN_GUIDELINES.md link in README.md.
Taken from https://github.com/ChromeDevTools/devtools-frontend/pull/158

Tbr: hablich@chromium.org
Change-Id: I37ed317cb5d42744df501877ee74d69ad152275d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2113376
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2020-03-23 07:44:00 +00:00
Tim van der Lippe 047eb488f5 Update README to recommend the integrated workflow
For active maintenance by engineers who regularly contribute to
DevTools, the integrated workflow is strongly recommended. Therefore,
move this workflow up in the README to make it more prominent.

The other workflows are supported for smaller changes, so they will
remain listed in the README.

R=sigurds@chromium.org,yangguo@chromium.org,aerotwist@chromium.org

Change-Id: I967c37ba5abbdab026a3f61ad777d9c6b57894c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088095
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-03-05 12:18:33 +00:00
Tim van der Lippe 91e71b3c5d Update README with format and check command
The `npm run format-py` should not be used, as it does not use
clang-format. `git cl format --js` is the appropriate formatting
command.

Moreover, we did not reference the `npm run check` command in the
README. Since we run these checks on CQ, we should include it.

Change-Id: Id0d9f1fefebc980b122e62e48e66a626df122e26
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002605
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
2020-01-15 19:05:53 +00:00
Simon Zünd 4b6d9afe20 Fix broken link to Omahaproxy in README.md
Change-Id: I214b3d767106c9889ae2a6f2ecc0084b52c2890d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953611
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2019-12-06 10:02:30 +00:00
Yang Guo ec1a1b9a3d Update README with instruction to use fetch
R=mathias@chromium.org

Change-Id: I09c2ceb7f9200e8b32eb34b2b171a7e5bd02258c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1936207
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2019-11-26 09:41:25 +00:00
Michael Hablich c951b2daa4 [Docs] Add information on how to merge
R=yangguo@chromium.org
BUG=1021467

Change-Id: I44999e25e34f6f3a5013d5a4b1ac098107398413
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928915
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Michael Hablich <hablich@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2019-11-21 11:47:44 +00:00
Michael Hablich 37becd02a0 [Docs] Add description about design review guidelines
Change-Id: I203fd6e4a8c471398d20e6c7a615153f99806beb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1897675
Commit-Queue: Michael Hablich <hablich@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2019-11-12 22:07:40 +00:00
Tim van der Lippe 9fc8e6d2fd Add extra note for standalone Chromium build
It took me a while to configure the standalone build, but eventually I
realized that I should not include the trailing slash. (I was using
tab-auto-completion on my terminal which adds the trailing slash by
default)

Change-Id: I1fa1a8912d49ae56388c8504cbeae41533e556f0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1899513
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2019-11-05 13:56:06 +00:00
Tim van der Lippe 4adb513598 README fixes
- Fixes broken headers
- Fixes custom-devtools-frontend command on Mac
- Add link to test waterfall

Change-Id: Ibfe0595068c59d6ff97960f8efbfee23587a76f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1893083
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2019-11-01 14:09:03 +00:00
Yang Guo 736b04307a Update README.md
R=aerotwist@chromium.org, tvanderlippe@chromium.org

Change-Id: I90f0eed99903870131096b3e775c45737c3145b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1890670
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2019-10-31 10:53:21 +00:00
Yang Guo 8b7e69e7eb Extend README.md by instructions to integrate standalone checkout
R=mathias@chromium.org

Change-Id: Ie112adac4045a23f922d2610e9d068c06dedbe3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1872586
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2019-10-22 09:29:44 +00:00
Mathias Bynens 544479c489 Remove broken link
beverloo@ is no longer maintaining the feeds. The link results in
a certificate error. This patch removes the broken link.

Change-Id: Id3d75ba1cfa1556b8305c03158f25fb0e950f85f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1871872
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
2019-10-21 12:59:51 +00:00
Yang Guo 566db28a0a Fix run instructions in README.md
TBR=janscheffler@chromium.org

Change-Id: I5c69ccb4fb4c311a7f025735b4691bcafdb75c58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1872029
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
2019-10-21 12:56:21 +00:00
Benedikt Meurer 3baead5b5b Update default out directory to be in sync with what Chromium uses.
The default out directory is now `out/Default` as it seems to be the
new standard in Chromium. Also add the missing `cd devtools-frontend`
step to the Build step.

Change-Id: Idf499c4ead866f4bbd1f0ec8a1d221aeb1ed9c93
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1871873
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2019-10-21 11:28:22 +00:00
Yang Guo 2b9efe8ce6 Update README.md wrt build instructions
Change-Id: I6e9b25b9850afb1be2e56b94ed2d0fa9f6842885
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1871870
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2019-10-21 10:59:01 +00:00
Yang Guo 4fd355cc40 Switch to new repository 2019-10-21 08:08:56 +02:00