zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 12:01:40 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
167 Commits
Author SHA1 Message Date
Changhao Han 34c39bcabc Add basic structure for rendering shortcuts 
Bug: 1314299
Change-Id: I45d7b66ac04d21404bfedac7e6d738694f628ebc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3575945
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-04-08 10:53:37 +00:00
Wolfgang Beyer 74705f0911 Add plus and minus icons 
(to be used in the editor for header overrides)

Bug: 1297532
Change-Id: I43e035c63b639b792496beab813086b653a42ef1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3494383
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-03-01 10:25:48 +00:00
Johan Bay 52f5be82ff Add @layer support in styles sidebar pane 
This CL provides support for @layer rules by providing two features:
1. we now separate the matched styles in the styles pane by their layer
to make it easier to see which layer each rule belongs.
2. we provide a layer overview widget that shows the layer tree for the
tree scope of the currently inspected element.

Screenshot: https://imgur.com/a/CxFrKyc

Doc: https://docs.google.com/document/d/1J7mvg-5eFsLhKLRkd7-mwdIxxDgt2fq1lhOTw47Df6E/edit?usp=sharing
Change-Id: I6fbffc7e272303e942af733029059a0a98771283
Bug: 1240596
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484212
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2022-02-25 13:56:51 +00:00
Tim van der Lippe 37b423ad6e Add back triangles for code folding 
With CodeMirror 6 we were using the default CodeMirror styled arrows,
whereas with CodeMirror 5 we had a custom version. After user feedback,
we opted for adding back the original arrows and move the code folding
buttons to the right of the line numbers.

We use the expand/collapsed arrows in various places, but they use the
legacy UI `smallIcons.svg` built with webkit mask images. To avoid
relying on the legacy icons, I opted for using the modern `Icon.ts` by
introducing new arrows for collapsing and expanded. These arrows should
be visually equivalent to the legacy versions. Please see the screenshot
below for the new CodeMirror 6 version.

Image: https://imgur.com/a/jyHQFkc

R=petermueller@chromium.org,yangguo@chromium.org

Fixed: 1299364
Change-Id: Ic8921229c3657fa4ad404d7c38a80ccc192e1319
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3480038
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-22 15:14:17 +00:00
Changhao Han 6509c35f86 Add copy all changes to the Styles pane 
Screencast: https://imgur.com/a/s98Bjwn

Design doc: https://docs.google.com/document/d/1jj9I7ANHh06tbCG6TtcZzd7vqa7hoQNWhOBSku5hKjA/edit

Architecture doc: https://docs.google.com/document/d/1zkOWg1OlUYudFjgqMFvZy1HuOCcrHUFho55q94MowtM/

Bug: chromium:1268754
Change-Id: I85c6b5ef75071193b3e32612bc75a1fbb32ab85a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3455486
Reviewed-by: Johan Bay <jobay@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-02-14 17:17:19 +00:00
Tim van der Lippe 28af9fbe78 Reland "Do not overwrite generated files when contents remains the same" 
This reverts commit aaae6b021a.

Reason for revert: always check if tsconfig.json needs to be updated

Original change's description:
> Revert "Do not overwrite generated files when contents remains the same"
>
> This reverts commit c1e414725a.
>
> Reason for revert: Seems to be the cause for CQ compilation errors:
> https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview
>
> Original change's description:
> > Do not overwrite generated files when contents remains the same
> >
> > To ensure that build timestamps don't unnecessarily cause full rebuilds,
> > make sure that we only write the generated contents to a file (if it
> > exists already) if it would be the same. This ensures that the file
> > timestamps remain the same, which will lead GN to conclude that the
> > build action is a noop (which it is).
> >
> > On a new year, the file contents would actually be different, so it
> > would cause a proper rebuild. However, in all months between when the
> > timestamp changes, it won't cause is unnecessarily to rebuild all these
> > files, even though the year hasn't changed (but the timestamp it was
> > based on did).
> >
> > R=​jacktfranklin@chromium.org
> >
> > Bug: 1283883
> > Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
> > Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
>
> Bug: 1283883
> Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583
> Auto-Submit: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 1283883
Change-Id: Iae23d721bdeb4c8af227903a38255ee9fc1bc49d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386675
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-13 15:20:09 +00:00
Simon Zünd aaae6b021a Revert "Do not overwrite generated files when contents remains the same" 
This reverts commit c1e414725a.

Reason for revert: Seems to be the cause for CQ compilation errors:
https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview

Original change's description:
> Do not overwrite generated files when contents remains the same
>
> To ensure that build timestamps don't unnecessarily cause full rebuilds,
> make sure that we only write the generated contents to a file (if it
> exists already) if it would be the same. This ensures that the file
> timestamps remain the same, which will lead GN to conclude that the
> build action is a noop (which it is).
>
> On a new year, the file contents would actually be different, so it
> would cause a proper rebuild. However, in all months between when the
> timestamp changes, it won't cause is unnecessarily to rebuild all these
> files, even though the year hasn't changed (but the timestamp it was
> based on did).
>
> R=​jacktfranklin@chromium.org
>
> Bug: 1283883
> Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: 1283883
Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2022-01-11 09:29:14 +00:00
Tim van der Lippe c1e414725a Do not overwrite generated files when contents remains the same 
To ensure that build timestamps don't unnecessarily cause full rebuilds,
make sure that we only write the generated contents to a file (if it
exists already) if it would be the same. This ensures that the file
timestamps remain the same, which will lead GN to conclude that the
build action is a noop (which it is).

On a new year, the file contents would actually be different, so it
would cause a proper rebuild. However, in all months between when the
timestamp changes, it won't cause is unnecessarily to rebuild all these
files, even though the year hasn't changed (but the timestamp it was
based on did).

R=jacktfranklin@chromium.org

Bug: 1283883
Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-10 15:54:45 +00:00
Tim van der Lippe b693eb34d5 Update remaining NPM dependencies 
DISABLE_THIRD_PARTY_CHECK=NPM fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I41baa3294f88b7e4463fdc580c050932c5abe40e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372932
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:42:53 +00:00
Tim van der Lippe 08285ab74f Use GN build timestamps for copyright year 
To avoid non-determinism on January 1st of a new year, we have
to use the build timestamp from GN to compute the current year.
The build timestamp will be the same for all bots, which ensures
that all files are built with the same year in the copyright header.

R=jacktfranklin@chromium.org

Fixed: 1283883
Change-Id: Ifbe581ddb65095ca6ef555625be11a370cb8f238
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372924
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-07 12:09:00 +00:00
Andres Olivares 09efec39cd Add 'info' icon with no background 
We currently have an info icon but this CL adds a variant which doesn't
have a background.

See:
https://imgur.com/a/sWlyxRL (new)

and

https://imgur.com/a/ZhucjOE

Bug: none
Change-Id: I1bc746eb7f765d080e48f7b31dcec08694555af5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3350848
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-12-21 15:14:25 +00:00
Riho Isawa 402308b666 [devtools] Add circled backslash icon 
This CL adds the circled backslash icon for the layout of BFCache on devtools
https://docs.google.com/presentation/d/1kQbFM1FxSZcMTBL9vmgF1fT4ntGKk3B9iY6rhU_0kSs/edit#slide=id.gfa319b6ac2_0_0
https://crrev.com/c/3253252

I plan to use this icon for Not-served status.

Bug: None
Change-Id: I2887f2a04ce6824d268a76b755a08f37b40d4b03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3312402
Commit-Queue: Riho Isawa <rhisawa@google.com>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-02 16:37:53 +00:00
Riho Isawa 27ddda8dd9 [devtools] Add circled exclamation icon 
This CL adds the circled exclamation icon for the layout of BFCache on devtools
https://docs.google.com/presentation/d/1kQbFM1FxSZcMTBL9vmgF1fT4ntGKk3B9iY6rhU_0kSs/edit#slide=id.gfa319b6ac2_0_0

Bug: None
Change-Id: I6ce9a1eacb6dfca812ce878233a1216eca1c1a8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3301347
Commit-Queue: Riho Isawa <rhisawa@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-25 09:32:05 +00:00
Jack Franklin cd565856d7 Rename feedback_thin_16x16_icon to survey_feedback_icon 
It's only used by the SurveyLink component and all other feedback
related things use the feedback_button_icon, so this is just a small
tidy-up for clarity.

Bug: none
Change-Id: I795b63a9c683e60dc16cff36b3818431a589ace4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3282584
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-16 10:06:32 +00:00
Tim van der Lippe 3588fcd4a0 Use accent-color for radio buttons 
The radio buttons were previously implemented using a custom image
and manual filter inversion. Instead, we can use `accent-color` to
explicitly set the color (to orange) just like we did for checkboxes.

This also allows us to remove the corresponding image.

R=yangguo@chromium.org

Bug: 1203631
Change-Id: I7d4afdb7cd67016d473301a9281fe98c84994c11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3282028
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-15 15:13:26 +00:00
Jack Franklin 0115259a94 Implement FeedbackButton component 
To be used in panels where we want feedback. Takes the URL that should be
linked to as its data.

Change-Id: I7af7edd95b9510203e94770ba540d380f5ea58ff
Bug: 1268802
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3275789
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-12 15:07:53 +00:00
Jecelyn Yeen 535c2b12da What's New in DevTools (Chrome 97) 
Bug: 1196969
Change-Id: I864c2302bf0faeedc2a735d23f303b75c29c7a02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3260046
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-04 10:36:29 +00:00
Jecelyn e0c60d5ed0 What's New in DevTools (Chrome 96) 
What's new in DevTools (Chrome 96)

Bug:1196969
Change-Id: I55573f7cef2eaeb9ae638949ced2a18e60f1a37a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3211332
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-07 11:45:38 +00:00
Changhao Han ef26abc890 Update CSS Overview starter UX to allow preview 
This CL also removes the experimental status of CSS Overview.

screenshot: https://drive.google.com/drive/u/2/folders/1wexxMX10YPeZRSnHVIgj64kZg8bcUsOU

Bug: chromium:1254557
Change-Id: I2c103918d22a79aaa663a216890c00deda21f56b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207873
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-07 07:13:08 +00:00
Alex Rudenko ec40026704 Implement an icon for experimental/preview tabs 
This CL adds an icon next to tabs containing preview/
experimental features. A tab can be marked as such in the
registerViewExtension call.

Screenshot: https://drive.google.com/drive/folders/1uu-SSwB2_Sa8-DzqlN9eISG7wF_9MlnS?usp=sharing
Bug: none
Change-Id: Id13d32494fadf47691046d14e102ba5475e71c6b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3201982
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-05 06:45:48 +00:00
Wolfgang Beyer cd7c3815fe App Id: move explainer note from tooltip into main UI 
Screenshot: https://i.imgur.com/egg72jf.png

Bug: 1222571
Change-Id: I41b30942273f3cad73e3bd843cba9d1e56b0b8b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3172980
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
 2021-09-22 13:19:31 +00:00
Wolfgang Beyer d1d95ab346 Extract copy icon into separate file 
Bug: 1222571
Change-Id: I3998cef2a1786cd3d543eb9c5c5f291c59950f11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3172838
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-09-22 08:27:46 +00:00
Jecelyn 1773880c8b What's new in DevTools (Chrome 95) 
Bug: 1196969
Change-Id: I7faed4dc78afbeca1ff6273706d22c095daecf05
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3150938
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2021-09-09 07:38:27 +00:00
Nancy Li 7e289166ae [DevTools Quick Open] Add icon to Help menu 
Before: https://imgur.com/a/hJ28tFc
After: https://imgur.com/a/PqohakM, also other panels are not changed visually (https://imgur.com/a/jsXJ2DT)

Bug: 1201997
Change-Id: I512c742e95b9bf773115f0a818233d3d5b1e9db8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3144495
Commit-Queue: Nancy Li <nancyly@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-09-08 12:56:50 +00:00
Wolfgang Beyer 419332169a Remove duplicate icon 
Bug: none
Change-Id: I5ea590eeb07dd2daf121f83c55080796f25939d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3118369
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-25 14:20:54 +00:00
Wolfgang Beyer e1acc5d510 Extract icon from sprite sheet 
Bug: 1222571
Change-Id: I1da07d5a54940348e59393342b7a4f7339aa4705
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3118366
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-08-25 14:17:24 +00:00
Nancy Li f3c75835a5 [DevTools Protocol Monitor] Replace "sent" and "received" is with icons 
Before: https://imgur.com/a/ZaGH031
After: https://imgur.com/a/PUcUiXg

Bug: 1226764
Change-Id: I659877ea7d29852fc15cff43ddc0bc86e4cf7030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3097667
Commit-Queue: Nancy Li <nancyly@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-18 11:38:29 +00:00
Jack Franklin 9c0542b99d Stop image CSS sheet overriding any other sheets. 
This doesn't cause us issues at the moment, but it is possible in the
future that we may adopt more stylesheets onto the document. This CL
updates so we always append the sheet rather than just overriding any
existing stylesheets.

Bug: none
Change-Id: I7f7abca19f1e4e5e40234a263aaddbb79da9286b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3090586
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-13 10:03:08 +00:00
Jecelyn b305c9236d What's New in DevTools (Chrome 94) 
Bug:1196969
Change-Id: Iea15c90bfa17a0892b16186b5de503d2ff9fb43a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3088605
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-08-12 08:29:53 +00:00
Rahul B S d8bf5f6885 Fix CSS var path resolution if the path uses special characters 
When devtools-frontend was hosted as stand alone application, icons
were missing if the local path of "devtools_app.html" is like
for example "out/custom devtools (1)/front_end/devtools_app.html".

Bug: None
Change-Id: I6a07fe9576276dc11924b2109325d0d11de60720
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3035144
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-19 14:28:00 +00:00
Jecelyn 2953cdd934 What's New in DevTools 93 
Bug:1196969
Change-Id: I605d6a20ebb3ac518455c01c49d86274fc76bffe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3030381
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2021-07-15 12:42:35 +00:00
Changhao Han ef157dab2c Add container axis details in container link 
This CL adds container queried size details in the container link in the
Styles pane.

Design doc: https://docs.google.com/document/d/1FGwUsRC3UHXJjcJ5H2DhMi2E2bIFY2tmUBuL984UK-I/edit

screencasts: https://imgur.com/a/HjmiaHe

Bug: chromium:1146422
Change-Id: I2e618e3fcea08607b23319f20eb126dc561d8420
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3023626
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
 2021-07-13 13:00:56 +00:00
Sigurd Schneider 8c56425327 Add issue link icon component 
This component will be used in all places that link to individual issues
which is currently the case in the console and the network panel.

Bug: chromium:1213393
Change-Id: I455ea93f98e07043505189f88fd079bcd3aabd80
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3017387
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-13 06:07:37 +00:00
Rahat Muneeb de216e6811 Added three_dots_menu_icon for hide issues feature 
This icon was taken from the largeicons.svg spritesheet
Bug:1175722
Change-Id: Idc67e8177ce69f2769125bae16f993fae793b94e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3000804
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Rahat Muneeb <irahatmuneeb@gmail.com>
 2021-07-09 10:04:01 +00:00
Johan Bay c74a145e1d Style accessibility tree toggle button 
https://imgur.com/a/N2QvX4n

Bug: 1226486
Change-Id: I24ca8760ed8cb8c97200d30952bd263f05d96361
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003440
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-07-05 14:28:15 +00:00
chait pinnamaneni a1a896acdc High contrast fix for close icon for tabs in DevTools 
Currently close icons for tabs are not changing colors under high contrast. This Cl updates the close icon and adds background color to the icon instead of changing icons.

Before: https://i.imgur.com/H6A8NSo.png
After: https://imgur.com/a/VjDgi84

Bug:1225492
Change-Id: I73e36fd43fbf8e7997643263e535c812bf4f4afa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2998329
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-01 19:48:33 +00:00
chait pinnamaneni 750a2d1627 Adds fields for client hints form in Device settings and added the same form in network conditions panel 
Improves UX for adding client hints in device settings screen. Instead of adding semi-colon separated value for brands, users will be able to input in different fields. Also added the same form to network conditions panel, so users can easily change client hints from network conditions. In network conditions, user agent client hints gets automatically updated when user changes device from dropdown.

Device settings:
Before: https://i.imgur.com/sn3E1dV.png
After: https://i.imgur.com/rBMNjQt.png

Network conditions panel:
https://i.imgur.com/Sk9k3Bb.png

Bug:1215598
Change-Id: Ie9f75456c67e30bb133675bef756a828fa117719
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933920
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Brandon Walderman <brwalder@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
 2021-06-16 18:26:58 +00:00
Danil Somsikov 4d4faeeb20 Using new network resource icons. 
Update both network log view and newly introduced web bundle view.

See: https://imgur.com/a/AUbvUEl

Bug: 1182537
Change-Id: Ic03a81b0ed9b0f7ba14e3ed727bf54e4ae02fc10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2956208
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-14 14:58:24 +00:00
Tim van der Lippe f27fc26d00 Use relative paths for broken sprites 
These sprites were using absolute coordinates, which were garbled
by the svg optimizer. Instead, we should be using relative movement
using the lowercase `v` and `h` calls that circumvent these issues.

R=wolfi@chromium.org

Bug: 1216402
Change-Id: Ia90b707cafc48fa58bb8f4a575bd9290d8e87824
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960175
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-14 14:54:34 +00:00
Tim van der Lippe 6e28ac91da Rename to devtools_svg_sources 
Any list with a variable name in GN that ends with `_sources`
is automatically alphabetically sorted.

R=dsv@chromium.org

Bug: none
Change-Id: I28664a76942776133ee63ec7b06dd2dfbdbf85dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2956348
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2021-06-14 12:12:34 +00:00
Wolfgang Beyer ece4f72a29 Fix list icon for automatic optimisation 
The automatic svg optimisation does not correctly handle the list icon.
By turning the group's translation matrix into a scale transform and
adapting the coordinates within the paths, the faulty optimisation can
be avoided.

Before: (E5) https://i.imgur.com/IUkHbkx.png
After: (E5) https://i.imgur.com/dk5dhBw.png

Bug: 1219419
Change-Id: I38b53c948a7c008eb8e75bf1f33af457a7b24a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960170
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-14 11:43:14 +00:00
Wolfgang Beyer edf33b835c Fix icon of nested frames for automatic optimisation 
The automatic svg optimisation does not correctly handle the icon for
nested frames. By removing the group's `translation` attribute and
instead adapting the coordinates within the individual paths, this can
be avoided.

before: (F6) https://i.imgur.com/a7hos2J.png
after: (F6) https://i.imgur.com/IUkHbkx.png

Bug: 1219419
Change-Id: Ief9f7dba0254c1181beef13ed2be696cc36aa8c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960609
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-14 11:38:44 +00:00
Wolfgang Beyer f9cf950994 Fix SVG icons to not get lost in optimisation step 
After switching to dynamically optimising SVGs in
https://crrev.com/c/2939994 some icons do not appear in the optimised
output. The root cause in the SVGO optimiser is unclear, but similar to
https://crrev.com/c/2853805 the bug can be avoided by moving the `fill`
attribute from individual <path>s to the <g> group.

Optimised icons before: https://i.imgur.com/VSZv783.png
Optimised icons after: https://i.imgur.com/a7hos2J.png

Bug: 1219419
Change-Id: I077793ad06ba3d39534025d67f4a48be70d888c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960608
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-14 11:31:54 +00:00
Danil Somsikov e7672c40f2 Implement minimal web bundle preview 
https://imgur.com/a/Mu6edRS

Bug: 1182537
Change-Id: I25e791c7b5d1284581e57a82ead066dd5f739b2b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2955364
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-11 12:05:59 +00:00
Jecelyn 2c1c5b5185 Add documentation link for experimental features 
After the change: https://imgur.com/ctvcaXv

Bug: 1217508
Change-Id: Ieac9e1e2a8bbb2ad6351f997f6d39423c34d066c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2946675
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-06-11 00:44:58 +00:00
Tim van der Lippe 727227900c Dynamically optimize svgs 
Currently, we optimize our SVGs out-of-sync and have a Python
script and PRESUBMIT check to make sure that the SVGs are correctly
optimized. This means that the SVGs are duplicated in the Images
folder and requires developers to install `svgo` on their command
line, which could be using differing versions.

Instead, we can optimize the SVG images (which is computationally
cheap) during build time using the rollup-plugin-import-meta-assets
and svgo packages. The rollup plugin traverses the required SVG
image files and puts them and rewrites them to the Images/ folder
(rather than in src/), while also allowing us to optimize them
along the way.

DISABLE_THIRD_PARTY_CHECK=Removing script from package.json
R=jacktfranklin@chromium.org

Bug: 1216402
Change-Id: Ieb6932b9a81753be5ecbccd00a5d84bd0efa23f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2939994
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-06-10 10:09:30 +00:00
Danil Somsikov 1e9a768d68 Add icons for web bundles and their inner resources. 
Bug: 1182537
Change-Id: I3e71311c59d4497ac48d5bb596b50d290fa679a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2950165
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2021-06-09 16:41:18 +00:00
Jecelyn e7ffb55b82 What's New in DevTools 92 
Bug:1196969

Change-Id: I6dad7f3a70551ab1b06cf4f620ef8308f0187847
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2909396
Reviewed-by: Jecelyn Yeen <jec@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jecelyn Yeen <jec@chromium.org>
 2021-05-20 09:44:05 +00:00
Patrick Brosset c0969ff0ad Fix the docking icon 
The docking icon recently regressed. It was getting overly optimized by
SVGO and was not displaying correctly.
Rather than understanding which setting of SGO in particular is causing
this issue, and turning that setting off (which we cannot do easily),
I'm changing the path code of the icon to avoid the problem.

Bug: 1204985
Change-Id: I2d108b10b466f02fb523368e61577f231c3030b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2867248
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
 2021-05-03 14:38:08 +00:00
Alex Rudenko 85c4713355 Add justify-items icons 
Screenshot: https://i.imgur.com/oG0Nr11.png
Bug: chromium:1203241
Change-Id: I4d254659b33d659f75e8b4b512d4679e98a8323e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854690
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-04-29 07:43:01 +00:00