zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
20 Commits
Author SHA1 Message Date
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Tim van der Lippe d3b32d536c Cleanup entrypoint initilization 
The `appStarted` callback was used to signal `MainImpl` that the Runtime
had finished loading all modules. However, since we no longer have any
such modules, we can remove this callback altogether and cleanup the
instantiation of each entrypoint a bit, reducing the amount of
side-effects that we have.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iacee65e6ce00ce6134756b4c77ffb24731e42745
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313061
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 13:50:13 +00:00
Tim van der Lippe 07805ea8f9 Remove entrypoints/startup/ 
None of the entrypoints require this anymore, so we can clean it up.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I2cd507ea169952c3bdb39388a7c4eff21746ef17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310870
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 12:15:37 +00:00
Tim van der Lippe fd742ce33a Remove entrypoints/js_app/js_app.json 
Since this was the last entrypoint that was still processed with
`build_release_applications`, GN now starts to error and claims the
action is unused (which it is). Therefore, we need to clean up this
action as well as all the GN variables it had been using. I will clean
up the actual Python implementation in a follow-up CL, to keep this one
as small as it can be.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ie4296885e6825d72a0b6c356971290337b680a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310868
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:32:52 +00:00
Tim van der Lippe 33d37636a0 Move main side-effect instantiation to entrypoints 
To ease the migration off the `.json` files, we first need to move the
main instantiation to the correct timing. If we perform it too early,
runnables that we register later don't work (which we are going to do in
a follow-up CL). However, side-effect instantiation is obscure anyways,
so let's move them into the appropriate entrypoints so that we make this
explicit.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I5686c446a371f0fc0bb4e784c705775973530f4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306498
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 16:31:06 +00:00
Tim van der Lippe 19b714a693 Remove entrypoints/shell/shell.json 
Shell no longer has any content, so we can remove it from all
entrypoints. We still want to share the contents of the meta files and
all, so keep these in. However, since we are no longer processing the
`shell.js` file `build_release_applications`, we can now fold in
`shell-meta-files.ts` into `shell.js`.

Ideally, we also change `shell` to be TypeScript-authored, but we can
only do that after all entrypoints that import it (in their respective
`.js` files) are TypeScript. So we will have to do that last.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I47239286f6f1dbff63ce69cf8ca4c78bd4761030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306497
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 15:55:52 +00:00
Tim van der Lippe 379c288384 Allow meta-files to import relative entrypoints 
We previously disabled this rule in a lot of places to workaround the
fact that the rule wasn't adhering to importing entrypoints in meta
files. Instead, let's update the rule to make it clear that this pattern
is expected and fine.

R=alexrudenko@chromium.org

Bug: 1271490
Change-Id: Idd139b42d9bb27f1f20e573b31bcd5efff8815af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289221
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 14:53:06 +00:00
Tim van der Lippe 28de514742 Remove panels/js_profiler/module.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iea3238e8ce6395eb781a99acb2b59864ff69ded6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3282588
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-17 14:57:23 +00:00
Kateryna Prokopenko e56810b085 Remove ObjectWrapper extension from files with no events 
Bug: 1228674
Change-Id: I5867c2b8894313cc369684c95e3a7c8ccb6a2b3c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3165097
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-09-17 07:58:55 +00:00
Sigurd Schneider 16cc89e295 Consistently type Target.{SessionID,TargetID} 
This uncovered a bug where we used a targetID to as a sessionID,
which is fixed in this CL. The bug caused target information to
not get updated and the fix should increase target information
accuracy.

DISABLE_THIRD_PARTY_CHECK=<reason>

Bug: chromium:1226471
Change-Id: I89e461381443617d96ae06d5775038cd32ad8dd1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3080308
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-09 11:42:37 +00:00
Jan Scheffler d5bf879558 [Underscore Migration] Migrate entrypoints 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: Iec114859ae3f46457bafa2d823e11add202c6eb2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077887
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-07 15:52:16 +00:00
Sigurd Schneider 79e812efee Move Target to its own file 
Bug: chromium:1213943
Change-Id: I309436e8608c3f89ac42a117a3f454b5e43eef16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933138
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-06-04 07:24:06 +00:00
Sigurd Schneider b9f6c7910e Move TargetManager to its own file 
Change-Id: I4708a6303198bc5c4ff6aa8e2b2a2f5e4530725f
Bug: chromium:1213943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919763
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-31 11:24:26 +00:00
Tim van der Lippe 6892da0014 Add GN visibility to entrypoints 
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I5ff52856d177529c26655e79f1fa5db96fa06196
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2856775
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-29 08:54:21 +00:00
Tim van der Lippe 339ad2698a Move components to ui/legacy/components/utils 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ib55515e9a436e21c4b1e7a014a95220b46021136
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843311
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-21 13:42:05 +00:00
Tim van der Lippe 28264f76dc Move js_profiler to panels/js_profiler 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Icf072fcd7c6c9840deafae3213defc09890b99a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831974
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-19 13:48:29 +00:00
Tim van der Lippe dbb97be22a Move startup to entrypoints/startup 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: If71a7d4eeda376e240fe7b1e12f94c853b3cba53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828129
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-15 16:45:15 +00:00
Jan Scheffler 9a3dc47824 [JSDOC2TS]: Migrate js_main 
Bug: chromium:1158760
Change-Id: I210b01ecb0505dd1083d3342dba009787cf7952e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2789344
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-14 16:46:21 +00:00
Tim van der Lippe 658218d0f0 Fold js_main into entrypoints/js_app 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I0d3a3b096c0126e7359391d9c95ea75a1a5f62a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2823705
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-13 16:36:49 +00:00
Tim van der Lippe 7b347ca16f Move entrypoints to sub-folder 
All JavaScript files for each entrypoint are put in their respective
sub-folder of front-end. The HTML files load from the new location and
build_release_applications has been updated to load from the correct
location.

R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I4b93f3a2127ef2d3ce7dccefe03f70e79dac1c19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2818379
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-12 12:04:18 +00:00