zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 20:11:38 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
112 Commits
Author SHA1 Message Date
Adam Raine 70d4a90431 Enable FR Lighthouse panel by default 
There really isn't any reason to keep the old panel after this.
Legacy navigation mode will still be accessible through it's option
in the Lighthouse settings. This CL is just the quickest way to enable
the new panel by default.

Bug: 1291284
Change-Id: I332753718e88e3c94ba0bdf493c108846f7ff8b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3636197
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2022-05-12 07:05:07 +00:00
Mathias Bynens 54303dcc64 Unify developer-facing and user-facing short URLs 
For any shortened URLs:

- Use goo.gle for Google Docs and chromium.org target URLs.
- Use g.co for everything else.

Bug: chromium:1321016
Change-Id: I09099dc62b92a14fa68d62155953262328476db2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613872
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2022-04-29 10:46:23 +00:00
Wolfgang Beyer 81477453b5 Fix local override filename handling for special characters 
This CL fixes local overrides for URLs which contain special characters.
When a resource is saved for overrides, a local path and filename are
generated from the resource's URL. Because not all characters are
allowed to be used in filenames, these characters need to be escaped
(via URL-encoding). The most common cases are '?', which is used for URL
query params and ':', which is used for the port number. Both '?' and
':' are not allowed within file names on Windows OSes.

Previously, DevTools was hiding this complexity of encoded file names
from the user by decoding the file names for user-facing strings. This
could lead to unexpected behaviour, e.g. when renaming files for which
the actual filename does not match the user-facing filename. With this
CL the actual (encoded) filename is shown to the user.

Bug: 1308257
Change-Id: I0303af33502e4e5768e0ccdb44d495b6a2b62190
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3579160
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-04-21 14:30:36 +00:00
Kim-Anh Tran f58a83ed9c Reland "Enable synchronization on instrumentation breakpoints" 
This is a reland of commit 1b596f3b4b.

Changes:
1. Gated behind an experiment
2. Removed changes that are currently not used since it's gated
   (i.e. test changes)

Original change's description:
> Enable synchronization on instrumentation breakpoints
>
> This CL introduces the synchronization point for setting
> breakpoints on new scripts using instrumentation breakpoints.
>
> Instrumentation breakpoints will trigger at the first statement
> of a newly run script. Afterwards we wait for all resources
> that we need to set a breakpoint (if one is cached for that
> particular script), set it, and resume.
>
> Note: this will not correctly synchronize the case where we
> just opened DevTools or just created a new target, as at this
> point some scripts might have started running. For this, we
> need to synchronize the Debugger.enable call, which is something
> that is left to take care of.
>
> Bug: chromium:1229541, chromium:1133307, chromium:1300509
> Change-Id: I44e9b053a7cf64cc1f477a68ce9389cd92a1d05d
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470237
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>

Bug: chromium:1229541, chromium:1133307, chromium:1300509
Change-Id: I19553ddac9530fa3ccac6b245a3dd89da88c6d51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542248
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2022-04-21 07:43:46 +00:00
Jack Franklin 311b4a28a0 De-prototype #deepActiveElement 
Removes `deepActiveElement` from the prototype and defines a util for
it.

Bug: 1050549
Change-Id: I0376ba0b3a00d82c070f2d4ada12350771046790
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3586910
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2022-04-19 11:12:54 +00:00
Yisi bbb56c21fa Enable eyedropperColorPicker by default 
Bug: 1245191
Change-Id: I872d529778862a2aae69efac6a9cd97cd887fecd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3583290
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-04-19 08:39:16 +00:00
Yisi 1a73be9f3c Color picker switches to the new EyeDropper API 
The EyeDropper API[1] has been enabled by default in Chrome 95[2]. Using the new API,we can draw colors outside of the Chrome window.

Added the `EYEDROPPER_COLOR_PICKER` experimental flag, the user can turn off this flag to switch to the old version of the color picker.

[1]: https://github.com/WICG/eyedropper-api/
[2]: https://bugs.chromium.org/p/chromium/issues/detail?id=897309#c35

Bug: 1245191
Change-Id: I05f8628322ab5d314cca640fb269b865821f2ae4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3134563
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-04-11 08:57:02 +00:00
Danil Somsikov c1abf4cd44 An option to run Karma unit tests with a fullt bootstrapped frontend and real CDP connection. 
This is needed to instantiate some classes e.g. CPUProfileView.

Bug: 1306830
Change-Id: Ib59ebc4235bfd08ef847e49f478351f2a830081a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3545148
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2022-03-23 17:12:52 +00:00
Danil Somsikov 2fc9ae9f46 A promise version of readyForTest in MainImpl. 
Bug: 1306830
Change-Id: Ia9bd87c0230ac845efd8c91b6678fe232f0732c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3542246
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2022-03-22 15:45:32 +00:00
Johan Bay 52f5be82ff Add @layer support in styles sidebar pane 
This CL provides support for @layer rules by providing two features:
1. we now separate the matched styles in the styles pane by their layer
to make it easier to see which layer each rule belongs.
2. we provide a layer overview widget that shows the layer tree for the
tree scope of the currently inspected element.

Screenshot: https://imgur.com/a/CxFrKyc

Doc: https://docs.google.com/document/d/1J7mvg-5eFsLhKLRkd7-mwdIxxDgt2fq1lhOTw47Df6E/edit?usp=sharing
Change-Id: I6fbffc7e272303e942af733029059a0a98771283
Bug: 1240596
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484212
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2022-02-25 13:56:51 +00:00
Jaroslav Sevcik f336ccf23d Expression evaluation with sourcemaps (under flag) 
This is a first step towards evaluating expressions with source map
resolution in the console.

This patch only replaces single variables expressions with the name
inferred from the source map. The feature is behind a flag because it is
still far from being usable (e.g., no support for more complex
expressions, auto-complete, partial expression evaluation, fallback UI,
etc.).

Bug: chromium:1297047
Change-Id: I5d4a233f65cf27112c370eeb81c509cd3e14623d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461558
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
 2022-02-16 08:01:52 +00:00
Adam Raine ff80ccb170 Experiment to add a mode selector to the Lighthouse panel 
Currently only includes navigation and snapshot modes, timespan mode
will require further UX changes because the user controls when timespan
mode ends.

Related:
https://chromium-review.googlesource.com/c/chromium/src/+/3456526

Bug: 1291284
Change-Id: Ic5c7c3b1925609de021e625c5095e8bd08348851
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3456629
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2022-02-14 19:02:37 +00:00
Wolfgang Beyer 6e80008cca Add DevTools experiment for response header overrides 
Bug: 1288023
Change-Id: I1a44d3f180062196e51a21e48fd6e8d41c0e2f6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430920
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-02-07 14:02:03 +00:00
Changhao Han 4cc9988ac7 CSS Changes: add change indicator in the Styles pane for changed properties 
This is the first step of integrating CSS Changes into the Styles pane.

Screencast: https://imgur.com/a/97Tn4Sj

Design doc: https://docs.google.com/document/d/1jj9I7ANHh06tbCG6TtcZzd7vqa7hoQNWhOBSku5hKjA/edit

Architecture doc: https://docs.google.com/document/d/1zkOWg1OlUYudFjgqMFvZy1HuOCcrHUFho55q94MowtM/

Bug: chromium:1268754
Change-Id: I515ccdf07343eabf1741c1a46085a0a45aa25afc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3404099
Reviewed-by: Johan Bay <jobay@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-01-25 10:51:10 +00:00
Wolfgang Beyer 668bc7a4bc Enable Reporting API Debugging experiment by default 
Bug: 1205856
Change-Id: If32317e9b265ae45fb0afe11262b2fce22f04687
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3398889
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-01-19 08:24:29 +00:00
Yuzu Saijo 74f95383e1 [bfcache] Add an experiment to show frame tree structured reason 
This CL adds a new experiment on DevTools to show the bfcache blocking
reasons in a frame tree strucuture. This will be enabled by default
once we have all the reasons reported (currently there's a bug where
some reasons are missing).

Bug: 1288158
Change-Id: Id778a8b7320ef7092e280297add40cdd2936a299
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3396918
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
 2022-01-18 12:42:07 +00:00
Yang Guo 3b147a66cd Fix layout for settings labels 
Fixed: 1287064, 1287012
Change-Id: Ica424dbc58ab3596603976b1c7f7cc1e69c48556
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3385518
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2022-01-13 12:55:50 +00:00
Tim van der Lippe 6bcbe0f26d Use window.setTimeout to avoid TS errors in VS Code 
R=aerotwist@chromium.org

Bug: none
Change-Id: I632aa0beb0e157197f5c2f982c2082a6d67f87f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380595
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-11 19:17:48 +00:00
Alex Rudenko a9a491e39a Add Settings.forceGet method 
The new method always bypasses the local cache
and gets the value from the backing store.

Backend CL: crrev.com/c/3302814
Bug: 1273058
Change-Id: I921edf3a4c741261a3823310c6f23b57934a9ad1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302733
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-11 10:21:34 +00:00
Yang Guo 7d228add95 Implement "Dock side" title's padding correctly 
Previously it's somewhat accidentally through a parent element's
margin attribute.

R=aerotwist@chromium.org

Fixed: 1284886
Change-Id: I2b3d50866a203e0dc87cead56ce3cde6a4452d50
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372934
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2022-01-07 16:17:30 +00:00
Paul Lewis fec2123b86 Remove reload when changing themes 
This is a fairly widesweeping set of small changes necessary to change
themes dynamically. It mostly involve a change or two to the Theme
Support implementation itself, such that it detects the move from light
to dark theme and, in so doing, clears out its caches and dispatches an
event. This event is used in various places to re-query theme-centric
variables. This applies particularly to the perf UI / flame chart.

Other smaller changes to function signatures are implied by some of the
changes, hence the number of files affected by this CL.

R=jacktfranklin@chromium.org

Bug: 1278738
Change-Id: Iacde026ee69020557491817c8a700b2a7fd2217f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369366
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2022-01-06 14:12:13 +00:00
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Tim van der Lippe 12bcadba35 Migrate to private class members in entrypoints/ 
This also enables the ESLint rule for this folder

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I872ac654d4a37946aba75def17cc1f1aa8ad893c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3341610
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-16 10:31:28 +00:00
Tim van der Lippe e343bdfafb Migrate to private class fields in entrypoints/ 
R=szuend@chromium.org

Bug: 1222126
Change-Id: I6863d8180c6a44a0e607e860bbce89bf9d3642ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3338351
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-12-15 11:49:27 +00:00
Tim van der Lippe b42cc464a5 Remove platform/utilities.ts 
The `assertNever` function was a TypeScript utility, so let's move it
into typescript-utilities.ts. The onload implementation is no longer
required. Since our HTML pages include the JS link as the last one and
the full page has been loaded, it is effectively a noop and always
immediately calls `callback`. Therefore, we can inline the callbacks and
remove some hoops.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ib530cb12324820fab8371e18f102c39ef6fbce51
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3327243
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-10 09:33:07 +00:00
Tim van der Lippe d3b32d536c Cleanup entrypoint initilization 
The `appStarted` callback was used to signal `MainImpl` that the Runtime
had finished loading all modules. However, since we no longer have any
such modules, we can remove this callback altogether and cleanup the
instantiation of each entrypoint a bit, reducing the amount of
side-effects that we have.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iacee65e6ce00ce6134756b4c77ffb24731e42745
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313061
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 13:50:13 +00:00
Yuzu Saijo f4b1333582 [bfcache] Remove the bfcache debugging experiment 
This CL removes bfcache debugging support from the list of experiment,
so that there is no disabling.

Bug:1110752
Change-Id: I989ceae5a70e981be6b031b6837a9a677b1cc9b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302236
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-30 04:47:38 +00:00
Tim van der Lippe 33d37636a0 Move main side-effect instantiation to entrypoints 
To ease the migration off the `.json` files, we first need to move the
main instantiation to the correct timing. If we perform it too early,
runnables that we register later don't work (which we are going to do in
a follow-up CL). However, side-effect instantiation is obscure anyways,
so let's move them into the appropriate entrypoints so that we make this
explicit.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I5686c446a371f0fc0bb4e784c705775973530f4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306498
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 16:31:06 +00:00
Changhao Han 4382b53352 Add option to format diff in the Changes tab 
This CL adds an experimental flag to automatically format code changes
in the Changes tab. This way the minified sources won't show only one
line of diff that's quite hard to trace the actual difference. It also
won't show formatted source as changes any more.

Screenshot: https://imgur.com/a/lIEqUmU

Bug: chromium:1238818, chromium:1268754, chromium:1086491
Change-Id: I0f2636d1bced17f2f9b32f594bf720951fd4e191
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3300359
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-25 09:05:44 +00:00
Simon Zünd 7b7b35e178 Revert "Remove V8 Runtime call stats experiment and corresponding code" 
This reverts commit 5a4048ceb0.

Reason for revert: Functionality will stay around.

Original change's description:
> Remove V8 Runtime call stats experiment and corresponding code
>
> R=​alexrudenko@chromium.org
>
> Fixed: 1272432
> Change-Id: Ic4cfa52e7eff3a89c8bb22882d3cc18117c4242b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295525
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1272432
Change-Id: I2fca19948a2f1a98123fbd3e8a53b542ee029fb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3302099
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-25 07:20:14 +00:00
Simon Zünd 5a4048ceb0 Remove V8 Runtime call stats experiment and corresponding code 
R=alexrudenko@chromium.org

Fixed: 1272432
Change-Id: Ic4cfa52e7eff3a89c8bb22882d3cc18117c4242b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3295525
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-22 13:15:49 +00:00
Riho Isawa a91afc977d [devtools] Normalize Back/forward cache display names 
"Back/forward cache" is the official name of BFCache.
https://groups.google.com/a/google.com/g/chrome-bfcache/c/WmRKH29afrw/m/JiXi0p0sBAAJ?utm_medium=email&utm_source=footer
This CL spells lowercase b when not starting a sentence.
This CL normalizes all notations.

Deactivate tests in Chromium: I356efe231e9f7547573eb94e2244b9e5e19266cf
Activate tests in Chromium: Ia69f55a42a9ce977ef89e5ec1f3398e874a88765

Bug: 1271044
Change-Id: Iadd4e198143572188a5a66b28834cf7237738482
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3281075
Commit-Queue: Riho Isawa <rhisawa@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Darren W <djw@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-11-19 08:14:47 +00:00
Tim van der Lippe 379c288384 Allow meta-files to import relative entrypoints 
We previously disabled this rule in a lot of places to workaround the
fact that the rule wasn't adhering to importing entrypoints in meta
files. Instead, let's update the rule to make it clear that this pattern
is expected and fine.

R=alexrudenko@chromium.org

Bug: 1271490
Change-Id: Idd139b42d9bb27f1f20e573b31bcd5efff8815af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289221
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 14:53:06 +00:00
Tim van der Lippe b5fb91dfa5 Move legacy file loading to legacy_test_runner 
DevTools startup has slowed down a bit over the last year. The main
suspect that we have is the amount of files that are loaded at startup.
We have historically made significant improvements by removing file
loading out of the critical path, for example by removing the `module.json`
files from various modules. These have all attributed to improvements.

For our shell, we were still loading these legacy files. However, now
that we are fully type-checked with TypeScript, we have for the most part
removed our reliance on globals. There are only a handful of places where
we still rely on globals, most notably `MainImpl` for instantiation of
singletons and a single declaration in `ui/legacy/Panel.ts` which sets
values on `UI.panels`. Other than that, there don't appear to be anymore
usages of globals.

Therefore, we can move these legacy files out of our main shell and into
the legacy_test_runner. Doing so, our production build will now include
fewer files and hopefully also boot faster, while we still load the
legacy files for our layout tests (which still rely on globals).

It isn't clear what the performance impact will be, but cleaning this up
is good and we are relatively confident this will alleviate at least
some of the performance problems that have been reported.

R=yangguo@chromium.org

Bug: none
Change-Id: Ie34fbf6b82f3d1ba11bed623a9cc3d2a03c4c0c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-15 14:39:55 +00:00
Simon Zünd 05db7a2785 [sync] Mark 'language' setting as synced 
R=wolfi@chromium.org

Fixed: 1268309
Change-Id: I267976d6ab2309d8505da47f4ead3d2cae9ac193
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3269831
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-11-09 09:53:22 +00:00
Riho Isawa 4859eb8295 [devtools] Normalize Back-Forward Cache display names 
"Back-Forward Cache" is the canonical capitalization of BFCache.
This CL normalizes all notations.

Bug: 1268278
Change-Id: Id83425249974abb96155de3fc454e53ed62a55e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3260050
Commit-Queue: Riho Isawa <rhisawa@google.com>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-09 08:53:11 +00:00
Simon Zünd d7976b8c6f [sync] Only record metrics when sync experiment is enabled 
In case the sync experiment is disabled, the sync setting itself is
not available. This causes an exception to be thrown when we try to
record sync UMA on startup.

This CL fixes this by only recording UMA in case the experiment is
enabled.

R=alexrudenko@chromium.org

Fixed: 1268102
Change-Id: Ifbf64d29d810ce072b88e8d14c6c9040b4d666e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3269824
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-09 07:30:02 +00:00
Tim van der Lippe 9d79e55bd8 Remove entrypoints/main/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: I5d752140d5ce265b087f166ba8b0015cb2872dbb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264208
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-08 11:17:38 +00:00
Tim van der Lippe 32de3f14fa Fix focus debuggee command 
It was still attempting to import the `inspector_main` module file,
which has been removed in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253399

R=yangguo@chromium.org

Fixed: 1267274
Change-Id: I8f878cf2c0bd43b9ecf15c6f6f10918ad3888a40
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264209
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-05 16:01:36 +00:00
Nancy Li 64ce607e3d Add experiement icon to preview features in "More tools" menu 
After: https://screenshot.googleplex.com/5BaAUemq6QnH4ff

Bug: none
Change-Id: I910f60ad851e750de0cf6a22567a106edca8e147
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3245695
Commit-Queue: Nancy Li <nancyly@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
 2021-11-04 20:18:26 +00:00
Simon Zünd 79bc9f90aa [uma] Record UMA for the sync setting 
We not only record whether the user has opted-in or out for DevTools
Settings sync, but whether Chrome Sync is active in the first place
and if the 'Settings' bucket is enabled. Otherwise DevTools settings
sync will not work anyway.

R=alexrudenko@chromium.org

Bug: 1245541
Change-Id: Ia829133977a3b3e7ff61cfdfd6f9009a46663dfc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257680
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-11-04 06:26:50 +00:00
Simon Zünd 4c44dc592f [sync] Enable sync experiment by default 
Drive-by: Mark the "consoleGroupSimilar" setting as synced.

R=alexrudenko@chromium.org

Fixed: 1245541
Change-Id: I15031094b609be0849f24f6f251f8d201c3a29ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3256544
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-02 09:15:29 +00:00
Changhao Han c8c027bd45 Add experiment setting for <length> 
Backend CL for histogram: https://crrev.com/c/3251024

Bug: chromium:1259088, chromium:1172993
Change-Id: I743f1841dd03008f29f7a680e776cde3438831a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3251065
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-29 09:50:04 +00:00
Simon Zünd d4f932ff17 [l10n] Remove the localized DevTools experiment 
The localized DevTools experiment has been enabled by default since
M94. With M97, we remove the experiment altogether. Users won't be
affected as English is always the default locale for DevTools even with
the experiment enabled.

R=dsv@chromium.org

Bug: None
Change-Id: I88bedfbcc38b9ace58dfbf3bfa84b4e3214fdebe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240943
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-10-25 10:55:09 +00:00
Simon Zünd 08766db2f9 [sync] Enable syncing of keyboard shortcuts and framework ignore list 
R=wolfi@chromium.org

Bug: 1245541
Change-Id: Iea90b83589bcf5b52c26353b3239c9b91f16889a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240364
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-25 09:24:19 +00:00
Wolfgang Beyer fd6bce7310 Remove duplicate experiment and keep only one copy 
The experiment was renamed to not contain a sensitive term.
Previous CL: https://crrev.com/c/2601481
Disable blink test CL: https://crrev.com/c/3226371
Update blink test CL: https://crrev.com/c/3229606

Bug: 1161439
Change-Id: If03ed75b6aaee77802bef14cc81354a4674744ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3229507
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-19 10:13:13 +00:00
Changhao Han ef26abc890 Update CSS Overview starter UX to allow preview 
This CL also removes the experimental status of CSS Overview.

screenshot: https://drive.google.com/drive/u/2/folders/1wexxMX10YPeZRSnHVIgj64kZg8bcUsOU

Bug: chromium:1254557
Change-Id: I2c103918d22a79aaa663a216890c00deda21f56b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207873
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-10-07 07:13:08 +00:00
Simon Zünd 06eeeef634 Settings of the APPEARANCE and GRID category should be synced 
R=dsv@chromium.org

Bug: 1245541
Change-Id: Idd02987f13612feba5b99e00a1c3f92355663c00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207870
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-10-06 12:16:48 +00:00
Simon Zünd 13c2e6189e [sync] Add 'register' method to SettingsBackingStore interface 
This CL adds a 'register' method to the backing store interface that
mirrors the `registerPreference` host bindings. For local and session
storage, 'register' is a no-op.

The CL also adds a unit test to ensure that `register` is always
called when settings are created.

R=dsv@chromium.org

Bug: 1245541
Change-Id: Iaf93171288ca99d939ab4562a91ee7bd44a61203
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207867
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2021-10-06 10:26:22 +00:00
Michael Liao ebfbe4c0dc [Accessibility]: Initialize hidden alert element on startup 
Issue:
- ARIAUtils.alert live element is created on the first use of ARIAUtils.alert
    - This may cause issues as it takes time for screenreaders to register live regions
    - Creating the element immediately before the first use may not give screen readers enough time to register the live region, causing issues on the first use of ARIAUtils.alert.

Changes:
- Initialize ARIAUtils.alert element in MainImpl.showAppUI

Bug: 1255276
Change-Id: Id48169bbfe8ab1d1c89208d751f8c4b94f0217b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3198499
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-05 19:14:34 +00:00