Commit Graph
3 Commits
Author SHA1 Message Date
Tim van der Lippe d3b32d536c Cleanup entrypoint initilization
The `appStarted` callback was used to signal `MainImpl` that the Runtime
had finished loading all modules. However, since we no longer have any
such modules, we can remove this callback altogether and cleanup the
instantiation of each entrypoint a bit, reducing the amount of
side-effects that we have.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iacee65e6ce00ce6134756b4c77ffb24731e42745
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313061
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-12-02 13:50:13 +00:00
Tim van der Lippe 339872c26f Remove modules support from Runtime
All of these fields/functions were related to loading the legacy modules
powered by the now-removed `module.json` files. Therefore, we can clean
all of this up, as they are all unused.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iebe807a91415d16ba653a32abe4cd237d5b60bc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313060
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
2021-12-02 13:27:53 +00:00
Tim van der Lippe 67872d6878 Remove entrypoints/node_app/node_app.json
This CL does a couple of things to preserve the current behavior:
- It folds `node_main` into `node_app`, since we no longer require that
distinction (this was only required prior where we used `autostart` for
`node_main`, which we no longer do)
- It removes as much side-effect instantiation from various modules and
moves them into `node_app.ts`. The order is a bit awkward, but the calls
at the end of `node_app.ts` is the order of side-effect calls as it
exists currently. After we cleaned up all entrypoints, we can remove
some of the calls and clean it up further, but let's keep them here
explicitly to ensure we retain existing behavior.
- Folds `node_app-meta.ts` into `node_app.ts` for simplicity
- We now roll up everything into `node_app.ts` directly, rather than
having a separate meta script. Since this is an entrypoint, we can do
that here. Since the entrypoint will always eagerly load, we don't need
an explicit difference between the meta file and the module
implementation.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ida1cee76ae04b3d590dcd16d0225f65852bce5a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306499
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-11-30 14:32:54 +00:00