Commit Graph
44 Commits
Author SHA1 Message Date
Simon Zünd 270c221862 [deps] Roll Chromium dependencies
R=kimanh@chromium.org

Bug: None
Change-Id: If9bfd8662ff3492cf2d40abadadd59e6b48ba37f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641406
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
2022-05-12 07:55:23 +00:00
Ari Chivukula 69f125d55c [i18n DevTool Deprecation Issue] (9) Roll deps
./scripts/deps/roll_deps.py ~/chromium/src ~/devtools/devtools-frontend
npm run generate-protocol-resources
I also fixed compile issues due to the removal of constants from
AttributionReportingIssue which is why non-gen files were touched.

This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Translate more Issues ...

DISABLE_THIRD_PARTY_CHECK=Fixes to AttributionReportingIssue

Bug: 1264960
Change-Id: I9b73f60d2cd56bced19e908a761b3d90ad940c46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3600575
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-04-22 06:18:57 +00:00
Danil Somsikov b3a303b8bf Roll protocol
DISABLE_THIRD_PARTY_CHECK=Need to update code depending on generated types

Bug: 1249776
Change-Id: I607c0984106b2d949f0dcdf108c231642f42a53c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3565360
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2022-04-01 08:42:03 +00:00
Ari Chivukula 7316c47c1c [devtools] roll deps
./scripts/deps/roll_deps.py ~/chromium/src ~/devtools/devtools-frontend
npm run generate-protocol-resources

Bug:1264960
Change-Id: If240022f6a82c9acbde100bde66019ae942fd9c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3558149
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-03-30 05:36:09 +00:00
Changhao Han 21cc9b98d6 Roll CDP and css_properties updates into DevTools
DISABLE_THIRD_PARTY_CHECK=add missing BFCache not restored reason

Bug: 1274308,1287996
Change-Id: If0795ce0d051901ddc686230ca2de60a63fed7a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3535880
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
2022-03-18 10:03:28 +00:00
Changhao Han 130eb5ac30 Roll browser protocol and css properties into frontend
DISABLE_THIRD_PARTY_CHECK=need to update
FederatedAuthRequestIssueReason strings

Bug: 1222574, 1222573
Change-Id: I4e5f56874642f4c4cc3f9d3bfed882b71ccd5870
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461557
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2022-02-15 09:45:49 +00:00
Russ Hamilton f65a1372fb Update protocol
Bug:1268496
Change-Id: I560df542bf5d34748e87ed3cfe790419aa96e99d
DISABLE_THIRD_PARTY_CHECK=add empty implementation for new events
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3399327
Auto-Submit: Russ Hamilton <behamilton@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2022-01-19 14:38:50 +00:00
Changhao Han 72ee54b64e Roll css_properties.json5 to devtools frontend
Bug: None
Change-Id: I14ddf57eda66884a8cbda65a3e4ca088aaffdf1f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3385516
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
2022-01-13 10:58:49 +00:00
Yang Guo d5424239aa Roll protocol and css_properties.json5
Bug: 1280961
Change-Id: I66ac6c0e03ae7b3de94fb0c6bbada57dc0be9bb2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3365262
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2022-01-03 16:47:37 +00:00
Ari Chivukula 322507ed64 [devtools_frontend] roll_deps + gen
Needed for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3258023

DISABLE_THIRD_PARTY_CHECK=hasExtraInfo is required build fails without it

Bug: 1248484
Change-Id: Ia1221356b4386cdeafb09cf0559480a6704148df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3258362
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-11-03 06:41:30 +00:00
Kateryna Prokopenko 93e98460f5 Update protocol to include generic issue
DISABLE_THIRD_PARTY_CHECK=<protocol update>

Bug: 1246855
Change-Id: Ifaec739518a743450fcb6df90d38e2c9f913409d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3185319
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2021-09-29 09:23:42 +00:00
Johan Bay d96113d8c7 Roll css_properties.json5 from Blink into DevTools
Bug: none
Change-Id: I24fc30a901dce02b34ac7ef2be3a9489bb6c000e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3157957
Commit-Queue: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Johan Bay <jobay@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2021-09-13 12:08:06 +00:00
Changhao Han aa193ea9e2 Roll css_properties.json5 from Blink into DevTools
Bug: chromium:1146422
Change-Id: I78587c041844bed6aeead3af1ce401048fb624d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3150281
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
2021-09-09 09:32:56 +00:00
Simon Zünd 6333b91ae2 [deps] Roll Chromium deps into DevTools
DISABLE_THIRD_PARTY_CHECK=Includes generated sources
R=sigurds@chromium.org

Bug: None
Change-Id: Ia2415cc6ff6cf2450831fa9a02ac842cb174c580
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093154
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-08-17 05:35:20 +00:00
Changhao Han dd59c2f133 Roll css_properties.json5 from Blink to DevTools
Bug: None
Change-Id: I71f8f8bbe5e612d0db37b24d2864b228eb9084ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3038598
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
2021-07-20 11:33:41 +00:00
Changhao Han d627b3b5cf [deps] Roll css_properties.json5 to DevTools
Bug: None
Change-Id: I2544998c518a26d3d37a7c3e72d45eca0b56729a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2972583
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-06-18 09:11:39 +00:00
Simon Zünd 5de450067b [deps] Roll Chromium deps into DevTools
R=wolfi@chromium.org

Bug: None
Change-Id: I914eb716ada5c50fec031a125c2c2dd9f6e43719
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2846322
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-04-22 08:45:57 +00:00
Yisi 207ee9372d Add accent-color and show color swatch
The backend support is here: https://chromium-review.googlesource.com/c/chromium/src/+/2681146


DISABLE_THIRD_PARTY_CHECK=roll CSS properties

Bug: 1092093
Change-Id: I77a861f6202a7f1c04095fbe7030db41676047e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2759547
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2021-03-15 08:47:23 +00:00
Simon Zünd 91cd729845 [deps] Roll Chromium deps
DISABLE_THIRD_PARTY_CHECK=Deps roll
R=wolfi@chromium.org

Bug: None
Change-Id: I1a7a50a1075d24c908d955f6c1eb1c97d675cba3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2748075
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-03-10 08:45:18 +00:00
Simon Zünd ccdfc9bed1 Roll deps from Chromium into DevTools
This CL is the result of running roll_deps.py and
npm run generate-protocol-resources.

Additionally, cookie unit tests are adjusted to include a new property.

DISABLE_THIRD_PARTY_CHECK=Chromium deps roll

R=wolfi@chromium.org

Change-Id: Ifb2d7b4bc6839de2a6fe269ebfe918f43f21d1b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619610
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-01-11 13:00:56 +00:00
Benedikt Meurer 51690fcadb Roll js_protocol.pdl ('wasm' type and 'executeWasmEvaluator' removal).
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1162062, chromium:1159402
Change-Id: I5321aa8750b9ecb22b3f5eee3278b3a3f3ccc45f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2617698
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2021-01-08 07:18:07 +00:00
Wolfgang Beyer 51ee90469d Update DevTools protocol
DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 1139949
Change-Id: Id718e8e6c605983be17887ac8fefde0ee2b3c92c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2549789
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-11-19 12:10:14 +00:00
Patrick Brosset e3cdc109f4 Rolling DevTools deps
This change is the result of running
scripts/deps/roll_deps.py && npm run generate-protocol-resources
in the devtools frontend repo.

This is needed to bring over a protocol change I made recently for the
flex overlay.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 1139949
Change-Id: I5598cedfdcdca52110b1ac240d42c85faa72b080
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2532734
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-11-12 10:54:40 +00:00
Songtao Xia 160e3844d9 Roll-deps and generate protocol resources.
To bring in newest CDP changes manually.

Result of roll_deps and generate_protocol_resources.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Change-Id: I11407f3870c58dec74e5a8670023a670ea4afc98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2497529
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-10-27 02:15:07 +00:00
Wolfgang Beyer 5893cf5633 Update protocol
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1107766
Change-Id: I6c3f0ca9d5b5493bf6241dc7fd3901fa44ba0f72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2440478
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-10-01 10:56:06 +00:00
Patrick Brosset 6f3b86ef7f Rolling DevTools deps
This CL is the result of running the roll_Deps.py script.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Change-Id: I7d284adfc099e80493fed0810f60462bae3dad10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2413039
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-09-16 16:36:07 +00:00
Wolfgang Beyer 43f4ee3624 Update CDP
Rolls browser_protocol.pdl from chromium to devtools-frontend.

Includes update to targetInfo (backend CL: https://crrev.com/c/2309698)

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1107766
Change-Id: I21b89d4a6a71a8bc443ebbaa7452e55bd056d166
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2339525
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-08-06 08:33:17 +00:00
Olivia Flynn 828c1805a6 Updating CDP and dependencies
created with roll_deps.py && npm run generate-protocol-resources
DISABLE_THIRD_PARTY_CHECK="rolling CDP"

Change-Id: I2cd4b128c924ff34bf8675e4be896a2457de97c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2333067
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Olivia Flynn <t-olfly@microsoft.com>
2020-07-31 20:25:23 +00:00
Alex Rudenko 94a6bdf144 Update CDP
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 384968
Change-Id: Ie9a551d01bb1008e44a20363ab1e152166f68a8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2270230
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-06-29 08:20:22 +00:00
Peter Marshall 3a5e4e6908 Update CDP
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: chromium:1084558
Change-Id: I983f40d70e7412df447fd4c31bc34719f9eb07b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253901
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-06-22 08:12:13 +00:00
Alex Rudenko 0697f50b6b Filter out internal CSS properties
Internal CSS properties should not be visible anywhere so this CL
removes them from the generated files to reduce the file size.

Fixed: 1092826
Change-Id: I0b4d4694a40bef8444b06eb0578185f60651633a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2245143
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-06-15 14:29:42 +00:00
Alex Rudenko d13aac9a56 Ignore internal css keywords
Adds filtering of internal CSS keywords to generate_supported_css.py
An internal keyword was added on the blink side[1] which breaks
CSS autocompletion tests.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/2217673

Bug: 1092826
Change-Id: I6aede74affcddd88c1efabd94e2441a9b6ebd8fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236403
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-06-09 11:04:09 +00:00
Alex Rudenko d3a1df10d3 Update CDP
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 946975
Change-Id: I3034ffdd3f0da223c8b6541875768470bcff2c6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236400
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-06-09 08:59:19 +00:00
Anubha Mathur f2ea618e6b Update browser_protocol.pdl
DISABLE_THIRD_PARTY_CHECK=Update browser.pdl deps

Temporarily disabled harImporter.js test:
https://chromium-review.googlesource.com/c/chromium/src/+/2220809

Change-Id: Ic827feb73fba7f5e788a4a80d779f8f919b77234
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2220495
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
2020-05-29 18:42:33 +00:00
Alex Rudenko 00931d64f3 Update CDP
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 924698
Change-Id: I7b684933792a7b518bbd9c7964c778ced1bee26d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2178887
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-05-04 08:32:31 +00:00
Mathias Bynens 5bcd719cf0 Roll css_properties.json5
DISABLE_THIRD_PARTY_CHECK=update generated code
TBR=mathias@chromium.org,changhaohan@chromium.org,alexrudenko@chromium.org
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
Bug: chromium:1075437
Change-Id: Iaf8efd63f9b2ab4e3e18174bef89a8ac95e18a3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168091
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-04-27 16:27:07 +00:00
Mathias Bynens e231df478c Revert "Roll deps"
This reverts commit 99d87e940b.

Reason for revert: https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/1355?

Original change's description:
> Roll deps
> 
> This patch includes some manual changes to the MediaModel, in order
> to support the new playerMessagesLogged and playerErrorsRaised events
> which are added in the roll.
> 
> The patch also includes the result of:
> 
>     scripts/deps/roll_deps.py $CHROMIUM_SRC_DIR $DEVTOOLS_FRONTEND_DIR
> 
> As a drive-by, this patch also makes `scripts/deps/*.py` executable so
> that they can be invoked directly without the need to explicitly invoke
> Python.
> 
> DISABLE_THIRD_PARTY_CHECK=see above
> 
> No-Presubmit: true
> Bug: chromium:1075437
> Change-Id: I794006f5a2077c8929f7d28bdd3f7b308603b6d9
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>

TBR=mathias@chromium.org,changhaohan@chromium.org,alexrudenko@chromium.org

Change-Id: If8c4886b61ef1200bdcd2e93604f7d67c57235ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1075437
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167397
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-04-27 11:48:48 +00:00
Mathias Bynens 99d87e940b Roll deps
This patch includes some manual changes to the MediaModel, in order
to support the new playerMessagesLogged and playerErrorsRaised events
which are added in the roll.

The patch also includes the result of:

    scripts/deps/roll_deps.py $CHROMIUM_SRC_DIR $DEVTOOLS_FRONTEND_DIR

As a drive-by, this patch also makes `scripts/deps/*.py` executable so
that they can be invoked directly without the need to explicitly invoke
Python.

DISABLE_THIRD_PARTY_CHECK=see above

No-Presubmit: true
Bug: chromium:1075437
Change-Id: I794006f5a2077c8929f7d28bdd3f7b308603b6d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165756
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-04-27 11:13:45 +00:00
Mathias Bynens 51980699f7 Avoid unnecessary use of Object.entries
Previously, the script would output code of the form:

    new Map(Object.entries({
      'word-wrap': 'overflow-wrap'
    }));

This patch simplifies that down to:

    new Map([
      ['word-wrap', 'overflow-wrap']
    ]);

No-Presubmit: true
Bug: chromium:1039620, chromium:1075437
Change-Id: Ia102b46b70bdbb227c5ff41742fcb82940d48eb9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165787
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-04-27 09:32:55 +00:00
Tim van der Lippe c19ea32ca5 Fix protocol generator formats
- The protocol files were generated without license headers
- There were whitespace issues in the .d.ts files

Change-Id: I19572989360a4a537fdfe829f212587ae70e180f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107217
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2020-03-17 12:34:08 +00:00
Changhao Han 1e4c9dd21a use "alias_for" from css_properties.json5 to get canonical css property names
Bug: chromium:1039620
Change-Id: I3be48ee7da959fa500c8775323aa416de520353e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2089908
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2020-03-09 21:49:48 +00:00
Tim van der Lippe 6a0c2e2f5b Sort generated property values on keys
When dumping the JSON object, we have to ensure that the keys are in the
same order. Otherwise, the generated file is non-deterministic.

We hit this issue when we made a subsequent update in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2089908
where we are adding an additional dictionary to the file, causing
failures on Windows.

R=changhaohan@chromium.org

Bug: 1039620
Change-Id: Iec33962d4fd5dff461bc2930db54e5c85ce645b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2095300
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2020-03-09 18:00:38 +00:00
Tim van der Lippe b3b90761b1 Generate InspectorBackendCommands.js on presubmit
This checks in the InspectorBackendCommands in the source tree file
and ensures that it is kept in sync whenever the third_party
location has been updated.

In the process, I discovered multiple misconfigurations in the formatting
presubmit check. First of all, it was never running, because the
.eslintignore had an empty line. Second of all, it was running twice,
which is unnecessary since we now check for changed files at the end
of the presubmit. Lastly, it was only formatting JS files, while it
should check all files.

I have also updated the _CheckGeneratedFiles check to only run if it
is actually necessary. If there are no changes made to any affected of
the files, it will skip the step. This should thus reduce the presubmit
time and we will only pay the cost if we actually update any of the
files.

Lastly, it will now properly format and lint the generated files. This
makes reading the code a lot easier and makes it easier to digest the
diff when a protocol update goes through. I have verified that, in a
full build, the files are still minified. Thus, this has no impact on
the loading performance.

DISABLE_THIRD_PARTY_CHECK=Updating protocol generation

Fixed: 1056614
Change-Id: If49b0e749978ea1a7838992ec13507ee761ad76c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087765
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-03-04 15:52:35 +00:00
Tim van der Lippe f664763cdf Generate SupportedCSSProperties.js on presubmit
This checks in the SupportedCSSProperties in the source tree file
and ensures that it is kept in sync whenever the third_party
location has been updated.

Bug: 1056614
Change-Id: If0ff2ba0f94f1f0eded2792922e9a917820d9772
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087762
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-03-04 14:23:14 +00:00