zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
18 Commits
Author SHA1 Message Date
Kateryna Prokopenko c64378bc34 Type path and URL vars in ContentProviderBasedProject to Branded Types 
Return type of fullDisplayName cannot be set to Branded Type as it depends on the type of uiSourceCode.nameInternal, which can be any of Branded Types

Bug: 1299775
Change-Id: I84ce9b3a5535c6614b4d3486a6af7b979aa19da3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484208
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-22 16:20:40 +00:00
Kateryna Prokopenko 639a9de9d1 Type all URL and path variables in UISourceCode to Branded Types 
Bug: 1299780
Change-Id: I133ae77524d058cddcecb220fec1f7bd52116183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484202
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-22 11:27:28 +00:00
Kateryna Prokopenko 2a1b3a93b0 Type all path and URL variables in WorkspaceImpl to Branded Types 
Bug: 1299780
Change-Id: I1dffe6edc834cf5914d48c4e331510b1866f78b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3484200
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-22 10:45:29 +00:00
Kateryna Prokopenko ac21da4db6 Type path in createFile as EncodedPathString 
Bug: 1253323
Change-Id: Icc520f383e032a8a6be8cbaffded2d2896ac4d37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470238
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-14 13:04:15 +00:00
Kateryna Prokopenko 43b58939ab Remove casts to EncodedPathString from ScriptSnippetFileSystem 
Bug: 1299786
Change-Id: I8b874211d44bc203391819a4653447a67b8c2fe1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3470236
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2022-03-14 09:33:46 +00:00
Simon Zünd 72eb091458 [cleanup] Turn 'Project' into a true interface 
This CL changes 'Project' from an abstract class into an interface
and makes 'ProjectStore' an abstract base class instead. This removes
the awkward usage of an abstract class in an "implements" clause as
well as the awkward cast of 'this' to 'Project' inside 'ProjectStore'.

R=kimanh@chromium.org

Bug: 1290254
Change-Id: I9a2617557dc02743f4fe0c5c965dc9ea6bf7e675
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3423904
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-01-31 15:00:39 +00:00
Mathias Bynens cf84f8dd57 Clean up redundant Promise.resolve() in ContentProviderBasedProject 
Relevant typescript-eslint issue:
https://github.com/typescript-eslint/typescript-eslint/issues/4500

Bug: chromium:1161501
Change-Id: I7d3ef6abec7a93326040e183098e1a9c84660977
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3427063
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2022-01-31 13:50:59 +00:00
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Tim van der Lippe 113abecd98 Reland "Migrate to private class fields in models/bindings" 
This reverts commit 550eb43d4e.

Reason for revert: Fixed layout test

Original change's description:
> Revert "Migrate to private class fields in models/bindings"
>
> This reverts commit bad24493c9.
>
> Reason for revert: layout test causing autoroll failures: https://crrev.com/c/3218502
>
> Original change's description:
> > Migrate to private class fields in models/bindings
> >
> > R=​szuend@chromium.org
> >
> > Bug: 1222126
> > Change-Id: I3a6fbea503d3c0fded7208109e0d2b52b1159516
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207879
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: 1222126
> Change-Id: I47dd7e76d749c8f6503955f23ee9b5e452382ffb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3218891
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Bug: 1222126
Change-Id: I80a7a70264de8236b8da860ff2ecc05b7ae32a85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3218075
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 12:44:28 +00:00
Jack Franklin 550eb43d4e Revert "Migrate to private class fields in models/bindings" 
This reverts commit bad24493c9.

Reason for revert: layout test causing autoroll failures: https://crrev.com/c/3218502

Original change's description:
> Migrate to private class fields in models/bindings
>
> R=​szuend@chromium.org
>
> Bug: 1222126
> Change-Id: I3a6fbea503d3c0fded7208109e0d2b52b1159516
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207879
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: 1222126
Change-Id: I47dd7e76d749c8f6503955f23ee9b5e452382ffb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3218891
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-10-12 09:14:00 +00:00
Tim van der Lippe bad24493c9 Migrate to private class fields in models/bindings 
R=szuend@chromium.org

Bug: 1222126
Change-Id: I3a6fbea503d3c0fded7208109e0d2b52b1159516
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207879
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-11 15:01:49 +00:00
Jan Scheffler 085122e946 [Underscore Migration] Migrate models/bindings 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I26928144c6ade2c1494c81920c63b5e5ea9c7ade
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077888
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-07 09:02:45 +00:00
Tim van der Lippe 877f04aa0e Remove eslint-disable statements from type imports 
We no longer use the no-unused-vars and instead use the version
of typescript-eslint. The latter can properly detect unused
type-import usages. Therefore, we can remove the eslint-disable
statements, which are essentially noops.

This CL is the result of replacing

```
import type (.*) // eslint-disable-line no-unused-vars
```

with

```
import type $1
```

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I141edcb7125e414c405760af1e4058bfdc6e30f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3048473
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-26 12:53:27 +00:00
Jan Scheffler 3d889a2069 [Underscore Migration] Prework on Progress.ts 
This patch renames Progress.worked to Progress.incrementWork
to better convey what it does.

Bug:chromium:1207342
Change-Id: I48088bf7cce017ba4899729ea8fa7a9a8f51c0e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2969424
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2021-06-17 15:52:58 +00:00
Jack Franklin a75ae7cbb3 Enforce import type when importing TS types. 
Bug: none
Change-Id: I02ef1182143b7fe091ce92d59f04ac2188903e0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886925
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-11 14:00:22 +00:00
Tim van der Lippe 99aeaf3724 Move workspace to models/workspace 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia4bf7cb736dca976fb30d9e94beeda3e28115dce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815118
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-09 15:32:33 +00:00
Tim van der Lippe fca98ed75d Move text_utils to models/text_utils 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I53965f7fac3f0f932ebb73fb0e38d28831451532
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815016
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 16:07:22 +00:00
Tim van der Lippe 959b6f067a Move bindings to models/bindings 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I48168f92899d652980df36cc15475da988f760c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2810278
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-07 10:03:50 +00:00