The description here is vague, but because the issue includes both a reference to the original request and the invalid header value, it
should still be more useful to developers than the situation before this
CL, which was for invalid headers to be silently ignored.
We will add additional metadata, such as the name of the invalid header
and the reason why it was invalid, in future changes.
Screenshot of reported issue available in crbug.com/1302318#c4.
Bug: 1302318
Change-Id: Ie7f3b5e34b25ff56d832bf553ffcac674b5a57ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3644629
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
The CL https://crrev.com/c/3613872 applied some weird formatting to
the UIStrings object of DeprecationIssue.ts. This then caused the
strings to be no longer collected by our l10n infra (the CL removes
them from en-US.json).
This CL fixes that by turning off clang-format in that file and let
the PRESUBMIT script re-populate en-US.json with the UIStrings from
that file.
We have not yet imported these strings into the TC, so we were
lucky in catching this early.
Bug: None
Change-Id: I05b9faca446e19ff57ef3eccd04e919234797f8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3635181
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
At long last, we can remove the old unused fields now that no
deprecation messages are untranslated.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Migrate DeprecationInfo::* {CHROMIUM}
(13) Roll deps
(14) Migrate DeprecationInfo::* {DEVTOOLS}
(15) Cleanup Deprecations {CHROMIUM}
(16) Cleanup Deprecations {DEVTOOLS}
(17) Final documentation tweaks
DISABLE_THIRD_PARTY_CHECK=Fields are being removed, so we have to touch non-gen code
Bug: 1264960
Change-Id: If5a286a50cafc073ff99f5e0d8f3d38d5e8ba83a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3613607
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
This is the last batch of deprecation messages! The next CL will remove
the unused codepaths due to the removal of the untranslated messages.
Followup tasks are used to fill in missing descriptions.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Migrate DeprecationInfo::* {CHROMIUM}
(13) Roll deps
(14) Migrate DeprecationInfo::* {DEVTOOLS}
(15) Cleanup Deprecations {CHROMIUM}
(16) Cleanup Deprecations {DEVTOOLS}
(17) Final documentation tweaks
Bug: 1264960
Change-Id: I76f9331acfb201d856af4f98a58aa36583ca625d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3610956
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
This CL ports the new issues into the translated deprecation flow! We
finally have non-example translations ready to go :-)
For the source of the strings see:
https://chromium-review.googlesource.com/c/chromium/src/+/3597476
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Translate more Issues ...
DISABLE_THIRD_PARTY_CHECK=This will be removed when not stacked
Bug: 1264960
Change-Id: Id5853ac2e48d3300fac4b4224abf76f7d33c7117
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3600576
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
./scripts/deps/roll_deps.py ~/chromium/src ~/devtools/devtools-frontend
npm run generate-protocol-resources
I also fixed compile issues due to the removal of constants from
AttributionReportingIssue which is why non-gen files were touched.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Roll deps
(10) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(11) Document changes in development process
(12) Translate more Issues ...
DISABLE_THIRD_PARTY_CHECK=Fixes to AttributionReportingIssue
Bug: 1264960
Change-Id: I9b73f60d2cd56bced19e908a761b3d90ad940c46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3600575
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
These links are the last bit of information missing from the translated
deprecation issue format. With this addition, we can start to migrate
messages.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Translate more Issues ...
Bug: 1264960
Change-Id: I12ae4a7f14b81acdb272cb315aaebd424f980eda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3591172
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
This CL adds support for translated issues in devtools_frontend.
The next step is to document (5) and start translating issues (6).
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Translate more Issues ...
Bug: 1264960
Change-Id: I5813a3b6ff5649dc78144a0f92f20480fa069634
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3561186
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
This CL starts the process of translating the deprecation issue message
by focusing on the title first. I noticed the markdown files aren't
auto-translated so this step seems necessary.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Translate more Issues ...
Bug: 1264960
Change-Id: Ie6548e441f88931c1930e8d2864db7513b7b196f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3533216
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
These changes rename SameSiteCookieIssue to CookieIssue. A follow-up
CL will make the file name change. It rolls the browser_protocol.pdl
from Chromium to DevTools frontend. Removes the compatibility changes
introduced in [1].
DISABLE_THIRD_PARTY_CHECK=changes required due to renaming
[1]: https://crrev.com/c/3478766
Bug: 1254192
Change-Id: I45b86611edfa469238f7f30bf0006556e8f07fd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3499339
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Juba Borgohain <chromiumjuba@gmail.com>
Andrew Paseltiner
