zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
6 Commits
Author SHA1 Message Date
Tim van der Lippe 4ea6ff4ba5 Migrate to private class members in models/issues_manager/ 
R=szuend@chromium.org

Bug: 1222126
Change-Id: Ie434053809b20f2309a4f771dd1137887bedf62b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3342106
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-12-15 16:57:47 +00:00
Sigurd Schneider 4c29a69985 Ensure P.Audits.IssueId is type-annotated consistently 
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: Ic9d3352c7ce348aa180b0b110208e5aefb9bdf8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3074606
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-05 11:44:39 +00:00
Simon Zünd 31a0489b00 Use type-safe events for IssuesManager 
This CL introduces a new type for the "IssuesManager.IssueAdded" event.
Using the new type-safe event infrastructure, all consumers of
IssuesManager events are now type-safe.

Bug: 1228674
Change-Id: I3e015fb3c44f26510fb78c385508a338bde741d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978378
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-19 06:48:21 +00:00
Simon Zünd 9a59e40402 [issues] Fix IssuesResolver using outdated event payload type 
The payload for the IssueManager.Events.IssueAdded changed a few months
ago from passing a single issue to passing a (issue, model) tuple.

This CL updates the MockIssuesManager and IssuesResolver to use the
correct type.

Once type-safe event listeners are available, this sort of bug will
be prevented.

Bug: 1229955
Change-Id: Ia574420f49efe222309bb62b6bad0732ae7c93c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3034064
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-07-16 09:29:19 +00:00
Simon Zünd 735921cd29 [cleanup] Move removeEventListeners off EventTarget 
removeEventListeners is already an exported function. Removing
the static method from `EventTarget` allows us to make `EventTarget`
a true interface.

Bug: 1228674
Change-Id: I8a870edc90438f6556b08f3329df6b2f850be297
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978375
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-07-13 12:33:35 +00:00
Sigurd Schneider 83c78f376d Introduce IssueResolver that can resolve issueIds to issues 
Bug: chromium:1213393
Change-Id: I1ec5792fd93cf0d21ba7bf5949b8db480be0eafd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3015649
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-12 09:44:24 +00:00