zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-13 01:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 45 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
39 Commits
Author SHA1 Message Date
Danil Somsikov 1d6bfbff90 Remove IssueManager when deinitializing global vars. 
Bug: 1306830
Change-Id: Ibb82b6470b04255e3919e12fd4a79e8b9a839259
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3541303
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2022-03-22 09:41:13 +00:00
Juba Borgohain 3adc3415bd Rename SameSiteCookieIssue.ts to CookieIssue.ts 
These changes are a follow-up to [1]. Because of the file rename
it also makes changes to locale json files and build files.

DISABLE_THIRD_PARTY_CHECK=changes required due to renaming

[1]: https://crrev.com/c/3499339

Bug: 1254192
Change-Id: Ie181b83067e720c3fd11cbf69ed7888d3d0615a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3500399
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Juba Borgohain <chromiumjuba@gmail.com>
 2022-03-03 12:02:17 +00:00
Juba Borgohain 2af14943bb Rename SameSiteCookieIssue to CookieIssue 
These changes rename SameSiteCookieIssue to CookieIssue. A follow-up
CL will make the file name change. It rolls the browser_protocol.pdl
from Chromium to DevTools frontend. Removes the compatibility changes
introduced in [1].

DISABLE_THIRD_PARTY_CHECK=changes required due to renaming

[1]: https://crrev.com/c/3478766

Bug: 1254192
Change-Id: I45b86611edfa469238f7f30bf0006556e8f07fd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3499339
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Juba Borgohain <chromiumjuba@gmail.com>
 2022-03-02 14:20:02 +00:00
Juba Borgohain be6b397cdf Translates CookieIssue to SameSiteCookieIssue 
This is a temporary change to translate CookieIssue to
SameSiteCookieIssue so changes can remain backwards compatible.
This compatibility code change will be removed once the refactoring
is completed.

Bug: 1254192
Change-Id: Iacc8a0cd182f30a6e7f0701bac63ab943b440607
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3478766
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Juba Borgohain <chromiumjuba@gmail.com>
 2022-02-25 03:39:20 +00:00
Danil Somsikov ce54fe62b7 Show FedCM issues in devtools 
Bug: 1291653
Change-Id: Ia8e4d5c0a25cb2b1f8048deae59534dfce3b2397
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3432785
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2022-02-08 08:05:33 +00:00
Wolfgang Beyer 1655fc6e5b Remove WASM cross-origin module sharing issue 
Cleaning up because after deprecation these issues are no longer needed.

Backend CL: https://crrev.com/c/3404078

Bug: 1257980
Change-Id: I9168299c4287c2b9e939b002e3463550e9de2d78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3404098
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2022-01-20 17:16:31 +00:00
Ari Chivukula 8ad687341f [Client Hint Issue] (3) Implement devtools issue {DEVTOOLS} 
Now that third-party delegation via markup for client hints is in M99,
we need to start alerting developers where they use unsupported
features. These features will be expanded and extended as more client
hint features launch.
https://docs.google.com/document/d/1lDEvj8tMeuvUs1HTTqL-44YiI-7ljeQkusM_WhUfIeE/edit

This CL is a part of a series:
(1) Implement devtools issue {CHROMIUM}
(2) Update devtools protocol {DEVTOOLS}
(3) Implement devtools issue {DEVTOOLS}

Bug: 1219359
Change-Id: Ia8aaf05b98894fd32f5aad8f973fcdf774e1634c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3343149
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Rowan Merewood <merewood@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
 2021-12-16 12:12:18 +00:00
Tim van der Lippe 4ea6ff4ba5 Migrate to private class members in models/issues_manager/ 
R=szuend@chromium.org

Bug: 1222126
Change-Id: Ie434053809b20f2309a4f771dd1137887bedf62b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3342106
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-12-15 16:57:47 +00:00
Ari Chivukula 86d4791e9d [Deprecation Console->Issue] (8) Implement Deprecation Issue (DevTools) 
This implements the deprecation protocol code per:
https://docs.google.com/document/d/1gU2caqBEek2x8AeKop9SrSxqlO51ipealPMV4aisQNE/edit
https://docs.google.com/document/d/1Jot9P30LFW9TQtc6eaQP9wRBwjLpUn-hIaxRJRUBFvI/edit

This is a part of a set of CLs:
(1) Remove legacy CSS Deprecation path
(2) Consolidate DeprecationInfo
(3) Streamline redundant Deprecation messages
(4) Add features for console/issue deprecation
(5) Fix feature status detail link
(6) Implement Deprecation Issue (Chromium)
(7) Move DeprecationIssue.ts code
(8) Implement Deprecation Issue (DevTools)
(9) Disable Console Deprecation
(10) Remove Console Deprecation

Bug: 1248484
Change-Id: I59b2ce66dfaea82bf38bf36dc905f9ab13172a21
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3258023
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-03 17:29:27 +00:00
Ari Chivukula b7905373b9 [Deprecation Console->Issue] (7) Move DeprecationIssue.ts code 
We should use the name DeprecationIssue for the new one we're making.
This one is for NavigatorUserAgentIssue.

This is a part of a set of CLs:
(1) Remove legacy CSS Deprecation path
(2) Consolidate DeprecationInfo
(3) Streamline redundant Deprecation messages
(4) Add features for console/issue deprecation
(5) Fix feature status detail link
(6) Implement Deprecation Issue (Chromium)
(7) Move DeprecationIssue.ts code
(8) Implement Deprecation Issue (DevTools)
(9) Add SourceLocation integration
(10) Launch Issue Deprecation
(11) Remove Console Deprecation

Bug: 1248484
Change-Id: I76c083db79dae8d708e58a902746179274040b3f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3245990
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-27 17:19:35 +00:00
Wolfgang Beyer 521312ac7b Let issue counters not count hidden issues 
This CL updates the number returned when querying for the number of
issues such that issue counters now do not count hidden issues.

Fixed: 1252726
Change-Id: I9d792215006b21d484e827dbea7528bd32050f65
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3207872
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-07 06:39:58 +00:00
Wolfgang Beyer 145e077027 Group Issues in the issues panel by IssueKind 
This cl includes logic which allows users to toggle grouping issues by issue kinds.

Screenshot: https://drive.google.com/file/d/1-blXNVQT185XJSnx4Tkq8CLj9jFvpc6X/view?usp=sharing

Bug:1175722
Change-Id: Ic6e0bc664f548b3f594df5fa79a5ec0f1455fd79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3099005
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-10-05 14:19:33 +00:00
Kateryna Prokopenko 77b1e27ced Add models functionality for GenericIssue 
Bug: 1246855
Change-Id: I96369a061b81888cd4d3d292e796cfb9b11f6753
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3187190
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2021-10-05 07:12:03 +00:00
Rahat Muneeb adc1e1a010 Unhide-issues in the Hidden Issues Row. 
This cl introduces the Hidden Issues Row and gives users the ability to unhide issues by IssueCode

Screenshot: https://drive.google.com/file/d/1PWIouPeSc_CqFO8vj98qspsfEGzlVd3E/view?usp=sharing

Bug:1175722
Change-Id: Ic188a091e596175981e24db280d91dc2078b47a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3085194
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-12 14:56:23 +00:00
Sigurd Schneider 0c89c093ba Only set hidden status for issues if experiment is enabled 
Bug: chromium:1175722
Change-Id: I70908e8b60412df88bd296f5ce3b7ed5a76e97ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3090598
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-12 13:53:13 +00:00
Sigurd Schneider bf0eead691 Only set issues hidden when the feature is enabled 
We currently set issues hidden independent of the status of the
'hideIssuesFeature', which means that if someone
1. enables the feature
2. hides an issue
3. disabled the feature
then the hidden issue will remain hidden with no UI to show it
again.

Bug: chromium:1175722
Change-Id: I15fe300ee7c75a167deb37bd8c3644a6c65a5c23
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3087346
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-08-11 07:29:15 +00:00
Rahat Muneeb 0200fc96fe Hide issues in the Issues panel 
This feature allows users to hide issues in the issues panel

Bug:1175722
Change-Id: I5d1b40be670635b2242f1619a18cc3d4d6e92008
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2985466
Commit-Queue: Rahat Muneeb <irahatmuneeb@gmail.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-30 12:42:56 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max 
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 14:10:15 +00:00
Tony Ross e4f74639df Remove circular dependency between IssuesManager and SourceFrameIssuesManager 
This change extracts the IssuesManager Events enum into a separate file
to break the circular dependency of values between IssuesManager.ts and
SourceFrameIssuesManager.ts. This helps reduce existing circular
dependencies, in theory moving us slightly closer to being able to
warn about such cycles at build-time to avoid unexpected errors.

This particular cycle recently led to a runtime error when attempting to
subclass IssuesManager to introduce additional functionality. This
subclass was included in the cycle as SourceFrameIssuesManager was
updated to import the subclass instead of IssuesManager. At the time
the Events enum for IssuesManager was non-const, causing the circular
dependency to exist post-build. The error occurred because the extends
relationship of the subclass was evaluated during module initialization.

Since then the Events enum has been converted to const which eliminates
the runtime error. However, eliminating even this cycle is still
beneficial. The compile-time only relationship is not obvious and
cannot otherwise be communicated explicitly until values from const enums
can be used with `import type` per
https://github.com/microsoft/TypeScript/issues/40344.

Bug: 1229328
Change-Id: I033080c77f22584aa0527bcd0559698341d200f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3040178
Commit-Queue: Tony Ross <tross@microsoft.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-21 16:12:29 +00:00
Simon Zünd ead1c8f1cb Use type-safe events for FrameManager 
R=wolfi@chromium.org

Bug: chromium:1228674
Change-Id: Idded229a07b23fd9d2f03cabfeed250a20ac87bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3037546
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-21 08:40:22 +00:00
Simon Zünd 27bf2c65c8 Use type-safe events for IssuesModel 
This CL forwards the `Events` generic parameter of `ObjectWrapper` on
`SDKModel` that allows SDKModel subclasses to use type-safe event
listeners.

Drive-by: Cleanup IssuesModel.

R=tvanderlippe@chromium.org

Bug: chromium:1228674
Change-Id: I7843dfffe7a91d40cdbc5abd4d6ceae4db9de41d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3037543
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-07-19 10:39:10 +00:00
Simon Zünd 31a0489b00 Use type-safe events for IssuesManager 
This CL introduces a new type for the "IssuesManager.IssueAdded" event.
Using the new type-safe event infrastructure, all consumers of
IssuesManager events are now type-safe.

Bug: 1228674
Change-Id: I3e015fb3c44f26510fb78c385508a338bde741d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978378
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-07-19 06:48:21 +00:00
Simon Zünd 735921cd29 [cleanup] Move removeEventListeners off EventTarget 
removeEventListeners is already an exported function. Removing
the static method from `EventTarget` allows us to make `EventTarget`
a true interface.

Bug: 1228674
Change-Id: I8a870edc90438f6556b08f3329df6b2f850be297
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978375
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-07-13 12:33:35 +00:00
Sigurd Schneider 5a9892c359 Add issue for cross-origin shared Wasm modules 
Bug: chromium:1224881
Change-Id: Iebc6cc281609594dfa5da5fa9e1c56d7e79d4763
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003261
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-07-06 12:31:10 +00:00
Sigurd Schneider 9548c0e4c0 Expose issueId on Issue and a couple of related classes 
Bug: chromium:1213393
Change-Id: I736a6934732f9456f8408059dc90eb11605827c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2974931
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-06-23 09:51:39 +00:00
Simon Zünd 66ff0add05 [cleanup] Initialize fields inline instead of in the constructor 
As per TypeScript style guide, simple field initializers should be
part of the field declaration. This way, constructors may often
be omitted or its more clearer if a constructor does more heavy
lifting than setting fields.

R=wolfi@chromium.org

Bug: None
Change-Id: Ia935e5b748f2002187a1d01d121baad2ed11ddfc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960463
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-15 09:12:34 +00:00
Simon Zünd db7686deb5 [issues] Fix AttributionReportingIssue.fromInspectorIssue 
The intial AR CL got the interface wrong. This CL fixes the
corresponding `fromInspectorIssue` so it takes a complete protocol
issue object instead of just the details.

Drive-by: Issues without "Learn more" links currently have a somewhat
large empty bottom margin. This CL skips adding the link container div
when there are no links specified.

R=sigurds@chromium.org

Bug: chromium:1190735
Change-Id: Ia6c251020a0061d9b9b08fa12a9f80a1b07a3e90
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960616
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-06-14 13:11:34 +00:00
Sigurd Schneider 75ae46fe4f Refactor fromInspectorIssue interface 
This enables piping the issueId to the issue creation.

Bug: chromium:1213393
Change-Id: I15d57d93fb3a98b5dbb3bb33fbd1c543f09758e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2931802
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-06-02 08:36:36 +00:00
Sigurd Schneider b9f6c7910e Move TargetManager to its own file 
Change-Id: I4708a6303198bc5c4ff6aa8e2b2a2f5e4530725f
Bug: chromium:1213943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919763
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-31 11:24:26 +00:00
Sigurd Schneider d6ed7f02fa Resolve typing todo's after protocol roll 
We used a couple of any types because we didn't want to depend on
the protocol roll for a CL. This CL cleans the types up after the
protocol changes have rolled in https://crrev.com/c/2916375.

Bug: chromium:1210842
Change-Id: I848e144d3d9587dbaf7588e13c1e6be383423920
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2916376
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-25 09:54:33 +00:00
Sigurd Schneider 9dfafb3241 Add issue for usage of user agent in JS 
This adds an issue about the usage of navigator.userAgent (and friends)
to the issues tab. This issue will be triggered on a lot of pages,
but since the change is risky, discussion revealed that this was a
good way of making people aware of the change.

Bug: chromium:1210842
Change-Id: Ib9912d33bf9391772488da1e00fb7760931aee0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905504
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
 2021-05-19 14:22:24 +00:00
Sigurd Schneider 388eea1ac3 Remove unnecessary diagnostic console.warn 
This console.warn was added to make it easier to identify the cause
for test breakage on https://crrev.com/c/2878731 and is not needed
anymore.

Bug: chromium:622660
Change-Id: I90931dd0782282fa94142d6c598e013cb49220af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2900257
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2021-05-17 10:42:12 +00:00
Changhao Han 79d5f4274f Add QuirksMode issue to the Issues tab 
Design doc: https://docs.google.com/document/d/13JFp5igs0yNr7CT6Nu-qGoFMbtbrrH5UcCyrH-JwvcY/edit

Screenshot: https://imgur.com/a/p4OWNX9

Backend CL: https://crrev.com/c/2875213

Bug: chromium:622660
Change-Id: I137fd4cf25a767b1dfbda4fa0148b4dc99997d24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2878731
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-17 10:09:22 +00:00
Tim van der Lippe 038d808e1a Import protocol types in models/ 
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: Icfda82842d5bd1e1da5fff109605925113fc651b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897516
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-05-17 07:59:52 +00:00
Sigurd Schneider 3fec5ca7c7 Update DevTools Chromium DEPS. 
TBR=machenbach@chromium.org,liviurau@chromium.org

DISABLE_THIRD_PARTY_CHECK=unblock roll

Bug: chromium:1209155
Change-Id: I9f029652effc0a8cd8cef8bb67d4d104f099e518
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897257
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-05-14 11:07:59 +00:00
Jack Franklin a75ae7cbb3 Enforce import type when importing TS types. 
Bug: none
Change-Id: I02ef1182143b7fe091ce92d59f04ac2188903e0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886925
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-05-11 14:00:22 +00:00
Simon Zünd c5716504bc [issues] Inject 'third party' setting into IssuesManager 
Injecting the setting via constructor removes any dependency onto
global state. This means IssuesManager can now be tested in isolation
without the need of 'describeWithEnvironment'.

R=sigurds@chromium.org, tvanderlippe@chromium.org

Bug: None
Change-Id: Idf99c606f49d76fc0dc3f58af5a77131fe5e5cf5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2866385
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-04 12:19:35 +00:00
Sigurd Schneider 84b6cf7111 Move Issue model classes to models/issues_manager 
Bug: chromium:1192078
Change-Id: I6a0d3ac29a9954b41946c08286585b9676de934e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2822637
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-04-13 09:01:17 +00:00
Sigurd Schneider 055e2e39cc Move issue-related non-presentation classes to models/issues_manager 
The issues_manager has two classes (IssuesManager, ContrastCheckTrigger)
that need to be instantiated early because they listen to events and
we need to make sure non are missed. These two classes are instantiated
in issues_manager.ts.

Bug: chromium:1192078
Change-Id: Iba7fce8b4bb52c6cef39f497f1a0101410e98044
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2817810
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-12 12:28:07 +00:00