Commit Graph
9 Commits
Author SHA1 Message Date
Tim van der Lippe 4ea6ff4ba5 Migrate to private class members in models/issues_manager/
R=szuend@chromium.org

Bug: 1222126
Change-Id: Ie434053809b20f2309a4f771dd1137887bedf62b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3342106
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-12-15 16:57:47 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-07-28 14:10:15 +00:00
Sigurd Schneider 75ae46fe4f Refactor fromInspectorIssue interface
This enables piping the issueId to the issue creation.

Bug: chromium:1213393
Change-Id: I15d57d93fb3a98b5dbb3bb33fbd1c543f09758e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2931802
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-06-02 08:36:36 +00:00
Tim van der Lippe 038d808e1a Import protocol types in models/
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: Icfda82842d5bd1e1da5fff109605925113fc651b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897516
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-17 07:59:52 +00:00
Jack Franklin a75ae7cbb3 Enforce import type when importing TS types.
Bug: none
Change-Id: I02ef1182143b7fe091ce92d59f04ac2188903e0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2886925
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-05-11 14:00:22 +00:00
Simon Zünd 5fb4a1795d [cleanup] Make 'substitutions' implicitly undefined in descriptor
The property has been marked either as a MarkdownIssueDescription or
an explicit undefined. This was due to how Closure typedefs worked.
After TS migration this is no longer necessary and we can remove all
the explicit undefined fields.

R=wolfi@chromium.org

Bug: None
Change-Id: Ia0b94f9c6f27239f6d3cfac7d5fcb83b56424834
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2853543
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-04-27 12:35:21 +00:00
Sigurd Schneider 574f62194f Cleanup MarkdownIssueDescription and add comments
Bug: chromium:1072335
Change-Id: Ib9a8fa7b4b86f8cecca265860053038f67e50cda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831436
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-04-16 11:22:15 +00:00
Sigurd Schneider 693a0e7803 Load issues via XMLHttpRequest
Bug: chromium:1192078
Change-Id: Ia96d4cc1e52a21c35ef0cbefced9c8961cde02be
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2825797
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-04-15 12:47:23 +00:00
Sigurd Schneider 84b6cf7111 Move Issue model classes to models/issues_manager
Bug: chromium:1192078
Change-Id: I6a0d3ac29a9954b41946c08286585b9676de934e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2822637
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-04-13 09:01:17 +00:00