Commit Graph
36 Commits
Author SHA1 Message Date
Kateryna Prokopenko a2d72a5d31 Type all path and URL variables in core/sdk to Branded Types
Bug: 1299773
Change-Id: I54609104283c074d0f3e03917dc9ba2a77544290
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3548478
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-03-28 12:39:45 +00:00
Kateryna Prokopenko 9964ab12fa Type URL vars NetworkLog to UrlString
Bug: 1299780
Change-Id: Ie89ed7f1403d636a506e93e2af872a3f3b45c5fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3535882
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
2022-03-23 17:35:11 +00:00
Tim van der Lippe 6bcbe0f26d Use window.setTimeout to avoid TS errors in VS Code
R=aerotwist@chromium.org

Bug: none
Change-Id: I632aa0beb0e157197f5c2f982c2082a6d67f87f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380595
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
2022-01-11 19:17:48 +00:00
Wolfgang Beyer fa718b573b Reland "Link from console message to network request if request id is available"
This is a reland of 4d79362604

Original change's description:
> Link from console message to network request if request id is available
>
> When a console log entry is created via CDP's `Log.entryAdded()` and
> the optional `networkRequestId` is available, then add an icon to the
> console message which links to the network request in the network
> panel
>
> Screenshot: https://i.imgur.com/zAfaOR5.png
>
> Bug: 1260776
> Change-Id: Iddf2c4b16ad11ff9ea7fc8c292a4591d72e6e657
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263406
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>

Bug: 1260776
Change-Id: I679d1930411223f5bea2858f93b1de6a02ee33f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3269837
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2021-11-09 13:56:40 +00:00
Wolfgang Beyer c71d3c0802 Revert "Link from console message to network request if request id is available"
This reverts commit 4d79362604.

Reason for revert: Breaking tests for Roll CL https://crrev.com/c/3268827

Original change's description:
> Link from console message to network request if request id is available
>
> When a console log entry is created via CDP's `Log.entryAdded()` and
> the optional `networkRequestId` is available, then add an icon to the
> console message which links to the network request in the network
> panel
>
> Screenshot: https://i.imgur.com/zAfaOR5.png
>
> Bug: 1260776
> Change-Id: Iddf2c4b16ad11ff9ea7fc8c292a4591d72e6e657
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263406
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>

Bug: 1260776
Change-Id: Ib3f101de3f0e5d2e2cb1dba91da581e0cc592122
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3269830
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2021-11-09 09:21:14 +00:00
Wolfgang Beyer 4d79362604 Link from console message to network request if request id is available
When a console log entry is created via CDP's `Log.entryAdded()` and
the optional `networkRequestId` is available, then add an icon to the
console message which links to the network request in the network
panel

Screenshot: https://i.imgur.com/zAfaOR5.png

Bug: 1260776
Change-Id: Iddf2c4b16ad11ff9ea7fc8c292a4591d72e6e657
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263406
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2021-11-08 17:27:21 +00:00
Danil Somsikov 82873eeb1c Add option to hide CORS errors in console
Bug: 1251176
Change-Id: I321fc4864bbbb15bfd7ad46e5a1a7f7d066a0ebf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3175286
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-09-30 10:51:17 +00:00
Kateryna Prokopenko 460f549c51 Use type-safe events for NetworkLog
Bug: 1228674
Change-Id: Id6d367d2fa2590a0aa1549984bf086947ec7f775
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3122338
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
2021-08-30 07:28:34 +00:00
Sigurd Schneider 171b7961d5 Type annotate ScriptId
DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I22b69f920789a9eb0516de2bc86d0e05dd0454da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3103235
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-08-18 15:40:31 +00:00
Jan Scheffler 4f199732f9 [Underscore Migration] Migrate models/logs
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: I32f470a3bd7a2c3b63f7753ed8db6012213faeab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077897
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-08-06 16:55:56 +00:00
Simon Zünd 99417c043c Use type-safe events for NetworkManager
R=sigurds@chromium.org

Bug: 1228674
Change-Id: Ib921a2c06cfd559562ed1b0fc7b4a7a5fb6264e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3068930
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-08-03 14:12:18 +00:00
Simon Zünd f375ea5f14 Use type-safe events for LogModel
R=sigurds@chromium.org

Bug: 1228674
Change-Id: I2c8cc01c4e94990593714a65b1513af91412b05d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3068925
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-08-03 11:58:53 +00:00
Simon Zünd 1a9304907f Use type-safe listeners for ResourceTreeModel events 2/2
R=wolfi@chromium.org

Bug: 1228674
Change-Id: I633e968442974a9c5e2b1b56604a456c585bbb19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3062563
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2021-07-30 10:23:46 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-07-28 14:10:15 +00:00
Sigurd Schneider 397d90e0ab Resolve TODOs in front_end/modles/logs
Bug: chromium:1172300
Change-Id: If9d35818b482f053404ca65e1f82fe38baf17c9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3029982
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-07-16 07:21:59 +00:00
Simon Zünd 735921cd29 [cleanup] Move removeEventListeners off EventTarget
removeEventListeners is already an exported function. Removing
the static method from `EventTarget` allows us to make `EventTarget`
a true interface.

Bug: 1228674
Change-Id: I8a870edc90438f6556b08f3329df6b2f850be297
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978375
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-07-13 12:33:35 +00:00
Sigurd Schneider 11614370f4 Refactor out ResolverBase for reuse
Bug: chromium:1213393
Change-Id: Id207d7d6019c69cb48607900af65126102e2f26a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3015647
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-07-12 09:28:04 +00:00
Sigurd Schneider 3d756d2481 Ensure consistent usage of Protocol.Network.RequestId
This uncovered the fact that NetworkRequests really have two
request ids: One that is a string used in the front-end that
doesn't always have a corresponding request in the back-end,
and one that is always a back-end id. This CL makes this
explit in the types.

DISABLE_THIRD_PARTY_CHECK=disable

Bug: chromium:1226471
Change-Id: I894d6ab4d14099b9793c5e1c1a2863d2ec9c2548
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014857
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-07-09 12:06:52 +00:00
Sigurd Schneider e0ab5f1fcc [cleanup] Improve types in ConsoleModel
Follow-up to https://crrev.com/c/2987959 that changes semantics
slightly: In a couple of places we don't convert the empty string
to undefined anymore, and we use undefined instead of null in a couple
of other places after this CL. Our educated guess is that it doesn't
matter.

Bug: chromium:1213393
Change-Id: Ie98059d328cc20d2ecde771ce29de929cf2c0fe2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987962
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-06-28 13:33:41 +00:00
Sigurd Schneider 6cf1fdb535 Use options bag for ConsoleMessage constructor
Depends on test update CLs:
Disable tests in https://crrev.com/c/2988019
Update and reenable tests: https://crrev.com/c/2988020

Bug: chromium:1213393
Change-Id: I12478e4906e31226e2fc31696f8f03c01dd02a9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2987959
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-06-25 10:11:17 +00:00
Sigurd Schneider 423b2bec97 Reland: Add component for linking to network requests
This CL adds a component that can be used to link to a network request.
The component optionally uses a RequestResolver to resolve the request
if only a requestId (in the form of an affected request) is provided.
The component updates its state once the request becomes available,
thereby supporting plasticity of the UI.

This is a plain reland of https://crrev.com/c/2960617. Landing
the CL originally uncovered a deficiency in the way our tests
were written, see crbug.com/1223300.

Bug: chromium:1217975
Change-Id: Ideccf4f9e64cf451a8c28583a9d72e717ff6706f
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_mac_rel
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983021
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-06-25 07:11:56 +00:00
Tim van der Lippe 591e00454b Revert "Add component for linking to network requests"
This reverts commit 5be8e37c41.

Reason for revert: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8843807658951242785/+/u/E2E_tests/stdout makes CORS test flake on Mac

Original change's description:
> Add component for linking to network requests
>
> This CL adds a component that can be used to link to a network request.
> The component optionally uses a RequestResolver to resolve the request
> if only a requestId (in the form of an affected request) is provided.
> The component updates its state once the request becomes available,
> thereby supporting plasticity of the UI.
>
> Bug: chromium:1217975
> Change-Id: I94faa598bb520d4cbdf003ca7858ec759fcc8a6c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960617
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>

Bug: chromium:1217975
Change-Id: I2d0a9b08a913a179dba913878c8789c55308ed66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978380
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-06-22 13:35:49 +00:00
Simon Zünd 4cb2aab19f [l10n] Improve descriptions and fix plurals
Bug: None
Change-Id: Ie2635935cb7a608df9dc803947d85542c4a32c8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2882758
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-06-22 11:21:39 +00:00
Sigurd Schneider 5be8e37c41 Add component for linking to network requests
This CL adds a component that can be used to link to a network request.
The component optionally uses a RequestResolver to resolve the request
if only a requestId (in the form of an affected request) is provided.
The component updates its state once the request becomes available,
thereby supporting plasticity of the UI.

Bug: chromium:1217975
Change-Id: I94faa598bb520d4cbdf003ca7858ec759fcc8a6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2960617
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-06-21 13:52:52 +00:00
Danil Somsikov cd1691bc4f Show pending requests from the previous page as unknown.
Only keep alive requests can survive page unload and there's no more
connection to devtools to report the request status.

Bug: 1072006
Change-Id: Ibd30bbd5ea240f2acf56258c2e67eed52d4d12ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2963192
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2021-06-17 13:11:17 +00:00
Sigurd Schneider 355a757a3a Refactor request-resolving logic to RequestResolver
When resolving requestIds to requests, it can happen that the request
has not yet arrived from the back-end. We currently have logic in the
issues panel that takes care of such cases by registering a listener
on the network log to learn about a request with a certain requestId
when it becomes known to the DevTools front-end. This CL refactors that
logic into its own class, and adds a promisified interface as well.

Bug: chromium:1217975
Change-Id: Ide7f6d41911f3d19fa392ed94230bd24cb48c1d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2949047
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-06-10 06:34:20 +00:00
Sigurd Schneider b9f6c7910e Move TargetManager to its own file
Change-Id: I4708a6303198bc5c4ff6aa8e2b2a2f5e4530725f
Bug: chromium:1213943
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919763
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-05-31 11:24:26 +00:00
Simon Zünd d74e151c60 Add missing dependencies
Experimenting with remote build execution revealed that many TypeScript
targets are not specifying all their dependencies in GN.

R=tvanderlippe@chromium.org

Bug: 1211289
Change-Id: Ie4d1dbedd1d8190595281bfe3715169b61cba3d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2912735
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-05-25 11:13:33 +00:00
Tim van der Lippe 025a168806 Add missing DEPS on protocol
When we made the protocol importable, the `ts_library` targets no
longer recompile when we update the protocol. To make sure that
all `ts_library` targets recompile when doing so, we need to
add the proper DEPS on them.

This patch makes sure that https://crrev.com/c/2902705 is correctly
recompiling (and failing DevTools) with the protocol update.

Longterm, we should enforce that all imported modules are listed
in the BUILD.gn file, to make sure that they recompile when required.

R=szuend@chromium.org

Bug: 1210830
Change-Id: I9fa108f84edf4f431328aa26e2df25fb1f440732
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905501
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-05-19 11:46:33 +00:00
Tim van der Lippe 038d808e1a Import protocol types in models/
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: Icfda82842d5bd1e1da5fff109605925113fc651b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897516
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-17 07:59:52 +00:00
Tim van der Lippe eb876c6b1e Generate const enums in protocol.d.ts
Some files currently rely on the Protocol to be available on the
global scope. However, the Protocol definitions are defined in
a .d.ts file, which isn't available on runtime. Therefore,
attempting to import Protocol with non-type imports would retain
the imports in the `.js` files and break on runtime.

Since the only usages of the Protocol on runtime are the enums,
we can make them const, such that they get inlined as intended.
Then, `import * as` will work again, as the enums are inlined and
the import is removed from the `.js` file.

DISABLE_THIRD_PARTY_CHECK=Protocol update
R=jacktfranklin@chromium.org

Bug: 1208357
Change-Id: I749e57c9f51596866b61cab686c59f00bc8a8eb4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897277
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-05-14 15:51:00 +00:00
Tim van der Lippe 300f2b3d7b Add GN visibility for models/
Downstream projects can define the devtools_models_visibility in
their `default_args` in their `.gn` file to add any other
dependencies.

R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I7e9ab02d3bcb0f76b170f3a5ffe67afb790d6285
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854687
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-28 13:07:14 +00:00
Tim van der Lippe 3fff977fdd Add GN visibility to all meta targets
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I7be4bd13a731065a9291cc4b37b830130b0873e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854676
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-28 09:10:13 +00:00
Tim van der Lippe bbb43fbe74 Consolidate owners in models/
Not every single person was present in all folders, but these owners
were present in a majority of all folders.

R=yangguo@chromium.org

Bug: 1187573
Change-Id: I4ed38d3e118715ab3ed14bd261095b0c8d54e6e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2848235
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-04-26 13:51:40 +00:00
Sigurd Schneider cf5b83042e Move NetworkLog to models/logs
NetworkLog is contains all requests encountered so far, and connects
them to each other and other entities. It uses many core/sdk classes
to accomplish that, but the actual job is conceptually one level
above SDK. This CL makes this explict and moves the NetworkLog to
models/logs.

Bug: chromium:1199668
Change-Id: I86331d4ee7e07cfa178f0c6ea3d09ab13ee0c93f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2846337
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-04-23 08:45:47 +00:00
Sigurd Schneider 7670c3304e Move LogManager to models/logs
This removes the browser_sdk/ library. In a follow-up, I want to move
NetworkLog to models/logs as well, but this is currently blocked on
tests in chromium.

Bug: chromium:1199668
Change-Id: Ibc263b6536f84c82499b68837177b112def2f359
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831446
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2021-04-16 14:47:35 +00:00