This functionality adds on top of the existing query mechanism, rather
than modify it.
This is because a query string can have multiple filters, some of them
regular expressions, some not. Each one of those filters could already
be negated with a "-" prefix, including the regular expressions. The
newly added top-level `invert` checkbox therefore inverts each one of
those individual filters, and properly handle the situation where a
query has multiple filters each with its own optional negation.
The drive-by changes to TextUtils.ts are primarily cosmetic, modernising
the JS slightly to help readability.
Change-Id: I3d429a98074eb3517ec891a848ea75c6c96d1ea5
Signed-off-by: Victor Porof <victorporof@chromium.org>
Bug: 1054464
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3034342
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Some files that don't import codemirror itself do refer to types
as declared by CodeMirror, which therefore need to implicitly
side-effect import the types. The reason being that these files
are used in both the standalone and full version of CodeMirror
(depending on whether they run in a worker context or not).
Therefore, they can't import `third_party/codemirror/codemirror.ts`,
as that would only contain the full version.
DISABLE_THIRD_PARTY_CHECK=Tsc update
R=szuend@chromium.org
Bug: 1209844
Change-Id: I8719a15b40e9d9f085b24c05af4372ad84812d1f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897979
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Marijn Haverbeke