zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
46 Commits
Author SHA1 Message Date
Changhao Han 6f6fbc0a9c UX fixes for Changes tracking 
This CL includes the following fixes/UX improvements:
- Allow user selection and clicking to source in Changes tab

- Match green change indicator with multiple changed lines

- Move style section bottom toolbar down to leave room for copy button

These come from this doc: https://docs.google.com/document/d/1DMM-oK64W0V9pbZ0fZLZ44Lxwg3OyjZ6fh3iCXNIRDY/edit

Bug: 1268754, 1297825, 1317599, 1299278
Change-Id: I04a7555feea2c900db182123d248ec3294e3991f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3607837
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-04-27 07:51:48 +00:00
Changhao Han 573dfc1cca Add copy button in the Changes tab 
This CL also moves the formatting function from StylesSidebarPane to
panels/utils, which can be shared between the Styles pane and the
Changes tab.

Bug: 1268754
Change-Id: I172a6a8d247c8326d67e1f6342a4d9bd91f1557a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3560436
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
 2022-03-31 13:10:50 +00:00
Changhao Han afe5698f1c Always compare changes based on formatted diff and source 
Since we record changed line numbers from formatted sources, we should
always compare formatted current line number against the changed line
numbers. This CL also retrieves the formatted mapping from the diff call
site and stores it for said comparison.

Bug: chromium:1268754
Change-Id: I9f0bdd7f081b17d15a1f80ce788de54defb6717b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3466037
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-02-16 11:34:12 +00:00
Paul Lewis 982b1a562e Removes aerotwist from OWNERS 
Thanks for everything :)

DISABLE_THIRD_PARTY_CHECK=Necessary for change

Bug: None
Change-Id: I1769098f0379eb919fb77ba8e98564642c8cc387
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386941
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-14 16:41:50 +00:00
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Changhao Han 4382b53352 Add option to format diff in the Changes tab 
This CL adds an experimental flag to automatically format code changes
in the Changes tab. This way the minified sources won't show only one
line of diff that's quite hard to trace the actual difference. It also
won't show formatted source as changes any more.

Screenshot: https://imgur.com/a/lIEqUmU

Bug: chromium:1238818, chromium:1268754, chromium:1086491
Change-Id: I0f2636d1bced17f2f9b32f594bf720951fd4e191
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3300359
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-25 09:05:44 +00:00
Tim van der Lippe 379c288384 Allow meta-files to import relative entrypoints 
We previously disabled this rule in a lot of places to workaround the
fact that the rule wasn't adhering to importing entrypoints in meta
files. Instead, let's update the rule to make it clear that this pattern
is expected and fine.

R=alexrudenko@chromium.org

Bug: 1271490
Change-Id: Idd139b42d9bb27f1f20e573b31bcd5efff8815af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289221
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 14:53:06 +00:00
Tim van der Lippe 25a6adb9c1 Reland "Fix all issues found by StyleLint 14" 
This reverts commit f746fe4a57.

Reason for revert: fix the missing script_args variable.

Original change's description:
> Revert "Fix all issues found by StyleLint 14"
>
> This reverts commit fb8852321b.
>
> Reason for revert: breaks the presubmit. Since the tree is closed,
> a fix forward is not landing soon. Therefore, let's pre-emptively revert.
>
> Original change's description:
> > Fix all issues found by StyleLint 14
> >
> > These are mostly auto-fixed by Stylelint 14 with a couple of manual
> > fixes (adding quotes around urls and fixing some shorthand properties).
> >
> > A follow-up CL will update us to Stylelint 14, at which point they will
> > be enforced.
> >
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
>
> Bug: none
> Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: none
Change-Id: I81b402e4a30981cb1a0360053b3553cd1934cbe6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-05 15:41:29 +00:00
Tim van der Lippe f746fe4a57 Revert "Fix all issues found by StyleLint 14" 
This reverts commit fb8852321b.

Reason for revert: breaks the presubmit. Since the tree is closed,
a fix forward is not landing soon. Therefore, let's pre-emptively revert.

Original change's description:
> Fix all issues found by StyleLint 14
>
> These are mostly auto-fixed by Stylelint 14 with a couple of manual
> fixes (adding quotes around urls and fixing some shorthand properties).
>
> A follow-up CL will update us to Stylelint 14, at which point they will
> be enforced.
>
> R=​szuend@chromium.org
>
> Bug: none
> Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

Bug: none
Change-Id: I155ef7e0633cba15b47439a37a71158b6dcb8f91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259702
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-04 16:13:19 +00:00
Tim van der Lippe fb8852321b Fix all issues found by StyleLint 14 
These are mostly auto-fixed by Stylelint 14 with a couple of manual
fixes (adding quotes around urls and fixing some shorthand properties).

A follow-up CL will update us to Stylelint 14, at which point they will
be enforced.

R=szuend@chromium.org

Bug: none
Change-Id: Ia813854accd1eb86eccea64a5fbf1f8534563964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259540
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-04 15:20:38 +00:00
Tim van der Lippe 89bdd334ff Remove panels/changes/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: I00d8c81058e00aa86324dc27914742744d0804bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240947
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-25 16:22:29 +00:00
Tim van der Lippe 09e01456d9 Remove panels/snippets/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: I7a8ac1e990749e2b38995648cc11bfc1611fbcbc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3240946
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-25 15:52:14 +00:00
Tim van der Lippe 5522bfcbad Rewrite the change diff viewer to no longer be an editor 
R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I8dd11ed4a418cce74095e99c839d831812b57e35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217626
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-14 14:02:57 +00:00
Philip Pfaffe 3211ef23de Use type-safe events for ChangesSidebar 
Bug: 1228674
Change-Id: Idfad69fdd5419e7d8ebf4b1e12d6a0b2238e3933
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3161990
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2021-09-15 16:17:14 +00:00
Tim van der Lippe 123aa0f84c Remove ui/legacy/components/utils/module.json 
This also includes the refactoring to use adoptedStylesheet
in JSPresentationUtils.ts.

R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1106746, 1127902
Change-Id: I93a8009e1c950f7fe2aa4d4d7075cc58abfcbd19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145218
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-09 11:35:48 +00:00
Tim van der Lippe b353e31242 Remove models/persistence/module.json 
R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1127902
Change-Id: I3d25122ebf28a0426190bfc7384830aee3cf32e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145215
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-09-08 11:23:05 +00:00
Tim van der Lippe effef52092 Remove models/workspace_diff/module.json 
R=jacktfranklin@chromium.org
CC=kritisapra@google.com

Bug: 1127902
Change-Id: I913d29863b93d720d3f7a2ba80afd27f3c0981fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3145214
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-09-08 10:54:52 +00:00
Kriti Sapra 37e7c84880 Removed resources from panels/application, panels/browser_debugger, 
panels/changes and panels/coverage

Bug: 1190991, 1127902
Change-Id: If0c491b248a19035f7cf56cfb45539eb7970466e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3132562
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-31 14:21:41 +00:00
Kateryna Prokopenko 18636ff717 Use type-safe events for WorkspaceDiff 
Bug: 1228674
Change-Id: I2a33700b2fb19d9af00db0e32a4e4059b48badb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093150
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
 2021-08-13 11:33:25 +00:00
Jan Scheffler b2e972040c [Underscore Migration] Migrate panels/changes 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I900a8dcbf88b34ebb0528ed5c1d12944ba5da3de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077394
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 11:39:41 +00:00
Kriti Sapra 6eb2f71235 [CSS]: panels/changes, panels/coverage and panels/developer_resources 
Bug: 1106746
Change-Id: I2ac488f70ee2440a4050d86fa446934553f4ead5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060700
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-29 15:45:48 +00:00
Simon Zünd 735921cd29 [cleanup] Move removeEventListeners off EventTarget 
removeEventListeners is already an exported function. Removing
the static method from `EventTarget` allows us to make `EventTarget`
a true interface.

Bug: 1228674
Change-Id: I8a870edc90438f6556b08f3329df6b2f850be297
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978375
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-07-13 12:33:35 +00:00
Tim van der Lippe a53672de83 Check license headers for CSS files during PRESUBMIT 
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.

To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).

R=jacktfranklin@chromium.org

Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-13 12:28:56 +00:00
Jack Franklin 84442c6766 [DarkMode] remove enableLegacyPatching option 
The option was only allowed to be set to `false`, so it's not been
used at all, so now we can remove it, given that we've had the dark
mode legacy patching disabled without any major bugs in the past few
weeks.

Bug: chromium:1152736
Change-Id: I1e794d75f9c354a0d16b1b3975f7ebdf82b3448b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-06-29 10:07:32 +00:00
Jack Franklin 453a2ba7ca [Dark mode] make changesSidebar.css consistent with sources sidebar 
Bug: chromium:1152736, chromium:1210894
Change-Id: I6b3b9af30fbe0b0e1fdddb6c10a4bc4647909093
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2910103
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-05-21 21:24:12 +00:00
Jack Franklin ccc02155cc [Dark Mode] changeSidebar.css 
Bug: chromium:1152736
Change-Id: Ifad64a29f1b97c9b564e2d9128d247263629395b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905505
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-19 12:32:33 +00:00
Jack Franklin 92fb5f5b91 [DarkMode] changesView.css 
Bug: chromium:1152736
Change-Id: Iae6c0d050d5f0593a1ff3eff0fa4e95641b5412d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905503
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-19 12:07:42 +00:00
Tim van der Lippe af02decd68 Disallow !important in CSS files 
To make sure that any newly written CSS files for new components
do not use !important, since they will be using shadow DOM. Moreover,
!important is usually an anti-pattern that makes it harder to reason
about CSS cascading. It is also disallowed internally at Google.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Idcd2c90d01ff2e782a02d0a4631be384b1a3ca74
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2871716
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-05-04 16:14:35 +00:00
Tim van der Lippe 908374f79d Add GN visibility to panels [1/2] 
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I0168889aa13b49b2caddc8a8bf2ef8b6b62b9367
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854691
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 14:39:44 +00:00
Jack Franklin 9b1435f00c Prefix more legacy CSS variables with --legacy-*. 
Bug: chromium:1152736
Change-Id: I2a122a944061a85764e4dfdd5c46025b8606e706
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854688
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 14:12:24 +00:00
Tim van der Lippe eea44828fe Add GN visibility to all legacy targets 
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I47b05c25df571de948ab59e9abcc6a62d0146ff2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854677
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 09:57:04 +00:00
Jack Franklin 374ec39011 Remove --toolbar-bg-color and --tab-selected-bg-color 
These were both aliased to new colors anyway, so this CL removes the
legacy colors and updates all usages to point to the new CSS
variables.

Bug: chromium:1152736
Change-Id: Ibe034fd8ca9fb8057f92dc6d3974dc73f28f8f92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2853384
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 09:29:44 +00:00
Tim van der Lippe 3fff977fdd Add GN visibility to all meta targets 
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I7be4bd13a731065a9291cc4b37b830130b0873e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2854676
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-28 09:10:13 +00:00
Tim van der Lippe 4c592ddd16 Move workspace_diff to models/workspace_diff 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I38bb15a1df8652f86e10737528c3f7b48457ff0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-20 14:37:25 +00:00
Tim van der Lippe eb75111549 Move snippets to panels/snippets 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I5c9c27398f331fb853eabfe6c278ddc4cc306034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831971
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-19 12:49:39 +00:00
Tim van der Lippe bb54ff77b0 Move diff to third_party/diff 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Iccb8f7095945db03d51fb833f2d2ba2a8962dc73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-16 10:39:45 +00:00
Tim van der Lippe 9a1c973dd7 Move text_editor to ui/legacy/components/text_editor 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I1cdad3b03212be4870a9b6889b1e03b364414eb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2825799
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-14 15:01:22 +00:00
Tim van der Lippe 99aeaf3724 Move workspace to models/workspace 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia4bf7cb736dca976fb30d9e94beeda3e28115dce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815118
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-09 15:32:33 +00:00
Tim van der Lippe 22d1903d32 Move persistence to models/persistence 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: I890a9fceb3441a8377c90faf47fb94d80d9f9398
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815014
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 15:33:22 +00:00
Tim van der Lippe aa61faf631 Move ui to ui/legacy 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Ifc536ba79b0a324aa38e76aa294c73cd699c6536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2810839
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-07 16:06:59 +00:00
Tim van der Lippe 7696157ed2 Move common to core/common 
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia0d2b3a5f6ec2b025e5fe19dc14fbb29e1a2b83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-06 11:24:38 +00:00
Tim van der Lippe bb352e6a14 Move i18n to core/i18n 
R=aerotwist@chromium.org
DISABLE_THIRD_PARTY_CHECK=i18n move

No-Presubmit: true
Bug: 1187573
Change-Id: I3dd02956bcf078e0e3b059240ea583b3a83c09b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-01 18:31:44 +00:00
Tim van der Lippe d8caac43df Move root to core/root 
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I243b006f0b96bec4ff251394cb301e01226893ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2797216
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-31 16:21:32 +00:00
Tim van der Lippe aa1ed7a5a9 Move platform to core/platform 
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I3d6c24a3ac359989d629e4d56e8a1301adbb5ffc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2797215
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-31 16:08:22 +00:00
Tim van der Lippe cf4887dd50 Remove modules from module.json 
This removes all declarations of modules in module.json. All of these
are now unused, since we load all files either explicitly in layout
tests or import them using ES modules.

The timeline_model/module.json file was empty after this change, so
I removed that one as well.

R=aerotwist@chromium.org

Fixed: 1131500
Change-Id: I7d769a8944d68d82da879daf2948571911ae5d49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2775933
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-22 13:40:54 +00:00
Tim van der Lippe ad935d1203 Move changes to panels/changes 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ie491631f84a89c24a8a1feedd74d667c8c38b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767265
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-18 13:38:37 +00:00