Commit Graph
15 Commits
Author SHA1 Message Date
Philip Pfaffe 3211ef23de Use type-safe events for ChangesSidebar
Bug: 1228674
Change-Id: Idfad69fdd5419e7d8ebf4b1e12d6a0b2238e3933
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3161990
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2021-09-15 16:17:14 +00:00
Kateryna Prokopenko 18636ff717 Use type-safe events for WorkspaceDiff
Bug: 1228674
Change-Id: I2a33700b2fb19d9af00db0e32a4e4059b48badb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093150
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
2021-08-13 11:33:25 +00:00
Jan Scheffler b2e972040c [Underscore Migration] Migrate panels/changes
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I900a8dcbf88b34ebb0528ed5c1d12944ba5da3de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077394
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-08-10 11:39:41 +00:00
Kriti Sapra 6eb2f71235 [CSS]: panels/changes, panels/coverage and panels/developer_resources
Bug: 1106746
Change-Id: I2ac488f70ee2440a4050d86fa446934553f4ead5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060700
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-07-29 15:45:48 +00:00
Simon Zünd 735921cd29 [cleanup] Move removeEventListeners off EventTarget
removeEventListeners is already an exported function. Removing
the static method from `EventTarget` allows us to make `EventTarget`
a true interface.

Bug: 1228674
Change-Id: I8a870edc90438f6556b08f3329df6b2f850be297
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2978375
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-07-13 12:33:35 +00:00
Jack Franklin 84442c6766 [DarkMode] remove enableLegacyPatching option
The option was only allowed to be set to `false`, so it's not been
used at all, so now we can remove it, given that we've had the dark
mode legacy patching disabled without any major bugs in the past few
weeks.

Bug: chromium:1152736
Change-Id: I1e794d75f9c354a0d16b1b3975f7ebdf82b3448b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-06-29 10:07:32 +00:00
Jack Franklin ccc02155cc [Dark Mode] changeSidebar.css
Bug: chromium:1152736
Change-Id: Ifad64a29f1b97c9b564e2d9128d247263629395b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905505
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2021-05-19 12:32:33 +00:00
Tim van der Lippe 4c592ddd16 Move workspace_diff to models/workspace_diff
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I38bb15a1df8652f86e10737528c3f7b48457ff0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-20 14:37:25 +00:00
Tim van der Lippe eb75111549 Move snippets to panels/snippets
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I5c9c27398f331fb853eabfe6c278ddc4cc306034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831971
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-19 12:49:39 +00:00
Tim van der Lippe 99aeaf3724 Move workspace to models/workspace
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia4bf7cb736dca976fb30d9e94beeda3e28115dce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815118
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-09 15:32:33 +00:00
Tim van der Lippe aa61faf631 Move ui to ui/legacy
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Ifc536ba79b0a324aa38e76aa294c73cd699c6536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2810839
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-04-07 16:06:59 +00:00
Tim van der Lippe 7696157ed2 Move common to core/common
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia0d2b3a5f6ec2b025e5fe19dc14fbb29e1a2b83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-06 11:24:38 +00:00
Tim van der Lippe bb352e6a14 Move i18n to core/i18n
R=aerotwist@chromium.org
DISABLE_THIRD_PARTY_CHECK=i18n move

No-Presubmit: true
Bug: 1187573
Change-Id: I3dd02956bcf078e0e3b059240ea583b3a83c09b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-04-01 18:31:44 +00:00
Tim van der Lippe aa1ed7a5a9 Move platform to core/platform
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I3d6c24a3ac359989d629e4d56e8a1301adbb5ffc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2797215
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-03-31 16:08:22 +00:00
Tim van der Lippe ad935d1203 Move changes to panels/changes
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ie491631f84a89c24a8a1feedd74d667c8c38b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767265
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2021-03-18 13:38:37 +00:00