zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,737 Commits 43 Branches 79 Tags
bedbd4f3fe201caedff255ae97fdf875e13063f8
Commit Graph
17 Commits
Author SHA1 Message Date
Changhao Han 6f6fbc0a9c UX fixes for Changes tracking 
This CL includes the following fixes/UX improvements:
- Allow user selection and clicking to source in Changes tab

- Match green change indicator with multiple changed lines

- Move style section bottom toolbar down to leave room for copy button

These come from this doc: https://docs.google.com/document/d/1DMM-oK64W0V9pbZ0fZLZ44Lxwg3OyjZ6fh3iCXNIRDY/edit

Bug: 1268754, 1297825, 1317599, 1299278
Change-Id: I04a7555feea2c900db182123d248ec3294e3991f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3607837
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-04-27 07:51:48 +00:00
Changhao Han 573dfc1cca Add copy button in the Changes tab 
This CL also moves the formatting function from StylesSidebarPane to
panels/utils, which can be shared between the Styles pane and the
Changes tab.

Bug: 1268754
Change-Id: I172a6a8d247c8326d67e1f6342a4d9bd91f1557a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3560436
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Johan Bay <jobay@chromium.org>
 2022-03-31 13:10:50 +00:00
Changhao Han afe5698f1c Always compare changes based on formatted diff and source 
Since we record changed line numbers from formatted sources, we should
always compare formatted current line number against the changed line
numbers. This CL also retrieves the formatted mapping from the diff call
site and stores it for said comparison.

Bug: chromium:1268754
Change-Id: I9f0bdd7f081b17d15a1f80ce788de54defb6717b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3466037
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2022-02-16 11:34:12 +00:00
Tim van der Lippe 2d9a95ce7b Suppress all existing promise races 
To suppress the races, we mark these invocations with `void` per
the instructions of `no-floating-promises`. This explicitly marks
these statements as side-effect promises.

Engineers can later analyze these void statements and determine
whether the promise races are intentional or accidental.

R=jacktfranklin@chromium.org

Bug: 1239617
Change-Id: I6b7a24cf21029d6ff73b112b3e8255ebab8c60ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366467
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-04 16:08:08 +00:00
Changhao Han 4382b53352 Add option to format diff in the Changes tab 
This CL adds an experimental flag to automatically format code changes
in the Changes tab. This way the minified sources won't show only one
line of diff that's quite hard to trace the actual difference. It also
won't show formatted source as changes any more.

Screenshot: https://imgur.com/a/lIEqUmU

Bug: chromium:1238818, chromium:1268754, chromium:1086491
Change-Id: I0f2636d1bced17f2f9b32f594bf720951fd4e191
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3300359
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-25 09:05:44 +00:00
Tim van der Lippe 5522bfcbad Rewrite the change diff viewer to no longer be an editor 
R=tvanderlippe@chromium.org

Bug: 1241848
Change-Id: I8dd11ed4a418cce74095e99c839d831812b57e35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3217626
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-10-14 14:02:57 +00:00
Jan Scheffler b2e972040c [Underscore Migration] Migrate panels/changes 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

R=tvanderlippe@chromium.org

Bug:chromium:1207342
Change-Id: I900a8dcbf88b34ebb0528ed5c1d12944ba5da3de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077394
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-10 11:39:41 +00:00
Kriti Sapra 6eb2f71235 [CSS]: panels/changes, panels/coverage and panels/developer_resources 
Bug: 1106746
Change-Id: I2ac488f70ee2440a4050d86fa446934553f4ead5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3060700
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-29 15:45:48 +00:00
Jack Franklin 84442c6766 [DarkMode] remove enableLegacyPatching option 
The option was only allowed to be set to `false`, so it's not been
used at all, so now we can remove it, given that we've had the dark
mode legacy patching disabled without any major bugs in the past few
weeks.

Bug: chromium:1152736
Change-Id: I1e794d75f9c354a0d16b1b3975f7ebdf82b3448b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2988303
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-06-29 10:07:32 +00:00
Jack Franklin 92fb5f5b91 [DarkMode] changesView.css 
Bug: chromium:1152736
Change-Id: Iae6c0d050d5f0593a1ff3eff0fa4e95641b5412d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2905503
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-05-19 12:07:42 +00:00
Tim van der Lippe 4c592ddd16 Move workspace_diff to models/workspace_diff 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I38bb15a1df8652f86e10737528c3f7b48457ff0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-20 14:37:25 +00:00
Tim van der Lippe bb54ff77b0 Move diff to third_party/diff 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Iccb8f7095945db03d51fb833f2d2ba2a8962dc73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-16 10:39:45 +00:00
Tim van der Lippe 99aeaf3724 Move workspace to models/workspace 
R=jacktfranklin@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia4bf7cb736dca976fb30d9e94beeda3e28115dce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815118
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-09 15:32:33 +00:00
Tim van der Lippe aa61faf631 Move ui to ui/legacy 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Ifc536ba79b0a324aa38e76aa294c73cd699c6536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2810839
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-07 16:06:59 +00:00
Tim van der Lippe 7696157ed2 Move common to core/common 
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: Ia0d2b3a5f6ec2b025e5fe19dc14fbb29e1a2b83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-06 11:24:38 +00:00
Tim van der Lippe bb352e6a14 Move i18n to core/i18n 
R=aerotwist@chromium.org
DISABLE_THIRD_PARTY_CHECK=i18n move

No-Presubmit: true
Bug: 1187573
Change-Id: I3dd02956bcf078e0e3b059240ea583b3a83c09b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-01 18:31:44 +00:00
Tim van der Lippe ad935d1203 Move changes to panels/changes 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Ie491631f84a89c24a8a1feedd74d667c8c38b3d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2767265
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-18 13:38:37 +00:00